rbeapi 0.5.1 → 1.0

data/spec/system/rbeapi/api/prefixlists_spec.rb

@@ -0,0 +1,198 @@
+#
+# Copyright (c) 2016, Arista Networks, Inc.
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are
+# met:
+#
+#   Redistributions of source code must retain the above copyright notice,
+#   this list of conditions and the following disclaimer.
+#
+#   Redistributions in binary form must reproduce the above copyright
+#   notice, this list of conditions and the following disclaimer in the
+#   documentation and/or other materials provided with the distribution.
+#
+#   Neither the name of Arista Networks nor the names of its
+#   contributors may be used to endorse or promote products derived from
+#   this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL ARISTA NETWORKS
+# BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
+# BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
+# WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE
+# OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN
+# IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+#
+require 'spec_helper'
+
+require 'rbeapi/client'
+require 'rbeapi/api/prefixlists'
+
+describe Rbeapi::Api::Prefixlists do
+  subject { described_class.new(node) }
+
+  let(:node) do
+    Rbeapi::Client.config.read(fixture_file('dut.conf'))
+    Rbeapi::Client.connect_to('dut')
+  end
+
+  describe '#get' do
+    before do
+      node.config(['no ip prefix-list test1',
+                   'ip prefix-list test1',
+                   'seq 10 permit 1.2.3.0/24',
+                   'seq 20 permit 2.3.4.0/24 le 30',
+                   'seq 30 deny 3.4.5.0/24 ge 26 le 30',
+                   'permit 5.6.7.16/28 eq 29'])
+    end
+
+    let(:prefixlist) { subject.get('test1') }
+
+    it 'returns the prefix list for an existing name' do
+      expect(prefixlist).to be_a_kind_of(Array)
+    end
+
+    it 'returns all rules as hash' do
+      expect(prefixlist).to all ( be_an(Hash) )
+    end
+
+    it 'has all keys for each rule' do
+      prefixlist.each do |rule|
+        expect(rule).to have_key('seq')
+        expect(rule).to have_key('prefix')
+        expect(rule).to have_key('action')
+      end
+    end
+
+    let(:values) do
+      [
+        {
+          'seq' => '10',
+          'action' => 'permit',
+          'prefix' => '1.2.3.0/24'
+        },
+        {
+          'seq' => '20',
+          'action' => 'permit',
+          'prefix' => '2.3.4.0/24 le 30'
+        },
+        {
+          'seq' => '30',
+          'action' => 'deny',
+          'prefix' => '3.4.5.0/24 ge 26 le 30'
+        },
+        {
+          'seq' => '40',
+          'action' => 'permit',
+          'prefix' => '5.6.7.16/28 eq 29'
+        }
+      ]
+    end
+
+    it 'returns the correct values for all the keys' do
+      expect(prefixlist).to eq(values)
+    end
+  end
+
+  describe '#getall' do
+    let(:del_pref_lists) {
+      subject.getall.keys.map { |k| "no ip prefix-list #{k}" } 
+    }
+
+    before do
+      node.config(del_pref_lists + 
+                  ['ip prefix-list test1',
+                  'seq 10 permit 1.2.3.0/24',
+                  'seq 20 permit 2.3.4.0/24 le 30',
+                  'seq 30 deny 3.4.5.0/24 ge 26 le 30',
+                  'permit 5.6.7.8/28',
+                  'ip prefix-list test2',
+                  'seq 10 permit 10.11.0.0/16',
+                  'seq 20 permit 10.12.0.0/16 le 24',
+                  'ip prefix-list test3'])
+    end
+
+    let(:prefixlists) { subject.getall }
+
+    it 'returns the collection as hash' do
+      expect(prefixlists).to be_a_kind_of(Hash)
+    end
+
+    it 'returns all prefix lists as array' do
+      expect(prefixlists).to all ( be_an(Array) )
+    end
+
+    it 'has three prefix lists' do
+       expect(prefixlists.size).to eq(3)
+    end
+  end
+
+  describe '#create' do
+    before do
+      node.config('no ip prefix-list test4')
+    end
+
+    it 'creates a new prefix list' do
+      expect(subject.get('test4')).to eq(nil)
+      expect(subject.create('test4')).to be_truthy
+      expect(subject.get('test4')).to eq([])
+      expect(subject.get('test4').size).to eq(0)
+    end
+  end
+
+  describe '#add_rule' do
+    before do
+      node.config(['no ip prefix-list test5',
+                    'ip prefix-list test5'])
+    end
+
+    it 'adds rule to an existing prefix list' do
+      expect(subject.get('test5')).to eq([])
+      expect(subject.add_rule('test5', 'permit', '1.1.1.0/24')).to be_truthy
+      expect(subject.get('test5')).to eq([{
+                                        "seq" => "10",
+                                        "action" => "permit",
+                                        "prefix" => "1.1.1.0/24"}])
+    end
+
+    it 'adds rule to a non-existent prefix list' do
+      expect(subject.get('test6')).to eq(nil)
+      expect(subject.add_rule('test6', 'deny', '2.2.2.0/24')).to be_truthy
+      expect(subject.get('test6')).to eq([{
+                                      "seq" => "10",
+                                      "action" => "deny",
+                                      "prefix" => "2.2.2.0/24"}])
+    end
+  end
+
+  describe '#delete' do
+    before do
+      node.config(['no ip prefix-list test7',
+                  'no ip prefix-list test8',
+                  'ip prefix-list test7',
+                  'seq 10 permit 7.7.0.0/16',
+                  'ip prefix-list test8',
+                  'seq 10 permit 8.8.0.0/16',
+                  'deny 9.9.0.0/16 le 24'])
+    end
+
+    it 'delets a prefix list' do
+      expect(subject.get('test7')).to be_truthy
+      expect(subject.delete('test7')).to be_truthy
+      expect(subject.get('test7')).to eq(nil)
+    end
+
+    it 'deletes a rule in the prefix list' do
+      expect(subject.get('test8')).to be_truthy
+      expect(subject.delete('test8', 20)).to be_truthy
+      expect(subject.get('test8').size).to eq(1)
+      expect(subject.get('test8')[1]).to eq(nil)
+    end
+  end
+end

data/spec/system/rbeapi/api/stp_instances_spec.rb

@@ -15,14 +15,24 @@ describe Rbeapi::Api::StpInstances do
     before do
       node.config(['spanning-tree mode mstp',
                    'spanning-tree mst configuration',
-                   'instance 1 vlans 1', 'exit'])
+                   'instance 10 vlans 100', 'exit'])
     end
 
     it 'returns the stp instance resource as a hash' do
+      expect(subject.get('10')).to be_a_kind_of(Hash)
+    end
+
+    it 'returns the default stp instance resources as a hash' do
+      expect(subject.get('0')).to be_a_kind_of(Hash)
       expect(subject.get('1')).to be_a_kind_of(Hash)
     end
 
     it 'returns the instance priority' do
+      expect(subject.get('10')).to include(:priority)
+    end
+
+    it 'returns the default instances priority' do
+      expect(subject.get('0')).to include(:priority)
       expect(subject.get('1')).to include(:priority)
     end
   end
@@ -41,38 +51,65 @@ describe Rbeapi::Api::StpInstances do
     before do
       node.config(['spanning-tree mode mstp',
                    'spanning-tree mst configuration',
-                   'instance 1 vlans 1', 'exit'])
+                   'instance 1 vlans 1',
+                   'instance 10 vlans 100', 'exit'])
     end
 
     it 'deletes the mst instance' do
+      expect(subject.get('10')).not_to be_nil
+      expect(subject.delete('10')).to be_truthy
+      expect(subject.get('10')).to be_nil
+    end
+
+    it 'does not delete the default mst instance' do
       expect(subject.get('1')).not_to be_nil
       expect(subject.delete('1')).to be_truthy
-      expect(subject.get('1')).to be_nil
+      expect(subject.get('1')).not_to be_nil
     end
   end
 
   describe '#set_priority' do
     before do
-      node.config(['default spanning-tree mst 1 priority',
+      node.config(['default spanning-tree mst 10 priority',
+                   'no spanning-tree mst 1 priority',
                    'spanning-tree mode mstp',
                    'default spanning-tree mst configuration',
                    'spanning-tree mst configuration',
-                   'instance 1 vlans 1', 'exit'])
+                   'instance 10 vlans 100', 'exit'])
     end
 
     it 'set the instance priority' do
+      expect(subject.get('10')[:priority]).to eq('32768')
+      expect(subject.set_priority('10', value: '16384')).to be_truthy
+      expect(subject.get('10')[:priority]).to eq('16384')
+    end
+
+    it 'set the default instance priority' do
       expect(subject.get('1')[:priority]).to eq('32768')
       expect(subject.set_priority('1', value: '4096')).to be_truthy
       expect(subject.get('1')[:priority]).to eq('4096')
     end
 
     it 'set the instance priority to default' do
+      expect(subject.set_priority('10', value: '16384',
+                                        default: true)).to be_truthy
+      expect(subject.get('10')[:priority]).to eq('32768')
+    end
+
+    it 'set the default instance priority to default' do
       expect(subject.set_priority('1', value: '4096',
                                        default: true)).to be_truthy
       expect(subject.get('1')[:priority]).to eq('32768')
     end
 
     it 'set the instance priority to enable false' do
+      expect(subject.set_priority('10', value: '16384',
+                                        default: false,
+                                        enable: false)).to be_truthy
+      expect(subject.get('10')[:priority]).to eq('32768')
+    end
+
+    it 'set the default instance priority to enable false' do
       expect(subject.set_priority('1', value: '4096',
                                        default: false,
                                        enable: false)).to be_truthy
@@ -80,6 +117,13 @@ describe Rbeapi::Api::StpInstances do
     end
 
     it 'set the instance priority to enable true' do
+      expect(subject.set_priority('10', value: '16384',
+                                        default: false,
+                                        enable: true)).to be_truthy
+      expect(subject.get('10')[:priority]).to eq('16384')
+    end
+
+    it 'set the default instance priority to enable true' do
       expect(subject.set_priority('1', value: '4096',
                                        default: false,
                                        enable: true)).to be_truthy

data/spec/system/rbeapi/api/switchports_spec.rb

@@ -191,34 +191,40 @@ describe Rbeapi::Api::Switchports do
         .to raise_error(ArgumentError)
     end
 
-    it 'sets vlan 8 and 9 to the trunk allowed vlans' do
+    it 'sets vlan 8-10 and 100 to the trunk allowed vlans' do
       node.config(['interface Ethernet1', 'switchport trunk allowed vlan none'])
       expect(subject.get('Ethernet1')[:trunk_allowed_vlans]).to be_empty
-      expect(subject.set_trunk_allowed_vlans('Ethernet1', value: [8, 9]))
+      expect(subject.set_trunk_allowed_vlans('Ethernet1', value: ['8-10',
+                                                                  '100']))
         .to be_truthy
-      expect(subject.get('Ethernet1')[:trunk_allowed_vlans]).to eq([8, 9])
+      expect(subject.get('Ethernet1')[:trunk_allowed_vlans]).to eq(['8-10',
+                                                                    '100'])
     end
 
     it 'negate switchport trunk allowed vlan' do
       node.config(['interface Ethernet1', 'switchport trunk allowed vlan none'])
       expect(subject.get('Ethernet1')[:trunk_allowed_vlans]).to be_empty
-      expect(subject.set_trunk_allowed_vlans('Ethernet1', value: [8, 9]))
+      expect(subject.set_trunk_allowed_vlans('Ethernet1', value: ['8-10',
+                                                                  '100']))
         .to be_truthy
-      expect(subject.get('Ethernet1')[:trunk_allowed_vlans]).to eq([8, 9])
+      expect(subject.get('Ethernet1')[:trunk_allowed_vlans])
+        .to eq(['8-10', '100'])
       expect(subject.set_trunk_allowed_vlans('Ethernet1', enable: false))
         .to be_truthy
-      expect(subject.get('Ethernet1')[:trunk_allowed_vlans].length).to eq(4094)
+      expect(subject.get('Ethernet1')[:trunk_allowed_vlans]).to eq(['1-4094'])
     end
 
     it 'default switchport trunk allowed vlan' do
       node.config(['interface Ethernet1', 'switchport trunk allowed vlan none'])
       expect(subject.get('Ethernet1')[:trunk_allowed_vlans]).to be_empty
-      expect(subject.set_trunk_allowed_vlans('Ethernet1', value: [8, 9]))
+      expect(subject.set_trunk_allowed_vlans('Ethernet1', value: ['8-10',
+                                                                  '100']))
         .to be_truthy
-      expect(subject.get('Ethernet1')[:trunk_allowed_vlans]).to eq([8, 9])
+      expect(subject.get('Ethernet1')[:trunk_allowed_vlans])
+        .to eq(['8-10', '100'])
       expect(subject.set_trunk_allowed_vlans('Ethernet1', default: true))
         .to be_truthy
-      expect(subject.get('Ethernet1')[:trunk_allowed_vlans].length).to eq(4094)
+      expect(subject.get('Ethernet1')[:trunk_allowed_vlans]).to eq(['1-4094'])
     end
   end
 

data/spec/system/rbeapi/api/vlans_spec.rb

@@ -159,4 +159,50 @@ describe Rbeapi::Api::Vlans do
       expect(subject.get('1')[:trunk_groups]).not_to include('foo')
     end
   end
+
+  describe '#set_trunk_groups' do
+    before do
+      node.config(['vlan 1', 'default trunk group'])
+    end
+
+    it 'raises an ArgumentError if value is not an array' do
+      expect { subject.set_trunk_groups('1', value: 'foo') }
+        .to raise_error(ArgumentError)
+    end
+
+    it 'sets trunk group to foo bar bang' do
+      node.config(['vlan 1', 'trunk group bang', 'trunk group baz'])
+      expect(subject.get('1')[:trunk_groups]).to eq(%w(bang baz))
+      expect(subject.set_trunk_groups('1', value: %w(foo bar bang)))
+        .to be_truthy
+      expect(subject.get('1')[:trunk_groups].sort).to eq(%w(bang bar foo))
+    end
+
+    it 'clears trunk group if no value specified' do
+      node.config(['vlan 1', 'trunk group bang', 'trunk group baz'])
+      expect(subject.get('1')[:trunk_groups]).to eq(%w(bang baz))
+      expect(subject.set_trunk_groups('1')).to be_truthy
+      expect(subject.get('1')[:trunk_groups]).to be_empty
+    end
+
+    it 'negate trunk group' do
+      node.config(['vlan 1', 'trunk group bang', 'trunk group baz'])
+      expect(subject.get('1')[:trunk_groups]).to eq(%w(bang baz))
+      expect(subject.set_trunk_groups('1', value: %w(foo bar bang)))
+        .to be_truthy
+      expect(subject.get('1')[:trunk_groups].sort).to eq(%w(bang bar foo))
+      expect(subject.set_trunk_groups('1', enable: false)).to be_truthy
+      expect(subject.get('1')[:trunk_groups]).to be_empty
+    end
+
+    it 'default trunk group' do
+      node.config(['vlan 1', 'trunk group bang', 'trunk group baz'])
+      expect(subject.get('1')[:trunk_groups]).to eq(%w(bang baz))
+      expect(subject.set_trunk_groups('1', value: %w(foo bar bang)))
+        .to be_truthy
+      expect(subject.get('1')[:trunk_groups].sort).to eq(%w(bang bar foo))
+      expect(subject.set_trunk_groups('1', default: true)).to be_truthy
+      expect(subject.get('1')[:trunk_groups]).to be_empty
+    end
+  end
 end

data/spec/unit/rbeapi/api/interfaces/base_spec.rb

@@ -23,7 +23,7 @@ describe Rbeapi::Api::BaseInterface do
     let(:resource) { subject.get('Loopback0') }
 
     let(:keys) do
-      [:type, :shutdown, :description, :name]
+      [:type, :shutdown, :load_interval, :description, :name]
     end
 
     it 'returns an ethernet resource as a hash' do

data/spec/unit/rbeapi/api/interfaces/ethernet_spec.rb

@@ -24,7 +24,7 @@ describe Rbeapi::Api::EthernetInterface do
 
     let(:keys) do
       [:type, :speed, :sflow, :flowcontrol_send, :flowcontrol_receive,
-       :forced, :shutdown, :description, :name]
+       :shutdown, :description, :name, :load_interval, :lacp_priority]
     end
 
     it 'returns an ethernet resource as a hash' do

data/spec/unit/rbeapi/api/interfaces/portchannel_spec.rb

@@ -31,8 +31,8 @@ describe Rbeapi::Api::PortchannelInterface do
     let(:resource) { subject.get('Port-Channel1') }
 
     let(:keys) do
-      [:type, :shutdown, :description, :name, :members, :lacp_mode,
-       :minimum_links, :lacp_timeout, :lacp_fallback]
+      [:type, :shutdown, :load_interval, :description, :name, :members,
+       :lacp_mode, :minimum_links, :lacp_timeout, :lacp_fallback]
     end
 
     it 'returns an ethernet resource as a hash' do
@@ -141,4 +141,11 @@ describe Rbeapi::Api::PortchannelInterface do
       expect(subject.set_shutdown('Port-Channel1', opts)).to be_truthy
     end
   end
+
+  describe '#set_members' do
+    it 'raises an ArgumentError if members is not an array' do
+      expect { subject.set_members('Port-Channel1', 'Ethernet3') }.to \
+        raise_error(ArgumentError)
+    end
+  end
 end