rbeapi 0.4.0 → 0.5.0

data/spec/system/rbeapi/api/dns_spec.rb

@@ -114,11 +114,27 @@ describe Rbeapi::Api::Dns do
       expect(subject.get[:domain_list]).to be_empty
     end
 
-    it 'default the name servers list' do
+    it 'default true the name servers list' do
       expect(subject.get[:domain_list]).to be_empty
+      expect(subject.set_domain_list(value: servers)).to be_truthy
       expect(subject.set_domain_list(default: true)).to be_truthy
       expect(subject.get[:domain_list]).to be_empty
     end
+
+    it 'default false the name servers list' do
+      expect(subject.get[:domain_list]).to be_empty
+      expect(subject.set_domain_list(default: false,
+                                     value: servers)).to be_truthy
+      expect(subject.get[:domain_list]).to eq(servers)
+    end
+
+    it 'default the name servers list with previous values' do
+      expect(subject.get[:domain_list]).to be_empty
+      expect(subject.set_domain_list(value: %w(foob bat))).to be_truthy
+      expect(subject.set_domain_list(default: false,
+                                     value: servers)).to be_truthy
+      expect(subject.get[:domain_list]).to eq(servers)
+    end
   end
 
   describe '#add_domain_list' do

data/spec/system/rbeapi/api/interfaces_base_spec.rb

@@ -11,15 +11,56 @@ describe Rbeapi::Api::Interfaces do
     Rbeapi::Client.connect_to('dut')
   end
 
+  describe '#respond_to?' do
+    it 'test to validate endpoint' do
+      expect(subject.respond_to?('get', 'Ethernet1')).to be_truthy
+    end
+  end
+
   describe '#get' do
-    let(:entity) do
-      { name: 'Loopback0', type: 'generic', description: '', shutdown: false }
+    context 'with interface Loopback' do
+      let(:entity) do
+        { name: 'Loopback0', type: 'generic', description: '', shutdown: false }
+      end
+
+      before { node.config(['no interface Loopback0', 'interface Loopback0']) }
+
+      it 'returns the interface resource' do
+        expect(subject.get('Loopback0')).to eq(entity)
+      end
     end
 
-    before { node.config(['no interface Loopback0', 'interface Loopback0']) }
+    context 'with interface Port-Channel' do
+      let(:entity) do
+        { name: 'Port-Channel1', type: 'portchannel', description: '',
+          shutdown: false, members: [], lacp_mode: 'on', minimum_links: '0',
+          lacp_fallback: 'disabled', lacp_timeout: '90' }
+      end
+
+      before do
+        node.config(['no interface Loopback0', 'no interface Port-Channel1',
+                     'interface Port-Channel1'])
+      end
+
+      it 'returns the interface resource' do
+        expect(subject.get('Port-Channel1')).to eq(entity)
+      end
+    end
+
+    context 'with interface Vxlan' do
+      let(:entity) do
+        { name: 'Vxlan1', type: 'vxlan', description: '',
+          shutdown: false, source_interface: '', multicast_group: '',
+          udp_port: 4789, flood_list: [], vlans: {} }
+      end
+
+      before do
+        node.config(['no interface Vxlan1', 'interface Vxlan1'])
+      end
 
-    it 'returns the interface resource' do
-      expect(subject.get('Loopback0')).to eq(entity)
+      it 'returns the interface resource' do
+        expect(subject.get('Vxlan1')).to eq(entity)
+      end
     end
   end
 

data/spec/system/rbeapi/api/interfaces_ethernet_spec.rb

@@ -1,3 +1,4 @@
+
 require 'spec_helper'
 
 require 'rbeapi/client'
@@ -85,6 +86,19 @@ describe Rbeapi::Api::Interfaces do
     end
   end
 
+  describe '#set_speed' do
+    before { node.config(['default interface Ethernet1']) }
+
+    it 'sets default true' do
+      expect(subject.set_speed('Ethernet1', default: true)).to be_truthy
+    end
+
+    it 'sets enable true' do
+      expect(subject.set_speed('Ethernet1', default: false,
+                                            enable: true)).to be_falsy
+    end
+  end
+
   describe '#set_sflow' do
     it 'sets the sflow value to true' do
       node.config(['interface Ethernet1', 'no sflow enable'])

data/spec/system/rbeapi/api/interfaces_portchannel_spec.rb

@@ -134,6 +134,74 @@ describe Rbeapi::Api::Interfaces do
       expect(subject.get('Port-Channel1')[:members]).to eq(%w(Ethernet1
                                                               Ethernet3))
     end
+
+    it 'updates the member interfaces and mode on existing interface' do
+      node.config(['no interface Port-Channel1', 'interface Ethernet1-2',
+                   'channel-group 1 mode on'])
+      expect(subject.get('Port-Channel1')[:members]).to eq(%w(Ethernet1
+                                                              Ethernet2))
+      expect(subject.get('Port-Channel1')[:lacp_mode]).to eq('on')
+      expect(subject.set_members('Port-Channel1',
+                                 %w(Ethernet1 Ethernet3),
+                                 'active')).to be_truthy
+      expect(subject.get('Port-Channel1')[:members]).to eq(%w(Ethernet1
+                                                              Ethernet3))
+      expect(subject.get('Port-Channel1')[:lacp_mode]).to eq('active')
+    end
+  end
+
+  describe '#add_member' do
+    before do
+      node.config(['no interface Port-Channel1',
+                   'interface Port-Channel1'])
+    end
+
+    it 'adds new members to the port-channel interface' do
+      node.config(['no interface Port-Channel1', 'interface Port-Channel1'])
+      expect(subject.get('Port-Channel1')[:members]).not_to include('Ethernet1')
+      expect(subject.add_member('Port-Channel1', 'Ethernet1')).to be_truthy
+      expect(subject.get('Port-Channel1')[:members]).to eq(['Ethernet1'])
+    end
+
+    it 'updates the member interfaces on existing interface' do
+      node.config(['no interface Port-Channel1', 'interface Ethernet1-2',
+                   'channel-group 1 mode on'])
+      expect(subject.get('Port-Channel1')[:members]).to eq(%w(Ethernet1
+                                                              Ethernet2))
+      expect(subject.add_member('Port-Channel1', 'Ethernet3')).to be_truthy
+      expect(subject.get('Port-Channel1')[:members]).to eq(%w(Ethernet1
+                                                              Ethernet2
+                                                              Ethernet3))
+      expect(subject.get('Port-Channel1')[:lacp_mode]).to eq('on')
+    end
+
+    it 'no update to the member interfaces on existing interface' do
+      node.config(['no interface Port-Channel1', 'interface Ethernet1-2',
+                   'channel-group 1 mode active'])
+      expect(subject.get('Port-Channel1')[:members]).to eq(%w(Ethernet1
+                                                              Ethernet2))
+      expect(subject.add_member('Port-Channel1', 'Ethernet2')).to be_truthy
+      expect(subject.get('Port-Channel1')[:members]).to eq(%w(Ethernet1
+                                                              Ethernet2))
+      expect(subject.get('Port-Channel1')[:lacp_mode]).to eq('active')
+    end
+  end
+
+  describe '#remove_member' do
+    before do
+      node.config(['no interface Port-Channel1',
+                   'interface Port-Channel1'])
+    end
+
+    it 'removes the member interface on existing interface' do
+      node.config(['no interface Port-Channel1', 'interface Ethernet1-2',
+                   'channel-group 1 mode on'])
+      expect(subject.get('Port-Channel1')[:members]).to eq(%w(Ethernet1
+                                                              Ethernet2))
+      expect(subject.remove_member('Port-Channel1', 'Ethernet1')).to be_truthy
+      expect(subject.get('Port-Channel1')[:members]).to eq(['Ethernet2'])
+      expect(subject.get('Port-Channel1')[:lacp_mode]).to eq('on')
+    end
   end
 
   describe '#set_lacp_mode' do

data/spec/system/rbeapi/api/interfaces_vxlan_spec.rb

@@ -41,7 +41,6 @@ describe Rbeapi::Api::Interfaces do
     before { node.config('no interface Vxlan1') }
 
     it 'creates a new interface resource' do
-      expect(subject.get('Vxlan1')).to be_nil
       expect(subject.create('Vxlan1')).to be_truthy
       expect(subject.get('Vxlan1')).not_to be_nil
     end

data/spec/system/{api_ospf_interfaces_spec.rb → rbeapi/api/ospf_interfaces_spec.rb}

@@ -12,8 +12,9 @@ describe Rbeapi::Api::OspfInterfaces do
   describe '#get' do
     before do
       node.config(['default interface Ethernet1', 'interface Ethernet1',
-                   'no switchport', 'ip address 88.99.99.99/24', 'exit',
-                   'default interface Ethernet2'])
+                   'no switchport', 'ip address 88.99.99.99/24',
+                   'ip ospf network point-to-point',
+                   'exit', 'default interface Ethernet2'])
     end
 
     it 'returns an ospf interface resource instance' do

data/spec/system/{api_ospf_spec.rb → rbeapi/api/ospf_spec.rb}

@@ -10,10 +10,19 @@ describe Rbeapi::Api::Ospf do
   let(:node) { Rbeapi::Client.connect_to('dut') }
 
   describe '#get' do
-    before { node.config(['no router ospf 1', 'router ospf 1']) }
+    before do
+      node.config(['no router ospf 1',
+                   'router ospf 1',
+                   'router-id 1.1.1.1',
+                   'redistribute static route-map word',
+                   'network 192.168.10.10/24 area 0.0.0.0',
+                   'network 192.168.11.10/24 area 0.0.0.0'])
+    end
 
     let(:entity) do
-      { 'router_id' => '', 'areas' => {}, 'redistribute' => {} }
+      { 'router_id' => '1.1.1.1',
+        'areas' => { '0.0.0.0' => ['192.168.10.0/24', '192.168.11.0/24'] },
+        'redistribute' => { 'static' => { 'route_map' => 'word' } } }
     end
 
     it 'returns an ospf resource instance' do

data/spec/system/rbeapi/api/routemaps_spec.rb

@@ -15,8 +15,7 @@ describe Rbeapi::Api::Routemaps do
     let(:resource) { subject.get }
 
     before do
-      node.config(['no route-map test', 'no route-map test1',
-                   'no route-map test2', 'no route-map test3',
+      node.config(['no route-map test',
                    'route-map test permit 10',
                    'route-map test permit 20', 'description descript',
                    'match ip address prefix-list MYLOOPBACK',
@@ -90,8 +89,8 @@ describe Rbeapi::Api::Routemaps do
       expect(subject.getall).to be_a_kind_of(Hash)
     end
 
-    it 'has a key for description' do
-      expect(subject.getall.count).to eq(2)
+    it 'has at least two entries' do
+      expect(subject.getall.count).to be >= 2
     end
 
     it 'returns the routemap collection' do

data/spec/system/rbeapi/api/snmp_spec.rb

@@ -23,6 +23,30 @@ describe Rbeapi::Api::Snmp do
     end
   end
 
+  describe '#set_notification' do
+    before { node.config(['default snmp-server']) }
+
+    it 'configures the snmp notification value to on' do
+      expect(subject.set_notification(state: 'on',
+                                      name: 'bgp')).to be_truthy
+      expect(subject.get[:notifications][0]).to eq(name: 'bgp',
+                                                   state: 'on')
+    end
+
+    it 'configures the snmp notification value to off' do
+      expect(subject.set_notification(state: 'off',
+                                      name: 'bgp')).to be_truthy
+      expect(subject.get[:notifications][0]).to eq(name: 'bgp',
+                                                   state: 'off')
+    end
+
+    it 'configures the snmp notification value to default' do
+      expect(subject.set_notification(state: 'default',
+                                      name: 'all')).to be_truthy
+      expect(subject.get).to include(:notifications)
+    end
+  end
+
   describe '#set_location' do
     before { node.config(['no snmp-server location']) }
 
@@ -119,6 +143,47 @@ describe Rbeapi::Api::Snmp do
     end
   end
 
+  describe '#add_community' do
+    before { node.config('no snmp-server community foo') }
+
+    it 'adds the specified community' do
+      expect(subject.add_community('foo')).to be_truthy
+      expect(subject.get[:communities]['foo'][:access]).to eq('ro')
+    end
+
+    it 'adds the specified community ro' do
+      expect(subject.add_community('foo', 'ro')).to be_truthy
+      expect(subject.get[:communities]['foo'][:access]).to eq('ro')
+    end
+
+    it 'adds the specified community rw' do
+      expect(subject.add_community('foo', 'rw')).to be_truthy
+      expect(subject.get[:communities]['foo'][:access]).to eq('rw')
+    end
+  end
+
+  describe '#remove_community' do
+    before { node.config('default snmp-server community foo') }
+
+    it 'removes the specified community foo' do
+      expect(subject.remove_community('foo')).to be_truthy
+    end
+  end
+
+  describe '#set_community_access' do
+    before { node.config('default snmp-server community foo') }
+
+    it 'sets the community access to ro' do
+      expect(subject.set_community_access('foo', 'ro')).to be_truthy
+      expect(subject.get[:communities]['foo'][:access]).to eq('ro')
+    end
+
+    it 'sets the community access to rw' do
+      expect(subject.set_community_access('foo', 'rw')).to be_truthy
+      expect(subject.get[:communities]['foo'][:access]).to eq('rw')
+    end
+  end
+
   describe '#set_community_acl' do
     before do
       node.config(['no snmp-server community foo',

data/spec/system/rbeapi/api/staticroutes_spec.rb

@@ -0,0 +1,177 @@
+#
+# Copyright (c) 2015, Arista Networks, Inc.
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are
+# met:
+#
+#   Redistributions of source code must retain the above copyright notice,
+#   this list of conditions and the following disclaimer.
+#
+#   Redistributions in binary form must reproduce the above copyright
+#   notice, this list of conditions and the following disclaimer in the
+#   documentation and/or other materials provided with the distribution.
+#
+#   Neither the name of Arista Networks nor the names of its
+#   contributors may be used to endorse or promote products derived from
+#   this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL ARISTA NETWORKS
+# BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
+# BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
+# WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE
+# OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN
+# IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+#
+require 'spec_helper'
+
+require 'rbeapi/client'
+require 'rbeapi/api/staticroutes'
+
+describe Rbeapi::Api::Staticroutes do
+  subject { described_class.new(node) }
+
+  let(:node) do
+    Rbeapi::Client.config.read(fixture_file('dut.conf'))
+    Rbeapi::Client.connect_to('dut')
+  end
+
+  describe '#getall' do
+    let(:resource) { subject.getall }
+
+    before do
+      node.config(['no ip route 1.2.3.4/32',
+                   'no ip route 192.0.2.0/24',
+                   'no ip route 192.0.3.0/24',
+                   'ip route 1.2.3.4/32 Ethernet7 4 tag 3 name frank',
+                   'ip route 1.2.3.4/32 Null0 32 tag 3 name fred',
+                   'ip route 192.0.2.0/24 Ethernet7 3 tag 0 name dummy1',
+                   'ip route 192.0.3.0/24 192.0.3.1 1 tag 0 name dummy2'])
+    end
+
+    it 'returns the staticroute collection' do
+      expect(subject.getall).to include(destination: '1.2.3.4/32',
+                                        nexthop: 'Ethernet7',
+                                        distance: '4',
+                                        tag: '3',
+                                        name: 'frank')
+      expect(subject.getall).to include(destination: '1.2.3.4/32',
+                                        nexthop: 'Null0',
+                                        distance: '32',
+                                        tag: '3',
+                                        name: 'fred')
+      expect(subject.getall).to include(destination: '192.0.2.0/24',
+                                        nexthop: 'Ethernet7',
+                                        distance: '3',
+                                        tag: '0',
+                                        name: 'dummy1')
+      expect(subject.getall).to include(destination: '192.0.3.0/24',
+                                        nexthop: '192.0.3.1',
+                                        distance: '1',
+                                        tag: '0',
+                                        name: 'dummy2')
+    end
+
+    it 'returns a hash collection' do
+      expect(subject.getall).to be_a_kind_of(Array)
+    end
+
+    it 'has four entries' do
+      expect(subject.getall.size).to eq(4)
+    end
+  end
+
+  describe '#create' do
+    let(:resource) { subject.getall }
+
+    before(:each) do
+      node.config(['no ip route 1.2.3.4/32',
+                   'no ip route 192.0.2.0/24',
+                   'no ip route 192.0.3.0/24'])
+    end
+
+    context 'creates a new staticroute resoure' do
+      it 'with minimum input' do
+        expect(subject.getall).to eq([])
+        expect(subject.create('192.0.2.0/24', 'Ethernet1')).to be_truthy
+        expect(subject.getall).to eq(resource)
+      end
+
+      it 'with a router_ip' do
+        node.config(['ip route 192.0.2.0/24 Ethernet1'])
+        expect(subject.getall).to eq(resource)
+
+        expect(subject.create('192.0.2.0/24', 'Ethernet1',
+                              router_ip: '192.168.1.1')).to be_truthy
+        expect(subject.getall).to eq(resource)
+      end
+
+      it 'with distance (metric)' do
+        node.config(['ip route 192.0.2.0/24 Ethernet1'])
+        expect(subject.getall).to eq(resource)
+
+        expect(subject.create('192.0.2.0/24', 'Ethernet1', distance: 254))
+          .to be_truthy
+        expect(subject.getall).to include(destination: '192.0.2.0/24',
+                                          nexthop: 'Ethernet1',
+                                          distance: '254',
+                                          tag: '0',
+                                          name: nil)
+      end
+
+      it 'with a tag' do
+        node.config(['ip route 192.0.2.0/24 Ethernet1'])
+        expect(subject.getall).to eq(resource)
+
+        expect(subject.create('192.0.2.0/24', 'Ethernet1', tag: 3))
+          .to be_truthy
+        expect(subject.getall).to include(destination: '192.0.2.0/24',
+                                          nexthop: 'Ethernet1',
+                                          distance: '1',
+                                          tag: '3',
+                                          name: nil)
+      end
+
+      it 'with a name' do
+        node.config(['ip route 192.0.2.0/24 Ethernet1'])
+        expect(subject.getall).to eq(resource)
+
+        expect(subject.create('192.0.2.0/24', 'Ethernet1', name: 'my_route'))
+          .to be_truthy
+        expect(subject.getall).to include(destination: '192.0.2.0/24',
+                                          nexthop: 'Ethernet1',
+                                          distance: '1',
+                                          tag: '0',
+                                          name: 'my_route')
+      end
+    end
+  end
+
+  describe '#delete' do
+    let(:resource) { subject.getall }
+
+    before do
+      node.config(['ip route 192.0.2.0/24 Ethernet1'])
+    end
+
+    context 'deletes a staticroute resource' do
+      it 'given only a destination network' do
+        expect(subject.getall).to eq(resource)
+        expect(subject.delete('192.0.2.0/24')).to be_truthy
+        expect(subject.getall).to eq([])
+      end
+
+      it 'given a destination and nexthop' do
+        expect(subject.getall).to eq(resource)
+        expect(subject.delete('192.0.2.0/24', 'Ethernet1')).to be_truthy
+        expect(subject.getall).to eq([])
+      end
+    end
+  end
+end