rbeapi 0.2.0 → 0.3.0

data/lib/rbeapi/api/vlans.rb

@@ -1,5 +1,5 @@
 #
-# Copyright (c) 2014, Arista Networks, Inc.
+# Copyright (c) 2014,2015, Arista Networks, Inc.
 # All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
@@ -98,7 +98,7 @@ module Rbeapi
       ##
       # parse_name scans the provided configuration block and parses the
       # vlan name value.  The vlan name should always return a value
-      # from the running conifguration.  The return value is intended to
+      # from the running configuration.  The return value is intended to
       # be merged into the resource hash
       #
       # @api private
@@ -129,7 +129,7 @@ module Rbeapi
       # parse_trunk_groups scans the provided configuration block and parses
       # the trunk groups.  If no trunk groups are found in the nodes
       # running configuration then an empty array is returned as the value.
-      # The return hash is intedned to be merged into the resource hash.
+      # The return hash is intended to be merged into the resource hash.
       #
       # @api private
       #
@@ -199,11 +199,11 @@ module Rbeapi
 
       ##
       # set_name configures the name value for the specified vlan id in the
-      # nodes running configuration.  If the value is not provided in the
+      # nodes running configuration.  If enable is false in the
       # opts keyword Hash then the name value is negated using the no
       # keyword.  If the default keyword is set to true, then the name value
       # is defaulted using the default keyword.  The default keyword takes
-      # precedence over the value keyword
+      # precedence over the enable keyword
       #
       # @eos_version 4.13.7M
       #
@@ -211,7 +211,7 @@ module Rbeapi
       #   vlan <id>
       #     name <value>
       #     no name
-      #     defaul name
+      #     default name
       #
       # @param [String, Integer] :id The vlan id to apply the configuration
       #   to.  The id value should be in the valid range of 1 to 4094
@@ -222,31 +222,26 @@ module Rbeapi
       #   to in the node configuration.  The name parameter accepts a-z, 0-9
       #   and _.
       #
+      # @option :opts [Boolean] :enable If false then the command is
+      #   negated. Default is true.
+      #
       # @option :opts [Boolean] :default Configure the vlan name value using
       #   the default keyword
       #
       # @return [Boolean] returns true if the command completed successfully
       def set_name(id, opts = {})
-        value = opts[:value]
-        default = opts[:default] || false
-
-        cmds = ["vlan #{id}"]
-        case default
-        when true
-          cmds << 'default name'
-        when false
-          cmds << (value.nil? ? 'no name' : "name #{value}")
-        end
+        cmd = command_builder('name', opts)
+        cmds = ["vlan #{id}", cmd]
         configure(cmds)
       end
 
       ##
       # set_state configures the state value for the specified vlan id in
-      # the nodes running configuration.  If the value is not provided in
+      # the nodes running configuration.  If enable is set to false in
       # the opts keyword Hash then the state value is negated using the no
       # keyword.  If the default keyword is set to true, then the state
       # value is defaulted using the default keyword.  The default keyword
-      # takes precedence over the value keyword
+      # takes precedence over the enable keyword
       #
       # @eos_version 4.13.7M
       #
@@ -265,7 +260,10 @@ module Rbeapi
       #   to in the node's configuration.  Accepted values are 'active' or
       #   'suspend'
       #
-      # @option :opts [Boolean] :deafult Configure the vlan state value using
+      # @option :opts [Boolean] :enable If false then the command is
+      #   negated. Default is true.
+      #
+      # @option :opts [Boolean] :default Configure the vlan state value using
       #   the default keyword
       #
       # @return [Boolean] returns true if the command completed successfully
@@ -274,19 +272,12 @@ module Rbeapi
       #   values
       def set_state(id, opts = {})
         value = opts[:value]
-        default = opts[:default] || false
-
         unless ['active', 'suspend', nil].include?(value)
           fail ArgumentError, 'state must be active, suspend or nil'
         end
 
-        cmds = ["vlan #{id}"]
-        case default
-        when true
-          cmds << 'default state'
-        when false
-          cmds << (value.nil? ? 'no state' : "state #{value}")
-        end
+        cmd = command_builder('state', opts)
+        cmds = ["vlan #{id}", cmd]
         configure(cmds)
       end
 

data/lib/rbeapi/api.rb

@@ -1,5 +1,5 @@
 #
-# Copyright (c) 2014, Arista Networks, Inc.
+# Copyright (c) 2014,2015, Arista Networks, Inc.
 # All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
@@ -39,7 +39,7 @@ module Rbeapi
   module Api
     ##
     # The Entity class provides a base class implementation for building
-    # API modules.  The Entity class is typcially not instantiated directly
+    # API modules.  The Entity class is typically not instantiated directly
     # but serves as a super class with convenience methods used to
     # work with the node.
     class Entity
@@ -58,7 +58,7 @@ module Rbeapi
 
       ##
       # The Entity class provides a base class implementation for building
-      # API modules.  The Entity class is typcially not instantiated directly
+      # API modules.  The Entity class is typically not instantiated directly
       # but serves as a super class with convenience methods used to
       # work with the node.
       #
@@ -84,7 +84,7 @@ module Rbeapi
       # one exists) of the node's connection instance
       #
       # @return [Rbeapi::Eapilib::CommandError] An instance of CommandError
-      #   that can be used to futher evaluate the root cause of an error
+      #   that can be used to further evaluate the root cause of an error
       def error
         @node.connection.error
       end
@@ -133,29 +133,38 @@ module Rbeapi
       end
 
       ##
-      # command_builder builds the correct version of a command based on the
-      # configuration options.  If the value option is not provided then the
-      # no keyword is used to build the command.  If the default value is
-      # provided and set to true, then the default keyword is used.  If both
-      # options are provided, then the default option will take precedence.
+      # Method called to build the correct version of a command based on
+      # the modifier options.  If value option is set then it is appended
+      # to the command. If the enable option is false then the 'no'
+      # keyword is prefixed to the command.  If the default value is
+      # provided and set to true, then the default keyword is used.  If
+      # both options are provided, then default option takes precedence.
       #
-      # @return [String]
+      # @param [String, Array] :commands The commands to send to the node
+      #   over the API connection to configure the system
+      # @param [Hash] :opts the options for the command
+      #
+      # @option :opts  [String] :value Optional value that is
+      #   appended to the command if set.
+      #
+      # @option :opts  [Boolean] :enable Prefix the command with 'no'.
+      #   Default is true.
+      #
+      # @option :opts  [Boolean] :default Configure the command using
+      #   the default keyword. Default is false.
+      #
+      # @return [String] Returns built command string
       def command_builder(cmd, opts = {})
-        value = opts[:value]
+        enable = opts.fetch(:enable, true)
         default = opts.fetch(:default, false)
-        case default
-        when true then "default #{cmd}"
-        when false
-          case value
-          when nil, false then "no #{cmd}"
-          when true then cmd
-          else "#{cmd} #{value}"
-          end
-        end
+        cmd << " #{opts[:value]}" if opts[:value]
+        return "default #{cmd}" if default
+        return "no #{cmd}" unless enable
+        cmd
       end
 
       ##
-      # configure_interface sends the commands over eAPI to the desitnation
+      # configure_interface sends the commands over eAPI to the destination
       # node to configure a specific interface.
       #
       # @param [String] :name The interface name to apply the configuration

data/lib/rbeapi/client.rb

@@ -156,7 +156,7 @@ module Rbeapi
     # The Config class holds the loaded configuration file data.  It is a
     # subclass of IniFile.
     class Config < IniFile
-      CONFIG_SEARCH_PATH = ['~/.eapi.conf', '/mnt/flash/eapi.conf']
+      CONFIG_SEARCH_PATH = ['/mnt/flash/eapi.conf']
 
       ##
       # The Config class will automatically search for a filename to load
@@ -182,6 +182,8 @@ module Rbeapi
       #   search path
       def autoload(opts = {})
         search_path = CONFIG_SEARCH_PATH.dup
+        # Add the home directory path if the HOME environement var is defined.
+        search_path.insert(0, '~/.eapi.conf') if ENV.key?('HOME')
         search_path.insert(0, ENV['EAPI_CONF']) if ENV.key?('EAPI_CONF')
 
         path = opts[:filename] || search_path

data/lib/rbeapi/version.rb

@@ -33,5 +33,5 @@
 # #
 # Rbeapi toplevel namespace
 module Rbeapi
-  VERSION = '0.2.0'
+  VERSION = '0.3.0'
 end

data/rbeapi.spec.tmpl

@@ -18,12 +18,16 @@ Requires: pe-rubygems
 Requires: pe-ruby
 Requires: pe-rubygem(net-http-unix)
 Requires: pe-rubygem(inifile)
+Requires: pe-rubygem(netaddr)
 Provides: pe-rubygem(%{gem_name}) = %{version}
 Provides: pe-rubygem-%{gem_name} = %{version}
 %else
 # Use these settings for all other installs
 %global gem gem
 Requires: ruby(abi) = %{rubyabi}
+Requires: ruby(net-http-unix)
+Requires: ruby(inifile)
+Requires: ruby(netaddr)
 Provides: ruby(%{gem_name}) = %{version}-%{release}
 %endif
 

data/spec/spec_helper.rb

@@ -1,6 +1,14 @@
 # encoding: utf-8
 
 require 'simplecov'
+require 'simplecov-json'
+require 'simplecov-rcov'
+SimpleCov.formatters = [
+  SimpleCov::Formatter::HTMLFormatter,
+  SimpleCov::Formatter::JSONFormatter,
+  SimpleCov::Formatter::RcovFormatter
+]
+
 SimpleCov.start do
   add_filter '/spec/'
   add_filter '/.bundle/'

data/spec/system/api_ospf_interfaces_spec.rb

@@ -57,5 +57,21 @@ describe Rbeapi::Api::OspfInterfaces do
         .to be_truthy
       expect(subject.get('Ethernet1')['network_type']).to eq('point-to-point')
     end
+
+    it 'negates the ospf interface type' do
+      expect(subject.set_network_type('Ethernet1', value: 'point-to-point'))
+        .to be_truthy
+      expect(subject.get('Ethernet1')['network_type']).to eq('point-to-point')
+      expect(subject.set_network_type('Ethernet1', enable: false)).to be_truthy
+      expect(subject.get('Ethernet1')['network_type']).to eq('broadcast')
+    end
+
+    it 'defaults the ospf interface type' do
+      expect(subject.set_network_type('Ethernet1', value: 'point-to-point'))
+        .to be_truthy
+      expect(subject.get('Ethernet1')['network_type']).to eq('point-to-point')
+      expect(subject.set_network_type('Ethernet1', default: true)).to be_truthy
+      expect(subject.get('Ethernet1')['network_type']).to eq('broadcast')
+    end
   end
 end

data/spec/system/api_ospf_spec.rb

@@ -53,6 +53,20 @@ describe Rbeapi::Api::Ospf do
       expect(subject.set_router_id('1', value: '1.1.1.1')).to be_truthy
       expect(subject.get('1')['router_id']).to eq('1.1.1.1')
     end
+
+    it 'negates the router id' do
+      expect(subject.set_router_id('1', value: '1.1.1.1')).to be_truthy
+      expect(subject.get('1')['router_id']).to eq('1.1.1.1')
+      expect(subject.set_router_id('1', enable: false)).to be_truthy
+      expect(subject.get('1')['router_id']).to be_empty
+    end
+
+    it 'defaults the router id' do
+      expect(subject.set_router_id('1', value: '1.1.1.1')).to be_truthy
+      expect(subject.get('1')['router_id']).to eq('1.1.1.1')
+      expect(subject.set_router_id('1', default: true)).to be_truthy
+      expect(subject.get('1')['router_id']).to be_empty
+    end
   end
 
   describe '#create' do

data/spec/system/api_varp_interfaces_spec.rb

@@ -65,5 +65,21 @@ describe Rbeapi::Api::VarpInterfaces do
         .to be_truthy
       expect(subject.get('Vlan100')['addresses']).not_to include('99.99.99.98')
     end
+
+    it 'negate the list of addresses' do
+      expect(subject.set_addresses('Vlan100', value: ['99.99.99.98']))
+        .to be_truthy
+      expect(subject.get('Vlan100')['addresses']).to include('99.99.99.98')
+      expect(subject.set_addresses('Vlan100', enable: false)).to be_truthy
+      expect(subject.get('Vlan100')['addresses']).to be_empty
+    end
+
+    it 'default the list of addresses' do
+      expect(subject.set_addresses('Vlan100', value: ['99.99.99.98']))
+        .to be_truthy
+      expect(subject.get('Vlan100')['addresses']).to include('99.99.99.98')
+      expect(subject.set_addresses('Vlan100', default: true)).to be_truthy
+      expect(subject.get('Vlan100')['addresses']).to be_empty
+    end
   end
 end

data/spec/system/rbeapi/api/dns_spec.rb

@@ -27,6 +27,44 @@ describe Rbeapi::Api::Dns do
       expect(subject.set_domain_name(value: 'arista.com')).to be_truthy
       expect(subject.get[:domain_name]).to eq('arista.com')
     end
+
+    it 'negates the domain name' do
+      expect(subject.set_domain_name(value: 'arista.com')).to be_truthy
+      expect(subject.get[:domain_name]).to eq('arista.com')
+      expect(subject.set_domain_name(enable: false)).to be_truthy
+      expect(subject.get[:domain_name]).to be_empty
+    end
+
+    it 'defaults the domain name' do
+      expect(subject.set_domain_name(value: 'arista.com')).to be_truthy
+      expect(subject.get[:domain_name]).to eq('arista.com')
+      expect(subject.set_domain_name(default: true)).to be_truthy
+      expect(subject.get[:domain_name]).to be_empty
+    end
+  end
+
+  describe '#set_name_servers' do
+    let(:servers) {  %w(1.2.3.4 5.6.7.8 9.10.11.12) }
+
+    before { node.config('no ip name-server') }
+
+    it 'add all the servers to the name servers list' do
+      expect(subject.get[:name_servers]).to be_empty
+      expect(subject.set_name_servers(value: servers)).to be_truthy
+      expect(subject.get[:name_servers]).to eq(servers)
+    end
+
+    it 'negate the name servers list' do
+      expect(subject.get[:name_servers]).to be_empty
+      expect(subject.set_name_servers(enable: false)).to be_truthy
+      expect(subject.get[:name_servers]).to be_empty
+    end
+
+    it 'default the name servers list' do
+      expect(subject.get[:name_servers]).to be_empty
+      expect(subject.set_name_servers(default: true)).to be_truthy
+      expect(subject.get[:name_servers]).to be_empty
+    end
   end
 
   describe '#add_name_server' do
@@ -55,6 +93,34 @@ describe Rbeapi::Api::Dns do
     end
   end
 
+  describe '#set_domain_list' do
+    let(:servers) {  %w(foo bar baz) }
+
+    before do
+      node.config(['no ip domain-list foo',
+                   'no ip domain-list bar',
+                   'no ip domain-list baz'])
+    end
+
+    it 'add all the servers to the name servers list' do
+      expect(subject.get[:domain_list]).to be_empty
+      expect(subject.set_domain_list(value: servers)).to be_truthy
+      expect(subject.get[:domain_list]).to eq(servers)
+    end
+
+    it 'negate the name servers list' do
+      expect(subject.get[:domain_list]).to be_empty
+      expect(subject.set_domain_list(enable: false)).to be_truthy
+      expect(subject.get[:domain_list]).to be_empty
+    end
+
+    it 'default the name servers list' do
+      expect(subject.get[:domain_list]).to be_empty
+      expect(subject.set_domain_list(default: true)).to be_truthy
+      expect(subject.get[:domain_list]).to be_empty
+    end
+  end
+
   describe '#add_domain_list' do
     before { node.config(['no ip domain-list arista.net']) }
 

data/spec/system/rbeapi/api/interfaces_base_spec.rb

@@ -76,17 +76,17 @@ describe Rbeapi::Api::Interfaces do
   end
 
   describe '#set_shutdown' do
-    it 'sets the shutdown value to true' do
+    it 'shutdown the interface' do
       node.config(['interface Loopback0', 'no shutdown'])
       expect(subject.get('Loopback0')[:shutdown]).to be_falsy
-      expect(subject.set_shutdown('Loopback0', value: true)).to be_truthy
+      expect(subject.set_shutdown('Loopback0', enable: false)).to be_truthy
       expect(subject.get('Loopback0')[:shutdown]).to be_truthy
     end
 
-    it 'sets the shutdown value to false' do
+    it 'enable the interface' do
       node.config(['interface Loopback0', 'shutdown'])
       expect(subject.get('Loopback0')[:shutdown]).to be_truthy
-      expect(subject.set_shutdown('Loopback0', value: false)).to be_truthy
+      expect(subject.set_shutdown('Loopback0', enable: true)).to be_truthy
       expect(subject.get('Loopback0')[:shutdown]).to be_falsy
     end
   end

data/spec/system/rbeapi/api/interfaces_ethernet_spec.rb

@@ -70,17 +70,17 @@ describe Rbeapi::Api::Interfaces do
   end
 
   describe '#set_shutdown' do
-    it 'sets the shutdown value to true' do
+    it 'shutdown the interface' do
       node.config(['interface Ethernet1', 'no shutdown'])
       expect(subject.get('Ethernet1')[:shutdown]).to be_falsy
-      expect(subject.set_shutdown('Ethernet1', value: true)).to be_truthy
+      expect(subject.set_shutdown('Ethernet1', enable: false)).to be_truthy
       expect(subject.get('Ethernet1')[:shutdown]).to be_truthy
     end
 
-    it 'sets the shutdown value to false' do
+    it 'enable the interface' do
       node.config(['interface Ethernet1', :shutdown])
       expect(subject.get('Ethernet1')[:shutdown]).to be_truthy
-      expect(subject.set_shutdown('Ethernet1', value: false)).to be_truthy
+      expect(subject.set_shutdown('Ethernet1', enable: true)).to be_truthy
       expect(subject.get('Ethernet1')[:shutdown]).to be_falsy
     end
   end
@@ -89,14 +89,14 @@ describe Rbeapi::Api::Interfaces do
     it 'sets the sflow value to true' do
       node.config(['interface Ethernet1', 'no sflow enable'])
       expect(subject.get('Ethernet1')[:sflow]).to be_falsy
-      expect(subject.set_sflow('Ethernet1', value: true)).to be_truthy
+      expect(subject.set_sflow('Ethernet1', enable: true)).to be_truthy
       expect(subject.get('Ethernet1')[:sflow]).to be_truthy
     end
 
     it 'sets the sflow value to false' do
       node.config(['interface Ethernet1', 'sflow enable'])
       expect(subject.get('Ethernet1')[:sflow]).to be_truthy
-      expect(subject.set_sflow('Ethernet1', value: false)).to be_truthy
+      expect(subject.set_sflow('Ethernet1', enable: false)).to be_truthy
       expect(subject.get('Ethernet1')[:sflow]).to be_falsy
     end
   end

data/spec/system/rbeapi/api/interfaces_portchannel_spec.rb

@@ -82,17 +82,17 @@ describe Rbeapi::Api::Interfaces do
   end
 
   describe '#set_shutdown' do
-    it 'sets the shutdown value to true' do
+    it 'shutdown the interface' do
       node.config(['interface Port-Channel1', 'no shutdown'])
       expect(subject.get('Port-Channel1')[:shutdown]).to be_falsy
-      expect(subject.set_shutdown('Port-Channel1', value: true)).to be_truthy
+      expect(subject.set_shutdown('Port-Channel1', enable: false)).to be_truthy
       expect(subject.get('Port-Channel1')[:shutdown]).to be_truthy
     end
 
-    it 'sets the shutdown value to false' do
-      node.config(['interface Port-Channel1', :shutdown])
+    it 'enable the interface' do
+      node.config(['interface Port-Channel1', 'shutdown'])
       expect(subject.get('Port-Channel1')[:shutdown]).to be_truthy
-      expect(subject.set_shutdown('Port-Channel1', value: false)).to be_truthy
+      expect(subject.set_shutdown('Port-Channel1', enable: true)).to be_truthy
       expect(subject.get('Port-Channel1')[:shutdown]).to be_falsy
     end
   end
@@ -183,7 +183,7 @@ describe Rbeapi::Api::Interfaces do
       node.config(['interface Port-Channel1',
                    'port-channel lacp fallback static'])
       expect(subject.get('Port-Channel1')[:lacp_fallback]).to eq('static')
-      expect(subject.set_lacp_fallback('Port-Channel1', value: 'disabled'))
+      expect(subject.set_lacp_fallback('Port-Channel1', enable: false))
         .to be_truthy
       expect(subject.get('Port-Channel1')[:lacp_fallback]).to eq('disabled')
     end

data/spec/system/rbeapi/api/interfaces_vxlan_spec.rb

@@ -77,17 +77,17 @@ describe Rbeapi::Api::Interfaces do
   end
 
   describe '#set_shutdown' do
-    it 'sets the shutdown value to true' do
+    it 'shutdown the interface' do
       node.config(['interface Vxlan1', 'no shutdown'])
       expect(subject.get('Vxlan1')[:shutdown]).to be_falsy
-      expect(subject.set_shutdown('Vxlan1', value: true)).to be_truthy
+      expect(subject.set_shutdown('Vxlan1', enable: false)).to be_truthy
       expect(subject.get('Vxlan1')[:shutdown]).to be_truthy
     end
 
-    it 'sets the shutdown value to false' do
+    it 'enable the interface' do
       node.config(['interface Vxlan1', 'shutdown'])
       expect(subject.get('Vxlan1')[:shutdown]).to be_truthy
-      expect(subject.set_shutdown('Vxlan1', value: false)).to be_truthy
+      expect(subject.set_shutdown('Vxlan1', enable: true)).to be_truthy
       expect(subject.get('Vxlan1')[:shutdown]).to be_falsy
     end
   end

data/spec/system/rbeapi/api/ipinterfaces_spec.rb

@@ -76,6 +76,22 @@ describe Rbeapi::Api::Ipinterfaces do
         .to be_truthy
       expect(subject.get('Ethernet1')[:address]).to eq('77.99.99.99/24')
     end
+
+    it 'negates the address value' do
+      expect(subject.set_address('Ethernet1', value: '77.99.99.99/24'))
+        .to be_truthy
+      expect(subject.get('Ethernet1')[:address]).to eq('77.99.99.99/24')
+      expect(subject.set_address('Ethernet1', enable: false)).to be_truthy
+      expect(subject.get('Ethernet1')[:address]).to be_empty
+    end
+
+    it 'defaults the address value' do
+      expect(subject.set_address('Ethernet1', value: '77.99.99.99/24'))
+        .to be_truthy
+      expect(subject.get('Ethernet1')[:address]).to eq('77.99.99.99/24')
+      expect(subject.set_address('Ethernet1', default: true)).to be_truthy
+      expect(subject.get('Ethernet1')[:address]).to be_empty
+    end
   end
 
   describe '#set_mtu' do
@@ -89,6 +105,20 @@ describe Rbeapi::Api::Ipinterfaces do
       expect(subject.set_mtu('Ethernet1', value: '2000')).to be_truthy
       expect(subject.get('Ethernet1')[:mtu]).to eq('2000')
     end
+
+    it 'negates the mtu' do
+      expect(subject.set_mtu('Ethernet1', value: '2000')).to be_truthy
+      expect(subject.get('Ethernet1')[:mtu]).to eq('2000')
+      expect(subject.set_mtu('Ethernet1', enable: false)).to be_truthy
+      expect(subject.get('Ethernet1')[:mtu]).to eq('1500')
+    end
+
+    it 'defaults the mtu' do
+      expect(subject.set_mtu('Ethernet1', value: '2000')).to be_truthy
+      expect(subject.get('Ethernet1')[:mtu]).to eq('2000')
+      expect(subject.set_mtu('Ethernet1', default: true)).to be_truthy
+      expect(subject.get('Ethernet1')[:mtu]).to eq('1500')
+    end
   end
 
   describe '#set_helper_addresses' do
@@ -106,5 +136,19 @@ describe Rbeapi::Api::Ipinterfaces do
       expect(subject.get('Ethernet1')[:helper_addresses].sort)
         .to eq(helpers.sort)
     end
+
+    it 'negates the helper addresses on the interface' do
+      expect(subject.get('Ethernet1')[:helper_addresses]).to be_empty
+      expect(subject.set_helper_addresses('Ethernet1', enable: false))
+        .to be_truthy
+      expect(subject.get('Ethernet1')[:helper_addresses].sort).to be_empty
+    end
+
+    it 'default the helper addresses on the interface' do
+      expect(subject.get('Ethernet1')[:helper_addresses]).to be_empty
+      expect(subject.set_helper_addresses('Ethernet1', default: true))
+        .to be_truthy
+      expect(subject.get('Ethernet1')[:helper_addresses].sort).to be_empty
+    end
   end
 end

data/spec/system/rbeapi/api/logging_spec.rb

@@ -31,16 +31,32 @@ describe Rbeapi::Api::Logging do
     it 'configures global logging enabled' do
       node.config('no logging on')
       expect(subject.get[:enable]).to be_falsy
-      expect(subject.set_enable(value: true)).to be_truthy
+      expect(subject.set_enable(enable: true)).to be_truthy
       expect(subject.get[:enable]).to be_truthy
     end
 
     it 'configures global logging disabled' do
       node.config('logging on')
       expect(subject.get[:enable]).to be_truthy
-      expect(subject.set_enable(value: false)).to be_truthy
+      expect(subject.set_enable(enable: false)).to be_truthy
       expect(subject.get[:enable]).to be_falsy
     end
+
+    it 'defaults the global logging' do
+      # Default is on
+
+      # Validate the on case
+      node.config('logging on')
+      expect(subject.get[:enable]).to be_truthy
+      expect(subject.set_enable(default: true)).to be_truthy
+      expect(subject.get[:enable]).to be_truthy
+
+      # Validate the off case
+      node.config('no logging on')
+      expect(subject.get[:enable]).to be_falsy
+      expect(subject.set_enable(default: true)).to be_truthy
+      expect(subject.get[:enable]).to be_truthy
+    end
   end
 
   describe '#add_host' do