rbeapi 0.1.0 → 0.2.0

data/spec/system/rbeapi/api/stp_instances_spec.rb

@@ -12,9 +12,11 @@ describe Rbeapi::Api::StpInstances do
   end
 
   describe '#get' do
-    before { node.config(['spanning-tree mode mstp',
-                          'spanning-tree mst configuration',
-                          'instance 1 vlans 1', 'exit']) }
+    before do
+      node.config(['spanning-tree mode mstp',
+                   'spanning-tree mst configuration',
+                   'instance 1 vlans 1', 'exit'])
+    end
 
     it 'returns the stp instance resource as a hash' do
       expect(subject.get('1')).to be_a_kind_of(Hash)
@@ -26,8 +28,9 @@ describe Rbeapi::Api::StpInstances do
   end
 
   describe '#getall' do
-    before { node.config(['no spanning-tree mode mstp',
-                          'spanning-tree mode mstp']) }
+    before do
+      node.config(['no spanning-tree mode mstp', 'spanning-tree mode mstp'])
+    end
 
     it 'returns a kind of hash' do
       expect(subject.getall).to be_a_kind_of(Hash)
@@ -35,9 +38,11 @@ describe Rbeapi::Api::StpInstances do
   end
 
   describe '#delete' do
-    before { node.config(['spanning-tree mode mstp',
-                          'spanning-tree mst configuration',
-                          'instance 1 vlans 1', 'exit']) }
+    before do
+      node.config(['spanning-tree mode mstp',
+                   'spanning-tree mst configuration',
+                   'instance 1 vlans 1', 'exit'])
+    end
 
     it 'deletes the mst instance' do
       expect(subject.get('1')).not_to be_nil
@@ -47,10 +52,13 @@ describe Rbeapi::Api::StpInstances do
   end
 
   describe '#set_priority' do
-    before { node.config(['spanning-tree mode mstp',
-                          'default spanning-tree mst configuration',
-                          'spanning-tree mst configuration',
-                          'instance 1 vlans 1', 'exit']) }
+    before do
+      node.config(['default spanning-tree mst 1 priority',
+                   'spanning-tree mode mstp',
+                   'default spanning-tree mst configuration',
+                   'spanning-tree mst configuration',
+                   'instance 1 vlans 1', 'exit'])
+    end
 
     it 'set the instance priority' do
       expect(subject.get('1')[:priority]).to eq('32768')

data/spec/system/rbeapi/api/stp_interfaces_spec.rb

@@ -12,9 +12,8 @@ describe Rbeapi::Api::StpInterfaces do
   end
 
   describe '#get' do
-
     let(:entity) do
-      { portfast: false, bpduguard: false }
+      { portfast: false, portfast_type: 'normal', bpduguard: false }
     end
 
     before { node.config('default interface Ethernet1') }
@@ -25,7 +24,6 @@ describe Rbeapi::Api::StpInterfaces do
   end
 
   describe '#getall' do
-
     before { node.config('default interface Ethernet1') }
 
     it 'includes interface ethernet1' do

data/spec/system/rbeapi/api/switchports_spec.rb

@@ -12,13 +12,14 @@ describe Rbeapi::Api::Switchports do
   end
 
   describe '#get' do
-
     let(:keys) do
-      [ :mode, :access_vlan, :trunk_native_vlan, :trunk_allowed_vlans ]
+      [:mode, :access_vlan, :trunk_native_vlan, :trunk_allowed_vlans]
     end
 
-    before { node.config(['default interface Ethernet1', 'interface Ethernet2',
-                          'no switchport']) }
+    before do
+      node.config(['default interface Ethernet1', 'interface Ethernet2',
+                   'no switchport'])
+    end
 
     it 'returns the switchport resource' do
       expect(subject.get('Ethernet1')).not_to be_nil
@@ -33,7 +34,8 @@ describe Rbeapi::Api::Switchports do
     end
 
     it 'returns allowed_vlans as an array' do
-      expect(subject.get('Ethernet1')[:trunk_allowed_vlans]).to be_a_kind_of(Array)
+      expect(subject.get('Ethernet1')[:trunk_allowed_vlans])
+        .to be_a_kind_of(Array)
     end
   end
 
@@ -47,7 +49,7 @@ describe Rbeapi::Api::Switchports do
     it 'returns a hash collection' do
       expect(subject.getall).to be_a_kind_of(Hash)
     end
- end
+  end
 
   describe '#create' do
     before { node.config(['interface Ethernet1', 'no switchport']) }
@@ -110,7 +112,8 @@ describe Rbeapi::Api::Switchports do
 
     it 'sets the trunk native vlan to 100' do
       expect(subject.get('Ethernet1')[:trunk_native_vlan]).to eq('1')
-      expect(subject.set_trunk_native_vlan('Ethernet1', value: '100')).to be_truthy
+      expect(subject.set_trunk_native_vlan('Ethernet1', value: '100'))
+        .to be_truthy
       expect(subject.get('Ethernet1')[:trunk_native_vlan]).to eq('100')
     end
   end
@@ -119,17 +122,16 @@ describe Rbeapi::Api::Switchports do
     before { node.config(['default interface Ethernet1', 'vlan 100']) }
 
     it 'raises an ArgumentError if value is not an array' do
-      expect {
-        subject.set_trunk_allowed_vlans('Ethernet1', value: '1-100')
-      }.to raise_error(ArgumentError)
+      expect { subject.set_trunk_allowed_vlans('Ethernet1', value: '1-100') }
+        .to raise_error(ArgumentError)
     end
 
     it 'sets vlan 100 to the trunk allowed vlans' do
       node.config(['interface Ethernet1', 'switchport trunk allowed vlan none'])
       expect(subject.get('Ethernet1')[:trunk_allowed_vlans]).to be_empty
-      expect(subject.set_trunk_allowed_vlans('Ethernet1', value: [100])).to be_truthy
+      expect(subject.set_trunk_allowed_vlans('Ethernet1', value: [100]))
+        .to be_truthy
       expect(subject.get('Ethernet1')[:trunk_allowed_vlans]).to include(100)
     end
   end
 end
-

data/spec/system/rbeapi/api/system_spec.rb

@@ -12,7 +12,6 @@ describe Rbeapi::Api::System do
   end
 
   describe '#get' do
-
     let(:entity) do
       { hostname: 'localhost' }
     end
@@ -34,5 +33,3 @@ describe Rbeapi::Api::System do
     end
   end
 end
-
-

data/spec/system/rbeapi/api/vlans_spec.rb

@@ -11,16 +11,29 @@ describe Rbeapi::Api::Vlans do
     Rbeapi::Client.connect_to('dut')
   end
 
-  describe '#get' do
+  context '#get' do
+    describe 'with defaults' do
+      let(:entity) do
+        { name: 'default', state: 'active', trunk_groups: [] }
+      end
 
-    let(:entity) do
-      { name: 'default', state: 'active', trunk_groups: [] }
+      before { node.config(['no vlan 1-4094', 'vlan 1']) }
+
+      it 'returns the vlan resource' do
+        expect(subject.get('1')).to eq(entity)
+      end
     end
 
-    before { node.config(['no vlan 1-4094', 'vlan 1']) }
+    describe 'validate name parser' do
+      let(:entity) do
+        { name: 'test-vlan', state: 'active', trunk_groups: [] }
+      end
+
+      before { node.config(['no vlan 1-4094', 'vlan 1', 'name test-vlan']) }
 
-    it 'returns the vlan resource' do
-      expect(subject.get('1')).to eq(entity)
+      it 'returns the vlan resource' do
+        expect(subject.get('1')).to eq(entity)
+      end
     end
   end
 
@@ -81,7 +94,6 @@ describe Rbeapi::Api::Vlans do
   end
 
   describe '#set_state' do
-
     it 'sets vlan 1 state to suspend' do
       node.config(['default vlan 1', 'vlan 1'])
       expect(subject.get('1')[:state]).to eq('active')
@@ -117,5 +129,3 @@ describe Rbeapi::Api::Vlans do
     end
   end
 end
-
-

data/spec/unit/rbeapi/api/acl/default_spec.rb

@@ -0,0 +1,158 @@
+#
+# Copyright (c) 2015, Arista Networks, Inc.
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are
+# met:
+#
+#   Redistributions of source code must retain the above copyright notice,
+#   this list of conditions and the following disclaimer.
+#
+#   Redistributions in binary form must reproduce the above copyright
+#   notice, this list of conditions and the following disclaimer in the
+#   documentation and/or other materials provided with the distribution.
+#
+#   Neither the name of Arista Networks nor the names of its
+#   contributors may be used to endorse or promote products derived from
+#   this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL ARISTA NETWORKS
+# BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
+# BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
+# WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE
+# OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN
+# IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+#
+require 'spec_helper'
+
+require 'rbeapi/api/acl'
+
+include FixtureHelpers
+
+describe Rbeapi::Api::Acl do
+  subject { described_class.new(node) }
+
+  let(:node) { double('node') }
+
+  def acls
+    acls = Fixtures[:acls]
+    return acls if acls
+    fixture('acl_standard', format: :text, dir: File.dirname(__FILE__))
+  end
+
+  before :each do
+    allow(subject.node).to receive(:running_config).and_return(acls)
+  end
+
+  describe '#get' do
+    let(:test1_entries) do
+      { '10' => { seqno: '10', action: 'permit', srcaddr: '1.2.3.4',
+                  srcprefixlen: '255.255.255.255', log: 'log' },
+        '20' => { seqno: '20', action: 'permit', srcaddr: '1.2.3.4',
+                  srcprefixlen: '255.255.0.0', log: 'log' },
+        '30' => { seqno: '30', action: 'deny', srcaddr: '0.0.0.0',
+                  srcprefixlen: '255.255.255.255', log: nil },
+        '40' => { seqno: '40', action: 'permit', srcaddr: '5.6.7.0',
+                  srcprefixlen: '24', log: nil },
+        '50' => { seqno: '50', action: 'permit', srcaddr: '16.0.0.0',
+                  srcprefixlen: '8', log: nil },
+        '60' => { seqno: '60', action: 'permit', srcaddr: '9.10.11.0',
+                  srcprefixlen: '255.255.255.0', log: 'log' }
+      }
+    end
+
+    it 'returns the ACL resource' do
+      expect(subject.get('test1')).to eq(test1_entries)
+    end
+  end
+
+  describe '#getall' do
+    it 'returns the ACL collection' do
+      expect(subject.getall).to include('test1')
+      expect(subject.getall).to include('test2')
+    end
+
+    it 'returns a hash collection' do
+      expect(subject.getall).to be_a_kind_of(Hash)
+    end
+
+    it 'has two entries' do
+      expect(subject.getall.size).to eq(2)
+    end
+  end
+
+  describe '#create' do
+    it 'creates a new ACL resource' do
+      expect(node).to receive(:config).with('ip access-list standard abc')
+      expect(subject.create('abc')).to be_truthy
+    end
+  end
+
+  describe '#delete' do
+    it 'deletes an ACL resource' do
+      expect(node).to receive(:config).with('no ip access-list standard abc')
+      expect(subject.delete('abc')).to be_truthy
+    end
+  end
+
+  describe '#default' do
+    it 'sets ACL abc to default value' do
+      expect(node).to receive(:config)
+        .with('default ip access-list standard abc')
+      expect(subject.default('abc')).to be_truthy
+    end
+  end
+
+  describe '#update_entry' do
+    let(:update_entry) do
+      { seqno: '60', action: 'permit', srcaddr: '0.0.0.0',
+        srcprefixlen: '255.255.255.255', log: nil }
+    end
+
+    let(:update_cmd) do
+      ['ip access-list standard test2', 'no 60',
+       '60 permit 0.0.0.0/255.255.255.255', 'exit']
+    end
+
+    it 'Change entry 60 to values in update_entry' do
+      expect(subject.get('test2')['60'][:action]).to eq('deny')
+      expect(node).to receive(:config).with(update_cmd)
+      expect(subject.update_entry('test2', update_entry)).to be_truthy
+    end
+  end
+
+  describe '#add_entry' do
+    let(:new_entry) do
+      { seqno: '90', action: 'deny', srcaddr: '1.2.3.0',
+        srcprefixlen: '255.255.255.0', log: nil }
+    end
+
+    let(:new_cmd) do
+      ['ip access-list standard test2', '90 deny 1.2.3.0/255.255.255.0',
+       'exit']
+    end
+
+    it 'Add entry 90 to the test2 ACL' do
+      expect(subject.get('test2')['90']).to be_falsy
+      expect(node).to receive(:config).with(new_cmd)
+      expect(subject.add_entry('test2', new_entry)).to be_truthy
+    end
+  end
+
+  describe '#remove_entry' do
+    let(:delete_cmd) do
+      ['ip access-list standard test2', 'no 30', 'exit']
+    end
+
+    it 'Remove entry 30 from the test2 ACL' do
+      expect(node).to receive(:config).with(delete_cmd)
+      expect(subject.remove_entry('test2', '30')).to be_truthy
+    end
+  end
+end

data/spec/unit/rbeapi/api/acl/fixture_acl_standard.text

@@ -0,0 +1,22 @@
+ip access-list standard test1
+   no statistics per-entry
+   fragment-rules
+   10 permit host 1.2.3.4 log
+   20 permit 1.2.3.4 255.255.0.0 log
+   30 deny any
+   40 permit 5.6.7.0/24
+   50 permit 16.0.0.0/8
+   60 permit 9.10.11.0 255.255.255.0 log
+!
+ip access-list standard test2
+   no statistics per-entry
+   fragment-rules
+   10 permit 100.1.1.0 255.255.0.0
+   20 permit 100.2.1.0 255.255.0.0
+   30 permit 100.3.1.0 255.255.0.0
+   40 permit 100.4.1.0 255.255.0.0
+   50 permit 100.5.1.0 255.255.0.0
+   60 deny 100.6.1.0 255.255.0.0 log
+   70 permit 11.12.13.14
+   80 permit 15.16.17.18
+!

data/spec/unit/rbeapi/api/interfaces/base_spec.rb

@@ -0,0 +1,123 @@
+require 'spec_helper'
+
+require 'rbeapi/api/interfaces'
+
+include FixtureHelpers
+
+describe Rbeapi::Api::BaseInterface do
+  subject { described_class.new(node) }
+
+  let(:node) { double('node') }
+
+  def interfaces
+    interfaces = Fixtures[:interfaces]
+    return interfaces if interfaces
+    fixture('interfaces', format: :text, dir: File.dirname(__FILE__))
+  end
+
+  before :each do
+    allow(subject.node).to receive(:running_config).and_return(interfaces)
+  end
+
+  describe '#get' do
+    let(:resource) { subject.get('Loopback0') }
+
+    let(:keys) do
+      [:type, :shutdown, :description, :name]
+    end
+
+    it 'returns an ethernet resource as a hash' do
+      expect(resource).to be_a_kind_of(Hash)
+    end
+
+    it 'returns an interface type of generic' do
+      expect(resource[:type]).to eq('generic')
+    end
+
+    it 'has all keys' do
+      expect(resource.keys).to match_array(keys)
+    end
+  end
+
+  describe '#create' do
+    it 'creates the interface in the config' do
+      expect(node).to receive(:config).with('interface Loopback0')
+      expect(subject.create('Loopback0')).to be_truthy
+    end
+  end
+
+  describe '#delete' do
+    it 'deletes the interface in the config' do
+      expect(node).to receive(:config).with('no interface Loopback0')
+      expect(subject.delete('Loopback0')).to be_truthy
+    end
+  end
+
+  describe '#default' do
+    it 'defaults the interface config' do
+      expect(node).to receive(:config).with('default interface Loopback0')
+      expect(subject.default('Loopback0')).to be_truthy
+    end
+  end
+
+  describe '#set_description' do
+    it 'sets the interface description' do
+      expect(node).to receive(:config).with(['interface Loopback0',
+                                             'description test string'])
+      expect(subject.set_description('Loopback0', value: 'test string'))
+        .to be_truthy
+    end
+
+    it 'negates the interface description' do
+      expect(node).to receive(:config).with(['interface Loopback0',
+                                             'no description'])
+      expect(subject.set_description('Loopback0')).to be_truthy
+    end
+
+    it 'defaults the interface description' do
+      expect(node).to receive(:config).with(['interface Loopback0',
+                                             'default description'])
+      expect(subject.set_description('Loopback0', default: true)).to be_truthy
+    end
+
+    it 'default is preferred over value' do
+      expect(node).to receive(:config).with(['interface Loopback0',
+                                             'default description'])
+      expect(subject.set_description('Loopback0', value: 'test',
+                                                  default: true)).to be_truthy
+    end
+  end
+
+  describe '#set_shutdown' do
+    it 'enables the interface' do
+      expect(node).to receive(:config).with(['interface Loopback0',
+                                             'no shutdown'])
+      expect(subject.set_shutdown('Loopback0', value: false)).to be_truthy
+    end
+
+    it 'disables the interface' do
+      expect(node).to receive(:config).with(['interface Loopback0',
+                                             'shutdown'])
+      expect(subject.set_shutdown('Loopback0', value: true)).to be_truthy
+    end
+
+    it 'negates the interface description' do
+      expect(node).to receive(:config).with(['interface Loopback0',
+                                             'no shutdown'])
+      expect(subject.set_shutdown('Loopback0')).to be_truthy
+    end
+
+    it 'defaults the interface state' do
+      expect(node).to receive(:config).with(['interface Loopback0',
+                                             'default shutdown'])
+      expect(subject.set_shutdown('Loopback0', default: true)).to be_truthy
+    end
+
+    it 'default is preferred over value' do
+      expect(node).to receive(:config).with(['interface Loopback0',
+                                             'default shutdown'])
+      expect(subject.set_shutdown('Loopback0', value: 'test',
+                                               default: true)).to be_truthy
+    end
+  end
+end

data/spec/unit/rbeapi/api/interfaces/ethernet_spec.rb

@@ -0,0 +1,89 @@
+require 'spec_helper'
+
+require 'rbeapi/api/interfaces'
+
+include FixtureHelpers
+
+describe Rbeapi::Api::EthernetInterface do
+  subject { described_class.new(node) }
+
+  let(:node) { double('node') }
+
+  def interfaces
+    interfaces = Fixtures[:interfaces]
+    return interfaces if interfaces
+    fixture('interfaces', format: :text, dir: File.dirname(__FILE__))
+  end
+
+  before :each do
+    allow(subject.node).to receive(:running_config).and_return(interfaces)
+  end
+
+  describe '#get' do
+    let(:resource) { subject.get('Ethernet1') }
+
+    let(:keys) do
+      [:type, :speed, :sflow, :flowcontrol_send, :flowcontrol_receive,
+       :forced, :shutdown, :description, :name]
+    end
+
+    it 'returns an ethernet resource as a hash' do
+      expect(resource).to be_a_kind_of(Hash)
+    end
+
+    it 'returns an interface type of ethernet' do
+      expect(resource[:type]).to eq('ethernet')
+    end
+
+    it 'has all keys' do
+      expect(resource.keys).to match_array(keys)
+    end
+  end
+
+  describe '#create' do
+    it 'raises a NotImplementedError on create' do
+      expect { subject.create('Ethernet1') }.to raise_error(NotImplementedError)
+    end
+  end
+
+  describe '#delete' do
+    it 'raises a NotImplementedError on delete' do
+      expect { subject.delete('Ethernet1') }.to raise_error(NotImplementedError)
+    end
+  end
+
+  describe '#default' do
+    it 'defaults the interface config' do
+      expect(node).to receive(:config).with('default interface Ethernet1')
+      expect(subject.default('Ethernet1')).to be_truthy
+    end
+  end
+
+  describe '#set_description' do
+    it 'sets the interface description' do
+      expect(node).to receive(:config).with(['interface Ethernet1',
+                                             'description test string'])
+      expect(subject.set_description('Ethernet1', value: 'test string'))
+        .to be_truthy
+    end
+
+    it 'negates the interface description' do
+      expect(node).to receive(:config).with(['interface Ethernet1',
+                                             'no description'])
+      expect(subject.set_description('Ethernet1')).to be_truthy
+    end
+
+    it 'defaults the interface description' do
+      expect(node).to receive(:config).with(['interface Ethernet1',
+                                             'default description'])
+      expect(subject.set_description('Ethernet1', default: true)).to be_truthy
+    end
+
+    it 'default is preferred over value' do
+      expect(node).to receive(:config).with(['interface Ethernet1',
+                                             'default description'])
+      expect(subject.set_description('Ethernet1', value: 'test',
+                                                  default: true)).to be_truthy
+    end
+  end
+end