rbcurse-core 0.0.0 → 0.0.1

data/lib/rbcurse/core/include/rhistory.rb

@@ -29,8 +29,9 @@ module RubyCurses
       bind_key($history_key) { _show_history }
       # widget should have CHANGED event, or this will either give error, or just not work
       # else please update history whenever you want a value to be retrieved
-      bind(:CHANGED) { @history << @text unless @history.include? @text }
+      bind(:CHANGED) { @history << @text if @text && (!@history.include? @text) }
     end
+    def history=(x); history(x); end
     
     # pass in some configuration for histroy such as row and column to show popup on
     def history_config config={}
@@ -42,13 +43,29 @@ module RubyCurses
     private
     def _show_history
       return unless @history
+      return  if @history.empty?
       list = @history
+      @_history_config ||= {}
+      #list = ["No history"]  if @history.empty?
+      raise ArgumentError, "show_history got nil list" unless list
       # calculate r and c
-      c = @_history_config[:col] || @col # this is also dependent on window coords, as in a status_window or messagebox
-      r = @row - 10
-      if @row < 10
-        r = @row + 1
+      # col if fine, except for when there's a label.
+      c = @_history_config[:col] || @field_col || @col # this is also dependent on window coords, as in a status_window or messagebox
+      sz = @history.size
+      wrow = 0
+      wrow = self.form.window.top if self.form
+      crow = wrow + @row
+      # if list can be displayed above, then fit it just above
+      if crow > sz + 2
+        r = crow - sz - 2
+      else
+        # else fit it in next row
+        r = crow + 1
       end
+      #r = @row - 10
+      #if @row < 10
+        #r = @row + 1
+      #end
       r = @_history_config[:row] || r
       ret = popuplist(list, :row => r, :col => c, :title  => " History ")
       if ret

data/lib/rbcurse/core/system/ncurses.rb

@@ -99,10 +99,9 @@ module VER
     #puts "curses over"
   ensure
     return unless error = @last_error
-    log = Config[:logfile].value
-
-    Kernel.warn "There may have been fatal errors logged to: #{log}."
-    Kernel.warn "The most recent was:"
+    #log = RbConfig[:logfile].value
+    #Kernel.warn "There may have been fatal errors logged to: #{log}."
+    #Kernel.warn "The most recent was:"
 
     $stderr.puts ''
     $stderr.puts @last_error_message if @last_error_message

data/lib/rbcurse/core/system/window.rb

@@ -36,7 +36,6 @@ module VER
     attr_reader   :window_type   # window or pad to distinguish 2009-11-02 23:11 
     attr_accessor :name  # more for debugging log files. 2010-02-02 19:58 
     attr_accessor :modified # has it been modified and may need a refresh
-    #attr_reader   :bottomline  # experimental here 2010-11-03 22:19 
 
     # @param [Array, Hash] window coordinates (ht, w, top, left)
     # or 
@@ -729,51 +728,6 @@ module VER
       mvwprintw(r, c, "%s", :string, string);
       wattroff(Ncurses.COLOR_PAIR(color) | att)
     end
-    # @deprecated
-    def print_error_message text=$error_message.get_value
-      alert text
-    end
-    # added by rk 2008-11-29 19:01 
-    # @deprecated. use global method of same name in rdialog
-    def print_status_message text=$status_message
-      #VER::print_status_message text
-      alert text
-    end
-    # added by rk 2008-11-29 19:01 
-    # Since these methods write directly to window they are not advised
-    # since clearing previous message we don't know how much to clear.
-    # Best to map error_message to a label.
-    #  2010-09-13 00:22 WE should not use these any longer.
-    #  Application should create a label and map a Variable named
-    #  $errormessage to it. We should only update the Variable
-    def DEPRECATED_print_error_message text=$error_message.get_value
-      r = $error_message_row || Ncurses.LINES-1
-      c = $error_message_col || (Ncurses.COLS-text.length)/2 
-
-      $log.debug "got ERROR MESSAGE #{text} row #{r} "
-      clear_error r, $datacolor
-      printstring r, c, text, color = $promptcolor
-      $error_message_clear_pending = true
-    end
-    # added by rk 2008-11-29 19:01 
-    # @deprecated. use global method of same name
-    def DEPRECATED_print_status_message text=$status_message
-      r = $status_message_row || Ncurses.LINES-1
-      clear_error r, $datacolor
-      # print it in centre
-      printstring r, (Ncurses.COLS-text.length)/2, text, color = $promptcolor
-    end
-    # Clear error message printed
-    # I am not only clearing if something was printed. This is since
-    # certain small forms like TabbedForm top form throw an error on printstring.
-    # @deprecated 
-    def clear_error r = $error_message_row, color = $datacolor
-      return unless $error_message_clear_pending
-      c = $error_message_col || (Ncurses.COLS-text.length)/2 
-      sz = $error_message_size || Ncurses.COLS
-      printstring(r, c, "%-*s" % [sz, " "], color)
-      $error_message_clear_pending = false
-    end
     ##
     # NOTE : FOR MESSAGEBOXES ONLY !!!! 
     def print_border_mb row, col, height, width, color, attr

data/lib/rbcurse/core/util/app.rb

@@ -18,14 +18,6 @@ require 'logger'
 require 'rbcurse'
 require 'rbcurse/core/util/widgetshortcuts'
 
-require 'rbcurse/core/util/bottomline'
-$tt ||= RubyCurses::Bottomline.new 
-$tt.name = "$tt"
-require 'forwardable'
-module Kernel
-  extend Forwardable
-  def_delegators :$tt, :ask, :say, :agree, :choose, :numbered_menu, :display_text, :display_text_interactive, :display_list, :say_with_pause, :hide_bottomline, :say_with_wait
-end
 include RubyCurses
 include RubyCurses::Utils
 include Io
@@ -85,9 +77,6 @@ module RubyCurses
     # the row on which to prompt user for any inputs
     #attr_accessor :prompt_row # 2011-10-17 14:06:22
 
-    extend Forwardable
-    def_delegators :$tt, :ask, :say, :agree, :choose, :numbered_menu, :display_text, :display_text_interactive, :display_list
-
     # TODO: i should be able to pass window coords here in config
     # :title
     def initialize config={}, &block
@@ -134,7 +123,7 @@ module RubyCurses
       @window.destroy if !@window.nil?
       $log.debug " INSIDE CLOSE, #{@stop_ncurses_on_close} "
       if @stop_ncurses_on_close
-        $tt.destroy  # added on 2011-10-9 since we created a window, but only hid it after use
+        $tt.destroy if $tt  # added on 2011-10-9 since we created a window, but only hid it after use
         VER::stop_ncurses
         $log.debug " CLOSING NCURSES"
       end
@@ -176,10 +165,10 @@ module RubyCurses
             begin
               @form.handle_key ch
             rescue => err
-              alert err.to_s
               $log.debug( "handle_key rescue reached ")
               $log.debug( err) 
               $log.debug(err.backtrace.join("\n")) 
+              textdialog [err.to_s, *err.backtrace], :title => "Exception"
             end
             #@form.repaint # was this duplicate ?? handle calls repaint not needed
             @window.wrefresh
@@ -222,17 +211,13 @@ module RubyCurses
       $status_message.value = text # trying out 2011-10-9 
       #@message.value = text # 2011-10-17 14:07:01
     end
-    # @deprecated please use {#status_line} instead of a message label
-    def message_row row
-      raise "Please use create_message_label first as message_label is no longer default behaviour" unless @message_label
-      @message_label.row = row 
-    end
+
     # during a process, when you wish to update status, since ordinarily the thread is busy
     # and form does not get control back, so the window won't refresh.
     # This will only update on keystroke since it uses statusline
     # @deprecated please use {#status_line} instead of a message label
     def message_immediate text
-      $log.warn "DEPRECATED, use message(), or say_with_pause, or say"
+      $log.warn "DEPRECATED, use message(),  or rb_puts or use status_window"
       $status_message.value = text # trying out 2011-10-9 user needs to use in statusline command
       # 2011-10-17 knocking off label, should be printed on status_line
     end
@@ -334,46 +319,49 @@ module RubyCurses
     # FIXME: why are we using rawmessage and then getchar when ask would suffice
     def bind_global
       opts = get_all_commands
-      cmd = ask("Select a command (TAB for choices) : ", opts)
+      cmd = rb_gets("Select a command (<tab> for choices) : ", opts)
       if cmd.nil? || cmd == ""
-        say_with_pause "Aborted."
+        rb_puts "Aborted."
         return
       end
       key = []
       str = ""
-      raw_message "Enter one or 2 keys. Finish with ENTER. Enter first key:"
-      #raw_message "Enter first key:"
-      ch = @window.getchar()
-      raw_message_destroy
-      if [KEY_ENTER, 10, 13, ?\C-g.getbyte(0)].include? ch
-        say_with_pause "Aborted."
+      #raw_message "Enter one or 2 keys. Finish with ENTER. Enter first key:"
+      #ch = @window.getchar()
+      #raw_message_destroy
+      #if [KEY_ENTER, 10, 13, ?\C-g.getbyte(0)].include? ch
+        #say_with_pause "Aborted."
+        #return
+      #end
+      # the next is fine but does not allow user to enter a control or alt or function character
+      # since it uses Field. It is fine if you want to force alphanum input
+      ch = rb_getchar("Enter one or two keys. Finish with <ENTER>. Enter first key:")
+      unless ch
+        rb_puts "Aborted. <Press a key>"
         return
       end
       key << ch
       str << keycode_tos(ch)
-      raw_message "Enter second key or hit return:"
-      ch = @window.getchar()
-      raw_message_destroy
-      if ch == 3 || ch == ?\C-g.getbyte(0)
-        say_with_pause "Aborted."
+      ch = rb_getchar  "Got #{str}. Enter second key or hit return:"
+      unless ch
+        rb_puts "Aborted. <Press a key>"
         return
       end
-      if ch == 10 || ch == KEY_ENTER || ch == 13
+      if ch == KEY_ENTER || ch == 13
       else
         key << ch
         str << keycode_tos(ch)
       end
       if !key.empty?
-        say_with_pause "Binding #{cmd} to #{str} "
+        rb_puts "Binding #{cmd} to #{str}. "
         key = key[0] if key.size == 1
         #@form.bind_key(key, cmd.to_sym) # not finding it, getting called by that comp
         @form.bind_key(key){ send(cmd.to_sym) }
       end
-      #message "Bound #{str} to #{cmd} "
-      raw_message_destroy
     end
     def bind_component
-      say_with_pause "Todo. <press>"
+      #rb_puts "Todo. ", :color_pair => get_color($promptcolor, :red, :black)
+      print_error_message "Todo this. "
       # the idea here is to get the current component
       # and bind some keys to some methods.
       # however, how do we divine the methods we can map to
@@ -384,9 +372,10 @@ module RubyCurses
       f = @form.get_current_field
       if f.respond_to?('help_text')
         h = f.help_text
-        textdialog "#{h}"
+        h = "No help text defined for this field.\nTry F1, or press '?' for key-bindings." unless h
+        textdialog "#{h}", :title => "Widget Help Text"
       else
-        alert "Could not get field #{f} or does not respond to helptext"
+        alert "Could not get field #{f} or does not respond to helptext. Try F1 or '?'"
       end
     end
     # prompts user for a command. we need to get this back to the calling app
@@ -395,10 +384,8 @@ module RubyCurses
     # or lines ??
     # Also may want command completion, or help so all commands can be displayed
     def get_command_from_user choices=["quit","help"]
-      #code, str = rbgetstr(@window, $lastline, 0, "", 80, :default => ":")
-      #return unless code == 0
-            @_command_history ||= Array.new
-      str = ask("Cmd: ", choices) { |q| q.default = @_previous_command; q.history = @_command_history }
+      @_command_history ||= Array.new
+      str = rb_gets("Cmd: ", choices) { |q| q.default = @_previous_command; q.history = @_command_history }
               @_command_history << str unless @_command_history.include? str
       # shell the command
       if str =~ /^!/
@@ -437,7 +424,7 @@ module RubyCurses
           ret = false
           # what is this execute_this: some kind of general routine for all apps ?
           ret = execute_this(cmd, *cmdline) if respond_to?(:execute_this, true)
-          say_with_pause("#{self.class} does not respond to #{cmd} ", :color_pair => $promptcolor) unless ret
+          rb_puts("#{self.class} does not respond to #{cmd} ", :color_pair => $promptcolor) unless ret
           # should be able to say in red as error
         end
       end
@@ -988,7 +975,7 @@ module RubyCurses
             opts = get_all_commands()
             @_command_history ||= Array.new
             # previous command should be in opts, otherwise it is not in this context
-            cmd = ask("Command: ", opts){ |q| q.default = @_previous_command; q.history = @_command_history }
+            cmd = rb_gets("Command: ", opts){ |q| q.default = @_previous_command; q.history = @_command_history }
             if cmd.nil? || cmd == ""
             else
               @_command_history << cmd unless @_command_history.include? cmd
@@ -1000,7 +987,7 @@ module RubyCurses
                 if rcmd.size == 1
                   cmd = rcmd.first
                 elsif !rcmd.empty?
-                  say_with_pause "Cannot resolve #{cmd}. Matches are: #{rcmd} "
+                  rb_puts "Cannot resolve #{cmd}. Matches are: #{rcmd} "
                 end
               end
               if respond_to?(cmd, true)
@@ -1013,11 +1000,11 @@ module RubyCurses
                   if exc
                     $log.debug( exc) 
                     $log.debug(exc.backtrace.join("\n")) 
-                    say_with_pause exc.to_s
+                    rb_puts exc.to_s
                   end
                 end
               else
-                say_with_pause("Command [#{cmd}] not supported by #{self.class} ", :color_pair => $promptcolor)
+                rb_puts("Command [#{cmd}] not supported by #{self.class} ", :color_pair => $promptcolor)
               end
             end
           }

data/lib/rbcurse/core/util/bottomline.rb

@@ -95,7 +95,6 @@ module RubyCurses
     end
     #
     # create a window at bottom and show and hide it.
-    # Causing a stack overflow since Window creates a bottomline too !
     #
     def _create_footer_window h = 1 , w = Ncurses.COLS, t = Ncurses.LINES-1, l = 0
       ewin = VER::Window.new(h, w , t, l)
@@ -320,7 +319,7 @@ module RubyCurses
       #
       # text to be shown if user presses M-h
       #
-      attr_accessor :helptext
+      attr_accessor :help_text
       attr_accessor :color_pair
       attr_accessor :history
 
@@ -984,7 +983,7 @@ module RubyCurses
       @key_handler_proc = @question.key_handler_proc
       @default = @question.default
       $log.debug "XXX: ASK RBGETS got default: #{@default} "
-      @helptext = @question.helptext
+      @help_text = @question.help_text
       @answer_type = @question.answer_type
       if @question.answer_type.is_a? Array
         @completion_proc = Proc.new{|str| @answer_type.dup.grep Regexp.new("^#{str}") }
@@ -1242,8 +1241,8 @@ module RubyCurses
             str.slice!(curpos) #rescue next
             clear_line len+maxlen+1, @prompt_length
           when ?\M-h.getbyte(0) #                            HELP KEY
-            helptext = @helptext || "No help provided"
-            print_help(helptext) 
+            help_text = @help_text || "No help provided..."
+            print_help(help_text) 
             clear_line len+maxlen+1
             print_str @statement # UGH
             #return 7, nil
@@ -1473,10 +1472,10 @@ module RubyCurses
       print_str("%-*s" % [len," "], :y => from)
     end
 
-    def print_help(helptext)
+    def print_help(help_text)
       # best to popup a window and hsow that with ENTER to dispell
-      print_str("%-*s" % [helptext.length+2," "])
-      print_str("%s" % helptext)
+      print_str("%-*s" % [help_text.length+2," "])
+      print_str("%s" % help_text)
       sleep(5)
     end
     def get_response
@@ -1592,7 +1591,7 @@ module RubyCurses
         w = rc.window
         rc.display_menu list1
         # earlier wmove bombed, now move is (window.rb 121)
-        str = ask(prompt) { |q| q.change_proc = Proc.new { |str| w.wmove(1,1) ; w.wclrtobot;  
+        str = ask(prompt) { |q| q.help_text = config[:help_text] ;  q.change_proc = Proc.new { |str| w.wmove(1,1) ; w.wclrtobot;  
 
           l = list1.select{|e| e.index(str)==0}  ;  # select those starting with str
 
@@ -1776,6 +1775,14 @@ module RubyCurses
   end
   end  # module
 end # module
+#require 'rbcurse/core/util/bottomline'
+$tt ||= RubyCurses::Bottomline.new 
+$tt.name = "$tt"
+require 'forwardable'
+module Kernel
+  extend Forwardable
+  def_delegators :$tt, :ask, :say, :agree, :choose, :numbered_menu, :display_text, :display_text_interactive, :display_list, :say_with_pause, :hide_bottomline, :say_with_wait
+end
 if __FILE__ == $PROGRAM_NAME
 
   #tabc = Proc.new {|str| Dir.glob(str +"*") }
@@ -1808,7 +1815,7 @@ if __FILE__ == $PROGRAM_NAME
     entry = {}
     entry[:file]       = ask("File?  ", Pathname)  do |q| 
       q.completion_proc = Proc.new {|str| Dir.glob(str +"*") }
-      q.helptext = "Enter start of filename and tab to get completion"
+      q.help_text = "Enter start of filename and tab to get completion"
     end
     alert "file: #{entry[:file]} "
     $log.debug "FILE: #{entry[:file]} "
@@ -1824,7 +1831,7 @@ if __FILE__ == $PROGRAM_NAME
     entry[:state]       = ask("State?  ") do |q|
       q._case     = :up
       q.validate = /\A[A-Z]{2}\Z/
-      q.helptext = "Enter 2 characters for your state"
+      q.help_text = "Enter 2 characters for your state"
     end
     entry[:zip]         = ask("Zip?  ") do |q|
     q.validate = /\A\d{5}(?:-?\d{4})?\Z/

data/lib/rbcurse/core/util/padreader.rb

@@ -163,7 +163,8 @@ class PadReader
         rescue => err
           $log.debug( err) if err
           $log.debug(err.backtrace.join("\n")) if err
-          alert "Got an exception in PadReader: #{err}. Check log"
+
+          textdialog ["Error in padreader: #{err} ", *err.backtrace], :title => "Exception"
           $error_message.value = ""
         ensure
         end

data/lib/rbcurse/core/util/rcommandwindow.rb

@@ -295,6 +295,7 @@ module RubyCurses
       @to
     end
     # displays a list
+    # Why did we create another list ? 2011-12-5 
     class ListObject
       attr_reader :cw
       attr_reader :list

data/lib/rbcurse/core/util/rdialogs.rb

@@ -22,15 +22,6 @@ require 'rbcurse/core/widgets/rwidget'
 #require 'rbcurse/deprecated/widgets/rmessagebox'
 require 'rbcurse/core/widgets/rmessagebox'
 
-# trying out 2011-12-4 so non-apps can get it.
-require 'rbcurse/core/util/bottomline'
-$tt ||= RubyCurses::Bottomline.new 
-$tt.name = "$tt"
-require 'forwardable'
-module Kernel
-  extend Forwardable
-  def_delegators :$tt, :ask, :say, :agree, :choose, :numbered_menu, :display_text, :display_text_interactive, :display_list, :say_with_pause, :hide_bottomline, :say_with_wait
-end
 # -- moving to the new Messagebox 2011-11-19 v 1.5.0
 # Alert user with a one line message
 #
@@ -66,7 +57,8 @@ end
 # Are we doing anyhting to let caller know, cancel was pressed. FIXME
 # @param [String] a label such as "Enter name:"
 # @return [String] value entered by user
-def get_string label, config={}
+# @yield [Field] field created by messagebox
+def get_string label, config={} # yield Field
   config[:title] ||= "Entry"
   label_config = config[:label_config] || {}
   label_config[:row] ||= 2
@@ -97,6 +89,8 @@ def get_string label, config={}
     item Label.new nil, label_config
     item Field.new nil, field_config
   end
+  # added yield to override settings
+  yield tp.form.by_name[:name] if block_given?
   index = tp.run
   if index == 0 # OK
     return tp.form.by_name[:name].text
@@ -109,14 +103,15 @@ end
 # new version using new messagebox
 # @param [String] question
 # @return [Boolean] true or false
-# FIXME focus hould fall on default button so ENTER does not fire first one.
+# @yield [Label]
+# 
 def confirm text, config={}, &block
   title = config['title'] || "Confirm"
   config[:default_button] ||= 0
-  #instance_eval &block if block_given?
+
   mb = RubyCurses::MessageBox.new config  do
     title title
-    message text
+    message text, &block 
     button_type :yes_no
   end
   index = mb.run
@@ -131,140 +126,6 @@ end
 # alert("You did not enter anything!", {"title"=>"Wake Up", "bgcolor"=>"blue", "color"=>"white"})
 # block currently ignored. don't know what to do, can't pass it to MB since alread sending in a block
 #
-def DEPalert text, config={}, &block
-  title = config['title'] || "Alert"
-  #instance_eval &block if block_given?
-  if text.is_a? RubyCurses::Variable # added 2011-09-20 incase variable passed
-    text = text.get_value
-  end
-  mb = RubyCurses::MessageBox.new nil, config  do
-    title title
-    message text
-    button_type :ok
-  end
-end
-# confirms from user returning :YES or :NO
-# Darn, should have returned boolean, now have to live with it.
-def OLDconfirm text, config={}, &block
-  title = config['title'] || "Confirm"
-  #instance_eval &block if block_given?
-  mb = RubyCurses::MessageBox.new nil, config  do
-    title title
-    message text
-    button_type :yes_no
-  end
-  return mb.selected_index == 0 ? :YES : :NO
-end
-
-##
-# allows user entry of a string.
-# In config you may pass Field related properties such as chars_allowed, valid_regex, values, etc.
-def DEPget_string(message, len=50, default="", config={})
-
-  config["input_config"] = {}
-  config["input_config"]["maxlen"] = len
-  config["maxlen"]=len
-  title = config["title"] || "Input required"
-  mb = RubyCurses::MessageBox.new nil, config do
-    title title
-    message message
-    type :input
-    button_type :ok
-    default_value default
-  end
-  return mb.input_value
-end
-
-##
-# Added 2009-02-05 13:16 
-# get a string from user with some additional checkboxes and optionally supply default values
-# Usage:
-#sel, inp, hash = get_string_with_options("Enter a filter pattern", 20, "*", {"checkboxes" => ["case sensitive","reverse"], "checkbox_defaults"=>[true, false]})
-# sel, inp, hash = get_string_with_options("Enter a filter pattern", 20, "*", {"checkboxes" => ["case sensitive","reverse"]})
-# $log.debug " POPUP: #{sel}: #{inp}, #{hash['case sensitive']}, #{hash['reverse']}"
-#
-# @param: message to print, 
-# @param: length of entry field
-# @param: default value of field
-# @param: configuration of box or field
-#         checkboxes: array of strings to use as checkboxes
-#         checkbox_defaults : array of true/false default values for each cb
-# @return: int 0 OK, 1 cancel pressed
-# @return: string value entered
-# @return: hash of strings and booleans for checkboxes and values
-#
-# @deprecated - user should be able to do this quite easily now.
-def TODOget_string_with_options(message, len=20, default="", config={})
-  title = config["title"] || "Input required"
-  input_config = config["input_config"] || {}
-  checks = config["checkboxes"] 
-  checkbox_defaults = config["checkbox_defaults"] || []
-
-  height = config["height"] || 1
-  display_length = config["display_length"] || 30
-
-  r = 3
-  c = 4
-  mform = RubyCurses::Form.new nil
-  message_label = RubyCurses::Label.new mform, {'text' => message, "name"=>"message_label","row" => r, "col" => c, "display_length" => display_length,  "height" => height, "attr"=>"reverse"}
-
-  r += 1
-  input = RubyCurses::Field.new mform, input_config do
-    name   "input" 
-    row  r 
-    col  c 
-    display_length  display_length
-    maxlen len
-    set_buffer default
-  end
-  if !checks.nil?
-    r += 2
-    checks.each_with_index do |cbtext,ix|
-      field = RubyCurses::CheckBox.new mform do
-        text cbtext
-        name cbtext
-        value checkbox_defaults[ix]||false
-        color 'black'
-        bgcolor 'white'
-        row r
-        col c
-      end
-      r += 1
-    end
-  end
-  radios = config["radiobuttons"] 
-  if !radios.nil?
-    radio_default = config["radio_default"] || radios[0]
-    radio = RubyCurses::Variable.new radio_default
-    r += 2
-    radios.each_with_index do |cbtext,ix|
-      field = RubyCurses::RadioButton.new mform do
-        variable radio
-        text cbtext
-        value cbtext
-        color 'black'
-        bgcolor 'white'
-        row r
-        col c
-      end
-      r += 1
-    end
-  end
-  mb = RubyCurses::MessageBox.new mform do
-    title title
-    button_type :ok_cancel
-    default_button 0
-  end
-  hash = {}
-  if !checks.nil?
-    checks.each do |c|
-      hash[c] = mform.by_name[c].getvalue
-    end
-  end
-  hash["radio"] = radio.get_value unless radio.nil?
-  # returns button index (0 = OK), value of field, hash containing values of checkboxes
-  return mb.selected_index, mform.by_name['input'].getvalue, hash
-end
 
 # ------------------------ We've Moved here from window class ---------------- #
 #                                                                              #
@@ -277,22 +138,33 @@ end
 # new version with a window created on 2011-10-1 12:37 AM 
 # Now can be separate from window class, needing nothing, just a util class
 # prints a status message and pauses for a char
+# @param [String] text to print
+# @param [Hash] config: :color :bgcolor :color_pair
+#              :wait (numbr of seconds to wait for a key press and then close) if not givn
+#              will keep waiting for keypress (the default)
 def print_status_message text, aconfig={}, &block
   _print_message :status, text, aconfig, &block
 end
+alias :rb_puts print_status_message
+
 # new version with a window created on 2011-10-1 12:30 AM 
 # Now can be separate from window class, needing nothing, just a util class
 # Why are we dealing with $error_message, that was due to old idea which failed
 # scrap it and send the message.
+# @param [String] text to print
+# @param [Hash] config: :color :bgcolor :color_pair
+#              :wait (numbr of seconds to wait for a key press and then close) if not givn
+#              will keep waiting for keypress (the default)
 def print_error_message text, aconfig={}, &block
   _print_message :error, text, aconfig, &block
 end
-def _create_footer_window h = 2 , w = Ncurses.COLS, t = Ncurses.LINES-2, l = 0
+private
+def _create_footer_window h = 2 , w = Ncurses.COLS, t = Ncurses.LINES-2, l = 0  #:nodoc:
   ewin = VER::Window.new(h, w , t, l)
 end
 # @param [:symbol] :error or :status kind of message
-# @private
-def _print_message type, text, aconfig={}, &block
+#private
+def _print_message type, text, aconfig={}, &block  #:nodoc:
   case text
   when RubyCurses::Variable # added 2011-09-20 incase variable passed
     text = text.get_value
@@ -300,30 +172,55 @@ def _print_message type, text, aconfig={}, &block
     text = text.to_s
   end
   # NOTE we are polluting global namespace
-  aconfig.each_pair { |k,v| instance_variable_set("@#{k}",v) }
+  # fixed on 2011-12-6 . to test
+  #aconfig.each_pair { |k,v| instance_variable_set("@#{k}",v) }
+  color = aconfig[:color]
+  bgcolor = aconfig[:bgcolor]
   ewin = _create_footer_window #*@layout
   r = 0; c = 1;
   case type 
   when :error
-    @color ||= 'red'
-    @bgcolor ||= 'black'
+    color ||= 'red'
+    bgcolor ||= 'black'
   else
-    @color ||= :white
-    @bgcolor ||= :black
+    color ||= :white
+    bgcolor ||= :black
   end
-  color_pair = get_color($promptcolor, @color, @bgcolor)
+  color_pair = get_color($promptcolor, color, bgcolor)
+  color_pair = aconfig[:color_pair] || color_pair
   ewin.bkgd(Ncurses.COLOR_PAIR(color_pair));
   ewin.printstring r, c, text, color_pair
-  ewin.printstring r+1, c, "Press a key", color_pair
+  ewin.printstring(r+1, c, "Press a key ", color_pair) unless aconfig[:wait]
   ewin.wrefresh
-  ewin.getchar
+  if aconfig[:wait]
+    #try this out, if user wants a wait, then it will wait for 5 seconds, or if a key is pressed sooner
+    value = aconfig[:wait]
+    if value.is_a? Fixnum
+      value = value * 10
+    else 
+      value = 50
+    end
+    Ncurses::halfdelay(tenths = value)
+    ewin.getch
+    Ncurses::halfdelay(tenths = 10)
+  else
+    ewin.getchar
+  end
   ewin.destroy
 end
 #
 # Alternative to confirm dialog, if you want this look and feel, at last 2 lines of screen
 # @param [String] text to prompt
 # @return [true, false] 'y' is true, all else if false
-def confirm_window text, aconfig={}, &block
+public
+def rb_confirm text, aconfig={}, &block
+  # backward compatibility with agree()
+  if aconfig == true || aconfig == false
+    default = aconfig
+    aconfig = {}
+  else 
+    default = aconfig[:default]
+  end
   case text
   when RubyCurses::Variable # added 2011-09-20 incase variable passed
     text = text.get_value
@@ -332,10 +229,13 @@ def confirm_window text, aconfig={}, &block
   end
   ewin = _create_footer_window
   r = 0; c = 1;
-  aconfig.each_pair { |k,v| instance_variable_set("@#{k}",v) }
-  @color ||= :white
-  @bgcolor ||= :black
-  color_pair = get_color($promptcolor, @color, @bgcolor)
+  #aconfig.each_pair { |k,v| instance_variable_set("@#{k}",v) }
+  # changed on 2011-12-6 
+  color = aconfig[:color]
+  bgcolor = aconfig[:bgcolor]
+  color ||= :white
+  bgcolor ||= :black
+  color_pair = get_color($promptcolor, color, bgcolor)
   ewin.bkgd(Ncurses.COLOR_PAIR(color_pair));
   ewin.printstring r, c, text, color_pair
   ewin.printstring r+1, c, "[y/n]", color_pair
@@ -344,13 +244,21 @@ def confirm_window text, aconfig={}, &block
   retval = false
   begin
     ch =  ewin.getchar 
+    retval = (ch == 'y'.ord || ch == 'Y'.ord )
+    # if caller passed a default value and user pressed ENTER return that
+    # can be true or false so don't change this to "if default". 2011-12-8 
+    if !default.nil?
+      if ch == 13 || ch == KEY_ENTER
+        retval = default
+      end
+    end
     #retval = :YES if ch.chr == 'y' 
-    retval = (ch.chr == 'y' )
   ensure
     ewin.destroy
   end
   retval
 end
+alias :confirm_window :rb_confirm
 # class created to display multiple messages without asking for user to hit a key
 # returns a window to which one can keep calling printstring with 0 or 1 as row.
 # destroy when finished.
@@ -451,6 +359,7 @@ end
 #  You may also pass bgcolor and color
 #  @since 1.4.1  2011-11-1 
 def popuplist list, config={}, &block
+  raise ArgumentError, "Nil list received by popuplist" unless list
   require 'rbcurse/core/widgets/rlist'
 
   max_visible_items = config[:max_visible_items]
@@ -522,6 +431,7 @@ def popuplist list, config={}, &block
 end
 # returns length of longest
 def longest_in_list list  #:nodoc:
+  raise ArgumentError, "rdialog.rb: longest_in_list recvd nil list" unless list
   longest = list.inject(0) do |memo,word|
     memo >= word.length ? memo : word.length
   end