rb_sys 0.9.0 → 0.9.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 27affe876fb5901792fe8af81776d7b6b6094b7b97849c1a8894296c6d119f77
-  data.tar.gz: a1e59e9580925d7d0a470ec33c72f4fe296148efacb546901d40b4fb99c543bf
+  metadata.gz: 89efba40337b3497f50ca87b01779b27375784efa2942fb70b1ff4ccd9b992ee
+  data.tar.gz: ac38b222bf1ba5d1efbc9e5bfff3cd13e02b71051b1e87cd0e1f97a72b270035
 SHA512:
-  metadata.gz: acfa547f5b88a8274c384a6d72953b22eaf5c8b551092caac377a533d80160a1f9fb76dbdf09668957dbe016ed78b6c1e5bfd57bb0ccfaf1cbab85b675353046
-  data.tar.gz: c56ed902664615dd777a9611fcbe3b7ae2229a8832690c47b568340df9746278939fd82d3b05dea1c7b258116ce2deb59a1c30ac954b648ddb552b922e70eef8
+  metadata.gz: 4ca0411407ac7351aaa7222d55b637f0889eaca970a022fc453b0a7138bdf469c9837b87401fc07a624b5602f2a6d094b64aa23a83f25c487ce17e9f10470a43
+  data.tar.gz: 32496275e8308a237efb3894be317f9a695a8e375791a44a4fa41f6e75c3c86b3493f38c927b0f2a98003eb9c20ec8df75aec2deca680f009fd60fb2c31be9ce

data/lib/rb_sys/cargo_builder/link_flag_converter.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+module RbSys
+  class CargoBuilder
+    # Converts Ruby link flags into something cargo understands
+    class LinkFlagConverter
+      def self.convert(arg)
+        case arg.chomp
+        when /^-L\s*(.+)$/
+          ["-L", "native=#{$1}"]
+        when /^--library=(\w+\S+)$/, /^-l\s*(\w+\S+)$/
+          ["-l", $1]
+        when /^-l\s*:lib(\S+).a$/
+          ["-l", "static=#{$1}"]
+        when /^-l\s*:lib(\S+).(so|dylib|dll)$/
+          ["-l", "dylib=#{$1}"]
+        when /^-F\s*(.*)$/
+          ["-l", "framework=#{$1}"]
+        else
+          ["-C", "link_arg=#{arg}"]
+        end
+      end
+    end
+  end
+end

data/lib/rb_sys/cargo_builder.rb

@@ -0,0 +1,336 @@
+module RbSys
+  class CargoBuilder < Gem::Ext::Builder
+    attr_accessor :spec, :runner, :profile, :env, :features, :target, :extra_rustc_args, :dry_run
+
+    def initialize(spec)
+      require "rubygems/command"
+      require_relative "cargo_builder/link_flag_converter"
+
+      @spec = spec
+      @runner = self.class.method(:run)
+      @profile = ENV.fetch("CARGO_BUILD_PROFILE", :release).to_sym
+      @env = {}
+      @features = []
+      @target = ENV["CARGO_BUILD_TARGET"]
+      @extra_rustc_args = []
+      @dry_run = true
+    end
+
+    def build(_extension, dest_path, results, args = [], lib_dir = nil, cargo_dir = Dir.pwd)
+      require "fileutils"
+      require "shellwords"
+
+      build_crate(dest_path, results, args, cargo_dir)
+      validate_cargo_build!(dest_path)
+      rename_cdylib_for_ruby_compatibility(dest_path)
+      finalize_directory(dest_path, lib_dir, cargo_dir)
+      results
+    end
+
+    def build_crate(dest_path, results, args, cargo_dir)
+      env = build_env
+      cmd = cargo_command(cargo_dir, dest_path, args)
+      runner.call cmd, results, "cargo", cargo_dir, env
+
+      results
+    end
+
+    def build_env
+      build_env = rb_config_env
+      build_env["RUBY_STATIC"] = "true" if ruby_static? && ENV.key?("RUBY_STATIC")
+      build_env.merge(env)
+    end
+
+    def cargo_command(cargo_dir, dest_path, args = [])
+      manifest = File.join(cargo_dir, "Cargo.toml")
+      cargo = ENV.fetch("CARGO", "cargo")
+
+      cmd = []
+      cmd += [cargo, "rustc"]
+      cmd += ["--target", target] if target
+      cmd += ["--target-dir", dest_path]
+      cmd += ["--features", features.join(",")] unless features.empty?
+      cmd += ["--manifest-path", manifest]
+      cmd += ["--lib"]
+      cmd += ["--profile", profile.to_s]
+      cmd += ["--locked"] if profile.to_s == "release"
+      cmd += Gem::Command.build_args
+      cmd += args
+      cmd += ["--"]
+      cmd += [*cargo_rustc_args(dest_path)]
+      cmd += extra_rustc_args
+      cmd
+    end
+
+    def cargo_dylib_path(dest_path)
+      prefix = so_ext == "dll" ? "" : "lib"
+      path_parts = [dest_path]
+      path_parts << target if target
+      path_parts += [profile_target_directory, "#{prefix}#{cargo_crate_name}.#{so_ext}"]
+      File.join(*path_parts)
+    end
+
+    private
+
+    def rb_config_env
+      result = {}
+      RbConfig::CONFIG.each { |k, v| result["RBCONFIG_#{k}"] = v }
+      result
+    end
+
+    def cargo_rustc_args(dest_dir)
+      [
+        *linker_args,
+        *mkmf_libpath,
+        *rustc_dynamic_linker_flags(dest_dir),
+        *rustc_lib_flags(dest_dir),
+        *platform_specific_rustc_args(dest_dir),
+        *debug_flags
+      ]
+    end
+
+    def platform_specific_rustc_args(dest_dir, flags = [])
+      if mingw_target?
+        # On mingw platforms, mkmf adds libruby to the linker flags
+        flags += libruby_args(dest_dir)
+
+        # Make sure ALSR is used on mingw
+        # see https://github.com/rust-lang/rust/pull/75406/files
+        flags += ["-C", "link-arg=-Wl,--dynamicbase"]
+        flags += ["-C", "link-arg=-Wl,--disable-auto-image-base"]
+
+        # If the gem is installed on a host with build tools installed, but is
+        # run on one that isn't the missing libraries will cause the extension
+        # to fail on start.
+        flags += ["-C", "link-arg=-static-libgcc"]
+      end
+
+      flags
+    end
+
+    # We want to use the same linker that Ruby uses, so that the linker flags from
+    # mkmf work properly.
+    def linker_args
+      # Have to handle CC="cl /nologo" on mswin
+      cc_flag = Shellwords.split(makefile_config("CC"))
+      linker = cc_flag.shift
+      link_args = cc_flag.flat_map { |a| ["-C", "link-arg=#{a}"] }
+
+      ["-C", "linker=#{linker}", *link_args]
+    end
+
+    def libruby_args(dest_dir)
+      libs = makefile_config(ruby_static? ? "LIBRUBYARG_STATIC" : "LIBRUBYARG_SHARED")
+      raw_libs = Shellwords.split(libs)
+      raw_libs.flat_map { |l| ldflag_to_link_modifier(l) }
+    end
+
+    def ruby_static?
+      return true if %w[1 true].include?(ENV["RUBY_STATIC"])
+
+      makefile_config("ENABLE_SHARED") == "no"
+    end
+
+    # Ruby expects the dylib to follow a file name convention for loading
+    def rename_cdylib_for_ruby_compatibility(dest_path)
+      new_path = final_extension_path(dest_path)
+      FileUtils.cp(cargo_dylib_path(dest_path), new_path)
+      new_path
+    end
+
+    def validate_cargo_build!(dir)
+      dylib_path = cargo_dylib_path(dir)
+
+      raise DylibNotFoundError, dir unless File.exist?(dylib_path)
+
+      dylib_path
+    end
+
+    def final_extension_path(dest_path)
+      dylib_path = cargo_dylib_path(dest_path)
+      dlext_name = "#{spec.name}.#{makefile_config("DLEXT")}"
+      dylib_path.gsub(File.basename(dylib_path), dlext_name)
+    end
+
+    def cargo_crate_name
+      spec.metadata.fetch("cargo_crate_name", spec.name).tr("-", "_")
+    end
+
+    def rustc_dynamic_linker_flags(dest_dir)
+      split_flags("DLDFLAGS")
+        .map { |arg| maybe_resolve_ldflag_variable(arg, dest_dir) }
+        .compact
+        .flat_map { |arg| ldflag_to_link_modifier(arg) }
+    end
+
+    def rustc_lib_flags(dest_dir)
+      split_flags("LIBS").flat_map { |arg| ldflag_to_link_modifier(arg) }
+    end
+
+    def split_flags(var)
+      Shellwords.split(RbConfig::CONFIG.fetch(var, ""))
+    end
+
+    def ldflag_to_link_modifier(arg)
+      LinkFlagConverter.convert(arg)
+    end
+
+    def msvc_target?
+      makefile_config("target_os").include?("msvc")
+    end
+
+    def darwin_target?
+      makefile_config("target_os").include?("darwin")
+    end
+
+    def mingw_target?
+      makefile_config("target_os").include?("mingw")
+    end
+
+    def win_target?
+      target_platform = RbConfig::CONFIG["target_os"]
+      !!Gem::WIN_PATTERNS.find { |r| target_platform =~ r }
+    end
+
+    # Interpolate substition vars in the arg (i.e. $(DEFFILE))
+    def maybe_resolve_ldflag_variable(input_arg, dest_dir)
+      var_matches = input_arg.match(/\$\((\w+)\)/)
+
+      return input_arg unless var_matches
+
+      var_name = var_matches[1]
+
+      return input_arg if var_name.nil? || var_name.chomp.empty?
+
+      case var_name
+      # On windows, it is assumed that mkmf has setup an exports file for the
+      # extension, so we have to to create one ourselves.
+      when "DEFFILE"
+        write_deffile(dest_dir)
+      else
+        RbConfig::CONFIG[var_name]
+      end
+    end
+
+    def write_deffile(dest_path)
+      dest_dir = File.dirname(final_extension_path(dest_path))
+      FileUtils.mkdir_p(dest_dir)
+      deffile_path = File.join(dest_dir, "#{spec.name}-#{RbConfig::CONFIG["arch"]}.def")
+      export_prefix = makefile_config("EXPORT_PREFIX") || ""
+
+      unless dry_run
+        File.open(deffile_path, "w") do |f|
+          f.puts "EXPORTS"
+          f.puts "#{export_prefix.strip}Init_#{spec.name}"
+        end
+      end
+
+      deffile_path
+    end
+
+    # We have to basically reimplement RbConfig::CONFIG['SOEXT'] here to support
+    # Ruby < 2.5
+    #
+    # @see https://github.com/ruby/ruby/blob/c87c027f18c005460746a74c07cd80ee355b16e4/configure.ac#L3185
+    def so_ext
+      return RbConfig::CONFIG["SOEXT"] if RbConfig::CONFIG.key?("SOEXT")
+
+      if win_target?
+        "dll"
+      elsif darwin_target?
+        "dylib"
+      else
+        "so"
+      end
+    end
+
+    # Corresponds to $(LIBPATH) in mkmf
+    def mkmf_libpath
+      ["-L", "native=#{makefile_config("libdir")}"]
+    end
+
+    def makefile_config(var_name)
+      val = RbConfig::MAKEFILE_CONFIG[var_name]
+
+      return unless val
+
+      RbConfig.expand(val.dup)
+    end
+
+    # Good balance between binary size and debugability
+    def debug_flags
+      return [] if profile == :dev
+
+      ["-C", "debuginfo=1"]
+    end
+
+    # Copied from ExtConfBuilder
+    def finalize_directory(dest_path, lib_dir, extension_dir)
+      require "fileutils"
+      require "tempfile"
+
+      ext_path = final_extension_path(dest_path)
+
+      begin
+        tmp_dest = Dir.mktmpdir(".gem.", extension_dir)
+
+        # Some versions of `mktmpdir` return absolute paths, which will break make
+        # if the paths contain spaces. However, on Ruby 1.9.x on Windows, relative
+        # paths cause all C extension builds to fail.
+        #
+        # As such, we convert to a relative path unless we are using Ruby 1.9.x on
+        # Windows. This means that when using Ruby 1.9.x on Windows, paths with
+        # spaces do not work.
+        #
+        # Details: https://github.com/rubygems/rubygems/issues/977#issuecomment-171544940
+        tmp_dest_relative = get_relative_path(tmp_dest.clone, extension_dir)
+
+        if tmp_dest_relative
+          full_tmp_dest = File.join(extension_dir, tmp_dest_relative)
+
+          # TODO: remove in RubyGems 3
+          if Gem.install_extension_in_lib && lib_dir
+            FileUtils.mkdir_p lib_dir
+            FileUtils.cp_r ext_path, lib_dir, remove_destination: true
+          end
+
+          FileUtils::Entry_.new(full_tmp_dest).traverse do |ent|
+            destent = ent.class.new(dest_path, ent.rel)
+            destent.exist? || FileUtils.mv(ent.path, destent.path)
+          end
+        end
+      ensure
+        FileUtils.rm_rf tmp_dest if tmp_dest
+      end
+    end
+
+    def get_relative_path(path, base)
+      path[0..base.length - 1] = "." if path.start_with?(base)
+      path
+    end
+
+    def profile_target_directory
+      case profile
+      when :release then "release"
+      when :dev then "debug"
+      else raise "unknown target directory for profile: #{profile}"
+      end
+    end
+
+    # Error raised when no cdylib artifact was created
+    class DylibNotFoundError < StandardError
+      def initialize(dir)
+        files = Dir.glob(File.join(dir, "**", "*")).map { |f| "- #{f}" }.join "\n"
+
+        super <<~MSG
+          Dynamic library not found for Rust extension (in #{dir})
+
+          Make sure you set "crate-type" in Cargo.toml to "cdylib"
+
+          Found files:
+          #{files}
+        MSG
+      end
+    end
+  end
+end

data/lib/rb_sys/mkmf.rb

@@ -2,7 +2,7 @@
 
 require "rubygems/ext"
 require "shellwords"
-require_relative "./../../vendor/rubygems/ext/cargo_builder"
+require_relative "cargo_builder"
 
 # Root module
 module RbSys
@@ -25,7 +25,7 @@ module RbSys
     # . create_rust_makefile("my_extension") do |r|
     # .   # All of these are optional
     # .   r.env = { 'FOO' => 'bar' }
-    # .   r.profile = ENV.fetch('CARGO_BUILD_PROFILE', :dev).to_sym
+    # .   r.profile = ENV.fetch('RB_SYS_CARGO_PROFILE', :dev).to_sym
     # .   r.features = %w[some_cargo_feature]
     # . end
     def create_rust_makefile(target, srcprefix = nil, &blk)
@@ -37,40 +37,66 @@ module RbSys
       end
 
       spec = Struct.new(:name, :metadata).new(target, {})
-      builder = Gem::Ext::CargoBuilder.new(spec)
+      builder = CargoBuilder.new(spec)
 
       yield builder if blk
 
       srcprefix ||= "$(srcdir)/#{srcprefix}".chomp("/")
       RbConfig.expand(srcdir = srcprefix.dup)
 
+      full_cargo_command = cargo_command(srcdir, builder)
+
       # rubocop:disable Style/GlobalVars
-      make_install = <<~MAKE
+      make_install = +<<~MAKE
+        RB_SYS_CARGO_PROFILE ?= #{builder.profile}
+        RB_SYS_CARGO_FEATURES ?= #{builder.features.join(",")}
+        CARGO ?= cargo
+
+        ifeq ($(RB_SYS_CARGO_PROFILE),dev)
+          RB_SYS_TARGET_DIR ?= debug
+        else
+          RB_SYS_TARGET_DIR ?= $(RB_SYS_CARGO_PROFILE)
+        endif
+
         target_prefix = #{target_prefix}
-        CARGO_PROFILE = release
-        CLEANLIBS = $(RUSTLIB) $(DLLIB)
+        TARGET_NAME = #{target[/\A\w+/]}
+        TARGET_ENTRY = #{RbConfig::CONFIG["EXPORT_PREFIX"]}Init_$(TARGET_NAME)
+        CLEANLIBS = $(RUSTLIB) $(DLLIB) $(DEFFILE)
         DISTCLEANDIRS = target/
         RUBYARCHDIR   = $(sitearchdir)$(target_prefix)
         RUSTLIB = #{dllib_path(builder)}
         TARGET = #{target}
         DLLIB = $(TARGET).#{RbConfig::CONFIG["DLEXT"]}
-
+        TARGET_DIR = #{Dir.pwd}/target/$(RB_SYS_TARGET_DIR)
+        DEFFILE = $(TARGET_DIR)/$(TARGET)-$(arch).def
         #{base_makefile(srcdir)}
-
         #{env_vars(builder)}
 
         FORCE: ;
 
-        $(DLLIB): FORCE
-        \t#{cargo_command(srcdir, builder)}
-        \t$(COPY) "$(RUSTLIB)" $@
+        $(TARGET_DIR):
+        \t$(ECHO) creating target directory \\($(@)\\)
+        \t$(Q) $(MAKEDIRS) $(TARGET_DIR)
 
-        install: $(DLLIB)
-        \t$(INSTALL_PROG) $(DLLIB) $(RUBYARCHDIR)
+        $(DEFFILE): $(TARGET_DIR)
+        \t$(ECHO) generating $(@)
+        \t$(Q) ($(COPY) $(srcdir)/$(TARGET).def $@ 2> /dev/null) || (echo EXPORTS && echo $(TARGET_ENTRY)) > $@
+
+        $(DLLIB): $(DEFFILE) FORCE
+        \t$(ECHO) generating $(@) \\("$(RB_SYS_CARGO_PROFILE)"\\)
+        \t$(Q) #{full_cargo_command}
+        \t$(Q) $(COPY) "$(RUSTLIB)" $@
+
+        install: $(DLLIB) Makefile
+        \t$(ECHO) installing $(DLLIB)
+        \t$(Q) $(MAKEDIRS) $(RUBYARCHDIR)
+        \t$(Q) $(INSTALL_PROG) $(DLLIB) $(RUBYARCHDIR)
 
         all: #{$extout ? "install" : "$(DLLIB)"}
       MAKE
 
+      gsub_cargo_command!(make_install, builder: builder)
+
       File.write("Makefile", make_install)
     end
     # rubocop:enable Style/GlobalVars
@@ -89,7 +115,7 @@ module RbSys
       dest_path = File.join(Dir.pwd, "target")
       args = []
       cargo_cmd = builder.cargo_command(cargo_dir, dest_path, args)
-      Shellwords.join(cargo_cmd).gsub("\\=", "=")
+      Shellwords.join(cargo_cmd).gsub("\\=", "=").gsub(/\Acargo/, "$(CARGO)")
     end
 
     def env_vars(builder)
@@ -111,6 +137,13 @@ module RbSys
     def dllib_path(builder)
       builder.cargo_dylib_path(File.join(Dir.pwd, "target"))
     end
+
+    def gsub_cargo_command!(cargo_command, builder:)
+      cargo_command.gsub!("--profile #{builder.profile}", "--profile $(RB_SYS_CARGO_PROFILE)")
+      cargo_command.gsub!(%r{--features \S+}, "--features $(RB_SYS_CARGO_FEATURES)")
+      cargo_command.gsub!(%r{/target/\w+/}, "/target/$(RB_SYS_TARGET_DIR)/")
+      cargo_command
+    end
   end
 end
 

data/lib/rb_sys/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RbSys
-  VERSION = "0.9.0"
+  VERSION = "0.9.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rb_sys
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.3
 platform: ruby
 authors:
 - Ian Ker-Seymer
@@ -30,7 +30,7 @@ cert_chain:
   Rl+ASkq2/1i07TkBpCf+2hq66+h/hx+/Y/KrUzXfe0jtvil0WESkJT2kqRqHWNhD
   9GKBxaQlXokNDtWCm1/gl6cD8WRZ0N5S4ZGJT1FLLsA=
   -----END CERTIFICATE-----
-date: 2022-05-25 00:00:00.000000000 Z
+date: 2022-06-02 00:00:00.000000000 Z
 dependencies: []
 description:
 email:
@@ -43,11 +43,11 @@ files:
 - LICENSE-MIT
 - certs/ianks.pem
 - lib/rb_sys.rb
+- lib/rb_sys/cargo_builder.rb
+- lib/rb_sys/cargo_builder/link_flag_converter.rb
 - lib/rb_sys/mkmf.rb
 - lib/rb_sys/version.rb
 - sig/rb_sys.rbs
-- vendor/rubygems/ext/cargo_builder.rb
-- vendor/rubygems/ext/cargo_builder/link_flag_converter.rb
 homepage: https://github.com/oxidize-rb/rb-sys
 licenses:
 - MIT

data/vendor/rubygems/ext/cargo_builder/link_flag_converter.rb

@@ -1,23 +0,0 @@
-# frozen_string_literal: true
-
-class Gem::Ext::CargoBuilder < Gem::Ext::Builder
-  # Converts Ruby link flags into something cargo understands
-  class LinkFlagConverter
-    def self.convert(arg)
-      case arg.chomp
-      when /^-L\s*(.+)$/
-        ["-L", "native=#{$1}"]
-      when /^--library=(\w+\S+)$/, /^-l\s*(\w+\S+)$/
-        ["-l", $1]
-      when /^-l\s*:lib(\S+).a$/
-        ["-l", "static=#{$1}"]
-      when /^-l\s*:lib(\S+).(so|dylib|dll)$/
-        ["-l", "dylib=#{$1}"]
-      when /^-F\s*(.*)$/
-        ["-l", "framework=#{$1}"]
-      else
-        ["-C", "link_arg=#{arg}"]
-      end
-    end
-  end
-end

data/vendor/rubygems/ext/cargo_builder.rb

@@ -1,336 +0,0 @@
-# frozen_string_literal: true
-
-# This class is used by rubygems to build Rust extensions. It is a thin-wrapper
-# over the `cargo rustc` command which takes care of building Rust code in a way
-# that Ruby can use.
-class Gem::Ext::CargoBuilder < Gem::Ext::Builder
-  attr_accessor :spec, :runner, :profile, :env, :features, :target, :extra_rustc_args
-
-  def initialize(spec)
-    require "rubygems/command"
-    require_relative "cargo_builder/link_flag_converter"
-
-    @spec = spec
-    @runner = self.class.method(:run)
-    @profile = ENV.fetch("CARGO_BUILD_PROFILE", :release).to_sym
-    @env = {}
-    @features = []
-    @target = ENV['CARGO_BUILD_TARGET']
-    @extra_rustc_args = []
-  end
-
-  def build(_extension, dest_path, results, args = [], lib_dir = nil, cargo_dir = Dir.pwd)
-    require "fileutils"
-    require "shellwords"
-
-    build_crate(dest_path, results, args, cargo_dir)
-    validate_cargo_build!(dest_path)
-    rename_cdylib_for_ruby_compatibility(dest_path)
-    finalize_directory(dest_path, lib_dir, cargo_dir)
-    results
-  end
-
-  def build_crate(dest_path, results, args, cargo_dir)
-    env = build_env
-    cmd = cargo_command(cargo_dir, dest_path, args)
-    runner.call cmd, results, "cargo", cargo_dir, env
-
-    results
-  end
-
-  def build_env
-    build_env = rb_config_env
-    build_env["RUBY_STATIC"] = "true" if ruby_static? && ENV.key?("RUBY_STATIC")
-    build_env.merge(env)
-  end
-
-  def cargo_command(cargo_dir, dest_path, args = [])
-    manifest = File.join(cargo_dir, "Cargo.toml")
-    cargo = ENV.fetch("CARGO", "cargo")
-
-    cmd = []
-    cmd += [cargo, "rustc"]
-    cmd += ["--target", target] if target
-    cmd += ["--target-dir", dest_path]
-    cmd += ["--features", features.join(",")] unless features.empty?
-    cmd += ["--manifest-path", manifest]
-    cmd += ["--lib"]
-    cmd += ["--profile", profile.to_s]
-    cmd += ["--locked"] if profile.to_s == 'release'
-    cmd += Gem::Command.build_args
-    cmd += args
-    cmd += ["--"]
-    cmd += [*cargo_rustc_args(dest_path)]
-    cmd += extra_rustc_args
-    cmd
-  end
-
-  def cargo_dylib_path(dest_path)
-    prefix = so_ext == "dll" ? "" : "lib"
-    path_parts = [dest_path]
-    path_parts << target if target 
-    path_parts += [profile_target_directory, "#{prefix}#{cargo_crate_name}.#{so_ext}"]
-    File.join(*path_parts)
-  end
-
-  private
-
-  def rb_config_env
-    result = {}
-    RbConfig::CONFIG.each { |k, v| result["RBCONFIG_#{k}"] = v }
-    result
-  end
-
-  def cargo_rustc_args(dest_dir)
-    [
-      *linker_args,
-      *mkmf_libpath,
-      *rustc_dynamic_linker_flags(dest_dir),
-      *rustc_lib_flags(dest_dir),
-      *platform_specific_rustc_args(dest_dir),
-      *debug_flags
-    ]
-  end
-
-  def platform_specific_rustc_args(dest_dir, flags = [])
-    if mingw_target?
-      # On mingw platforms, mkmf adds libruby to the linker flags
-      flags += libruby_args(dest_dir)
-
-      # Make sure ALSR is used on mingw
-      # see https://github.com/rust-lang/rust/pull/75406/files
-      flags += ["-C", "link-arg=-Wl,--dynamicbase"]
-      flags += ["-C", "link-arg=-Wl,--disable-auto-image-base"]
-
-      # If the gem is installed on a host with build tools installed, but is
-      # run on one that isn't the missing libraries will cause the extension
-      # to fail on start.
-      flags += ["-C", "link-arg=-static-libgcc"]
-    end
-
-    flags
-  end
-
-  # We want to use the same linker that Ruby uses, so that the linker flags from
-  # mkmf work properly.
-  def linker_args
-    # Have to handle CC="cl /nologo" on mswin
-    cc_flag = Shellwords.split(makefile_config("CC"))
-    linker = cc_flag.shift
-    link_args = cc_flag.flat_map { |a| ["-C", "link-arg=#{a}"] }
-
-    ["-C", "linker=#{linker}", *link_args]
-  end
-
-  def libruby_args(dest_dir)
-    libs = makefile_config(ruby_static? ? "LIBRUBYARG_STATIC" : "LIBRUBYARG_SHARED")
-    raw_libs = Shellwords.split(libs)
-    raw_libs.flat_map { |l| ldflag_to_link_modifier(l) }
-  end
-
-  def ruby_static?
-    return true if %w[1 true].include?(ENV["RUBY_STATIC"])
-
-    makefile_config("ENABLE_SHARED") == "no"
-  end
-
-  # Ruby expects the dylib to follow a file name convention for loading
-  def rename_cdylib_for_ruby_compatibility(dest_path)
-    new_path = final_extension_path(dest_path)
-    FileUtils.cp(cargo_dylib_path(dest_path), new_path)
-    new_path
-  end
-
-  def validate_cargo_build!(dir)
-    dylib_path = cargo_dylib_path(dir)
-
-    raise DylibNotFoundError, dir unless File.exist?(dylib_path)
-
-    dylib_path
-  end
-
-  def final_extension_path(dest_path)
-    dylib_path = cargo_dylib_path(dest_path)
-    dlext_name = "#{spec.name}.#{makefile_config("DLEXT")}"
-    dylib_path.gsub(File.basename(dylib_path), dlext_name)
-  end
-
-  def cargo_crate_name
-    spec.metadata.fetch("cargo_crate_name", spec.name).tr("-", "_")
-  end
-
-  def rustc_dynamic_linker_flags(dest_dir)
-    split_flags("DLDFLAGS")
-      .map { |arg| maybe_resolve_ldflag_variable(arg, dest_dir) }
-      .compact
-      .flat_map { |arg| ldflag_to_link_modifier(arg) }
-  end
-
-  def rustc_lib_flags(dest_dir)
-    split_flags("LIBS").flat_map { |arg| ldflag_to_link_modifier(arg) }
-  end
-
-  def split_flags(var)
-    Shellwords.split(RbConfig::CONFIG.fetch(var, ""))
-  end
-
-  def ldflag_to_link_modifier(arg)
-    LinkFlagConverter.convert(arg)
-  end
-
-  def msvc_target?
-    makefile_config("target_os").include?("msvc")
-  end
-
-  def darwin_target?
-    makefile_config("target_os").include?("darwin")
-  end
-
-  def mingw_target?
-    makefile_config("target_os").include?("mingw")
-  end
-
-  def win_target?
-    target_platform = RbConfig::CONFIG["target_os"]
-    !!Gem::WIN_PATTERNS.find { |r| target_platform =~ r }
-  end
-
-  # Interpolate substition vars in the arg (i.e. $(DEFFILE))
-  def maybe_resolve_ldflag_variable(input_arg, dest_dir)
-    var_matches = input_arg.match(/\$\((\w+)\)/)
-
-    return input_arg unless var_matches
-
-    var_name = var_matches[1]
-
-    return input_arg if var_name.nil? || var_name.chomp.empty?
-
-    case var_name
-    # On windows, it is assumed that mkmf has setup an exports file for the
-    # extension, so we have to to create one ourselves.
-    when "DEFFILE"
-      write_deffile(dest_dir)
-    else
-      RbConfig::CONFIG[var_name]
-    end
-  end
-
-  def write_deffile(dest_path)
-    dest_dir = File.dirname(final_extension_path(dest_path))
-    FileUtils.mkdir_p(dest_dir)
-    deffile_path = File.join(dest_dir, "#{spec.name}-#{RbConfig::CONFIG["arch"]}.def")
-    export_prefix = makefile_config("EXPORT_PREFIX") || ""
-
-    File.open(deffile_path, "w") do |f|
-      f.puts "EXPORTS"
-      f.puts "#{export_prefix.strip}Init_#{spec.name}"
-    end
-
-    deffile_path
-  end
-
-  # We have to basically reimplement RbConfig::CONFIG['SOEXT'] here to support
-  # Ruby < 2.5
-  #
-  # @see https://github.com/ruby/ruby/blob/c87c027f18c005460746a74c07cd80ee355b16e4/configure.ac#L3185
-  def so_ext
-    return RbConfig::CONFIG["SOEXT"] if RbConfig::CONFIG.key?("SOEXT")
-
-    if win_target?
-      "dll"
-    elsif darwin_target?
-      "dylib"
-    else
-      "so"
-    end
-  end
-
-  # Corresponds to $(LIBPATH) in mkmf
-  def mkmf_libpath
-    ["-L", "native=#{makefile_config("libdir")}"]
-  end
-
-  def makefile_config(var_name)
-    val = RbConfig::MAKEFILE_CONFIG[var_name]
-
-    return unless val
-
-    RbConfig.expand(val.dup)
-  end
-
-  # Good balance between binary size and debugability
-  def debug_flags
-    return [] if profile == :dev
-
-    ["-C", "debuginfo=1"]
-  end
-
-  # Copied from ExtConfBuilder
-  def finalize_directory(dest_path, lib_dir, extension_dir)
-    require "fileutils"
-    require "tempfile"
-
-    ext_path = final_extension_path(dest_path)
-
-    begin
-      tmp_dest = Dir.mktmpdir(".gem.", extension_dir)
-
-      # Some versions of `mktmpdir` return absolute paths, which will break make
-      # if the paths contain spaces. However, on Ruby 1.9.x on Windows, relative
-      # paths cause all C extension builds to fail.
-      #
-      # As such, we convert to a relative path unless we are using Ruby 1.9.x on
-      # Windows. This means that when using Ruby 1.9.x on Windows, paths with
-      # spaces do not work.
-      #
-      # Details: https://github.com/rubygems/rubygems/issues/977#issuecomment-171544940
-      tmp_dest_relative = get_relative_path(tmp_dest.clone, extension_dir)
-
-      if tmp_dest_relative
-        full_tmp_dest = File.join(extension_dir, tmp_dest_relative)
-
-        # TODO: remove in RubyGems 3
-        if Gem.install_extension_in_lib && lib_dir
-          FileUtils.mkdir_p lib_dir
-          FileUtils.cp_r ext_path, lib_dir, remove_destination: true
-        end
-
-        FileUtils::Entry_.new(full_tmp_dest).traverse do |ent|
-          destent = ent.class.new(dest_path, ent.rel)
-          destent.exist? || FileUtils.mv(ent.path, destent.path)
-        end
-      end
-    ensure
-      FileUtils.rm_rf tmp_dest if tmp_dest
-    end
-  end
-
-  def get_relative_path(path, base)
-    path[0..base.length - 1] = "." if path.start_with?(base)
-    path
-  end
-
-  def profile_target_directory
-    case profile
-    when :release then "release"
-    when :dev then "debug"
-    else raise "unknown target directory for profile: #{profile}"
-    end
-  end
-
-  # Error raised when no cdylib artifact was created
-  class DylibNotFoundError < StandardError
-    def initialize(dir)
-      files = Dir.glob(File.join(dir, "**", "*")).map { |f| "- #{f}" }.join "\n"
-
-      super <<~MSG
-        Dynamic library not found for Rust extension (in #{dir})
-
-        Make sure you set "crate-type" in Cargo.toml to "cdylib"
-
-        Found files:
-        #{files}
-      MSG
-    end
-  end
-end