rb_snowflake_client 1.6.1 → 1.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 57d979564fce1cdc8fb8b92043e89b631f4f1ca35db2cc2d4601a1739506e89a
-  data.tar.gz: ecfd25eb94ae8e5767e49c7b3b5dd33f02905e09c839ba0bd59be81f629f1390
+  metadata.gz: 14628efb496cd0a61e49675e329f38d075dd5bb201371df522b7a84e31a6beca
+  data.tar.gz: b8b3618986b2d8d5a24d660270ab8860ebb985718375183c8ab73af0a89cd124
 SHA512:
-  metadata.gz: 906470b3b67d6a102bbe25bc02e42c2178a4a9fc7a1eb6785398a1bfc45d6e47e9b5dc392aebc4dc35dbd0c6a2263c30c39c3ce522396a6584629f8d8e7ad43e
-  data.tar.gz: d767e9956def03c80dd8eb66d24649c54c987f37dc07870a319a55ac9455821b330e4d5a59e89246282899f40d76222c6a07b90dc6882a5e89ba3c410a6c1f95
+  metadata.gz: '00485ce43306464ac2d541a1349879d0e0130c4ced1dba7c785a0c1cd78319954e3eea734c6f77e4448d825f3ed42538f6ea042b1224a01d4b644d587cfa805b'
+  data.tar.gz: 90a65fc0820e5783870540d335a1db672f1a01affb5160cf4d88ba5411217a4e45ad896a16b274061f1d892161863958ad2da1c6ae87a373506c7c59692426f4

data/.github/workflows/arby-review.yml

@@ -0,0 +1,96 @@
+# For a PUBLIC repo: copy this one file into its .github/workflows/ instead of review.yml,
+# review-manual-request.yml and review-dismiss-stale.yml. A public repo can't use actions or reusable
+# workflows from rinsed-org/review-bot-workflows (an internal repo), so it doesn't run Arby itself. It asks
+# rinsed-org/review-bot-public-runner (internal) to, by dispatching that repo's review workflow with nothing
+# but this repo's name and the PR number. The runner reads this repo's settings (limit-approval-to,
+# blocking-severities, ...) from its own config file and runs the reusable workflow in cross-repo mode, which
+# reviews this PR in public repo mode and posts the review here as Arby. Per-repo setup: add this repo to the
+# runner's config, then add this file. See the bot's README, "Public repositories".
+#
+# Nothing PR-controlled reaches the dispatch: only github.repository and the PR number, passed through env.
+# No checkout, no PR code. The token is minted from the Arby Dispatcher app (Actions: write, installed only on
+# the runner repo) and scoped to that one repo, so all it can do is start runs there. The run's own red/green
+# status shows in the runner repo; on this PR the result is Arby's review. Manual "re-request Arby" reviews
+# aren't supported here yet: push a commit to get a new review.
+name: Arby review (public repo)
+
+on:
+  pull_request_target:
+    types: [opened, synchronize, reopened, ready_for_review]
+
+# Nothing by default; each job asks for exactly what it needs.
+permissions: {}
+
+jobs:
+  dispatch:
+    name: Request Arby review
+    # Drafts skip, as in review.yml.
+    if: github.event.pull_request.draft == false
+    runs-on: ubuntu-latest
+    timeout-minutes: 5
+    # Only the app token is used, so the job's own token needs nothing.
+    permissions: {}
+    steps:
+      - name: Mint a dispatch token
+        id: token
+        uses: actions/create-github-app-token@v3
+        with:
+          client-id: ${{ secrets.ARBY_DISPATCH_CLIENT_ID }}
+          private-key: ${{ secrets.ARBY_DISPATCH_PRIVATE_KEY }}
+          owner: rinsed-org
+          repositories: review-bot-public-runner
+          permission-actions: write
+      - name: Dispatch the review
+        env:
+          GH_TOKEN: ${{ steps.token.outputs.token }}
+          REPO: ${{ github.repository }}
+          PR: ${{ github.event.pull_request.number }}
+        run: |
+          # The REST endpoint directly, with an explicit ref: `gh workflow run` would first look up the runner
+          # repo's default branch, which needs Contents read, and this token has only Actions: write.
+          gh api --method POST repos/rinsed-org/review-bot-public-runner/actions/workflows/review.yml/dispatches \
+            -f ref=master -f "inputs[repo]=$REPO" -f "inputs[pr]=$PR"
+
+  # A COPY of rinsed-org/review-bot-workflows' dismiss-stale/action.yml, inlined because a public repo can't
+  # use that internal action. The two must change together. Its own job, so it stays a cheap check with no
+  # dependency on Arby, the app or the runner repo: make THIS job ("Dismiss stale Arby approvals") the
+  # required status check, as in review-dismiss-stale.yml. It runs on the job's default token and consumes
+  # nothing PR-controlled beyond the PR number.
+  dismiss:
+    # The required check is keyed on this name; keep it exactly as is.
+    name: Dismiss stale Arby approvals
+    concurrency:
+      group: arby-dismiss-stale-${{ github.event.pull_request.number }}
+      cancel-in-progress: true
+    timeout-minutes: 5
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
+    steps:
+      - name: Dismiss stale review-bot approvals
+        shell: bash
+        env:
+          GH_TOKEN: ${{ github.token }}
+          REPO: ${{ github.repository }}
+          PR: ${{ github.event.pull_request.number }}
+          BOT_LOGIN: rinsed-review-bot
+        run: |
+          set -euo pipefail
+          if [ -z "$PR" ]; then
+            echo "::error::No pull request in the event payload — call this from a pull_request_target workflow."
+            exit 1
+          fi
+          # Skip approvals for the PR's current head: the review workflow runs on the same event with no
+          # ordering, so a delayed dismiss job must not kill an approval Arby already gave the new commits. The
+          # head is fetched at execution time (not from the event payload) so a run delayed past a newer push
+          # can't dismiss that newer push's approval either.
+          head_sha=$(gh api "repos/$REPO/pulls/$PR" --jq .head.sha)
+          gh api "repos/$REPO/pulls/$PR/reviews" --paginate \
+            --jq ".[] | select(.user.login == \"$BOT_LOGIN\" and .state == \"APPROVED\"
+                              and .commit_id != \"$head_sha\") | .id" |
+          while read -r review_id; do
+            echo "Dismissing stale approval (review $review_id)"
+            # The API rejects blank (or whitespace-only) messages, so this is as terse as GitHub allows.
+            gh api --method PUT "repos/$REPO/pulls/$PR/reviews/$review_id/dismissals" \
+              --field message="Dismissing stale review" --field event="DISMISS"
+          done

data/CHANGELOG.md

@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+## [1.6.2] - 2026-10-19
+### Fixed
+- Compatibility with `json` 3.0, where `JSON.parse` options are keyword-only: every query raised
+  `ArgumentError: wrong number of arguments (given 2, expected 1)` because the parse options were passed
+  as a positional Hash. They're now passed as keywords, which works on `json` 2.x and 3.x. (#191)
+
 ## [1.6.1] - 2026-08-18
 ### Security
 - Bumped `json` to patch a format-string injection CVE (#169)

data/lib/ruby_snowflake/client.rb

@@ -300,12 +300,12 @@ module RubySnowflake
       end
 
       def retrieve_result_set(query_start_time, query, response, streaming, query_timeout)
-        json_body = JSON.parse(response.body, JSON_PARSE_OPTIONS)
+        json_body = JSON.parse(response.body, **JSON_PARSE_OPTIONS)
         statement_handle = json_body["statementHandle"]
 
         if response.code == POLLING_RESPONSE_CODE
           result_response = poll_for_completion_or_timeout(query_start_time, query, statement_handle, query_timeout)
-          json_body = JSON.parse(result_response.body, JSON_PARSE_OPTIONS)
+          json_body = JSON.parse(result_response.body, **JSON_PARSE_OPTIONS)
         end
 
         num_threads = number_of_threads_to_use(json_body["resultSetMetaData"]["partitionInfo"].size)
@@ -331,7 +331,7 @@ module RubySnowflake
         end
 
         partition_json = {}
-        bm = Benchmark.measure { partition_json = JSON.parse(partition_response.body, JSON_PARSE_OPTIONS) }
+        bm = Benchmark.measure { partition_json = JSON.parse(partition_response.body, **JSON_PARSE_OPTIONS) }
         logger.debug { "JSON parsing took: #{bm.real}" }
         partition_data = partition_json["data"]
 

data/lib/ruby_snowflake/version.rb

@@ -1,3 +1,3 @@
 module RubySnowflake
-  VERSION = "1.6.1"
+  VERSION = "1.6.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rb_snowflake_client
 version: !ruby/object:Gem::Version
-  version: 1.6.1
+  version: 1.6.2
 platform: ruby
 authors:
 - Rinsed
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-08-18 00:00:00.000000000 Z
+date: 2026-10-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bigdecimal
@@ -120,6 +120,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".github/dependabot.yml"
+- ".github/workflows/arby-review.yml"
 - ".github/workflows/ci.yml"
 - ".github/workflows/release-gh-packages.yml"
 - ".github/workflows/release-rubygems.yml"