rb-net_http-client 1.0.1 → 1.0.2

data/spec/unit/request/request_spec.rb

@@ -0,0 +1,275 @@
+# frozen_string_literal: true
+
+require 'webmock/rspec'
+require_relative '../../spec_helper'
+
+describe 'NetHTTP::Client web service calls' do
+  it 'makes a request with an invalid HTTP method' do
+    net_http_client = NetHTTP.client(
+      uri: 'https://jsonplaceholder.typicode.com/posts'
+    )
+
+    expect {
+      net_http_client.call_web_service(
+        method: 'DOES_NOT_EXIST'
+      )
+    }.to raise_error(RuntimeError, "Request method => 'DOES_NOT_EXIST' not yet supported.")
+  end
+
+  it 'makes a request with valid HTTP method => delete' do
+    stub_request(
+      :delete,
+      'https://jsonplaceholder.typicode.com/posts'
+    ).with(
+      headers: request_headers,
+      body: nil
+    ).to_return(
+      status: 200,
+      headers: successful_post_response_headers,
+      body: successful_post_response_body
+    )
+
+    net_http_client = NetHTTP.client(
+      uri: 'https://jsonplaceholder.typicode.com/'
+    )
+
+    response = net_http_client.call_web_service(
+      method: 'delete',
+      path: '/posts'
+    )
+
+    expect(response.code.to_s).to eq('200')
+    expect(response.headers).to eq(successful_post_response_headers)
+    expect(response.headers_hash).not_to eq(nil)
+    expect(response.headers_hash.class).to eq(Hash)
+    expect(response.body).to eq(successful_post_response_body)
+    expect(response.body_obj).not_to eq(nil)
+    expect(response.body_obj.class).to eq(Hash)
+  end
+
+  it 'makes a request with valid HTTP method => get' do
+    stub_request(
+      :get,
+      'https://jsonplaceholder.typicode.com/posts'
+    ).with(
+      headers: request_headers,
+      body: nil
+    ).to_return(
+      status: 200,
+      headers: successful_post_response_headers,
+      body: successful_post_response_body
+    )
+
+    net_http_client = NetHTTP.client(
+      uri: 'https://jsonplaceholder.typicode.com/'
+    )
+
+    response = net_http_client.call_web_service(
+      method: 'get',
+      path: '/posts'
+    )
+
+    expect(response.code.to_s).to eq('200')
+    expect(response.headers).to eq(successful_post_response_headers)
+    expect(response.headers_hash).not_to eq(nil)
+    expect(response.headers_hash.class).to eq(Hash)
+    expect(response.body).to eq(successful_post_response_body)
+    expect(response.body_obj).not_to eq(nil)
+    expect(response.body_obj.class).to eq(Hash)
+  end
+
+  it 'makes a request with valid HTTP method => post' do
+    stub_request(
+      :post,
+      'https://jsonplaceholder.typicode.com/posts'
+    ).with(
+      headers: request_headers,
+      body: nil
+    ).to_return(
+      status: 200,
+      headers: successful_post_response_headers,
+      body: successful_post_response_body
+    )
+
+    net_http_client = NetHTTP.client(
+      uri: 'https://jsonplaceholder.typicode.com/'
+    )
+
+    response = net_http_client.call_web_service(
+      method: 'post',
+      path: '/posts'
+    )
+
+    expect(response.code.to_s).to eq('200')
+    expect(response.headers).to eq(successful_post_response_headers)
+    expect(response.headers_hash).not_to eq(nil)
+    expect(response.headers_hash.class).to eq(Hash)
+    expect(response.body).to eq(successful_post_response_body)
+    expect(response.body_obj).not_to eq(nil)
+    expect(response.body_obj.class).to eq(Hash)
+  end
+
+#   it 'makes a request with valid HTTP method => post_form' do
+#      stub_request(
+#       :post,
+#       'https://jsonplaceholder.typicode.com/posts'
+#     ).with(
+#       headers: request_headers,
+#       body: nil
+#     ).to_return(
+#       status: 200,
+#       headers: successful_post_response_headers,
+#       body: successful_post_response_body
+#     )
+# 
+#     net_http_client = NetHTTP.client(
+#       uri: 'https://jsonplaceholder.typicode.com/'
+#     )
+#     response = net_http_client.call_web_service(
+#       method: 'post_form',
+#       path: '/posts'
+#     )
+# 
+#     expect(response.code.to_s).to eq('200')
+#     expect(response.headers).to eq(successful_post_response_headers)
+#     expect(response.headers_hash).not_to eq(nil)
+#     expect(response.headers_hash.class).to eq(Hash)
+#     expect(response.body).to eq(successful_post_response_body)
+#     expect(response.body_obj).not_to eq(nil)
+#     expect(response.body_obj.class).to eq(Hash)
+#   end
+
+  it 'makes a request with valid HTTP method => put' do
+    stub_request(
+      :put,
+      'https://jsonplaceholder.typicode.com/posts'
+    ).with(
+      headers: request_headers,
+      body: nil
+    ).to_return(
+      status: 200,
+      headers: successful_post_response_headers,
+      body: successful_post_response_body
+    )
+
+    net_http_client = NetHTTP.client(
+      uri: 'https://jsonplaceholder.typicode.com/'
+    )
+
+    response = net_http_client.call_web_service(
+      method: 'put',
+      path: '/posts'
+    )
+
+    expect(response.code.to_s).to eq('200')
+    expect(response.headers).to eq(successful_post_response_headers)
+    expect(response.headers_hash).not_to eq(nil)
+    expect(response.headers_hash.class).to eq(Hash)
+    expect(response.body).to eq(successful_post_response_body)
+    expect(response.body_obj).not_to eq(nil)
+    expect(response.body_obj.class).to eq(Hash)
+  end
+
+  it 'successfully make a POST request' do
+    stub_request(
+      :post,
+      'https://jsonplaceholder.typicode.com/posts'
+    ).with(
+      headers: request_headers,
+      body: nil
+    ).to_return(
+      status: 200,
+      headers: successful_post_response_headers,
+      body: successful_post_response_body
+    )
+
+    net_http_client = NetHTTP.client(
+      uri: 'https://jsonplaceholder.typicode.com/'
+    )
+    response = net_http_client.post(
+      path: '/posts'
+    )
+
+    expect(response.code.to_s).to eq('200')
+    expect(response.headers).to eq(successful_post_response_headers)
+    expect(response.headers_hash).not_to eq(nil)
+    expect(response.headers_hash.class).to eq(Hash)
+    expect(response.body).to eq(successful_post_response_body)
+    expect(response.body_obj).not_to eq(nil)
+    expect(response.body_obj.class).to eq(Hash)
+  end
+
+  it 'makes a request with valid HTTP method => get with ? in request path' do
+    stub_request(
+      :get,
+      "https://autotrader.com/cars-for-sale/searchresults.xhtml?searchRadius=0"
+    ).with(
+      headers: {
+        'Accept' => '*/*',
+        'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
+        'User-Agent' => 'Ruby'
+      }
+    ).to_return(
+      status: 200,
+      body: '',
+      headers: {}
+    )
+
+    net_http_client = NetHTTP.client(
+      uri: 'https://autotrader.com'
+    )
+
+    response = net_http_client.get(
+      path: '/cars-for-sale/searchresults.xhtml',
+      query: '?searchRadius=0'
+    )
+
+    expect(response.code.to_s).to eq('200')
+    expect(response.headers).to eq({})
+    expect(response.headers_hash).not_to eq(nil)
+    expect(response.headers_hash.class).to eq(Hash)
+    expect(response.body).to eq('')
+    expect(response.body_obj).not_to eq(nil)
+    expect(response.body_obj.class).to eq(Hash)
+  end
+
+  private
+
+  def request_headers
+    {
+      'Accept' => '*/*',
+      'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
+      'User-Agent' => 'Ruby'
+    }
+  end
+
+  def successful_post_response_headers
+    {
+      'date' => 'Tue, 05 Mar 2019 22:44:58 GMT',
+      'content-type' => 'application/json; charset=utf-8',
+      'content-length' => '15',
+      'connection' => 'close',
+      'set-cookie' => '__cfduid=d9e01b81c42675802849336961ecd18371551825898; expires=Wed, 04-Mar-20 22:44:58 GMT; path=/; domain=.typicode.com; HttpOnly',
+      'x-powered-by' => 'Express',
+      'vary' => 'Origin, X-HTTP-Method-Override, Accept-Encoding',
+      'access-control-allow-credentials' => 'true',
+      'cache-control' => 'no-cache',
+      'pragma' => 'no-cache',
+      'expires' => '-1',
+      'access-control-expose-headers' => 'Location',
+      'location' => 'http://jsonplaceholder.typicode.com/posts/101',
+      'x-content-type-options' => 'nosniff',
+      'etag' => "W/'f-4jjw4Y8q22Yv1PV9m28FczJgjzk'",
+      'via' => '1.1 vegur',
+      'expect-ct' => "max-age=604800, report-uri='https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct'",
+      'server' => 'cloudflare',
+      'cf-ray' => '4b2f9e1b0c9dcd00-EWR'
+    }
+  end
+
+  def successful_post_response_body
+    '{
+      "id": 101
+    }'
+  end
+end

data/spec/unit/response/response_spec.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+require_relative '../../spec_helper'
+
+describe 'NetHTTP::Response' do
+  it 'rescues body_obj= JSON::ParserError' do
+    # response = NetHTTP::Response.new(
+    #   response: 
+    # )
+  end
+
+  it 'rescues body_obj= XML Nokogiri::XML::SyntaxError' do
+
+  end
+
+  it 'rescues body_obj= HTML Nokogiri::XML::SyntaxError' do
+
+  end
+
+  private
+
+  def invalid_json_body
+    '''
+
+    '''
+  end
+
+  def invalid_xml_body
+    '''
+
+    '''
+  end
+
+  def invalid_html_body
+    '''
+
+    '''
+  end
+end

data/spec/{integration/net_http → unit}/version_spec.rb

@@ -1,4 +1,4 @@
-require_relative '../../spec_helper'
+require_relative '../spec_helper'
 
 describe NetHTTP::VERSION do
   it 'should have a valid version' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rb-net_http-client
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Ryan Bostian
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-28 00:00:00.000000000 Z
+date: 2019-03-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-validation
@@ -209,22 +209,14 @@ files:
 - lib/request/request.rb
 - lib/request/schema.rb
 - lib/response/response.rb
-- lib/response/schema.rb
 - lib/version.rb
-- spec/integration/net_http/client/client_ext_spec.rb
-- spec/integration/net_http/client/client_spec.rb
-- spec/integration/net_http/net_http_core_spec.rb
-- spec/integration/net_http/request/request_ext_spec.rb
-- spec/integration/net_http/response/response_ext_spec.rb
-- spec/integration/net_http/version_spec.rb
-- spec/unit/net_http/client/client_ext_spec.rb
-- spec/unit/net_http/client/client_schema_spec.rb
-- spec/unit/net_http/client/client_spec.rb
-- spec/unit/net_http/net_http_core_spec.rb
-- spec/unit/net_http/request/request_ext_spec.rb
-- spec/unit/net_http/request/request_schema_spec.rb
-- spec/unit/net_http/response/response_ext_spec.rb
-- spec/unit/net_http/version_spec.rb
+- spec/unit/client/client_spec.rb
+- spec/unit/client/ext_spec.rb
+- spec/unit/core/core_spec.rb
+- spec/unit/core/utilities_spec.rb
+- spec/unit/request/request_spec.rb
+- spec/unit/response/response_spec.rb
+- spec/unit/version_spec.rb
 homepage: https://github.com/rabos5/rb-net_http-client
 licenses:
 - MIT

data/lib/response/schema.rb

@@ -1,11 +0,0 @@
-# frozen_string_literal: true
-
-require 'dry-validation'
-
-module NetHTTP
-  class Response
-    Schema = Dry::Validation.Schema do
-      required(:response).filled(type?: Net::HTTPResponse)
-    end
-  end
-end

data/spec/integration/net_http/client/client_ext_spec.rb

@@ -1,7 +0,0 @@
-require_relative '../../../spec_helper'
-
-describe NetHTTP::Client::Ext do
-  # it '' do
-  #
-  # end
-end

data/spec/integration/net_http/client/client_spec.rb

@@ -1,7 +0,0 @@
-require_relative '../../../spec_helper'
-
-describe 'NetHTTP.client' do
-  # it '' do
-  #
-  # end
-end

data/spec/integration/net_http/net_http_core_spec.rb

@@ -1,18 +0,0 @@
-require_relative '../../spec_helper'
-
-describe NetHTTP::Core do
-  it 'returns schema validation errors when invalid options are used to instantiate a NetHTTP client' do
-    client_opts = {}
-
-    expect { NetHTTP.client(client_opts) } .to raise_error('NetHTTP::Core::Error - schema input validation failed.')
-  end
-
-  it 'returns schema validation errors when invalid options are used to instantiate a NetHTTP client with logger' do
-    client_opts = {}
-    logger = Logger.new(STDOUT)
-    logger.level = Logger::INFO
-    client_opts[:logger] = logger
-
-    expect { NetHTTP.client(client_opts) } .to raise_error('NetHTTP::Core::Error - schema input validation failed.')
-  end
-end