rb-net_http-client 0.0.4

data/spec/integration/net_http/response/response_ext_spec.rb

@@ -0,0 +1,7 @@
+require_relative '../../../spec_helper'
+
+describe NetHTTP::Response::Ext do
+  # it '' do
+  #
+  # end
+end

data/spec/integration/net_http/version_spec.rb

@@ -0,0 +1,10 @@
+require_relative '../../spec_helper'
+
+describe NetHTTP::VERSION do
+  it 'should have a valid version' do
+    expect(NetHTTP::VERSION.nil?).to eq(false)
+    expect(NetHTTP::VERSION.empty?).to eq(false)
+    expect(NetHTTP::VERSION.class).to eq(String)
+    expect(NetHTTP::VERSION.frozen?).to eq(true)
+  end
+end

data/spec/unit/net_http/client/client_ext_spec.rb

@@ -0,0 +1,7 @@
+require_relative '../../../spec_helper'
+
+describe NetHTTP::Client::Ext do
+  # it '' do
+  #
+  # end
+end

data/spec/unit/net_http/client/client_schema_spec.rb

@@ -0,0 +1,8 @@
+require_relative '../../../spec_helper'
+
+describe NetHTTP::Client::Schema do
+  # TODO: Add unit tests around input validation.
+  # it '' do
+  #
+  # end
+end

data/spec/unit/net_http/client/client_spec.rb

@@ -0,0 +1,232 @@
+require_relative '../../../spec_helper'
+
+describe 'NetHTTP.client' do
+  it 'returns a valid Net::HTTP client instance' do
+    client_opts = {}
+    client_opts[:uri] = 'https://esg-qa-oauth2-internal.fmr.com/as/resourceOwner'
+
+    client = NetHTTP.client(client_opts)
+
+    expect(client.class).to eq(Net::HTTP)
+    expect(client.logger.class).to eq(Logger)
+    expect(client.logger.level).to eq(Logger::INFO)
+    expect(client.uri.to_s).to eq(client_opts[:uri])
+    expect(client.host).to eq('esg-qa-oauth2-internal.fmr.com')
+    expect(client.port).to eq(443)
+    expect(client.path).to eq('/as/resourceOwner')
+    expect(client.proxy_uri.to_s).to eq('http://http.proxy.fmr.com:8000/')
+    expect(client.use_proxy).to eq(true)
+    expect(client.use_ssl).to eq(true)
+    expect(client.verify_mode).to eq(OpenSSL::SSL::VERIFY_NONE)
+    expect(client.open_timeout).to eq(60)
+    expect(client.read_timeout).to eq(60)
+  end
+
+  it 'returns a valid Net::HTTP client instance' do
+    client_opts = {}
+    client_opts[:uri] = 'https://esg-qa-oauth2-internal.fmr.com/as/resourceOwner'
+    client_opts[:use_ssl] = true
+    client_opts[:verify_mode] = OpenSSL::SSL::VERIFY_NONE
+
+    client = NetHTTP.client(client_opts)
+
+    expect(client.class).to eq(Net::HTTP)
+    expect(client.logger.class).to eq(Logger)
+    expect(client.logger.level).to eq(Logger::INFO)
+    expect(client.uri.to_s).to eq(client_opts[:uri])
+    expect(client.host).to eq('esg-qa-oauth2-internal.fmr.com')
+    expect(client.port).to eq(443)
+    expect(client.path).to eq('/as/resourceOwner')
+    expect(client.proxy_uri.to_s).to eq('http://http.proxy.fmr.com:8000/')
+    expect(client.use_proxy).to eq(true)
+    expect(client.use_ssl).to eq(true)
+    expect(client.verify_mode).to eq(OpenSSL::SSL::VERIFY_NONE)
+    expect(client.open_timeout).to eq(60)
+    expect(client.read_timeout).to eq(60)
+  end
+
+  it 'returns a valid Net::HTTP client instance when uri is eelslap.com:80/' do
+    client_opts = {}
+    client_opts[:uri] = 'eelslap.com:80/'
+
+    client = NetHTTP.client(client_opts)
+
+    expect(client.class).to eq(Net::HTTP)
+    expect(client.logger.class).to eq(Logger)
+    expect(client.logger.level).to eq(Logger::INFO)
+    expect(client.uri.to_s).to eq('http://eelslap.com/')
+    expect(client.host).to eq('eelslap.com')
+    expect(client.port).to eq(80)
+    expect(client.path).to eq('/')
+    expect(client.proxy_uri.to_s).to eq('http://http.proxy.fmr.com:8000/')
+    expect(client.use_proxy).to eq(true)
+    expect(client.use_ssl).to eq(false)
+    expect(client.verify_mode).to eq(nil)
+    expect(client.open_timeout).to eq(60)
+    expect(client.read_timeout).to eq(60)
+  end
+
+  it 'returns a valid Net::HTTP client instance when no uri / url is provided' do
+    client_opts = {}
+    client_opts[:scheme] = 'https'
+    client_opts[:host] = 'esg-qa-oauth2-internal.fmr.com'
+    client_opts[:port] = 443
+    client_opts[:path] = '/as/resourceOwner'
+
+    client = NetHTTP.client(client_opts)
+
+    expect(client.class).to eq(Net::HTTP)
+    expect(client.logger.class).to eq(Logger)
+    expect(client.logger.level).to eq(Logger::INFO)
+    expect(client.uri.to_s).to eq('https://esg-qa-oauth2-internal.fmr.com/as/resourceOwner')
+    expect(client.host).to eq('esg-qa-oauth2-internal.fmr.com')
+    expect(client.port).to eq(443)
+    expect(client.path).to eq('/as/resourceOwner')
+    expect(client.proxy_uri.to_s).to eq('http://http.proxy.fmr.com:8000/')
+    expect(client.use_proxy).to eq(true)
+    expect(client.use_ssl).to eq(true)
+    expect(client.verify_mode).to eq(OpenSSL::SSL::VERIFY_NONE)
+    expect(client.open_timeout).to eq(60)
+    expect(client.read_timeout).to eq(60)
+  end
+
+  it 'returns a valid Net::HTTP client instance when only host, port, and path are provided' do
+    client_opts = {}
+    client_opts[:host] = 'esg-qa-oauth2-internal.fmr.com'
+    client_opts[:port] = 443
+    client_opts[:path] = '/as/resourceOwner'
+
+    client = NetHTTP.client(client_opts)
+
+    expect(client.class).to eq(Net::HTTP)
+    expect(client.logger.class).to eq(Logger)
+    expect(client.logger.level).to eq(Logger::INFO)
+    expect(client.uri.to_s).to eq('https://esg-qa-oauth2-internal.fmr.com/as/resourceOwner')
+    expect(client.host).to eq('esg-qa-oauth2-internal.fmr.com')
+    expect(client.port).to eq(443)
+    expect(client.path).to eq('/as/resourceOwner')
+    expect(client.proxy_uri.to_s).to eq('http://http.proxy.fmr.com:8000/')
+    expect(client.use_proxy).to eq(true)
+    expect(client.use_ssl).to eq(true)
+    expect(client.verify_mode).to eq(OpenSSL::SSL::VERIFY_NONE)
+    expect(client.open_timeout).to eq(60)
+    expect(client.read_timeout).to eq(60)
+  end
+
+  it 'returns a valid Net::HTTP client instance when only host and path are provided' do
+    client_opts = {}
+    client_opts[:host] = 'esg-qa-oauth2-internal.fmr.com'
+    client_opts[:path] = '/as/resourceOwner'
+    client_opts[:enforce_schema_validation] = false
+
+    client = NetHTTP.client(client_opts)
+
+    expect(client.class).to eq(Net::HTTP)
+    expect(client.logger.class).to eq(Logger)
+    expect(client.logger.level).to eq(Logger::INFO)
+    expect(client.uri.to_s).to eq('https://esg-qa-oauth2-internal.fmr.com/as/resourceOwner')
+    expect(client.host).to eq('esg-qa-oauth2-internal.fmr.com')
+    expect(client.port).to eq(443)
+    expect(client.path).to eq('/as/resourceOwner')
+    expect(client.proxy_uri.to_s).to eq('http://http.proxy.fmr.com:8000/')
+    expect(client.use_proxy).to eq(true)
+    expect(client.use_ssl).to eq(true)
+    expect(client.verify_mode).to eq(OpenSSL::SSL::VERIFY_NONE)
+    expect(client.open_timeout).to eq(60)
+    expect(client.read_timeout).to eq(60)
+  end
+
+  it 'returns a valid Net::HTTP client instance when use_proxy & use_ssl are false' do
+    client_opts = {}
+    client_opts[:uri] = 'https://esg-qa-oauth2-internal.fmr.com/as/resourceOwner'
+    client_opts[:use_proxy] = false
+    client_opts[:use_ssl] = false
+
+    client = NetHTTP.client(client_opts)
+
+    expect(client.class).to eq(Net::HTTP)
+    expect(client.logger.class).to eq(Logger)
+    expect(client.logger.level).to eq(Logger::INFO)
+    expect(client.uri.to_s).to eq(client_opts[:uri])
+    expect(client.host).to eq('esg-qa-oauth2-internal.fmr.com')
+    expect(client.port).to eq(443)
+    expect(client.path).to eq('/as/resourceOwner')
+    # expect(client.proxy_uri.to_s).to eq((ENV['http_proxy'] ||= 'http://http.proxy.fmr.com:8000/'))
+    expect(client.use_proxy).to eq(false)
+    expect(client.use_ssl).to eq(false)
+    expect(client.verify_mode).to eq(nil)
+    expect(client.open_timeout).to eq(60)
+    expect(client.read_timeout).to eq(60)
+  end
+
+  it 'returns a valid Net::HTTP client instance use_ssl and scheme are nil' do
+    client_opts = {}
+    client_opts[:uri] = 'esg-qa-oauth2-internal.fmr.com:443/as/resourceOwner'
+    client_opts[:enforce_schema_validation] = false
+    client_opts[:use_ssl] = nil
+
+    client = NetHTTP.client(client_opts)
+
+    expect(client.class).to eq(Net::HTTP)
+    expect(client.logger.class).to eq(Logger)
+    expect(client.logger.level).to eq(Logger::INFO)
+    expect(client.uri.to_s).to eq('https://esg-qa-oauth2-internal.fmr.com/as/resourceOwner')
+    expect(client.host).to eq('esg-qa-oauth2-internal.fmr.com')
+    expect(client.port).to eq(443)
+    expect(client.path).to eq('/as/resourceOwner')
+    # expect(client.proxy_uri.to_s).to eq((ENV['http_proxy'] ||= 'http://http.proxy.fmr.com:8000/'))
+    expect(client.use_proxy).to eq(true)
+    expect(client.use_ssl).to eq(true)
+    expect(client.verify_mode).to eq(OpenSSL::SSL::VERIFY_NONE)
+    expect(client.open_timeout).to eq(60)
+    expect(client.read_timeout).to eq(60)
+  end
+
+  it 'returns a valid Net::HTTP client instance use_ssl, scheme, and port are nil' do
+    client_opts = {}
+    client_opts[:uri] = 'esg-qa-oauth2-internal.fmr.com/as/resourceOwner'
+    client_opts[:enforce_schema_validation] = false
+    client_opts[:use_ssl] = nil
+
+    client = NetHTTP.client(client_opts)
+
+    expect(client.class).to eq(Net::HTTP)
+    expect(client.logger.class).to eq(Logger)
+    expect(client.logger.level).to eq(Logger::INFO)
+    expect(client.uri.to_s).to eq('https://esg-qa-oauth2-internal.fmr.com/as/resourceOwner')
+    expect(client.host).to eq('esg-qa-oauth2-internal.fmr.com')
+    expect(client.port).to eq(443)
+    expect(client.path).to eq('/as/resourceOwner')
+    # expect(client.proxy_uri.to_s).to eq((ENV['http_proxy'] ||= 'http://http.proxy.fmr.com:8000/'))
+    expect(client.use_proxy).to eq(true)
+    expect(client.use_ssl).to eq(true)
+    expect(client.verify_mode).to eq(OpenSSL::SSL::VERIFY_NONE)
+    expect(client.open_timeout).to eq(60)
+    expect(client.read_timeout).to eq(60)
+  end
+
+  it 'returns a valid Net::HTTP client instance when use_proxy & use_ssl are true' do
+    client_opts = {}
+    client_opts[:uri] = 'https://esg-qa-oauth2-internal.fmr.com/as/resourceOwner'
+    client_opts[:use_proxy] = true
+    client_opts[:use_ssl] = true
+
+    client = NetHTTP.client(client_opts)
+
+    expect(client.class).to eq(Net::HTTP)
+    expect(client.logger.class).to eq(Logger)
+    expect(client.logger.level).to eq(Logger::INFO)
+    expect(client.uri.to_s).to eq(client_opts[:uri])
+    expect(client.host).to eq('esg-qa-oauth2-internal.fmr.com')
+    expect(client.port).to eq(443)
+    expect(client.path).to eq('/as/resourceOwner')
+    # expect(client.proxy_uri.to_s).to eq((ENV['http_proxy'] ||= 'http://http.proxy.fmr.com:8000/'))
+    expect(client.use_proxy).to eq(true)
+    expect(client.use_ssl).to eq(true)
+    expect(client.verify_mode).to eq(OpenSSL::SSL::VERIFY_NONE)
+    expect(client.open_timeout).to eq(60)
+    expect(client.read_timeout).to eq(60)
+  end
+
+  # TODO: Add in the unit tests for the cert based scenarios (i.e. MAUI)
+end

data/spec/unit/net_http/net_http_core_spec.rb

@@ -0,0 +1,433 @@
+require_relative '../../spec_helper'
+
+describe NetHTTP::Core do
+  Schema = Dry::Validation.Schema do
+    required(:required).filled(:type? => String)
+  end
+
+  # NetHTTP::Core.assign_logger(logger = nil)
+  it 'assigns logger by default when no logger is provided' do
+    logger = NetHTTP::Core.assign_logger
+    expect(logger.class).to eq(Logger)
+    expect(logger.level).to eq(Logger::INFO)
+  end
+
+  it 'assigns logger by default when logger is nil' do
+    logger = nil
+    logger = NetHTTP::Core.assign_logger(logger)
+    expect(logger.class).to eq(Logger)
+    expect(logger.level).to eq(Logger::INFO)
+  end
+
+  it 'assigns logger by default when logger is empty' do
+    logger = ''
+    logger = NetHTTP::Core.assign_logger(logger)
+    expect(logger.class).to eq(Logger)
+    expect(logger.level).to eq(Logger::INFO)
+  end
+
+  it 'returns logger when valid logger is provided' do
+    logger = Logger.new(STDOUT)
+    logger.level = Logger::FATAL
+
+    logger = NetHTTP::Core.assign_logger(logger)
+    expect(logger.class).to eq(Logger)
+    expect(logger.level).to eq(Logger::FATAL)
+  end
+
+  # NetHTTP::Core.parse_uri(uri)
+  it 'should return nil if nil uri is provided' do
+    uri = nil
+    uri = NetHTTP::Core.parse_uri(uri)
+    expect(uri).to eq(nil)
+  end
+
+  it 'should return nil if empty uri is provided' do
+    uri = ''
+    uri = NetHTTP::Core.parse_uri(uri)
+    expect(uri).to eq(nil)
+  end
+
+  it 'should return valid URI object if valid uri is provided' do
+    uri = 'https://esg-qa-oauth2-internal.fmr.com/as/resourceOwner'
+    uri = NetHTTP::Core.parse_uri(uri)
+    expect(uri.scheme).to eq('https')
+    expect(uri.host).to eq('esg-qa-oauth2-internal.fmr.com')
+    expect(uri.port).to eq(443)
+    expect(uri.path).to eq('/as/resourceOwner')
+  end
+
+  it 'should return valid URI object if uri with no scheme is provided' do
+    uri = 'esg-qa-oauth2-internal.fmr.com:443/as/resourceOwner'
+    uri = NetHTTP::Core.parse_uri(uri)
+    expect(uri.scheme).to eq('https')
+    expect(uri.host).to eq('esg-qa-oauth2-internal.fmr.com')
+    expect(uri.port).to eq(443)
+    expect(uri.path).to eq('/as/resourceOwner')
+  end
+
+  it 'should return valid URI object if uri with no scheme or port is provided' do
+    uri = 'esg-qa-oauth2-internal.fmr.com/as/resourceOwner'
+    uri = NetHTTP::Core.parse_uri(uri)
+    expect(uri.scheme).to eq('https')
+    expect(uri.host).to eq('esg-qa-oauth2-internal.fmr.com')
+    expect(uri.port).to eq(443)
+    expect(uri.path).to eq('/as/resourceOwner')
+  end
+
+  it 'should return valid URI object if uri is a URI object provided' do
+    uri = URI('https://esg-qa-oauth2-internal.fmr.com/as/resourceOwner')
+    uri = NetHTTP::Core.parse_uri(uri)
+    expect(uri.scheme).to eq('https')
+    expect(uri.host).to eq('esg-qa-oauth2-internal.fmr.com')
+    expect(uri.port).to eq(443)
+    expect(uri.path).to eq('/as/resourceOwner')
+  end
+
+  it 'should successfully parse the Fidelity proxy uri' do
+    uri = 'http://http.proxy.fmr.com:8000'
+    uri = NetHTTP::Core.parse_uri(uri)
+    expect(uri.scheme).to eq('http')
+    expect(uri.host).to eq('http.proxy.fmr.com')
+    expect(uri.port).to eq(8000)
+    expect(uri.path).to eq('')
+  end
+
+  # NetHTTP::Core.schema_validation(opts, schema, logger = nil)
+  it 'should execute schema validation (pass) with no logger provided' do
+    opts = {}
+    opts[:required] = 'hello'
+    NetHTTP::Core.schema_validation(opts, Schema)
+  end
+
+  it 'should execute schema validation (pass) with logger provided' do
+    logger = Logger.new(STDOUT)
+    logger.level = Logger::INFO
+
+    opts = {}
+    opts[:required] = 'hello'
+    NetHTTP::Core.schema_validation(opts, Schema, logger)
+  end
+
+  it 'should execute schema validation (fail) with no logger provided' do
+    opts = {}
+    begin
+      NetHTTP::Core.schema_validation(opts, Schema)
+    rescue RuntimeError => err
+      expect(err.message.include?('NetHTTP::Core::Error - schema input validation failed.')).to eq(true)
+    end
+  end
+
+  it 'should execute schema validation (fail) with logger provided' do
+    logger = Logger.new(STDOUT)
+    logger.level = Logger::DEBUG
+
+    opts = {}
+    begin
+      NetHTTP::Core.schema_validation(opts, Schema, logger)
+    rescue RuntimeError => err
+      expect(err.message.include?('NetHTTP::Core::Error - schema input validation failed.')).to eq(true)
+    end
+  end
+
+  # NetHTTP::Core.valid_json?(string)
+  it 'should return true for valid json string' do
+    valid_json_string = '{"key":"value"}'
+
+    expect(NetHTTP::Core.valid_json?(valid_json_string)).to eq(true)
+  end
+
+  it 'should return true for valid json string passing in logger' do
+    logger = Logger.new(STDOUT)
+    logger.level = Logger::DEBUG
+    valid_json_string = '{"key":"value"}'
+
+    expect(NetHTTP::Core.valid_json?(valid_json_string, logger)).to eq(true)
+  end
+
+  it 'should return false for invalid json string' do
+    invalid_json_string = ':'
+
+    expect(NetHTTP::Core.valid_json?(invalid_json_string)).to eq(false)
+  end
+
+  it 'should return false for invalid json string passing in logger' do
+    logger = Logger.new(STDOUT)
+    logger.level = Logger::DEBUG
+    invalid_json_string = ':'
+
+    expect(NetHTTP::Core.valid_json?(invalid_json_string, logger)).to eq(false)
+  end
+
+  # NetHTTP::Core.valid_xml?(string)
+  it 'should return true for valid xml string' do
+    valid_xml_string = '<key>value</key>'
+
+    expect(NetHTTP::Core.valid_xml?(valid_xml_string)).to eq(true)
+  end
+
+  it 'should return true for valid xml string passing in logger' do
+    logger = Logger.new(STDOUT)
+    logger.level = Logger::DEBUG
+    valid_xml_string = '<key>value</key>'
+
+    expect(NetHTTP::Core.valid_xml?(valid_xml_string, logger)).to eq(true)
+  end
+
+  it 'should return false for invalid xml string' do
+    invalid_xml_string = '<key>value</key'
+
+    expect(NetHTTP::Core.valid_xml?(invalid_xml_string)).to eq(false)
+  end
+
+  it 'should return false for invalid xml string passing in logger' do
+    logger = Logger.new(STDOUT)
+    logger.level = Logger::DEBUG
+    invalid_xml_string = '<key>value</key'
+
+    expect(NetHTTP::Core.valid_xml?(invalid_xml_string, logger)).to eq(false)
+  end
+
+  it 'should return false for an invalid xml string (html) but fails strict parsing passing in logger' do
+    logger = Logger.new(STDOUT)
+    logger.level = Logger::DEBUG
+    invalid_xml_string = %(<!DOCTYPE html>
+<html>
+    <head>
+        <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
+        <title>Eel slap!</title>
+        <meta property="og:title" content="Eel slap!" />
+        <meta property="og:type" content="website" />
+        <meta property="og:url" content="http://www.eelslap.com" />
+        <meta property="og:image" content="http://www.eelslap.com/facebook.png" />
+        <meta property="og:site_name" content="Eel slap!" />
+        <meta property="fb:admins" content="543574574" />
+        <META NAME="keywords" CONTENT="eel slap, eelslap, eel slapping, eelslapping, eel, eal, eal slapping, eal slap, fish slapping, fishslapping,  slap this guy with an eel, slap a guy with an eel slap a man with an eel, slap a dude with an eel, slap a guy with eel, slap a man with eel, slap a dude with eel, slap someone with an eel, slap someone with eel, eal slap, ell slap, per hansson, per stenius, fimpen">
+        <META NAME="description" CONTENT="Ever wanted to slap someone in the face with an eel? Well, today is your lucky day.">
+        <META NAME="author" CONTENT="Per Stenius - http://www.perstenius.com">
+        <link rel="SHORTCUT ICON" href="favicon.ico"/>
+        <script type="text/javascript">
+            var _gaq = _gaq || [];
+            _gaq.push(['_setAccount', 'UA-114693-12']);
+            _gaq.push(['_trackPageview']);
+
+            (function() {
+            var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true;
+            ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js';
+            var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s);
+            })();
+        </script>
+        <link rel="stylesheet" href="css/normalize.css" type="text/css">
+        <link rel="stylesheet" type="text/css" href="css/eelslap.css"/>
+        <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.8.3/jquery.min.js"></script>
+        <script src="js/eelslap.js"></script>
+
+    </head>
+    <body>
+        <div id="eelcontainer" class="eel">
+            <div id="loader">LOADING...</div>
+            <div id="introtext">yo</div>
+            <div id="allimages">
+                <img class="eelimages" id="eelimage1" src="" width="15360" height="480">
+                <img class="eelimages" id="eelimage2" src="" width="14720" height="480">
+                <img class="eelimages" id="eelimage3" src="" width="15360" height="480">
+                <img class="eelimages" id="eelimage4" src="" width="14720" height="480">
+            </div>
+        </div>
+        <div class="footer">
+            <a href="https://twitter.com/share" class="twitter-share-button" data-url="http://www.eelslap.com" data-count="vertical">Tweet</a>
+            <script type="text/javascript" src="http://platform.twitter.com/widgets.js">
+            </script>
+            <iframe src="http://www.facebook.com/plugins/like.php?href=http%3A%2F%2Fwww.eelslap.com&amp;send=false&amp;layout=box_count&amp;width=55&amp;show_faces=false&amp;action=like&amp;colorscheme=light&amp;font&amp;height=62" scrolling="no" frameborder="0" style="border:none; overflow:hidden; width:55px; height:62px;">
+            </iframe><br>
+
+            <a href="http://actnormal.co" target="_blank">made by</a>
+        </div>
+    </body>
+</html>)
+
+    expect(NetHTTP::Core.valid_xml?(invalid_xml_string, logger)).to eq(false)
+  end
+
+  # NetHTTP::Core.valid_html?(string)
+  it 'should return true for valid html string' do
+    valid_html_string = '<!DOCTYPE html>
+<html>
+<body>
+<h1>Heading</h1>
+<p>Paragraph.</p>
+</body>
+</html>'
+
+    expect(NetHTTP::Core.valid_html?(valid_html_string)).to eq(true)
+  end
+
+  it 'should return true for an invalid html string passing in logger' do
+    logger = Logger.new(STDOUT)
+    logger.level = Logger::DEBUG
+    valid_html_string = '<!DOCTYPE html>
+<html>
+<body>
+<h1>Heading</h1>
+<p>Paragraph.</p>
+</body>
+</html>'
+
+    expect(NetHTTP::Core.valid_html?(valid_html_string, logger)).to eq(true)
+  end
+
+  it 'should return true for a valid html string which contains javascript but fails strict parsing' do
+    html_string = %(<!DOCTYPE html>
+<html>
+    <head>
+        <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
+        <title>Eel slap!</title>
+        <meta property="og:title" content="Eel slap!" />
+        <meta property="og:type" content="website" />
+        <meta property="og:url" content="http://www.eelslap.com" />
+        <meta property="og:image" content="http://www.eelslap.com/facebook.png" />
+        <meta property="og:site_name" content="Eel slap!" />
+        <meta property="fb:admins" content="543574574" />
+        <META NAME="keywords" CONTENT="eel slap, eelslap, eel slapping, eelslapping, eel, eal, eal slapping, eal slap, fish slapping, fishslapping,  slap this guy with an eel, slap a guy with an eel slap a man with an eel, slap a dude with an eel, slap a guy with eel, slap a man with eel, slap a dude with eel, slap someone with an eel, slap someone with eel, eal slap, ell slap, per hansson, per stenius, fimpen">
+        <META NAME="description" CONTENT="Ever wanted to slap someone in the face with an eel? Well, today is your lucky day.">
+        <META NAME="author" CONTENT="Per Stenius - http://www.perstenius.com">
+        <link rel="SHORTCUT ICON" href="favicon.ico"/>
+        <script type="text/javascript">
+            var _gaq = _gaq || [];
+            _gaq.push(['_setAccount', 'UA-114693-12']);
+            _gaq.push(['_trackPageview']);
+
+            (function() {
+            var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true;
+            ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js';
+            var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s);
+            })();
+        </script>
+        <link rel="stylesheet" href="css/normalize.css" type="text/css">
+        <link rel="stylesheet" type="text/css" href="css/eelslap.css"/>
+        <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.8.3/jquery.min.js"></script>
+        <script src="js/eelslap.js"></script>
+
+    </head>
+    <body>
+        <div id="eelcontainer" class="eel">
+            <div id="loader">LOADING...</div>
+            <div id="introtext">yo</div>
+            <div id="allimages">
+                <img class="eelimages" id="eelimage1" src="" width="15360" height="480">
+                <img class="eelimages" id="eelimage2" src="" width="14720" height="480">
+                <img class="eelimages" id="eelimage3" src="" width="15360" height="480">
+                <img class="eelimages" id="eelimage4" src="" width="14720" height="480">
+            </div>
+        </div>
+        <div class="footer">
+            <a href="https://twitter.com/share" class="twitter-share-button" data-url="http://www.eelslap.com" data-count="vertical">Tweet</a>
+            <script type="text/javascript" src="http://platform.twitter.com/widgets.js">
+            </script>
+            <iframe src="http://www.facebook.com/plugins/like.php?href=http%3A%2F%2Fwww.eelslap.com&amp;send=false&amp;layout=box_count&amp;width=55&amp;show_faces=false&amp;action=like&amp;colorscheme=light&amp;font&amp;height=62" scrolling="no" frameborder="0" style="border:none; overflow:hidden; width:55px; height:62px;">
+            </iframe><br>
+
+            <a href="http://actnormal.co" target="_blank">made by</a>
+        </div>
+    </body>
+</html>)
+
+    expect(NetHTTP::Core.valid_html?(html_string)).to eq(true)
+  end
+
+  it 'should return true for a valid html string which contains javascript but fails strict parsing passing in logger' do
+    logger = Logger.new(STDOUT)
+    logger.level = Logger::DEBUG
+    html_string = %(<!DOCTYPE html>
+<html>
+    <head>
+        <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
+        <title>Eel slap!</title>
+        <meta property="og:title" content="Eel slap!" />
+        <meta property="og:type" content="website" />
+        <meta property="og:url" content="http://www.eelslap.com" />
+        <meta property="og:image" content="http://www.eelslap.com/facebook.png" />
+        <meta property="og:site_name" content="Eel slap!" />
+        <meta property="fb:admins" content="543574574" />
+        <META NAME="keywords" CONTENT="eel slap, eelslap, eel slapping, eelslapping, eel, eal, eal slapping, eal slap, fish slapping, fishslapping,  slap this guy with an eel, slap a guy with an eel slap a man with an eel, slap a dude with an eel, slap a guy with eel, slap a man with eel, slap a dude with eel, slap someone with an eel, slap someone with eel, eal slap, ell slap, per hansson, per stenius, fimpen">
+        <META NAME="description" CONTENT="Ever wanted to slap someone in the face with an eel? Well, today is your lucky day.">
+        <META NAME="author" CONTENT="Per Stenius - http://www.perstenius.com">
+        <link rel="SHORTCUT ICON" href="favicon.ico"/>
+        <script type="text/javascript">
+            var _gaq = _gaq || [];
+            _gaq.push(['_setAccount', 'UA-114693-12']);
+            _gaq.push(['_trackPageview']);
+
+            (function() {
+            var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true;
+            ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js';
+            var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s);
+            })();
+        </script>
+        <link rel="stylesheet" href="css/normalize.css" type="text/css">
+        <link rel="stylesheet" type="text/css" href="css/eelslap.css"/>
+        <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.8.3/jquery.min.js"></script>
+        <script src="js/eelslap.js"></script>
+
+    </head>
+    <body>
+        <div id="eelcontainer" class="eel">
+            <div id="loader">LOADING...</div>
+            <div id="introtext">yo</div>
+            <div id="allimages">
+                <img class="eelimages" id="eelimage1" src="" width="15360" height="480">
+                <img class="eelimages" id="eelimage2" src="" width="14720" height="480">
+                <img class="eelimages" id="eelimage3" src="" width="15360" height="480">
+                <img class="eelimages" id="eelimage4" src="" width="14720" height="480">
+            </div>
+        </div>
+        <div class="footer">
+            <a href="https://twitter.com/share" class="twitter-share-button" data-url="http://www.eelslap.com" data-count="vertical">Tweet</a>
+            <script type="text/javascript" src="http://platform.twitter.com/widgets.js">
+            </script>
+            <iframe src="http://www.facebook.com/plugins/like.php?href=http%3A%2F%2Fwww.eelslap.com&amp;send=false&amp;layout=box_count&amp;width=55&amp;show_faces=false&amp;action=like&amp;colorscheme=light&amp;font&amp;height=62" scrolling="no" frameborder="0" style="border:none; overflow:hidden; width:55px; height:62px;">
+            </iframe><br>
+
+            <a href="http://actnormal.co" target="_blank">made by</a>
+        </div>
+    </body>
+</html>)
+
+    expect(NetHTTP::Core.valid_html?(html_string, logger)).to eq(true)
+  end
+
+  it 'should return false for an invalid html string' do
+    invalid_html_string = '<!DOCTYPE html>
+                             <html>
+                               <body>
+                                 <h1>Heading</h1>
+                                 <p>Paragraph.</p>
+                               </body'
+
+    expect(NetHTTP::Core.valid_html?(invalid_html_string)).to eq(false)
+  end
+
+  it 'should return false for an invalid html string passing in logger' do
+    logger = Logger.new(STDOUT)
+    logger.level = Logger::DEBUG
+    invalid_html_string = '<!DOCTYPE html>
+                             <html>
+                               <body>
+                                 <h1>Heading</h1>
+                                 <p>Paragraph.</p>
+                               </body'
+
+    expect(NetHTTP::Core.valid_html?(invalid_html_string, logger)).to eq(false)
+  end
+
+  it 'should return false for an invalid html string' do
+    invalid_html_string = '<!DOCTYPE html>
+                             <html>
+                               <body>
+                                 <h1>Heading</h1>
+                                 <p>Paragraph.</p>
+                               </body>'
+
+    expect(NetHTTP::Core.valid_html?(invalid_html_string)).to eq(false)
+  end
+end