rb-fsevent 0.4.1 → 0.4.3

data/README.rdoc

@@ -3,9 +3,9 @@
 Very simple & usable Mac OSX FSEvents API
 
 - RubyCocoa not required!
-- Signals are working
-- Tested on MRI 1.8.6, 1.8.7 & 1.9.2
-- Tested on JRuby-head, with experimental (but sufficient) extconf/mkmf support
+- Signals are working (really)
+- Tested on MRI 1.8.7 & 1.9.2
+- Tested on JRuby 1.6.3
 
 == Install
 
@@ -247,10 +247,6 @@ The list of tested RVM targets is currently:
 
     %w[1.8.6 1.8.7 1.9.2 jruby-head]
 
-Development note: As of my last attempt to do so, jruby-head's cext support will NOT compile, as-is, using xcode 4.0.1. Simply editing the makefile to point -isysroot to '/' rather than depend on an SDK specific environment and switching the minimum OS to 10.6 was enough to get past this. Making these changes within the context of an RVM installed ruby, however, requires creating a patch and then informing rvm that it needs to apply this patch pre-build.
-
-If you have xcode4, and jruby-head has not yet been fixed to allow unmodified compilation, then it's perfectly understandable and acceptable to just remove jruby-head as a testing target. This is especially true considering that it requires an unreleased version of JRuby to begin with.
-
 == Authors
 
 - {Thibaud Guillaume-Gentil}[http://github.com/thibaudgg]

data/ext/extconf.rb

@@ -2,6 +2,8 @@
 require 'mkmf'
 create_makefile('none')
 
+# TODO: determine whether we really need to be working around instead of with mkmf
+
 if `uname -s`.chomp != 'Darwin'
   puts "Warning! Only Darwin (Mac OS X) systems are supported, nothing will be compiled"
 else
@@ -37,13 +39,15 @@ else
     -dead_strip -framework CoreServices
   }
 
-  gcc_opts = core_flags + ldflags
+  cc_opts = core_flags + ldflags
 
-  gcc_opts += %w{
+  cc_opts += %w{
     -D DEBUG=true
   } if ENV['FWDEBUG'] == "true"
+  
+  cc_bin = `which clang || which gcc`.to_s.strip!
 
-  compile_command = "CFLAGS='#{cflags.join(' ')} #{wflags.join(' ')}' /usr/bin/gcc #{gcc_opts.join(' ')} -o '#{gem_root}/bin/fsevent_watch' fsevent/fsevent_watch.c"
+  compile_command = "CFLAGS='#{cflags.join(' ')} #{wflags.join(' ')}' #{cc_bin} #{cc_opts.join(' ')} -o '#{gem_root}/bin/fsevent_watch' fsevent/fsevent_watch.c"
 
   STDERR.puts(compile_command)
 

data/ext/fsevent/fsevent_watch.c

@@ -167,6 +167,35 @@ static void callback(FSEventStreamRef streamRef,
 
 int main(int argc, const char *argv[])
 {
+  /*
+   * a subprocess will initially inherit the process group of its parent. the
+   * process group may have a control terminal associated with it, which would
+   * be the first tty device opened by the group leader. typically the group
+   * leader is your shell and the control terminal is your login device. a
+   * subset of signals triggered on the control terminal are sent to all members
+   * of the process group, in large part to facilitate sane and consistent
+   * cleanup (ex: control terminal was closed).
+   *
+   * so why the overly descriptive lecture style comment?
+   *   1. SIGINT and SIGQUIT are among the signals with this behavior
+   *   2. a number of applications gank the above for their own use
+   *   3. ruby's insanely useful "guard" is one of these applications
+   *   4. despite having some level of understanding of POSIX signals and a few
+   *      of the scenarios that might cause problems, i learned this one only
+   *      after reading ruby 1.9's process.c
+   *   5. if left completely undocumented, even slightly obscure bugfixes
+   *      may be removed as cruft by a future maintainer
+   *
+   * hindsight is 20/20 addition: if you're single-threaded and blocking on IO
+   * with a subprocess, then handlers for deferrable signals might not get run
+   * when you expect them to. In the case of Ruby 1.8, that means making use of
+   * IO::select, which will preserve correct signal handling behavior.
+   */
+  if (setpgid(0,0) < 0) {
+    fprintf(stderr, "Unable to set new process group.\n");
+    return 1;
+  }
+
   parse_cli_settings(argc, argv);
 
   FSEventStreamContext context = {0, NULL, NULL, NULL, NULL};

data/lib/rb-fsevent/fsevent.rb

@@ -28,7 +28,10 @@ class FSEvent
   end
 
   def run
-    while !pipe.eof?
+    @running = true
+    # please note the use of IO::select() here, as it is used specifically to
+    # preserve correct signal handling behavior in ruby 1.8.
+    while @running && IO::select([pipe], nil, nil, nil)
       if line = pipe.readline
         modified_dir_paths = line.split(":").select { |dir| dir != "\n" }
         callback.call(modified_dir_paths)
@@ -46,7 +49,7 @@ class FSEvent
     end
   rescue IOError
   ensure
-    @pipe = false
+    @pipe = @running = nil
   end
 
   if RUBY_VERSION < '1.9'

data/lib/rb-fsevent/version.rb

@@ -1,3 +1,3 @@
 class FSEvent
-  VERSION = "0.4.1"
+  VERSION = "0.4.3"
 end

metadata

@@ -1,60 +1,82 @@
---- !ruby/object:Gem::Specification
+--- !ruby/object:Gem::Specification 
 name: rb-fsevent
-version: !ruby/object:Gem::Version
-  version: 0.4.1
+version: !ruby/object:Gem::Version 
+  hash: 9
   prerelease: 
+  segments: 
+  - 0
+  - 4
+  - 3
+  version: 0.4.3
 platform: ruby
-authors:
+authors: 
 - Thibaud Guillaume-Gentil
 - Travis Tilley
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-07-06 00:00:00.000000000 +02:00
-default_executable: 
-dependencies:
-- !ruby/object:Gem::Dependency
+
+date: 2011-08-12 00:00:00 Z
+dependencies: 
+- !ruby/object:Gem::Dependency 
   name: bundler
-  requirement: &2152430220 !ruby/object:Gem::Requirement
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
+    requirements: 
     - - ~>
-      - !ruby/object:Gem::Version
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 1
+        - 0
+        - 10
         version: 1.0.10
   type: :development
-  prerelease: false
-  version_requirements: *2152430220
-- !ruby/object:Gem::Dependency
+  version_requirements: *id001
+- !ruby/object:Gem::Dependency 
   name: rspec
-  requirement: &2152429140 !ruby/object:Gem::Requirement
+  prerelease: false
+  requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
+    requirements: 
     - - ~>
-      - !ruby/object:Gem::Version
+      - !ruby/object:Gem::Version 
+        hash: 27
+        segments: 
+        - 2
+        - 5
+        - 0
         version: 2.5.0
   type: :development
-  prerelease: false
-  version_requirements: *2152429140
-- !ruby/object:Gem::Dependency
+  version_requirements: *id002
+- !ruby/object:Gem::Dependency 
   name: guard-rspec
-  requirement: &2152427640 !ruby/object:Gem::Requirement
+  prerelease: false
+  requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
+    requirements: 
     - - ~>
-      - !ruby/object:Gem::Version
+      - !ruby/object:Gem::Version 
+        hash: 9
+        segments: 
+        - 0
+        - 1
+        - 9
         version: 0.1.9
   type: :development
-  prerelease: false
-  version_requirements: *2152427640
+  version_requirements: *id003
 description: FSEvents API with Signals catching (without RubyCocoa)
-email:
+email: 
 - thibaud@thibaud.me
 - ttilley@gmail.com
 executables: []
-extensions:
+
+extensions: 
 - ext/extconf.rb
 extra_rdoc_files: []
-files:
+
+files: 
 - lib/rb-fsevent/fsevent.rb
 - lib/rb-fsevent/version.rb
 - lib/rb-fsevent.rb
@@ -62,35 +84,38 @@ files:
 - ext/fsevent/fsevent_watch.c
 - LICENSE
 - README.rdoc
-has_rdoc: true
 homepage: http://rubygems.org/gems/rb-fsevent
 licenses: []
+
 post_install_message: 
 rdoc_options: []
-require_paths:
+
+require_paths: 
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement
+required_ruby_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
-      segments:
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
       - 0
-      hash: -3134696196885608875
-required_rubygems_version: !ruby/object:Gem::Requirement
+      version: "0"
+required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
-      segments:
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
       - 0
-      hash: -3134696196885608875
+      version: "0"
 requirements: []
+
 rubyforge_project: rb-fsevent
-rubygems_version: 1.6.2
+rubygems_version: 1.8.6
 signing_key: 
 specification_version: 3
 summary: Very simple & usable FSEvents API
 test_files: []
+