razorpay 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dc80169863413c4b51ebcd5dbc7a163a48c35a06
-  data.tar.gz: 73f38b5fafff2e2933c112a54e7d3e418f9440a1
+  metadata.gz: 0c5e4a481b2e5c76f95a1b57784911d2c597a692
+  data.tar.gz: 11d9f4211bc2a291a43ddac976d562e16410907d
 SHA512:
-  metadata.gz: 1740e3ece8cbdd0b3af137d861c8fecbeb880688df7f971d6780cd81bfac40a3341625e8f5d62dca1842f6a1a9015598c25737778fc0bd241accb0de8b4e7d52
-  data.tar.gz: 56c6cbba384b3035cc9cb08a5d1ecdf5ca09401e0af7d1335d90e1a37962f455efaa9d5fb318af7f4acab7df690e1a00f29d11ee9b8733cc5f13f7d92733c4e5
+  metadata.gz: 75d442e5f84558f8dd223410450efe0c0e59ab9581c5418c24506332cf13e3df22c1ea4fc0a0322aa39ff87129564b2ef941fca1b00ed23316a7f3d3999b02e4
+  data.tar.gz: 7dbb7b5703a9fb06f7f0b4ddc4525a0223f337aba26e2d6318de28cdb024c831ca795af4090cd4f6f0ee14b7ccd5b2f9f8ef596d345afc2ffa5681c448e98b1d

data/.rubocop.yml

@@ -6,6 +6,9 @@ Metrics/LineLength:
   Max: 110
   AllowURI: true
 
+Style/SymbolArray:
+  MinSize: 3
+
 Style/ClassVars:
   Enabled: false
 

data/CHANGELOG

@@ -4,7 +4,11 @@ Changelog for Razorpay-Ruby SDK.
 
 ## Unreleased
 
-## [2.0.0] - 2016-03-02
+## [2.0.1] - 2017-07-31
+### Fixed
+- Webhook signature verification
+
+## [2.0.0] - 2017-03-02
 ### Added
 - Adds `require` for all Razorpay supported entities
 - All entity objects now throw `NoMethodError` instead of `NameError` if the attribute doesn't exist
@@ -46,7 +50,8 @@ Changelog for Razorpay-Ruby SDK.
 ### Added
 - Initial Release
 
-[Unreleased]: https://github.com/razorpay/razorpay-ruby/compare/2.0.0...HEAD
+[Unreleased]: https://github.com/razorpay/razorpay-ruby/compare/2.0.1...HEAD
+[2.0.1]: https://github.com/razorpay/razorpay-ruby/compare/2.0.0...2.0.1
 [2.0.0]: https://github.com/razorpay/razorpay-ruby/compare/1.2.1...2.0.0
 [1.2.1]: https://github.com/razorpay/razorpay-ruby/compare/1.2.0...1.2.1
 [1.2.0]: https://github.com/razorpay/razorpay-ruby/compare/1.1.0...1.2.0

data/README.md

@@ -2,7 +2,7 @@
 
 [![Build Status](https://travis-ci.org/razorpay/razorpay-ruby.svg?branch=master)](https://travis-ci.org/razorpay/razorpay-ruby) [![Gem Version](https://badge.fury.io/rb/razorpay.svg)](http://badge.fury.io/rb/razorpay) [![Coverage Status](https://coveralls.io/repos/github/Razorpay/razorpay-ruby/badge.svg?branch=master)](https://coveralls.io/github/Razorpay/razorpay-ruby?branch=master) [![License](http://img.shields.io/:license-mit-blue.svg)](http://doge.mit-license.org)
 
-This is the base ruby gem for interacting with the Razorpay API. This is primarily meant for merchants who wish to perform interactions with the Razorpay API programatically.
+This is the base ruby gem for interacting with the Razorpay API. This is primarily meant for users who wish to perform interactions with the Razorpay API programatically.
 
 ## Installation
 
@@ -27,7 +27,7 @@ Remember to `require razorpay` before anything else.
 Next, you need to setup your key and secret using the following:
 
 ```rb
-Razorpay.setup("merchant_key_id", "merchant_key_secret")
+Razorpay.setup('key_id', 'key_secret')
 ```
 
 You can set customer headers for your requests using the following:
@@ -47,14 +47,14 @@ Razorpay::Payment.fetch("payment_id").capture({amount:500})
 # that the purchase was correctly done and not tampered
 ```
 
-You can handle refunds using the following constructs:
+You can refund a payment via the following:
 
 ```rb
 Razorpay::Payment.fetch("payment_id").refund({amount:500})
 refunds = Razorpay::Payment.fetch("payment_id").refunds
 ```
 
-Refunds can also be handled without fetching payments:
+A payment can also be refunded without fetching it:
 ```rb
 refund = Razorpay::Refund.create(payment_id:"payment_id")
 Razorpay::Refund.fetch(refund.id)
@@ -95,6 +95,10 @@ puts payment_response
 # }
 Razorpay::Utility.verify_payment_signature(payment_response)
 ```
+You can also [verify the signature](https://github.com/razorpay/razorpay-ruby/wiki/Webhooks) received in a webhook:
+```rb
+Razorpay::Utility.verify_webhook_signature(webhook_body, webhook_signature, webhook_secret)
+```
 
 ### Customers
 ```rb
@@ -110,7 +114,7 @@ card = Razorpay::Card.fetch('card_7EZLhWkDt05n7V')
 puts card.network #VISA
 ```
 
-You can find invoices API documentation at <https://docs.razorpay.com/v1/page/cards>.
+You can find cards API documentation at <https://docs.razorpay.com/v1/page/cards>.
 
 ### Invoices
 ```rb

data/lib/razorpay/constants.rb

@@ -2,5 +2,5 @@
 module Razorpay
   BASE_URI = 'https://api.razorpay.com/v1/'.freeze
   TEST_URL = 'https://api.razorpay.com/'.freeze
-  VERSION = '2.0.0'.freeze
+  VERSION = '2.0.1'.freeze
 end

data/lib/razorpay/utility.rb

@@ -10,19 +10,19 @@ module Razorpay
 
       data = [order_id, payment_id].join '|'
 
-      verify_signature(signature, data)
+      secret = Razorpay.auth[:password]
+
+      verify_signature(data, signature, secret)
     end
 
-    def self.verify_webhook_signature(signature, body)
-      verify_signature(signature, body)
+    def self.verify_webhook_signature(body, signature, secret)
+      verify_signature(body, signature, secret)
     end
 
     class << self
       private
 
-      def verify_signature(signature, data)
-        secret = Razorpay.auth[:password]
-
+      def verify_signature(data, signature, secret)
         expected_signature = OpenSSL::HMAC.hexdigest('SHA256', secret, data)
 
         verified = secure_compare(expected_signature, signature)

data/razorpay-ruby.gemspec

@@ -1,4 +1,5 @@
 # coding: utf-8
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'razorpay/constants'
@@ -6,8 +7,8 @@ require 'razorpay/constants'
 Gem::Specification.new do |spec|
   spec.name          = 'razorpay'
   spec.version       = Razorpay::VERSION
-  spec.authors       = ['Abhay Rana']
-  spec.email         = ['nemo@razorpay.com']
+  spec.authors       = ['Abhay Rana', 'Harman Singh']
+  spec.email         = ['nemo@razorpay.com', 'harman@razorpay.com']
   spec.summary       = "Razorpay's Ruby API"
   spec.description   = 'Official ruby bindings for the Razorpay API'
   spec.homepage      = 'https://razorpay.com/'
@@ -22,6 +23,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'minitest', '~> 5.10'
   spec.add_development_dependency 'webmock', '~> 2.3'
   spec.add_development_dependency 'coveralls', '~> 0.8'
-  spec.add_development_dependency 'rubocop', '~> 0.47'
+  spec.add_development_dependency 'rubocop', '~> 0.49'
   spec.add_dependency 'httparty', '~> 0.14'
 end

data/test/razorpay/test_utility.rb

@@ -23,12 +23,13 @@ module Razorpay
 
     def test_webhook_signature_verification
       webhook_body = fixture_file('fake_payment_authorized_webhook')
-      signature = 'd60e67fd884556c045e9be7dad57903e33efc7172c17c6e3ef77db42d2b366e9'
-      Razorpay::Utility.verify_webhook_signature(signature, webhook_body)
+      secret = 'chosen_webhook_secret'
+      signature = 'dda9ca344c56ccbd90167b1be0fd99dfa92fe2b827020f27e2a46024e31c7c99'
+      Razorpay::Utility.verify_webhook_signature(webhook_body, signature, secret)
 
       signature = '_dummy_signature' * 4
       assert_raises(SecurityError) do
-        Razorpay::Utility.verify_webhook_signature(signature, webhook_body)
+        Razorpay::Utility.verify_webhook_signature(webhook_body, signature, secret)
       end
     end
   end

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: razorpay
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Abhay Rana
+- Harman Singh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-02 00:00:00.000000000 Z
+date: 2017-07-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -72,14 +73,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.47'
+        version: '0.49'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.47'
+        version: '0.49'
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement
@@ -97,6 +98,7 @@ dependencies:
 description: Official ruby bindings for the Razorpay API
 email:
 - nemo@razorpay.com
+- harman@razorpay.com
 executables: []
 extensions: []
 extra_rdoc_files: []