raygun4ruby 2.7.1 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d6ec0020abc8721120597f8c22ab79c7a1167d0f
-  data.tar.gz: 52cb79e2a9759b812fe3f1b4b9210c151ce930da
+  metadata.gz: 61736f6afdee2839d8085205074cc3e36a0d1ab2
+  data.tar.gz: 91f356594710741eec38c69f2e1122eb7bfdf3e9
 SHA512:
-  metadata.gz: 9d7f73f586ae735d6c9dfc1b0bdaf17edfecef52c03b444aac7b9dec753b4b0388a997d7a58a09c2d27463e55871a59d170cd78c4467f33ee04a7712d400360a
-  data.tar.gz: 5049a108a762044416fc4bf382791b8d3cb356c609ec1f0444c173ca7401bf3f334b19cf65b3943f6292ccaf888fb887b1f14cd161303b25ca38925eb61a55c1
+  metadata.gz: 1c5a29513ec9b6603e798381c89005802a87ac470bcfdb6e77f2287523d880f4db7dc0fe6122254e8f8722aa5e54fb5f418b72702fa1b4a2cb5defc69626556b
+  data.tar.gz: b44748b701d56a4359644c679abe517ef9540049c9a8acd960babbe2614d68d27457ec2563298d625ed4485f6f2d6705ffc512bba0e6e4f36b3ed193b2cf0919

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 3.0.0 (18/12/2018):
+  Breaking changes:
+    Parameter filters are now applied if you are using the `filter_payload_with_whitelist` functionality. Previously if this was set to true the parameter filtering was bailed out of ([#136](https://github.com/MindscapeHQ/raygun4ruby/pull/136/files))
+
 ## 2.7.1 (11/06/2018)
   This is a patch release to update the required ruby version to correctly be 2.0 or greater
 

data/README.md

@@ -70,14 +70,14 @@ end
 
 begin
   # your lovely code here
-rescue Exception => e
+rescue => e
   Raygun.track_exception(e)
 end
 
 # You may also pass a user object as the third argument to allow affected user tracking, like so
 begin
   # your lovely code here
-rescue Exception => e
+rescue => e
   # The second argument is the request environment variables
   Raygun.track_exception(e, {}, user)
 end

data/lib/raygun/client.rb

@@ -253,8 +253,6 @@ module Raygun
       end
 
       def filter_params_with_blacklist(params_hash = {}, extra_filter_keys = nil)
-        return params_hash if Raygun.configuration.filter_payload_with_whitelist
-
         filter_parameters = Raygun.configuration.filter_parameters
 
         if filter_parameters.is_a? Proc

data/lib/raygun/version.rb

@@ -1,3 +1,3 @@
 module Raygun
-  VERSION = "2.7.1"
+  VERSION = "3.0.0"
 end

data/test/unit/client_test.rb

@@ -656,6 +656,44 @@ class ClientTest < Raygun::UnitTest
     assert_equal expected_hash, details[:request]
   end
 
+
+  def test_filter_payload_with_whitelist_and_filter_parameters_applies_both
+    Raygun.configuration.filter_parameters = [:password]
+    Raygun.configuration.filter_payload_with_whitelist = true
+    Raygun.configuration.whitelist_payload_shape = proc do |payload|
+      payload[:request][:headers]["Cookie"] = "[FILTERED]"
+      payload
+    end
+
+    parameters = {
+      "something_normal" => "hello",
+      "password" => "wouldntyouliketoknow"
+    }
+
+    post_body_env_hash = sample_env_hash.merge(
+      "REQUEST_METHOD" => "POST",
+      "rack.input" => StringIO.new(URI.encode_www_form(parameters))
+    )
+
+    payload = @client.send(:build_payload_hash, test_exception, post_body_env_hash)
+    request_payload = payload[:details][:request]
+
+    expected_form = {
+      "something_normal" => "hello",
+      "password" => "[FILTERED]"
+    }
+
+    assert_equal expected_form, request_payload[:form]
+
+    expected_headers = {
+      "Version" => "HTTP/1.1",
+      "Host" => "localhost:3000",
+      "Cookie" => "[FILTERED]"
+    }
+
+    assert_equal expected_headers, request_payload[:headers]
+  end
+
   def test_build_payload_hash_adds_affected_user_details_when_supplied_with_user
     user = OpenStruct.new(id: '123', email: 'test@email.com', first_name: 'Taylor')
     expected_details = {

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: raygun4ruby
 version: !ruby/object:Gem::Version
-  version: 2.7.1
+  version: 3.0.0
 platform: ruby
 authors:
 - Mindscape
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-10 00:00:00.000000000 Z
+date: 2018-12-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -282,7 +282,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: This gem provides support for Ruby and Ruby on Rails for the Raygun.io error