ravelin 0.1.6 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4b248ecddc8dd466d77736a5b37960ebd6312f30
-  data.tar.gz: 3fbde0a73dcb74135b4722c42568e9136978283b
+  metadata.gz: 9c386b1036368c92c7f077bbefccf8e42addf9b6
+  data.tar.gz: 5129f6ff9570d295569498722cc0ce7f3488588d
 SHA512:
-  metadata.gz: 80709c4159f06bd611eaa7400c538b35b1e9fda246fa5cd67b5b6e5e6b6e910513dd7953a20d833ad3eac9d811ddda3104e95fc90f5094c710ad5dd83b24a622
-  data.tar.gz: 9d838d99ec670371d6405be97abc6b846b2fb506ebbd78a81339b8f7803919931a318b091c04eabec6c29b7d88ebda8261e87037a5a017d3134f6a8403a93ec6
+  metadata.gz: dad24150d4298d44d139f696f4c9f608d968e21aef21e572e299ec73a65b87b213e29ed4eb65d768b8927de70978dfe405c7871207ffbbc38bbba5acae2eec49
+  data.tar.gz: 655c9c5577f278fa94777bc5dbc2e146fe0fb016bea995167688d82498076a1a1dc993ccf7898db50030bc5934a92dc48d081fdfd57bd8135d6ae988b4a34652

data/lib/ravelin.rb

@@ -37,6 +37,7 @@ module Ravelin
     attr_accessor :faraday_adapter, :faraday_timeout
 
     def camelize(str)
+      return '3ds' if str == :three_d_secure # hack to get around Ruby not support 3ds an attribute.
       str.to_s.gsub(/_(.)/) { |e| $1.upcase }
     end
 

data/lib/ravelin/event.rb

@@ -11,7 +11,7 @@ module Ravelin
     end
 
     def serializable_hash
-      payload_hash = hash_map(self.payload) do |k, v|
+      payload_hash = hash_map(payload) do |k, v|
         k = Ravelin.camelize(k)
 
         if v.is_a?(Ravelin::RavelinObject)
@@ -33,7 +33,7 @@ module Ravelin
         order:          Order,
         payment_method: PaymentMethod,
         voucher_redemption: VoucherRedemption,
-        transaction:    self.name == :pretransaction ? PreTransaction : Transaction,
+        transaction:    name == :pretransaction ? PreTransaction : Transaction,
         label:          Label,
         voucher:        Voucher,
       }
@@ -44,56 +44,52 @@ module Ravelin
     def validate_top_level_payload_params
       validate_customer_id_presence_on :order, :paymentmethod,
         :pretransaction, :transaction, :label
-      case self.name
-        when :customer
-          validate_payload_inclusion_of :customer
-        when :voucher
-          validate_payload_inclusion_of :voucher
-        when :'paymentmethod/voucher'
-          validate_payload_inclusion_of :'voucher_redemption'
-        when :pretransaction, :transaction
-          validate_payload_must_include_one_of(
-            :payment_method_id, :payment_method
-          )
-          validate_payload_inclusion_of :order_id
-        when :login
-          validate_payload_inclusion_of :customer_id, :temp_customer_id
-        when :checkout
-          validate_payload_inclusion_of :customer, :order,
-            :payment_method, :transaction
+      case name
+      when :customer
+        validate_payload_inclusion_of :customer
+      when :voucher
+        validate_payload_inclusion_of :voucher
+      when :'paymentmethod/voucher'
+        validate_payload_inclusion_of :'voucher_redemption'
+      when :pretransaction, :transaction
+        validate_payload_must_include_one_of(
+          :payment_method_id, :payment_method
+        )
+        validate_payload_inclusion_of :order_id
+      when :login
+        validate_payload_inclusion_of :customer_id
+      when :checkout
+        validate_payload_inclusion_of :customer, :order,
+          :payment_method, :transaction
       end
     end
 
     def validate_customer_id_presence_on(*events)
-      if events.include?(self.name) && !payload_customer_reference_present?
-        raise ArgumentError.
-          new(%q{payload missing customer_id or temp_customer_id parameter})
+      if events.include?(name) && !payload_customer_reference_present?
+        raise ArgumentError, 'payload missing customer_id or temp_customer_id parameter'
       end
     end
 
     def validate_payload_inclusion_of(*required_keys)
-      missing = required_keys - self.payload.keys
+      missing = required_keys - payload.keys
 
       if missing.any?
-        raise ArgumentError.
-          new(%Q{payload missing parameters: #{missing.join(', ')}})
+        raise ArgumentError, "payload missing parameters: #{missing.join(', ')}"
       end
     end
 
     def validate_payload_must_include_one_of(*mutually_exclusive_keys)
-      intersection = mutually_exclusive_keys & self.payload.keys
+      intersection = mutually_exclusive_keys & payload.keys
 
       if intersection.size > 1
-        raise ArgumentError
-          .new(%Q{parameters are mutally exclusive: #{mutually_exclusive_keys.join(', ')}})
-      elsif intersection.size == 0
-        raise ArgumentError
-          .new(%Q{payload must include one of: #{mutually_exclusive_keys.join(', ')}})
+        raise ArgumentError, "parameters are mutally exclusive: #{mutually_exclusive_keys.join(', ')}"
+      elsif intersection.empty?
+        raise ArgumentError, "payload must include one of: #{mutually_exclusive_keys.join(', ')}"
       end
     end
 
     def payload_customer_reference_present?
-      self.payload.keys.any? {|k| %i(customer_id temp_customer_id).include? k }
+      payload.keys.any? { |k| %i[customer_id temp_customer_id].include? k }
     end
 
     def convert_to_epoch(val)
@@ -102,7 +98,7 @@ module Ravelin
       elsif val.is_a?(Integer)
         val
       else
-        raise TypeError.new(%Q{timestamp requires a Time or epoch Integer})
+        raise TypeError, 'timestamp requires a Time or epoch Integer'
       end
     end
 

data/lib/ravelin/transaction.rb

@@ -1,27 +1,38 @@
 module Ravelin
   class Transaction < RavelinObject
     attr_accessor :transaction_id,
-      :email,
-      :currency,
-      :debit,
-      :credit,
-      :gateway,
-      :custom,
-      :success,
-      :auth_code,
-      :decline_code,
-      :gateway_reference,
-      :avs_result_code,
-      :cvv_result_code,
-      :type,
-      :time
+                  :email,
+                  :currency,
+                  :debit,
+                  :credit,
+                  :gateway,
+                  :custom,
+                  :success,
+                  :auth_code,
+                  :decline_code,
+                  :gateway_reference,
+                  :avs_result_code,
+                  :cvv_result_code,
+                  :type,
+                  :time,
+                  :three_d_secure
 
     attr_required :transaction_id,
-      :currency,
-      :debit,
-      :credit,
-      :gateway,
-      :gateway_reference,
-      :success
+                  :currency,
+                  :debit,
+                  :credit,
+                  :gateway,
+                  :gateway_reference,
+                  :success
+
+    def initialize(params)
+      three_d_secure_data = params['3ds']
+      unless three_d_secure_data.nil?
+        self.three_d_secure = three_d_secure_data
+        params.delete('3ds')
+      end
+
+      super(params)
+    end
   end
 end

data/lib/ravelin/version.rb

@@ -1,3 +1,3 @@
 module Ravelin
-  VERSION = "0.1.6"
+  VERSION = "0.1.7"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ravelin
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors:
 - Sam Levy
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-03-07 00:00:00.000000000 Z
+date: 2017-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday