rats 0.4.1 → 0.5.0

data/spec/data/meridian_spec.rb

@@ -1,84 +1,76 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require_relative '../spec_helper'
 
 describe Rats::Meridian do
-  
   it "initializes" do
     data = Rats::Meridian.new
     data.is_a?(Rats::Meridian).should be_true
   end
-  
+
   describe "boundaries" do
-    
     it "knows valid data" do
       data = Rats::Meridian.new(6)
       data.valid?.should be_true
     end
-    
+
     it "knows invalid data" do
       data = Rats::Meridian.new(3)
       data.valid?.should be_false
       data.error.should == "not allowed"
     end
-    
+
     it "raises error with invalid data" do
       data = Rats::Meridian.new
       data.raise_errors!
       lambda { data.value = 3 }.should raise_error(ArgumentError)
     end
-    
   end
-  
+
   describe "read/write" do
-    
     it "returns a padded value" do
       data = Rats::Meridian.new('4')
       data.to_p.should == '4'
     end
-    
+
     it "returns the integer" do
       data = Rats::Meridian.new('4')
       data.v.should == 4
     end
-    
+
     it "returns a string" do
       data = Rats::Meridian.new('4')
       data.to_s.should == 'W4'
     end
-    
+
     it "writes just the integer" do
       data = Rats::Meridian.new('W4')
       data.v.should == 4
     end
-    
+
     it "writes the fullname" do
       data = Rats::Meridian.new('W4')
       data.fullname.should == 'West of the Fourth Meridian'
     end
-    
+
     describe "transforming" do
-      
       it "accepts integers" do
         Rats::Meridian.transform(4).should == 4
       end
-      
+
       it "accepts strings" do
         Rats::Meridian.transform('4').should == 4
       end
-      
+
       it "accepts string prepended W" do
         Rats::Meridian.transform('W4').should == 4
       end
-      
+
       it "accepts string prepended w" do
         Rats::Meridian.transform('w4').should == 4
       end
-      
+
       it "doesn't accept other data" do
         Rats::Meridian.transform('E4').should be_nil
       end
-      
     end
-    
   end
-  
-end
+end

data/spec/data/quarter_spec.rb

@@ -1,43 +1,39 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require_relative '../spec_helper'
 
 describe Rats::Quarter do
-  
   it "initializes" do
     data = Rats::Quarter.new
     data.is_a?(Rats::Quarter).should be_true
   end
-  
+
   it "returns the full_name" do
     data = Rats::Quarter.new('NE')
     data.fullname.should == "the Northeast Quarter"
   end
-  
+
   it "detects half" do
     Rats::Quarter.half?('NE').should be_false
     Rats::Quarter.half?('N').should be_true
     Rats::Quarter.half?('North').should be_true
   end
-  
+
   it "transform input" do
     Rats::Quarter.transform('ne').should == 'NE'
     Rats::Quarter.transform('north').should == 'N'
     Rats::Quarter.transform('n').should == 'N'
   end
-  
+
   describe "boundaries" do
-    
     it "knows valid data" do
       data = Rats::Quarter.new('NE')
       data.valid?.should be_true
       data.error.should be_nil
     end
-    
+
     it "knows invalid data" do
       data = Rats::Quarter.new('bad')
       data.valid?.should be_false
       data.error.should == "not allowed"
     end
-    
   end
-  
-end
+end

data/spec/data/range_spec.rb

@@ -1,66 +1,58 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require_relative '../spec_helper'
 
 describe Rats::Range do
-  
   it "initializes" do
     data = Rats::Range.new
     data.is_a?(Rats::Range).should be_true
   end
-  
+
   describe "boundaries" do
-    
     it "knows valid data" do
       data = Rats::Range.new(6)
       data.valid?.should be_true
       data.error.should be_nil
     end
-    
+
     it "knows invalid data" do
       data = Rats::Range.new(31)
       data.valid?.should be_false
       data.error.should == "not allowed"
     end
-    
   end
-  
+
   describe "read/write" do
-    
     it "returns a padded value" do
       data = Rats::Range.new('4')
       data.to_p.should == '04'
     end
-    
+
     it "returns the integer" do
       data = Rats::Range.new('4')
       data.v.should == 4
     end
-    
+
     it "returns a string" do
       data = Rats::Range.new('4')
       data.to_s.should == '4'
     end
-    
+
     it "writes the fullname" do
       data = Rats::Range.new('4')
       data.fullname.should == 'Range 4'
     end
-    
+
     describe "transforming" do
-      
       it "accepts integers" do
         Rats::Range.transform(4).should == 4
       end
-      
+
       it "accepts strings" do
         Rats::Range.transform('4').should == 4
       end
-      
+
       it "doesn't accept other data" do
         Rats::Range.transform('E4').should be_nil
       end
-      
     end
-    
   end
-  
-end
+end

data/spec/data/section_spec.rb

@@ -1,66 +1,58 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require_relative '../spec_helper'
 
 describe Rats::Section do
-  
   it "initializes" do
     data = Rats::Section.new
     data.is_a?(Rats::Section).should be_true
   end
-  
+
   describe "boundaries" do
-    
     it "knows valid data" do
       data = Rats::Section.new(6)
       data.valid?.should be_true
       data.error.should be_nil
     end
-    
+
     it "knows invalid data" do
       data = Rats::Section.new(37)
       data.valid?.should be_false
       data.error.should == "not allowed"
     end
-    
   end
-  
+
   describe "read/write" do
-    
     it "returns a padded value" do
       data = Rats::Section.new('4')
       data.to_p.should == '04'
     end
-    
+
     it "returns the integer" do
       data = Rats::Section.new('4')
       data.v.should == 4
     end
-    
+
     it "returns a string" do
       data = Rats::Section.new('4')
       data.to_s.should == '4'
     end
-    
+
     it "writes the fullname" do
       data = Rats::Section.new('4')
       data.fullname.should == 'Section 4'
     end
-    
+
     describe "transforming" do
-      
       it "accepts integers" do
         Rats::Section.transform(4).should == 4
       end
-      
+
       it "accepts strings" do
         Rats::Section.transform('4').should == 4
       end
-      
+
       it "doesn't accept other data" do
         Rats::Section.transform('E4').should be_nil
       end
-      
     end
-    
   end
-  
-end
+end

data/spec/data/township_spec.rb

@@ -1,66 +1,58 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require_relative '../spec_helper'
 
 describe Rats::Township do
-  
   it "initializes" do
     data = Rats::Township.new
     data.is_a?(Rats::Township).should be_true
   end
-  
+
   describe "boundaries" do
-    
     it "knows valid data" do
       data = Rats::Township.new(6)
       data.valid?.should be_true
       data.error.should be_nil
     end
-    
+
     it "knows invalid data" do
       data = Rats::Township.new(130)
       data.valid?.should be_false
       data.error.should == "not allowed"
     end
-    
   end
-  
+
   describe "read/write" do
-    
     it "returns a padded value" do
       data = Rats::Township.new('4')
       data.to_p.should == '004'
     end
-    
+
     it "returns the integer" do
       data = Rats::Township.new('4')
       data.v.should == 4
     end
-    
+
     it "returns a string" do
       data = Rats::Township.new('4')
       data.to_s.should == '4'
     end
-    
+
     it "writes the fullname" do
       data = Rats::Township.new('4')
       data.fullname.should == 'Township 4'
     end
-    
+
     describe "transforming" do
-      
       it "accepts integers" do
         Rats::Township.transform(4).should == 4
       end
-      
+
       it "accepts strings" do
         Rats::Township.transform('4').should == 4
       end
-      
+
       it "doesn't accept other data" do
         Rats::Township.transform('E4').should be_nil
       end
-      
     end
-    
   end
-  
-end
+end

data/spec/rats_spec.rb

@@ -1,51 +1,43 @@
-require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
+require 'spec_helper'
 
-describe "Rats" do
-  
+describe Rats do
   it "initializes the class" do
     land = Rats.new
     land.is_a?(Rats::Base).should be_true
   end
-  
+
   describe "attributes" do
-    
-    before(:each) do
-      @land = Rats.new
-    end
-    
+    let(:land) { Rats.new }
+
     describe "writing and reading" do
-      
       it "writes quarter" do
-        @land.quarter = "NE"
-        @land.quarter.should == "NE"
+        land.quarter = "NE"
+        land.quarter.should == "NE"
       end
-      
+
       it "writes section" do
-        @land.section = 1
-        @land.section.should == 1
+        land.section = 1
+        land.section.should == 1
       end
-      
+
       it "writes township" do
-        @land.township = 1
-        @land.township.should == 1
+        land.township = 1
+        land.township.should == 1
       end
-      
+
       it "writes range" do
-        @land.range = 1
-        @land.range.should == 1
+        land.range = 1
+        land.range.should == 1
       end
-      
+
       it "writes meridian" do
-        @land.meridian = 4
-        @land.meridian.should == 4
+        land.meridian = 4
+        land.meridian.should == 4
       end
-      
     end
-    
   end
-  
+
   describe "parsing locations" do
-    
     it "understands NE 1-2-3 W4" do
       land = Rats.new("NE 1-2-3 W4")
       land.quarter.should == "NE"
@@ -55,7 +47,7 @@ describe "Rats" do
       land.meridian.should == 4
       land.scope.should == :quarter
     end
-    
+
     it "understands NE-1-2-3-W4" do
       land = Rats.new("NE-1-2-3-W4")
       land.quarter.should == "NE"
@@ -65,7 +57,7 @@ describe "Rats" do
       land.meridian.should == 4
       land.scope.should == :quarter
     end
-    
+
     it "understands NE-1-2-3-4" do
       land = Rats.new("NE-1-2-3-4")
       land.quarter.should == "NE"
@@ -75,7 +67,7 @@ describe "Rats" do
       land.meridian.should == 4
       land.scope.should == :quarter
     end
-    
+
     it "understands NE 1-1-1-4" do
       land = Rats.new("NE 1-2-3-4")
       land.quarter.should == "NE"
@@ -85,7 +77,7 @@ describe "Rats" do
       land.meridian.should == 4
       land.scope.should == :quarter
     end
-    
+
     it "understands NE 1 2 3 4" do
       land = Rats.new("NE 1 2 3 4")
       land.quarter.should == "NE"
@@ -95,7 +87,7 @@ describe "Rats" do
       land.meridian.should == 4
       land.scope.should == :quarter
     end
-    
+
     it "understands N 1-2-3 W4" do
       land = Rats.new("N 1-2-3 W4")
       land.quarter.should == "N"
@@ -105,7 +97,7 @@ describe "Rats" do
       land.meridian.should == 4
       land.scope.should == :half
     end
-    
+
     it "understands North 1-2-3 W4" do
       land = Rats.new("North 1-2-3 W4")
       land.quarter.should == "N"
@@ -115,7 +107,7 @@ describe "Rats" do
       land.meridian.should == 4
       land.scope.should == :half
     end
-    
+
     it "understands 40300201NE" do
       land = Rats.new("40300201NE")
       land.quarter.should == "NE"
@@ -125,7 +117,7 @@ describe "Rats" do
       land.meridian.should == 4
       land.scope.should == :quarter
     end
-    
+
     it "understands 40300201" do
       land = Rats.new("40300201")
       land.quarter.should be_nil
@@ -135,7 +127,7 @@ describe "Rats" do
       land.meridian.should == 4
       land.scope.should == :section
     end
-    
+
     it "understands 1-2-3 W4" do
       land = Rats.new("1-2-3 W4")
       land.quarter.should be_nil
@@ -145,7 +137,7 @@ describe "Rats" do
       land.meridian.should == 4
       land.scope.should == :section
     end
-    
+
     it "understands 2-3 W4" do
       land = Rats.new("2-3 W4")
       land.quarter.should be_nil
@@ -155,7 +147,7 @@ describe "Rats" do
       land.meridian.should == 4
       land.scope.should == :township
     end
-    
+
     it "understands 3 W4" do
       land = Rats.new("3 W4")
       land.quarter.should be_nil
@@ -165,7 +157,7 @@ describe "Rats" do
       land.meridian.should == 4
       land.scope.should == :unknown
     end
-    
+
     it "understands W4" do
       land = Rats.new("W4")
       land.quarter.should be_nil
@@ -175,7 +167,7 @@ describe "Rats" do
       land.meridian.should == 4
       land.scope.should == :unknown
     end
-    
+
     it "understands individual values" do
       land = Rats.new(4, 3, 2, 1, "NE")
       land.quarter.should == "NE"
@@ -185,7 +177,7 @@ describe "Rats" do
       land.meridian.should == 4
       land.scope.should == :quarter
     end
-    
+
     it "understands SE 1-119-24 W4" do
       land = Rats.new("SE 1-119-24 W4")
       land.quarter.should == "SE"
@@ -195,9 +187,9 @@ describe "Rats" do
       land.meridian.should == 4
       land.scope.should == :quarter
     end
-    
+
     describe "alternate method" do
-    
+
       it "using location and a string" do
         land = Rats.new
         land.location = "NE 1-2-3 W4"
@@ -217,46 +209,36 @@ describe "Rats" do
         land.range.should == 3
         land.meridian.should == 4
       end
-      
     end
-    
   end
-  
+
   describe "validation (does it exist)" do
-    
-    # each individual field has already been tested to know what is a valid field
-    # here, I am testing the location as a whole, as a location can be valid
-    # in respect to its individual components, but not as a whole
-    
     it "knows a valid and existing location" do
       land = Rats.new("SE 1-2-3 W4")
       land.location.should == "SE 1-2-3 W4"
       land.exists?.should be_true
     end
-    
+
     it "knows an non-existing section (in a valid township)" do
       land = Rats.new("SE 2-119-24 W4")
       land.exists?.should be_false
-      
-      # but it neightbour does
+
       land = Rats.new("SE 1-119-24 W4")
       land.exists?.should be_true
     end
-    
+
     it "knows an non-existing township (in a valid range)" do
       land = Rats.new("SE 1-19-30 W4")
       land.exists?.should be_false
     end
-    
+
     it "knows an non-existing range (in a valid township)" do
       land = Rats.new("SE 1-20-30 W4")
       land.exists?.should be_false
     end
-    
   end
-  
+
   describe "boundaries" do
-                    
     it "knows when a township is North of Alberta" do
       land = Rats.new("SE 1-127-1 W4")
       land.valid?.should be_false
@@ -264,7 +246,7 @@ describe "Rats" do
       land.errors.has_key?(:township).should be_true
       land.errors[:township].first.should == 'not allowed'
     end
-    
+
     it "knows when a township is East of Alberta" do
       land = Rats.new("SE 1-1-1 W3")
       land.valid?.should be_false
@@ -272,7 +254,7 @@ describe "Rats" do
       land.errors.has_key?(:meridian).should be_true
       land.errors[:meridian].first.should == 'not allowed'
     end
-    
+
     it "knows when a township is West of Alberta" do
       land = Rats.new("SE 1-1-1 W7")
       land.valid?.should be_false
@@ -280,7 +262,7 @@ describe "Rats" do
       land.errors.has_key?(:meridian).should be_true
       land.errors[:meridian].first.should == 'not allowed'
     end
-    
+
     it "knows when a township has been squeezed out" do
       land = Rats.new("SE 1-126-25 W4")
       land.valid?.should be_false
@@ -288,7 +270,7 @@ describe "Rats" do
       land.errors.has_key?(:land).should be_true
       land.errors[:land].first.should == 'does not exist'
     end
-    
+
     it "knows when a section has been squeezed out" do
       land = Rats.new("SE 6-119-24 W4")
       land.valid?.should be_false
@@ -296,40 +278,32 @@ describe "Rats" do
       land.errors.has_key?(:land).should be_true
       land.errors[:land].first.should == 'does not exist'
     end
-    
-    # it "knows when a quarter has been squeezed out" do
-    # end
-    
   end
-  
+
   describe "formatting" do
-    
     describe ":default" do
-    
       it "returns NE 1-2-3 W4" do
         land = Rats.new("NE 1-2-3 W4")
         land.location.should == "NE 1-2-3 W4"
       end
-    
+
       it "returns 1-2-3 W4" do
         land = Rats.new("1-2-3 W4")
         land.location.should == "1-2-3 W4"
       end
-    
+
       it "returns 2-3 W4" do
         land = Rats.new("2-3 W4")
         land.location.should == "2-3 W4"
       end
-      
     end
-    
+
     describe ":short" do
-    
       it "returns NE01002034" do
         land = Rats.new("NE 1-2-3 W4")
         land.location(:short).should == "40300201NE"
       end
-      
+
       it "returns 01001014" do
         land = Rats.new("1-2-3 W4")
         land.location(:short).should == "40300201"
@@ -339,122 +313,107 @@ describe "Rats" do
         land = Rats.new("2-3 W4")
         land.location(:short).should == "403002"
       end
-
     end
-    
+
     describe ":padded" do
-    
       it "returns NE 01-002-03 W4" do
         land = Rats.new("NE 1-2-3 W4")
         land.location(:padded).should == "NE 01-002-03 W4"
       end
-    
+
       it "returns 01-002-03 W4" do
         land = Rats.new("1-2-3 W4")
         land.location(:padded).should == "01-002-03 W4"
       end
-    
+
       it "returns 002-03 W4" do
         land = Rats.new("2-3 W4")
         land.location(:padded).should == "002-03 W4"
       end
-      
     end
-    
+
     describe ":long" do
-          
       it "returns the long version with Quarter" do
         land = Rats.new("NE 1-2-3 W4")
         land.location(:long).should == "the Northeast Quarter of Section 1, Township 2, Range 3, West of the Fourth Meridian"
       end
-      
+
       it "returns the long version with Half" do
         land = Rats.new("N 1-2-3 W4")
         land.location(:long).should == "the North Half of Section 1, Township 2, Range 3, West of the Fourth Meridian"
       end
-      
+
       it "returns the long version with Section" do
         land = Rats.new("1-2-3 W4")
-        #puts land.inspect
         land.location(:long).should == "Section 1, Township 2, Range 3, West of the Fourth Meridian"
       end
-      
+
       it "returns the long version with Township" do
         land = Rats.new("2-3 W4")
-        #puts land.inspect
         land.location(:long).should == "Township 2, Range 3, West of the Fourth Meridian"
       end
-      
     end
-    
   end
-  
+
   describe "scope" do
-    
     it "knows quarter" do
       land = Rats.new("NE 1-2-3 W4")
       land.scope.should == :quarter
     end
-    
+
     it "knows half" do
       land = Rats.new("E 1-2-3 W4")
       land.scope.should == :half
     end
-    
+
     it "knows half" do
       land = Rats.new("East 1-2-3 W4")
       land.scope.should == :half
     end
-    
+
     it "knows section" do
       land = Rats.new("1-2-3 W4")
       land.scope.should == :section
     end
-    
+
     it "knows township" do
       land = Rats.new("2-3 W4")
       land.scope.should == :township
     end
-    
+
     it "anything else is unknown" do
       land = Rats.new("3 W4")
       land.scope.should == :unknown
     end
-    
   end
-  
+
   describe "methods" do
-    
     describe "validity" do
-      
       it "knows when it is valid" do
         land = Rats.new("NE 1-2-3 W4")
         land.valid?.should be_true
       end
-      
+
       it "knows when it isn't valid"do
         land = Rats.new("3 W4")
-        #puts land.inspect
         land.valid?.should be_false
       end
-      
     end
-    
+
     it "responds_to :to_s" do
       land = Rats.new("NE 1-2-3 W4")
       land.to_s.should == land.location
     end
-    
+
     it "responds_to :to_a" do
       land = Rats.new("NE 1-2-3 W4")
       land.to_a.should == ['NE', 1, 2, 3, 4]
-      
+
       land = Rats.new("1-2-3 W4")
       land.to_a.should == [1, 2, 3, 4]
     end
-    
+
     describe "expansion" do
-      
       it "is divisible" do
         Rats.new("N 1-2-3 W4").is_divisible?.should be_true
         Rats.new("NSE 1-2-3 W4").is_divisible?.should be_true
@@ -462,20 +421,20 @@ describe "Rats" do
         Rats.new("1-2-3 W4").is_divisible?.should be_true
         Rats.new("2-3 W4").is_divisible?.should be_true
       end
-      
+
       it "is not divisible" do
         Rats.new("NE 1-2-3 W4").is_divisible?.should be_false
         Rats.new("3 W4").is_divisible?.should be_false
         Rats.new("W4").is_divisible?.should be_false
       end
-      
+
       describe "half -> 2 quarters" do
         quarters = Rats.new("N 1-2-3 W4").divide
         quarters.size.should == 2
         quarters.first.quarter.should == 'NE'
         quarters.last.quarter.should == 'NW'
       end
-      
+
       describe "3/4 -> 3 quarters" do
         quarters = Rats.new("NSE 1-2-3 W4").divide
         quarters.size.should == 3
@@ -483,7 +442,7 @@ describe "Rats" do
         quarters[1].quarter.should == 'NW'
         quarters[2].quarter.should == 'SE'
       end
-      
+
       describe "section -> 4 quarters" do
         quarters = Rats.new("1-2-3 W4").divide
         quarters.size.should == 4
@@ -492,7 +451,7 @@ describe "Rats" do
         quarters[2].quarter.should == 'SE'
         quarters[3].quarter.should == 'SW'
       end
-      
+
       describe "ALL -> 4 quarters" do
         quarters = Rats.new("ALL 1-2-3 W4").divide
         quarters.size.should == 4
@@ -501,14 +460,11 @@ describe "Rats" do
         quarters[2].quarter.should == 'SE'
         quarters[3].quarter.should == 'SW'
       end
-      
+
       describe "township -> 144 quarters" do
         quarters = Rats.new("2-3 W4").divide
         quarters.size.should == 144
       end
-      
     end
-                    
   end
-  
 end