ratonvirus 0.4.3 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 54fcf1a6676b0edbd60fc04c6e0790b538fa795d9ec78e2e99e33292f09ba2d5
-  data.tar.gz: e840f5043ce9a27115f69e205bb848fa4266cfae74ecf6d9dafa7173fadb51b6
+  metadata.gz: 5837213cdad0ffd1363940af339c4476926dc87546c6fc5c1fefdac457e747a6
+  data.tar.gz: 1bc2caa99dec67aca116bf8f650f2750483f5dd111111f5a074950ba12e2b4db
 SHA512:
-  metadata.gz: 6df74f6e28b507d9ae253ba09b684fa59c777542f6fc40539d543960105f867ee73528265e59b43e869c0301492401ae84f2f001b78fcce1be08923d14e5979d
-  data.tar.gz: 4f783c558fecd0b8e7b62c6e78867305197f23c5dd0a7a368ceef7fbcd0806dca854e8c7af327848e57ad245be73b54a8da0a398f3d3e794ff3668edacd5d03f
+  metadata.gz: d5844998f549d6e9b2a2d2e3260f737508977a66bbeb2526fa44135e262e839c3a99c904ea46bf2e52859d58892553f6656c362f57736e38d36a91ac3f6af364
+  data.tar.gz: 53c0c90eb8af893aa5e0bd0c5b002b25a0ec081338d36d4225cd29adf5a08ae8d13ae7d33f23e4a507894b2f8a78d40eadc29f38341d78966a9717f912fa1dac

data/CHANGELOG.md

@@ -1,3 +1,31 @@
+# v0.6.0
+
+Support for Rails 8
+
+Changed:
+
+- ActiveSupport dependency updated to `8.x` in order to support Rails 8
+- The minimum Ruby version is now set to 3.2 as it is a requirement of Rails 8
+- The development dependencies are removed from the `.gemspec` and moved to the local `Gemfile` within the development repository
+- Handling `ActiveStorage::Attached::Changes::CreateMany` now fetches the new uploads through `change.pending_uploads` instead of `change.subchanges` in order to get access to the newly uploaded file objects [#41](https://github.com/mainio/ratonvirus/pull/41)
+
+# v0.5.0
+
+Changed:
+
+- Scanning is now skipped for blobs that have a related attachment that has been persisted in order to avoid scanning the same file multiple times. We assume that the file needs to be scanned only once during the first time it is being attached to a record because otherwise it would be re-scanned every time when the attached record is updated (in which case the file would not be changed, as if the file is changed, also the attached blob is changed).
+
+Fixed:
+
+- Skip antivirus scan for persisted blobs [#39](https://github.com/mainio/ratonvirus/pull/39)
+- XAmzContentSHA256Mismatch when using active storage with s3 backend [#36](https://github.com/mainio/ratonvirus/issues/36)
+
+# v0.4.3
+
+Fixed:
+
+- Manual scan is not working for File objects [#32](https://github.com/mainio/ratonvirus/pull/32)
+
 # v0.4.2
 
 Fixed:

data/README.md

@@ -250,6 +250,26 @@ For installing ClamAV, refer to
 For further information about the configurations and how to create custom
 scanners, please refer to the [documentation](docs/index.md).
 
+## Common issues
+
+### NoMethodError (undefined method `attached?' ...)
+
+Multiple issues have been opened because of users getting the following error
+when trying to run a scan against a file path:
+
+```
+NoMethodError (undefined method `attached?' for "/path/to/file.pdf":String)
+```
+
+Most of the times this issue is because you have not configured the storage
+correctly. If you want to run direct scans against files, please use the
+`:filepath` storage option as described at
+[Manually checking for viruses](#manually-checking-for-viruses).
+
+If you need both: scans against file paths and scans against Active Storage
+attached files, please use the `:multi` storage option as described in the same
+section of the documentation.
+
 ## License
 
 MIT, see [LICENSE](LICENSE).

data/lib/ratonvirus/processable.rb

@@ -7,10 +7,10 @@ module Ratonvirus
       @asset = asset
     end
 
-    def path(&block)
+    def path(&)
       return unless block_given?
 
-      @storage.asset_path(@asset, &block)
+      @storage.asset_path(@asset, &)
     end
 
     def remove

data/lib/ratonvirus/scanner/support/callbacks.rb

@@ -47,13 +47,13 @@ module Ratonvirus
       module Callbacks
         private
 
-        def run_callbacks(type, *args, &_block)
+        def run_callbacks(type, *, &)
           raise NotDefinedError, "No callbacks defined" if @_callbacks.nil?
           raise NotDefinedError, "Callbacks for #{type} not defined" if @_callbacks[type].nil?
 
-          run_callback_callables @_callbacks[type][:before], *args
-          result = yield(*args)
-          run_callback_callables @_callbacks[type][:after], *args
+          run_callback_callables(@_callbacks[type][:before], *)
+          result = yield(*)
+          run_callback_callables(@_callbacks[type][:after], *)
 
           result
         end

data/lib/ratonvirus/storage/active_storage.rb

@@ -15,7 +15,7 @@ module Ratonvirus
           resource.is_a?(::ActiveStorage::Attached::Many)
       end
 
-      def process(resource, &block)
+      def process(resource, &)
         return unless block_given?
         return if resource.nil?
         return unless resource.attached?
@@ -24,13 +24,13 @@ module Ratonvirus
 
         case change
         when ::ActiveStorage::Attached::Changes::CreateOne
-          handle_create_one(change, &block)
+          handle_create_one(change, &)
         when ::ActiveStorage::Attached::Changes::CreateMany
-          handle_create_many(change, &block)
+          handle_create_many(change, &)
         end
       end
 
-      def asset_path(asset, &block)
+      def asset_path(asset, &)
         return unless block_given?
         return unless asset.is_a?(Array)
 
@@ -40,10 +40,10 @@ module Ratonvirus
           # These files should be already locally stored but their permissions
           # can prevent the virus scanner executable from accessing them.
           # Therefore, a temporary file is created for them as well.
-          io_path(asset[1], ext, &block)
+          io_path(asset[1], ext, &)
         when Hash
           io = asset[1].fetch(:io)
-          io_path(io, ext, &block) if io
+          io_path(io, ext, &) if io
         when ::ActiveStorage::Blob
           asset[1].open do |tempfile|
             prepare_for_scanner tempfile.path
@@ -82,20 +82,20 @@ module Ratonvirus
 
       private
 
-      def handle_create_one(change, &block)
-        yield_processable_from(change, &block)
+      def handle_create_one(change, &)
+        yield_processable_from(change, &)
       end
 
       def handle_create_many(change, &block)
-        change.send(:subchanges).each do |subchange|
+        change.pending_uploads.each do |subchange|
           yield_processable_from(subchange, &block)
         end
       end
 
-      def yield_processable_from(change, &_block)
+      def yield_processable_from(change, &)
         attachable = change.attachable
         return unless attachable
-        return if attachable.is_a?(::ActiveStorage::Blob)
+        return if attachable.is_a?(::ActiveStorage::Blob) && change.attachment.persisted?
 
         # If the attachable is a string, it is a reference to an already
         # existing blob. This can happen e.g. when the file blob is uploaded

data/lib/ratonvirus/storage/carrierwave.rb

@@ -11,13 +11,13 @@ module Ratonvirus
 
       def accept?(resource)
         if resource.is_a?(Array)
-          resource.all? { |subr| subr.is_a?(::CarrierWave::Uploader::Base) }
+          resource.all?(::CarrierWave::Uploader::Base)
         else
           resource.is_a?(::CarrierWave::Uploader::Base)
         end
       end
 
-      def asset_path(asset, &block)
+      def asset_path(asset, &)
         return unless block_given?
         return if asset.nil?
         return if asset.file.nil?
@@ -32,7 +32,7 @@ module Ratonvirus
         # scan on.
         io = StringIO.new(asset.file.read)
         ext = File.extname(asset.file.path)
-        io_path(io, ext, &block)
+        io_path(io, ext, &)
       end
 
       def asset_remove(asset)

data/lib/ratonvirus/storage/filepath.rb

@@ -20,7 +20,7 @@ module Ratonvirus
         end
       end
 
-      def asset_path(asset, &block)
+      def asset_path(asset, &)
         return unless block_given?
 
         return unless asset
@@ -29,7 +29,7 @@ module Ratonvirus
         if asset.respond_to?(:path)
           # A file asset that responds to path (e.g. default `File`
           # object).
-          asset_path(asset.path, &block)
+          asset_path(asset.path, &)
 
           return
         end

data/lib/ratonvirus/storage/support/io_handling.rb

@@ -23,8 +23,13 @@ module Ratonvirus
           begin
             tempfile.binmode
             if io.is_a?(StringIO)
+              orig_pos = io.pos
+              io.rewind
+
               # cannot specify src_offset for non-IO
               IO.copy_stream(io, tempfile)
+
+              io.pos = orig_pos
             else
               IO.copy_stream(io, tempfile, nil, 0)
             end

data/lib/ratonvirus/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ratonvirus
-  VERSION = "0.4.3"
+  VERSION = "0.6.0"
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ratonvirus
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.6.0
 platform: ruby
 authors:
 - Antti Hukkanen
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-10-18 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -16,140 +15,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '7.0'
+        version: '8.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '7.0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: rspec-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.0'
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.18.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.18.0
-- !ruby/object:Gem::Dependency
-  name: activemodel
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '7.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '7.0'
-- !ruby/object:Gem::Dependency
-  name: activestorage
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '7.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '7.0'
-- !ruby/object:Gem::Dependency
-  name: carrierwave
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.1'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.1'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.11.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.11.0
-- !ruby/object:Gem::Dependency
-  name: rubocop-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 2.2.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 2.2.0
+        version: '8.0'
 description: Adds antivirus check capability for Rails applications.
 email:
 - antti.hukkanen@mainiotech.fi
@@ -184,8 +57,8 @@ files:
 homepage: https://github.com/mainio/ratonvirus
 licenses:
 - MIT
-metadata: {}
-post_install_message: 
+metadata:
+  rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths:
 - lib
@@ -193,15 +66,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.7'
+      version: '3.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Provides antivirus checks for Rails.
 test_files: []