ratonvirus-clamby 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2ab97421ef8f1bcf87fc7465487f76f65d703b9e31ffc7fa156846863887ff90
-  data.tar.gz: d917af42da7b4602fb6e674e863c8ee16ba454457cc7d500396f16c35b1b1eaa
+  metadata.gz: bbbf31447a05facfeb03d9c2549eff8a7213217dcf94e69efd3c7803dff9c99c
+  data.tar.gz: 42526d14c2b6abfbc698d727ae0e5bbc6eab286f46407c1d36b67dcac0ab7809
 SHA512:
-  metadata.gz: 308ed44513124fd828b795f4bee414ead467a4ff8ae3c086d15b2a02a39a6dcf3fd9ccd7ce180a90e1278f06fdb11eecc923e34bd5a0704f840da11531f16a00
-  data.tar.gz: 6d551e25b9247bc0c72e11a5dce518e6920c8ddc27c6b5d149d3646751b687e32dcb7b4bc2c4759cafc61edee31fe5b088c5c3e6e1b11b03ad2451d6cdd138ea
+  metadata.gz: d60272c1828bf8e95ab5a604ef4b044bdf3d99f43d79091e68419957fd8d5861549e78f9c74b8b7259e473109ba662be93d67a2487fe4a6a57819ce857b53b14
+  data.tar.gz: 8ce13e2af541516995c31b567ff0ffa34f1b1c1d1113a5aadfc18c1f6b4730149f80e52ac62040d84e7bfe8ee09f9eca31ebdab4b5e6cee11bae3b208c01ad9f

data/CHANGELOG.md

@@ -0,0 +1,3 @@
+# v0.1.0
+
+Initial public release.

data/README.md

@@ -123,18 +123,19 @@ the application folder or the folder where the users are uploading the files in
 order to ensure that ClamAV daemon is able to access that folder and read files
 from it.
 
-Also note that Decidim uses
-[CarrierWave](https://github.com/carrierwaveuploader/carrierwave) to handle its
-file uploads and processing on the server, so make sure you are also testing the
-possible temporary paths of CarrierWave.
+Also note that applications using
+[CarrierWave](https://github.com/carrierwaveuploader/carrierwave) or other file
+upload management system may store temporary files in specific configured
+temporary paths (e.g. `tmp/storage`). Make sure you are also testing that the
+files are scannable in all possible temporary paths.
 
 ## Installation
 
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'ratonvirus'
-gem 'ratonvirus-clamby'
+gem "ratonvirus"
+gem "ratonvirus-clamby"
 ```
 
 Then execute:
@@ -177,8 +178,6 @@ Shown when the `clamdscan` executable returns with the exit code other than 0 or
 
 ### antivirus_client_error ("could not be processed for virus scan")
 
-This means that the given file contains a virus detected by ClamAV.
-
 In this case the `clamdscan` executable did not finish its work successfully and
 an error was produced. This can be generally caused by the `clamav-daemon`
 service because of few different reasons:

data/lib/ratonvirus/clamby.rb

@@ -1,7 +1,9 @@
-require 'clamby'
+# frozen_string_literal: true
 
-require_relative 'clamby/version'
-require_relative 'scanner/clamby'
+require "clamby"
+
+require_relative "clamby/version"
+require_relative "scanner/clamby"
 
 module Ratonvirus
   module Clamby

data/lib/ratonvirus/clamby/version.rb

@@ -2,6 +2,6 @@
 
 module Ratonvirus
   module Clamby
-    VERSION = "0.1.0"
+    VERSION = "0.2.0"
   end
 end

data/lib/ratonvirus/scanner/clamby.rb

@@ -16,11 +16,11 @@ module Ratonvirus
         # We want Ratonvirus to report issues on file missing errors.
         error_file_missing: true,
         # No output is required not to fill the logs. The scanning errors
-        output_level: 'off',
+        output_level: "off"
       ).freeze
 
       class << self
-        def configure(config={})
+        def configure(config = {})
           ::Clamby.configure(config)
         end
 
@@ -44,32 +44,33 @@ module Ratonvirus
       end
 
       protected
-        def run_scan(path)
-          # In case the file is not present at all, scanning should always pass
-          # because nil is not a virus.
-          return if path.nil?
 
-          begin
-            errors << :antivirus_virus_detected if ::Clamby.virus?(path)
-          rescue ::Clamby::ClamscanClientError
-            # This can happen e.g. if the clamdscan utility does not have access
-            # to read the file path. For debugging, try to run the clamdscan
-            # utility manually for the same file:
-            # clamdscan /path/to/file.pdf
-            #
-            # Also, make sure that the file uploads store directory is readable
-            # by the clamdscan utility. E.g. /path/to/app/public/uploads/tmp.
-            #
-            # Another possible reason is that in case there are too many
-            # concurrent virus checks ongoing, it may also trigger this error.
-            errors << :antivirus_client_error
-          rescue ::Clamby::FileNotFound
-            # This should be pretty rare since the scanner should not be even
-            # called when the file is not available. As the storage backend may
-            # be configured, this may still happen with some storage backends.
-            errors << :antivirus_file_not_found
-          end
+      def run_scan(path)
+        # In case the file is not present at all, scanning should always pass
+        # because nil is not a virus.
+        return if path.nil?
+
+        begin
+          errors << :antivirus_virus_detected if ::Clamby.virus?(path)
+        rescue ::Clamby::ClamscanClientError
+          # This can happen e.g. if the clamdscan utility does not have access
+          # to read the file path. For debugging, try to run the clamdscan
+          # utility manually for the same file:
+          # clamdscan /path/to/file.pdf
+          #
+          # Also, make sure that the file uploads store directory is readable
+          # by the clamdscan utility. E.g. /path/to/app/public/uploads/tmp.
+          #
+          # Another possible reason is that in case there are too many
+          # concurrent virus checks ongoing, it may also trigger this error.
+          errors << :antivirus_client_error
+        rescue ::Clamby::FileNotFound
+          # This should be pretty rare since the scanner should not be even
+          # called when the file is not available. As the storage backend may
+          # be configured, this may still happen with some storage backends.
+          errors << :antivirus_file_not_found
         end
+      end
 
       # Make sure we are starting up with the default configuration.
       reset

metadata

@@ -1,57 +1,57 @@
 --- !ruby/object:Gem::Specification
 name: ratonvirus-clamby
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Antti Hukkanen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-10 00:00:00.000000000 Z
+date: 2020-06-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: ratonvirus
+  name: clamby
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: '1.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: '1.6'
 - !ruby/object:Gem::Dependency
-  name: clamby
+  name: ratonvirus
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: 0.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: 0.2.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -72,14 +72,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.16.0
+        version: 0.18.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.18.0
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.86.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.86.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.40'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.16.0
+        version: '1.40'
 description: Provides ClamAV scanner backed by Clamby for the Ratonvirus gem.
 email:
 - antti.hukkanen@mainiotech.fi
@@ -87,9 +115,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- CHANGELOG.md
 - LICENSE
 - README.md
-- Rakefile
 - lib/ratonvirus/clamby.rb
 - lib/ratonvirus/clamby/version.rb
 - lib/ratonvirus/scanner/clamby.rb
@@ -112,8 +140,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Clamby scanner for Ratonvirus.

data/Rakefile

@@ -1,17 +0,0 @@
-# frozen_string_literal: true
-
-require 'rspec/core/rake_task'
-
-# Run all tests, with coverage report
-RSpec::Core::RakeTask.new(:coverage) do |t, task_args|
-  ENV['CODECOV'] = '1'
-  t.verbose = false
-end
-
-# Run all tests, include all
-RSpec::Core::RakeTask.new(:spec) do |t, task_args|
-  t.verbose = false
-end
-
-# Run both by default
-task default: [:spec, :coverage]