rating_for 0.2 → 0.3

data/lib/rating_for.rb

@@ -13,6 +13,7 @@ module RatingFor
       has_one "rating_for_#{element}", 
               :dependent => :destroy, 
               :as => :element,
+              :class_name => 'RateableElement',
               :conditions => {:element_attribute => element.to_s}
       
       define_method "rating_for_#{element}" do

data/lib/rating_for/rateable_element.rb

@@ -1,5 +1,5 @@
 class RateableElement < ActiveRecord::Base
-  has_many :ratings, :dependent => :destroy
+  has_many :ratings, :dependent => :destroy, :inverse_of => :rateable_element
   belongs_to :element, :polymorphic => true
   before_save :recalculate_avg_rating
   

data/lib/rating_for/rating.rb

@@ -1,5 +1,5 @@
 class Rating < ActiveRecord::Base
-  belongs_to :rateable_element
+  belongs_to :rateable_element, :inverse_of => :ratings, :touch => true
   belongs_to :rater, :polymorphic => true
 
   validates_associated :rateable_element
@@ -32,6 +32,7 @@ class Rating < ActiveRecord::Base
   
   def update_rateable_element
     self.rateable_element.recalculate_rating
+    p 'a12'
   end
   
-end
+end

data/lib/rating_for/version.rb

@@ -1,3 +1,3 @@
 module RatingFor
-  VERSION = "0.2"
+  VERSION = "0.3"
 end

data/test/rating_for_test.rb

@@ -1,4 +1,4 @@
-require 'test_helper'
+require_relative 'test_helper.rb'
 
 class User < ActiveRecord::Base
 end
@@ -99,7 +99,7 @@ class RatingForTest < ActiveRecord::TestCase
     assert hotel.rating_for_quality.avg_rating != new_avg_rating
     assert_equal avg_rating, hotel.rating_for_quality.avg_rating
     
-    # new objects get their data fresh out of the database - this data is corect
+    # new objects get their data fresh out of the database - this data is correct
     h2 = Hotel.find(1)
     assert_equal h.rating_for_quality.avg_rating, h2.rating_for_quality.avg_rating
     assert hotel.rating_for_quality.avg_rating != h2.rating_for_quality.avg_rating
@@ -126,4 +126,16 @@ class RatingForTest < ActiveRecord::TestCase
     assert avg_rating != hotel.rating_for_quality.avg_rating
     assert_equal new_avg_rating, hotel.rating_for_quality.avg_rating
   end
+
+  test "remove objects" do
+    hotel = Hotel.find(1)
+    hotel.rating_for_service.add 10
+
+    r = RateableElement.where(:element_type => 'Hotel', :element_attribute => 'service', :element_id => 1)
+    assert_equal 1, r.count
+
+    hotel.destroy
+    r = RateableElement.where(:element_type => 'Hotel', :element_attribute => 'service', :element_id => 1)
+    assert_equal 0, r.count
+  end
 end

data/test/test_helper.rb

@@ -2,10 +2,10 @@ require 'rubygems'
 require 'active_record'
 require 'active_record/test_case'
 require 'active_record/fixtures'
+require 'rating_for'
 
 require 'test/unit'
-require File.dirname(__FILE__) + '/../init'
-require File.dirname(__FILE__) + '/../lib/generators/rating_for/migration/templates/migration'
+require File.join(File.dirname(__FILE__) + '/../lib/generators/rating_for/migration/templates/migration')
 
 ActiveRecord::Base.establish_connection({
   :adapter => 'sqlite3', :database => ':memory:'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rating_for
 version: !ruby/object:Gem::Version
-  version: '0.2'
+  version: '0.3'
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-23 00:00:00.000000000 Z
+date: 2012-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &70173126204620 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,15 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *70173126204620
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &70173126201800 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,7 +37,12 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70173126201800
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: This plugin allows you to add multiple different rating criteria to your
   ActiveRecord based model. It provides column-caching and a polymorphic association
   for raters.
@@ -79,7 +89,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: rating_for
-rubygems_version: 1.8.10
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: A context-based rating gem for Rails