rating 0.2.0 → 0.3.0

data/spec/models/extension/rate_for_spec.rb

@@ -3,14 +3,14 @@
 require 'rails_helper'
 
 RSpec.describe Rating::Extension, ':rate_for' do
-  let!(:user)    { create :user }
+  let!(:author)  { create :author }
   let!(:article) { create :article }
 
   context 'with no scopeable' do
     it 'delegates to rate object' do
-      expect(Rating::Rate).to receive(:rate_for).with author: user, resource: article, scopeable: nil
+      expect(Rating::Rate).to receive(:rate_for).with author: author, resource: article, scopeable: nil
 
-      user.rate_for article
+      author.rate_for article
     end
   end
 
@@ -18,9 +18,9 @@ RSpec.describe Rating::Extension, ':rate_for' do
     let!(:category) { build :category }
 
     it 'delegates to rate object' do
-      expect(Rating::Rate).to receive(:rate_for).with author: user, resource: article, scopeable: category
+      expect(Rating::Rate).to receive(:rate_for).with author: author, resource: article, scopeable: category
 
-      user.rate_for article, scope: category
+      author.rate_for article, scope: category
     end
   end
 end

data/spec/models/extension/rate_spec.rb

@@ -3,14 +3,16 @@
 require 'rails_helper'
 
 RSpec.describe Rating::Extension, ':rate' do
-  let!(:user)    { create :user }
+  let!(:author)  { create :author }
   let!(:article) { create :article }
 
   context 'with no scopeable' do
     it 'delegates to rate object' do
-      expect(Rating::Rate).to receive(:create).with author: user, resource: article, scopeable: nil, value: 3
+      expect(Rating::Rate).to receive(:create).with(
+        author: author, metadata: {}, resource: article, scopeable: nil, value: 3
+      )
 
-      user.rate article, 3
+      author.rate article, 3
     end
   end
 
@@ -18,9 +20,33 @@ RSpec.describe Rating::Extension, ':rate' do
     let!(:category) { build :category }
 
     it 'delegates to rate object' do
-      expect(Rating::Rate).to receive(:create).with author: user, resource: article, scopeable: category, value: 3
+      expect(Rating::Rate).to receive(:create).with(
+        author: author, metadata: {}, resource: article, scopeable: category, value: 3
+      )
 
-      user.rate article, 3, scope: category
+      author.rate article, 3, scope: category
+    end
+  end
+
+  context 'with no metadata' do
+    it 'delegates an empty hash to rate object' do
+      expect(Rating::Rate).to receive(:create).with(
+        author: author, resource: article, metadata: {}, scopeable: nil, value: 3
+      )
+
+      author.rate article, 3
+    end
+  end
+
+  context 'with metadata' do
+    let!(:category) { build :category }
+
+    it 'delegates to rate object' do
+      expect(Rating::Rate).to receive(:create).with(
+        author: author, metadata: { comment: 'comment' }, resource: article, scopeable: nil, value: 3
+      )
+
+      author.rate article, 3, metadata: { comment: 'comment' }
     end
   end
 end

data/spec/models/extension/rated_question_spec.rb

@@ -3,20 +3,20 @@
 require 'rails_helper'
 
 RSpec.describe Rating::Extension, ':rated?' do
-  let!(:user)    { create :user }
+  let!(:author)  { create :author }
   let!(:article) { create :article }
 
   context 'with no scopeable' do
     context 'when has no rate for the given resource' do
-      before { allow(user).to receive(:rate_for).with(article, scope: nil) { nil } }
+      before { allow(author).to receive(:rate_for).with(article, scope: nil).and_return nil }
 
-      specify { expect(user.rated?(article)).to eq false }
+      specify { expect(author.rated?(article)).to eq false }
     end
 
     context 'when has rate for the given resource' do
-      before { allow(user).to receive(:rate_for).with(article, scope: nil) { double } }
+      before { allow(author).to receive(:rate_for).with(article, scope: nil).and_return double }
 
-      specify { expect(user.rated?(article)).to eq true }
+      specify { expect(author.rated?(article)).to eq true }
     end
   end
 
@@ -24,15 +24,15 @@ RSpec.describe Rating::Extension, ':rated?' do
     let!(:category) { build :category }
 
     context 'when has no rate for the given resource' do
-      before { allow(user).to receive(:rate_for).with(article, scope: category) { nil } }
+      before { allow(author).to receive(:rate_for).with(article, scope: category).and_return nil }
 
-      specify { expect(user.rated?(article, scope: category)).to eq false }
+      specify { expect(author.rated?(article, scope: category)).to eq false }
     end
 
     context 'when has rate for the given resource' do
-      before { allow(user).to receive(:rate_for).with(article, scope: category) { double } }
+      before { allow(author).to receive(:rate_for).with(article, scope: category).and_return double }
 
-      specify { expect(user.rated?(article, scope: category)).to eq true }
+      specify { expect(author.rated?(article, scope: category)).to eq true }
     end
   end
 end

data/spec/models/extension/rated_records_spec.rb

@@ -1,26 +1,12 @@
 # frozen_string_literal: true
 
 require 'rails_helper'
+require 'support/shared_context/with_database_records'
 
 RSpec.describe Rating::Extension, '.rated_records' do
-  let!(:category) { create :category }
-
-  let!(:user_1) { create :user }
-  let!(:user_2) { create :user }
-
-  let!(:article_1) { create :article }
-  let!(:article_2) { create :article }
-  let!(:article_3) { create :article }
-
-  let!(:rate_1) { create :rating_rate, author: user_1, resource: article_1, value: 100 }
-  let!(:rate_2) { create :rating_rate, author: user_1, resource: article_2, value: 11 }
-  let!(:rate_3) { create :rating_rate, author: user_1, resource: article_3, value: 10 }
-  let!(:rate_4) { create :rating_rate, author: user_2, resource: article_1, value: 1 }
-
-  let!(:rate_5) { create :rating_rate, author: user_1, resource: article_1, scopeable: category, value: 1 }
-  let!(:rate_6) { create :rating_rate, author: user_2, resource: article_1, scopeable: category, value: 2 }
+  include_context 'with_database_records'
 
   it 'returns all rates that this author gave' do
-    expect(user_1.rated_records).to match_array [rate_1, rate_2, rate_3, rate_5]
+    expect(author_1.rated_records).to match_array [rate_1, rate_2, rate_3, rate_5]
   end
 end

data/spec/models/extension/rated_spec.rb

@@ -1,57 +1,39 @@
 # frozen_string_literal: true
 
 require 'rails_helper'
+require 'support/shared_context/with_database_records'
 
 RSpec.describe Rating::Extension, ':rated' do
-  let!(:category) { create :category }
-
-  let!(:user_1) { create :user }
-  let!(:user_2) { create :user }
-
-  let!(:article_1) { create :article }
-  let!(:article_2) { create :article }
-  let!(:article_3) { create :article }
-
-  let!(:rate_1) { create :rating_rate, author: user_1, resource: article_1, value: 100 }
-  let!(:rate_2) { create :rating_rate, author: user_1, resource: article_2, value: 11 }
-  let!(:rate_3) { create :rating_rate, author: user_1, resource: article_3, value: 10 }
-  let!(:rate_4) { create :rating_rate, author: user_2, resource: article_1, value: 1 }
-
-  let!(:rate_5) { create :rating_rate, author: user_1, resource: article_1, scopeable: category, value: 1 }
-  let!(:rate_6) { create :rating_rate, author: user_2, resource: article_1, scopeable: category, value: 2 }
+  include_context 'with_database_records'
 
   context 'with no scope' do
     it 'returns rates made by this author' do
-      expect(user_1.rated).to match_array [rate_1, rate_2, rate_3]
+      expect(author_1.rated).to match_array [rate_1, rate_2, rate_3]
     end
   end
 
   context 'with no scope' do
     it 'returns scoped rates made by this author' do
-      expect(user_1.rated(scope: category)).to eq [rate_5]
+      expect(author_1.rated(scope: category)).to eq [rate_5]
     end
   end
 
   context 'when destroy author' do
-    before do
-      expect(Rating::Rate.where(author: user_1).count).to eq 4
+    it 'destroys rates of that author' do
+      expect(Rating::Rate.where(author: author_1).count).to eq 4
 
-      user_1.destroy!
-    end
+      author_1.destroy!
 
-    it 'destroys rates of that author' do
-      expect(Rating::Rate.where(author: user_1).count).to eq 0
+      expect(Rating::Rate.where(author: author_1).count).to eq 0
     end
   end
 
   context 'when destroy resource rated by author' do
-    before do
+    it 'destroys rates of that resource' do
       expect(Rating::Rate.where(resource: article_1).count).to eq 4
 
       article_1.destroy!
-    end
 
-    it 'destroys rates of that resource' do
       expect(Rating::Rate.where(resource: article_1).count).to eq 0
     end
   end

data/spec/models/extension/rates_records_spec.rb

@@ -1,24 +1,10 @@
 # frozen_string_literal: true
 
 require 'rails_helper'
+require 'support/shared_context/with_database_records'
 
 RSpec.describe Rating::Extension, '.rates_records' do
-  let!(:category) { create :category }
-
-  let!(:user_1) { create :user }
-  let!(:user_2) { create :user }
-
-  let!(:article_1) { create :article }
-  let!(:article_2) { create :article }
-  let!(:article_3) { create :article }
-
-  let!(:rate_1) { create :rating_rate, author: user_1, resource: article_1, value: 100 }
-  let!(:rate_2) { create :rating_rate, author: user_1, resource: article_2, value: 11 }
-  let!(:rate_3) { create :rating_rate, author: user_1, resource: article_3, value: 10 }
-  let!(:rate_4) { create :rating_rate, author: user_2, resource: article_1, value: 1 }
-
-  let!(:rate_5) { create :rating_rate, author: user_1, resource: article_1, scopeable: category, value: 1 }
-  let!(:rate_6) { create :rating_rate, author: user_2, resource: article_1, scopeable: category, value: 2 }
+  include_context 'with_database_records'
 
   it 'returns all rates that this resource received' do
     expect(article_1.rates_records).to match_array [rate_1, rate_4, rate_5, rate_6]

data/spec/models/extension/rates_spec.rb

@@ -1,24 +1,10 @@
 # frozen_string_literal: true
 
 require 'rails_helper'
+require 'support/shared_context/with_database_records'
 
 RSpec.describe Rating::Extension, ':rates' do
-  let!(:category) { create :category }
-
-  let!(:user_1) { create :user }
-  let!(:user_2) { create :user }
-
-  let!(:article_1) { create :article }
-  let!(:article_2) { create :article }
-  let!(:article_3) { create :article }
-
-  let!(:rate_1) { create :rating_rate, author: user_1, resource: article_1, value: 100 }
-  let!(:rate_2) { create :rating_rate, author: user_1, resource: article_2, value: 11 }
-  let!(:rate_3) { create :rating_rate, author: user_1, resource: article_3, value: 10 }
-  let!(:rate_4) { create :rating_rate, author: user_2, resource: article_1, value: 1 }
-
-  let!(:rate_5) { create :rating_rate, author: user_1, resource: article_1, scopeable: category, value: 1 }
-  let!(:rate_6) { create :rating_rate, author: user_2, resource: article_1, scopeable: category, value: 2 }
+  include_context 'with_database_records'
 
   context 'with no scope' do
     it 'returns rates that this resource received' do
@@ -34,11 +20,11 @@ RSpec.describe Rating::Extension, ':rates' do
 
   context 'when destroy author' do
     it 'destroys rates of that author' do
-      expect(Rating::Rate.where(author: user_1).count).to eq 4
+      expect(Rating::Rate.where(author: author_1).count).to eq 4
 
-      user_1.destroy!
+      author_1.destroy!
 
-      expect(Rating::Rate.where(author: user_1).count).to eq 0
+      expect(Rating::Rate.where(author: author_1).count).to eq 0
     end
   end
 

data/spec/models/extension/rating_records_spec.rb

@@ -1,26 +1,10 @@
 # frozen_string_literal: true
 
 require 'rails_helper'
+require 'support/shared_context/with_database_records'
 
 RSpec.describe Rating::Extension, '.rating' do
-  let!(:category) { create :category }
-
-  let!(:user_1) { create :user }
-  let!(:user_2) { create :user }
-
-  let!(:article_1) { create :article }
-  let!(:article_2) { create :article }
-  let!(:article_3) { create :article }
-
-  before do
-    create :rating_rate, author: user_1, resource: article_1, value: 100
-    create :rating_rate, author: user_1, resource: article_2, value: 11
-    create :rating_rate, author: user_1, resource: article_3, value: 10
-    create :rating_rate, author: user_2, resource: article_1, value: 1
-
-    create :rating_rate, author: user_1, resource: article_1, scopeable: category, value: 1
-    create :rating_rate, author: user_2, resource: article_1, scopeable: category, value: 2
-  end
+  include_context 'with_database_records'
 
   it 'returns all rating of this resource' do
     expect(article_1.rating_records).to match_array Rating::Rating.where(resource: article_1)

data/spec/models/extension/rating_spec.rb

@@ -1,24 +1,10 @@
 # frozen_string_literal: true
 
 require 'rails_helper'
+require 'support/shared_context/with_database_records'
 
 RSpec.describe Rating::Extension, '.rating' do
-  let!(:category) { create :category }
-
-  let!(:user_1) { create :user }
-  let!(:user_2) { create :user }
-
-  let!(:article_1) { create :article }
-  let!(:article_2) { create :article }
-  let!(:article_3) { create :article }
-
-  let!(:rate_1) { create :rating_rate, author: user_1, resource: article_1, value: 100 }
-  let!(:rate_2) { create :rating_rate, author: user_1, resource: article_2, value: 11 }
-  let!(:rate_3) { create :rating_rate, author: user_1, resource: article_3, value: 10 }
-  let!(:rate_4) { create :rating_rate, author: user_2, resource: article_1, value: 1 }
-
-  let!(:rate_5) { create :rating_rate, author: user_1, resource: article_1, scopeable: category, value: 1 }
-  let!(:rate_6) { create :rating_rate, author: user_2, resource: article_1, scopeable: category, value: 2 }
+  include_context 'with_database_records'
 
   context 'with no scope' do
     it 'returns rating record' do
@@ -36,7 +22,7 @@ RSpec.describe Rating::Extension, '.rating' do
     it 'does not destroy resource rating' do
       expect(Rating::Rating.where(resource: article_1).count).to eq 2
 
-      user_1.destroy!
+      author_1.destroy!
 
       expect(Rating::Rating.where(resource: article_1).count).to eq 2
     end

data/spec/models/rate/create_spec.rb

@@ -3,17 +3,17 @@
 require 'rails_helper'
 
 RSpec.describe Rating::Rate, ':create' do
-  let!(:user)    { create :user }
+  let!(:author)  { create :author }
   let!(:article) { create :article }
 
   context 'with no scopeable' do
-    before { create :rating_rate, author: user, resource: article, value: 3 }
+    before { described_class.create author: author, metadata: {}, resource: article, value: 3 }
 
     context 'when rate does not exist yet' do
       it 'creates a rate entry' do
         rate = described_class.last
 
-        expect(rate.author).to   eq user
+        expect(rate.author).to   eq author
         expect(rate.resource).to eq article
         expect(rate.value).to    eq 3
       end
@@ -30,24 +30,24 @@ RSpec.describe Rating::Rate, ':create' do
     end
 
     context 'when rate already exists' do
-      let!(:user_2) { create :user }
+      let!(:author_2) { create :author }
 
-      before { create :rating_rate, author: user_2, resource: article, value: 4 }
+      before { described_class.create author: author_2, metadata: {}, resource: article, value: 4 }
 
       it 'creates one more rate entry' do
-        rates = described_class.where(author: [user, user_2]).order('created_at asc')
+        rates = described_class.where(author: [author, author_2]).order('created_at asc')
 
         expect(rates.size).to eq 2
 
         rate = rates[0]
 
-        expect(rate.author).to   eq user
+        expect(rate.author).to   eq author
         expect(rate.resource).to eq article
         expect(rate.value).to    eq 3
 
         rate = rates[1]
 
-        expect(rate.author).to   eq user_2
+        expect(rate.author).to   eq author_2
         expect(rate.resource).to eq article
         expect(rate.value).to    eq 4
       end
@@ -67,13 +67,13 @@ RSpec.describe Rating::Rate, ':create' do
   context 'with scopeable' do
     let!(:category) { create :category }
 
-    before { create :rating_rate, author: user, resource: article, scopeable: category, value: 3 }
+    before { described_class.create author: author, metadata: {}, resource: article, scopeable: category, value: 3 }
 
     context 'when rate does not exist yet' do
       it 'creates a rate entry' do
         rate = described_class.last
 
-        expect(rate.author).to    eq user
+        expect(rate.author).to    eq author
         expect(rate.resource).to  eq article
         expect(rate.scopeable).to eq category
         expect(rate.value).to     eq 3
@@ -92,25 +92,25 @@ RSpec.describe Rating::Rate, ':create' do
     end
 
     context 'when rate already exists' do
-      let!(:user_2) { create :user }
+      let!(:author_2) { create :author }
 
-      before { create :rating_rate, author: user_2, resource: article, scopeable: category, value: 4 }
+      before { described_class.create author: author_2, metadata: {}, resource: article, scopeable: category, value: 4 }
 
       it 'creates one more rate entry' do
-        rates = described_class.where(author: [user, user_2]).order('created_at asc')
+        rates = described_class.where(author: [author, author_2]).order('created_at asc')
 
         expect(rates.size).to eq 2
 
         rate = rates[0]
 
-        expect(rate.author).to    eq user
+        expect(rate.author).to    eq author
         expect(rate.resource).to  eq article
         expect(rate.scopeable).to eq category
         expect(rate.value).to     eq 3
 
         rate = rates[1]
 
-        expect(rate.author).to    eq user_2
+        expect(rate.author).to    eq author_2
         expect(rate.resource).to  eq article
         expect(rate.scopeable).to eq category
         expect(rate.value).to     eq 4
@@ -128,4 +128,45 @@ RSpec.describe Rating::Rate, ':create' do
       end
     end
   end
+
+  context 'with metadata' do
+    context 'with nil value' do
+      it 'creates a rate entry ignoring metadata' do
+        described_class.create author: author, metadata: nil, resource: article, value: 3
+
+        rate = described_class.last
+
+        expect(rate.author).to   eq author
+        expect(rate.comment).to  eq nil
+        expect(rate.resource).to eq article
+        expect(rate.value).to    eq 3
+      end
+    end
+
+    context 'with empty value' do
+      it 'creates a rate entry ignoring metadata' do
+        described_class.create author: author, metadata: '', resource: article, value: 3
+
+        rate = described_class.last
+
+        expect(rate.author).to   eq author
+        expect(rate.comment).to  eq nil
+        expect(rate.resource).to eq article
+        expect(rate.value).to    eq 3
+      end
+    end
+
+    context 'with hash value' do
+      it 'creates a rate entry with metadata included' do
+        described_class.create author: author, metadata: { comment: 'comment' }, resource: article, value: 3
+
+        rate = described_class.last
+
+        expect(rate.author).to   eq author
+        expect(rate.comment).to  eq 'comment'
+        expect(rate.resource).to eq article
+        expect(rate.value).to    eq 3
+      end
+    end
+  end
 end