rating 0.10.0 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bf4f916eaf8978771365715fff38db48916a423e061a4fe680cc105d48d3558b
-  data.tar.gz: 409e9990a8171000cbd898744f6859358f75e302f0d169287ba29c94fc293758
+  metadata.gz: 3478dbe5fac4bb47db0a3b730f0b21d49747912056447d9de55d5ec82f6072ec
+  data.tar.gz: 3d95a77107c053347876554c1f36121a62b9342dd4b585833cd12b2f32aadd0c
 SHA512:
-  metadata.gz: 5c06d75fec9d344f0cca88d6f250d23b4d3612539f2c12d10d6db3c56b86349f9552e3036a34c065d8ccbe9b5e13f00c2ab34f70167d6d16e7ca2d3f90868351
-  data.tar.gz: c3788409c80bc0a8c9b17df8d40720e35f225a0e8dd5ed6c136260c821f176dd8caa87809dcc68e3b50f892d58d9863f7248c554ea8a69832b05f0cb16aa1249
+  metadata.gz: caabeb2c0336c22a86d95a064688424d242c96f84c8e28bd93883a2472f15a22d937ab726f060f765332bb8277f19ffb2fde571a2e7019b91e02c8aced96867d
+  data.tar.gz: 5acbf2bb5e2280de7507e9c23785ecc75e31b62a8c434a48972f50e78d09fa38a8e4280d4272c91bb3109994cdab217f5766a01d94c5a384d9990aa080c18e06

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## v0.11.0
+
+### Updates
+
+- Same rate value hits DB to update metadata.
+
 ## v0.10.0
 
 ### News

data/README.md

@@ -390,7 +390,7 @@ rating:
 
 ### Unscoped Rating
 
-All rating values are grouped by the scope, but you can disable it and group all of them.
+All rating values are grouped by its own scope, but you can disable it and group all of them together.
 
 ```ruby
 rating unscoped_rating: true
@@ -404,7 +404,8 @@ author.rate resource, 2, scope: scope
 author.rate resource, 3
 ```
 
-Now the `sum` will be `6` and the `total` will be `3` because all rating will be calculated into just one rating record ignoring the `scopeable` object. The rating record is always saved on the record with `scopeable` as `nil`.
+Now the `sum` will be `6` and the `total` will be `3` because all rating will be calculated into just one rating record ignoring the `scopeable` object.
+The rating record is *always* saved on the record with `scopeable` as `nil`.
 
 ### where
 

data/lib/rating/models/rating/rate.rb

@@ -23,8 +23,6 @@ module Rating
       attributes = { author: author, resource: resource, scopeable: scopeable }.merge(extra_scopes)
       record     = find_or_initialize_by(attributes)
 
-      return record if record.persisted? && value == record.value
-
       metadata.each { |k, v| record[k] = v } if metadata.present?
 
       record.value = value
@@ -34,9 +32,7 @@ module Rating
     end
 
     def self.rate_for(author:, extra_scopes: {}, resource:, scopeable: nil)
-      attributes = { author: author, resource: resource, scopeable: scopeable }.merge(extra_scopes)
-
-      find_by attributes
+      find_by extra_scopes.merge(author: author, resource: resource, scopeable: scopeable)
     end
 
     private

data/lib/rating/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Rating
-  VERSION = '0.10.0'
+  VERSION = '0.11.0'
 end

data/spec/models/extension/unscoped_rating_spec.rb

@@ -5,6 +5,7 @@ require 'rails_helper'
 RSpec.describe Rating::Extension, 'unscoped_rating' do
   let!(:author_1) { create :author }
   let!(:author_2) { create :author }
+  let!(:author_3) { create :author }
   let!(:scope)    { create :category }
 
   context 'when is false' do
@@ -13,7 +14,7 @@ RSpec.describe Rating::Extension, 'unscoped_rating' do
     it 'groups in different line record' do
       author_1.rate resource, 1, scope: scope
       author_2.rate resource, 2, scope: scope
-      author_1.rate resource, 5
+      author_2.rate resource, 5
 
       ratings = Rating::Rating.all.order('id')
 
@@ -45,7 +46,7 @@ RSpec.describe Rating::Extension, 'unscoped_rating' do
     it 'groups in the same line record' do
       author_1.rate resource, 1, scope: scope
       author_2.rate resource, 2, scope: scope
-      author_1.rate resource, 5
+      author_2.rate resource, 5
 
       ratings = Rating::Rating.all.order('id')
 
@@ -62,15 +63,15 @@ RSpec.describe Rating::Extension, 'unscoped_rating' do
     end
   end
 
-  context 'when is true and have a non scopeable record first on database' do
+  context 'when is true and have a non scoped record first on database' do
     let!(:resource) { create :global }
 
     before { ::Rating::Rating.create resource: resource, scopeable: scope }
 
-    it 'groups in the line with no scope' do
+    it 'sets the result on record with no scope' do
       author_1.rate resource, 1, scope: scope
       author_2.rate resource, 2, scope: scope
-      author_1.rate resource, 5
+      author_3.rate resource, 5
 
       ratings = Rating::Rating.all.order('id')
 

data/spec/models/rate/create_spec.rb

@@ -192,6 +192,64 @@ RSpec.describe Rating::Rate, ':create' do
         expect(rate.value).to    eq 3
       end
     end
+
+    context 'when already has an entry' do
+      before do
+        described_class.create(
+          author:       author,
+          extra_scopes: {},
+          metadata:     { comment: 'comment' },
+          resource:     article,
+          value:        1
+        )
+      end
+
+      context 'when value is the same' do
+        it 'still updates metadata' do
+          described_class.create(
+            author:       author,
+            extra_scopes: {},
+            metadata:     { comment: 'comment.updated' },
+            resource:     article,
+            value:        1
+          )
+
+          rates = described_class.all
+
+          expect(rates.size).to eq 1
+
+          rate = rates[0]
+
+          expect(rate.author).to   eq author
+          expect(rate.comment).to  eq 'comment.updated'
+          expect(rate.resource).to eq article
+          expect(rate.value).to    eq 1
+        end
+      end
+
+      context 'when value is different same' do
+        it 'still updates metadata' do
+          described_class.create(
+            author:       author,
+            extra_scopes: {},
+            metadata:     { comment: 'comment.updated' },
+            resource:     article,
+            value:        2
+          )
+
+          rates = described_class.all
+
+          expect(rates.size).to eq 1
+
+          rate = rates[0]
+
+          expect(rate.author).to   eq author
+          expect(rate.comment).to  eq 'comment.updated'
+          expect(rate.resource).to eq article
+          expect(rate.value).to    eq 2
+        end
+      end
+    end
   end
 
   if ENV['CONFIG_ENABLED_WITH_EXTRA_SCOPES'] == 'true'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rating
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.11.0
 platform: ruby
 authors:
 - Washington Botelho
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-12-20 00:00:00.000000000 Z
+date: 2020-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -233,7 +233,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: A true Bayesian rating system with scope and cache enabled.