rating 0.1.0 → 0.2.0

data/lib/rating/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Rating
-  VERSION = '0.1.0'
+  VERSION = '0.2.0'
 end

data/spec/factories/article.rb

@@ -2,6 +2,6 @@
 
 FactoryBot.define do
   factory :article do
-    sequence(:name) { |i| "Name #{i}" }
+    sequence(:name) { |i| "Article #{i}" }
   end
 end

data/spec/factories/author.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+FactoryBot.define do
+  factory :author do
+    sequence(:name) { |i| "Author #{i}" }
+  end
+end

data/spec/factories/category.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+FactoryBot.define do
+  factory :category do
+    sequence(:name) { |i| "Category #{i}" }
+  end
+end

data/spec/factories/user.rb

@@ -2,6 +2,6 @@
 
 FactoryBot.define do
   factory :user do
-    sequence(:name) { |i| "Name #{i}" }
+    sequence(:name) { |i| "User #{i}" }
   end
 end

data/spec/models/extension/after_create_spec.rb

@@ -3,17 +3,26 @@
 require 'rails_helper'
 
 RSpec.describe Rating::Extension, ':after_create' do
-  context 'when creates object' do
+  context 'with :as as nil' do
     let!(:user) { create :user }
 
-    it 'creates a record with zero values just to be easy to make the count' do
+    it 'creates a rating record with zero values just to be easy to make the count' do
       rating = Rating::Rating.find_by(resource: user)
 
-      expect(rating.average).to  eq 0
-      expect(rating.estimate).to eq 0
-      expect(rating.resource).to eq user
-      expect(rating.sum).to      eq 0
-      expect(rating.total).to    eq 0
+      expect(rating.average).to   eq 0
+      expect(rating.estimate).to  eq 0
+      expect(rating.resource).to  eq user
+      expect(rating.scopeable).to eq nil
+      expect(rating.sum).to       eq 0
+      expect(rating.total).to     eq 0
+    end
+  end
+
+  context 'with :as as :author' do
+    let!(:author) { create :author }
+
+    it 'does not creates a rating record' do
+      expect(Rating::Rating.exists?(resource: author)).to eq false
     end
   end
 end

data/spec/models/extension/order_by_rating_spec.rb

@@ -3,6 +3,8 @@
 require 'rails_helper'
 
 RSpec.describe Rating::Extension, ':order_by_rating' do
+  let!(:category) { create :category }
+
   let!(:user_1) { create :user }
   let!(:user_2) { create :user }
 
@@ -15,6 +17,9 @@ RSpec.describe Rating::Extension, ':order_by_rating' do
     create :rating_rate, author: user_1, resource: article_2, value: 11
     create :rating_rate, author: user_1, resource: article_3, value: 10
     create :rating_rate, author: user_2, resource: article_1, value: 1
+
+    create :rating_rate, author: user_1, resource: article_1, scopeable: category, value: 1
+    create :rating_rate, author: user_2, resource: article_1, scopeable: category, value: 2
   end
 
   context 'with default filters' do
@@ -36,6 +41,14 @@ RSpec.describe Rating::Extension, ':order_by_rating' do
           article_1
         ]
       end
+
+      context 'with scope' do
+        it 'works' do
+          expect(Article.order_by_rating(:average, :asc, scope: category)).to eq [
+            article_1
+          ]
+        end
+      end
     end
 
     context 'as desc' do
@@ -46,6 +59,14 @@ RSpec.describe Rating::Extension, ':order_by_rating' do
           article_3
         ]
       end
+
+      context 'with scope' do
+        it 'works' do
+          expect(Article.order_by_rating(:average, :desc, scope: category)).to eq [
+            article_1
+          ]
+        end
+      end
     end
   end
 
@@ -58,6 +79,14 @@ RSpec.describe Rating::Extension, ':order_by_rating' do
           article_1
         ]
       end
+
+      context 'with scope' do
+        it 'works' do
+          expect(Article.order_by_rating(:estimate, :asc, scope: category)).to eq [
+            article_1
+          ]
+        end
+      end
     end
 
     context 'as desc' do
@@ -68,6 +97,14 @@ RSpec.describe Rating::Extension, ':order_by_rating' do
           article_3
         ]
       end
+
+      context 'with scope' do
+        it 'works' do
+          expect(Article.order_by_rating(:estimate, :desc, scope: category)).to eq [
+            article_1
+          ]
+        end
+      end
     end
   end
 
@@ -80,6 +117,14 @@ RSpec.describe Rating::Extension, ':order_by_rating' do
           article_1
         ]
       end
+
+      context 'with scope' do
+        it 'works' do
+          expect(Article.order_by_rating(:sum, :asc, scope: category)).to eq [
+            article_1
+          ]
+        end
+      end
     end
 
     context 'as desc' do
@@ -90,6 +135,14 @@ RSpec.describe Rating::Extension, ':order_by_rating' do
           article_3
         ]
       end
+
+      context 'with scope' do
+        it 'works' do
+          expect(Article.order_by_rating(:sum, :desc, scope: category)).to eq [
+            article_1
+          ]
+        end
+      end
     end
 
     context 'filtering by :total' do
@@ -100,6 +153,14 @@ RSpec.describe Rating::Extension, ':order_by_rating' do
           expect(result[0..1]).to match_array [article_2, article_3]
           expect(result.last).to  eq article_1
         end
+
+        context 'with scope' do
+          it 'works' do
+            expect(Article.order_by_rating(:total, :asc, scope: category)).to eq [
+              article_1
+            ]
+          end
+        end
       end
 
       context 'as desc' do
@@ -109,6 +170,14 @@ RSpec.describe Rating::Extension, ':order_by_rating' do
           expect(result.first).to eq article_1
           expect(result[1..2]).to match_array [article_2, article_3]
         end
+
+        context 'with scope' do
+          it 'works' do
+            expect(Article.order_by_rating(:total, :desc, scope: category)).to eq [
+              article_1
+            ]
+          end
+        end
       end
     end
   end
@@ -117,5 +186,11 @@ RSpec.describe Rating::Extension, ':order_by_rating' do
     it 'works' do
       expect(User.order_by_rating(:total, :desc)).to match_array [user_1, user_2]
     end
+
+    context 'with scope' do
+      it 'returns empty since creation has no scope' do
+        expect(User.order_by_rating(:total, :desc, scope: category)).to eq []
+      end
+    end
   end
 end

data/spec/models/extension/rate_for_spec.rb

@@ -6,9 +6,21 @@ RSpec.describe Rating::Extension, ':rate_for' do
   let!(:user)    { create :user }
   let!(:article) { create :article }
 
-  it 'delegates to rate object' do
-    expect(Rating::Rate).to receive(:rate_for).with author: user, resource: article
+  context 'with no scopeable' do
+    it 'delegates to rate object' do
+      expect(Rating::Rate).to receive(:rate_for).with author: user, resource: article, scopeable: nil
 
-    user.rate_for article
+      user.rate_for article
+    end
+  end
+
+  context 'with scopeable' do
+    let!(:category) { build :category }
+
+    it 'delegates to rate object' do
+      expect(Rating::Rate).to receive(:rate_for).with author: user, resource: article, scopeable: category
+
+      user.rate_for article, scope: category
+    end
   end
 end

data/spec/models/extension/rate_spec.rb

@@ -6,9 +6,21 @@ RSpec.describe Rating::Extension, ':rate' do
   let!(:user)    { create :user }
   let!(:article) { create :article }
 
-  it 'delegates to rate object' do
-    expect(Rating::Rate).to receive(:create).with author: user, resource: article, value: 3
+  context 'with no scopeable' do
+    it 'delegates to rate object' do
+      expect(Rating::Rate).to receive(:create).with author: user, resource: article, scopeable: nil, value: 3
 
-    user.rate article, 3
+      user.rate article, 3
+    end
+  end
+
+  context 'with scopeable' do
+    let!(:category) { build :category }
+
+    it 'delegates to rate object' do
+      expect(Rating::Rate).to receive(:create).with author: user, resource: article, scopeable: category, value: 3
+
+      user.rate article, 3, scope: category
+    end
   end
 end

data/spec/models/extension/rated_question_spec.rb

@@ -6,15 +6,33 @@ RSpec.describe Rating::Extension, ':rated?' do
   let!(:user)    { create :user }
   let!(:article) { create :article }
 
-  context 'when has no rate for the given resource' do
-    before { allow(user).to receive(:rate_for).with(article) { nil } }
+  context 'with no scopeable' do
+    context 'when has no rate for the given resource' do
+      before { allow(user).to receive(:rate_for).with(article, scope: nil) { nil } }
 
-    specify { expect(user.rated?(article)).to eq false }
+      specify { expect(user.rated?(article)).to eq false }
+    end
+
+    context 'when has rate for the given resource' do
+      before { allow(user).to receive(:rate_for).with(article, scope: nil) { double } }
+
+      specify { expect(user.rated?(article)).to eq true }
+    end
   end
 
-  context 'when has rate for the given resource' do
-    before { allow(user).to receive(:rate_for).with(article) { double } }
+  context 'with scopeable' do
+    let!(:category) { build :category }
+
+    context 'when has no rate for the given resource' do
+      before { allow(user).to receive(:rate_for).with(article, scope: category) { nil } }
+
+      specify { expect(user.rated?(article, scope: category)).to eq false }
+    end
+
+    context 'when has rate for the given resource' do
+      before { allow(user).to receive(:rate_for).with(article, scope: category) { double } }
 
-    specify { expect(user.rated?(article)).to eq true }
+      specify { expect(user.rated?(article, scope: category)).to eq true }
+    end
   end
 end

data/spec/models/extension/rated_records_spec.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe Rating::Extension, '.rated_records' do
+  let!(:category) { create :category }
+
+  let!(:user_1) { create :user }
+  let!(:user_2) { create :user }
+
+  let!(:article_1) { create :article }
+  let!(:article_2) { create :article }
+  let!(:article_3) { create :article }
+
+  let!(:rate_1) { create :rating_rate, author: user_1, resource: article_1, value: 100 }
+  let!(:rate_2) { create :rating_rate, author: user_1, resource: article_2, value: 11 }
+  let!(:rate_3) { create :rating_rate, author: user_1, resource: article_3, value: 10 }
+  let!(:rate_4) { create :rating_rate, author: user_2, resource: article_1, value: 1 }
+
+  let!(:rate_5) { create :rating_rate, author: user_1, resource: article_1, scopeable: category, value: 1 }
+  let!(:rate_6) { create :rating_rate, author: user_2, resource: article_1, scopeable: category, value: 2 }
+
+  it 'returns all rates that this author gave' do
+    expect(user_1.rated_records).to match_array [rate_1, rate_2, rate_3, rate_5]
+  end
+end

data/spec/models/extension/rated_spec.rb

@@ -3,36 +3,56 @@
 require 'rails_helper'
 
 RSpec.describe Rating::Extension, ':rated' do
-  let!(:user)    { create :user }
-  let!(:article) { create :article }
+  let!(:category) { create :category }
 
-  before { user.rate article, 3 }
+  let!(:user_1) { create :user }
+  let!(:user_2) { create :user }
 
-  it 'returns rates made by the caller' do
-    expect(user.rated).to eq [Rating::Rate.find_by(resource: article)]
+  let!(:article_1) { create :article }
+  let!(:article_2) { create :article }
+  let!(:article_3) { create :article }
+
+  let!(:rate_1) { create :rating_rate, author: user_1, resource: article_1, value: 100 }
+  let!(:rate_2) { create :rating_rate, author: user_1, resource: article_2, value: 11 }
+  let!(:rate_3) { create :rating_rate, author: user_1, resource: article_3, value: 10 }
+  let!(:rate_4) { create :rating_rate, author: user_2, resource: article_1, value: 1 }
+
+  let!(:rate_5) { create :rating_rate, author: user_1, resource: article_1, scopeable: category, value: 1 }
+  let!(:rate_6) { create :rating_rate, author: user_2, resource: article_1, scopeable: category, value: 2 }
+
+  context 'with no scope' do
+    it 'returns rates made by this author' do
+      expect(user_1.rated).to match_array [rate_1, rate_2, rate_3]
+    end
+  end
+
+  context 'with no scope' do
+    it 'returns scoped rates made by this author' do
+      expect(user_1.rated(scope: category)).to eq [rate_5]
+    end
   end
 
   context 'when destroy author' do
     before do
-      expect(Rating::Rate.where(author: user).count).to eq 1
+      expect(Rating::Rate.where(author: user_1).count).to eq 4
 
-      user.destroy!
+      user_1.destroy!
     end
 
-    it 'destroys rates of this author' do
-      expect(Rating::Rate.where(author: user).count).to eq 0
+    it 'destroys rates of that author' do
+      expect(Rating::Rate.where(author: user_1).count).to eq 0
     end
   end
 
   context 'when destroy resource rated by author' do
     before do
-      expect(Rating::Rate.where(resource: article).count).to eq 1
+      expect(Rating::Rate.where(resource: article_1).count).to eq 4
 
-      article.destroy!
+      article_1.destroy!
     end
 
-    it 'destroys rates for that resource' do
-      expect(Rating::Rate.where(resource: article).count).to eq 0
+    it 'destroys rates of that resource' do
+      expect(Rating::Rate.where(resource: article_1).count).to eq 0
     end
   end
 end

data/spec/models/extension/rates_records_spec.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe Rating::Extension, '.rates_records' do
+  let!(:category) { create :category }
+
+  let!(:user_1) { create :user }
+  let!(:user_2) { create :user }
+
+  let!(:article_1) { create :article }
+  let!(:article_2) { create :article }
+  let!(:article_3) { create :article }
+
+  let!(:rate_1) { create :rating_rate, author: user_1, resource: article_1, value: 100 }
+  let!(:rate_2) { create :rating_rate, author: user_1, resource: article_2, value: 11 }
+  let!(:rate_3) { create :rating_rate, author: user_1, resource: article_3, value: 10 }
+  let!(:rate_4) { create :rating_rate, author: user_2, resource: article_1, value: 1 }
+
+  let!(:rate_5) { create :rating_rate, author: user_1, resource: article_1, scopeable: category, value: 1 }
+  let!(:rate_6) { create :rating_rate, author: user_2, resource: article_1, scopeable: category, value: 2 }
+
+  it 'returns all rates that this resource received' do
+    expect(article_1.rates_records).to match_array [rate_1, rate_4, rate_5, rate_6]
+  end
+end

data/spec/models/extension/rates_spec.rb

@@ -3,36 +3,52 @@
 require 'rails_helper'
 
 RSpec.describe Rating::Extension, ':rates' do
-  let!(:user)    { create :user }
-  let!(:article) { create :article }
+  let!(:category) { create :category }
 
-  before { user.rate article, 3 }
+  let!(:user_1) { create :user }
+  let!(:user_2) { create :user }
 
-  it 'returns rates record' do
-    expect(article.rates).to eq [Rating::Rate.last]
-  end
+  let!(:article_1) { create :article }
+  let!(:article_2) { create :article }
+  let!(:article_3) { create :article }
 
-  context 'when destroy author' do
-    before do
-      expect(Rating::Rate.where(resource: article).count).to eq 1
+  let!(:rate_1) { create :rating_rate, author: user_1, resource: article_1, value: 100 }
+  let!(:rate_2) { create :rating_rate, author: user_1, resource: article_2, value: 11 }
+  let!(:rate_3) { create :rating_rate, author: user_1, resource: article_3, value: 10 }
+  let!(:rate_4) { create :rating_rate, author: user_2, resource: article_1, value: 1 }
+
+  let!(:rate_5) { create :rating_rate, author: user_1, resource: article_1, scopeable: category, value: 1 }
+  let!(:rate_6) { create :rating_rate, author: user_2, resource: article_1, scopeable: category, value: 2 }
 
-      user.destroy!
+  context 'with no scope' do
+    it 'returns rates that this resource received' do
+      expect(article_1.rates).to match_array [rate_1, rate_4]
     end
+  end
 
-    it 'destroys rates of that resource' do
-      expect(Rating::Rate.where(resource: article).count).to eq 0
+  context 'with scope' do
+    it 'returns scoped rates that this resource received' do
+      expect(article_1.rates(scope: category)).to match_array [rate_5, rate_6]
     end
   end
 
-  context 'when destroy resource' do
-    before do
-      expect(Rating::Rate.where(resource: article).count).to eq 1
+  context 'when destroy author' do
+    it 'destroys rates of that author' do
+      expect(Rating::Rate.where(author: user_1).count).to eq 4
+
+      user_1.destroy!
 
-      article.destroy!
+      expect(Rating::Rate.where(author: user_1).count).to eq 0
     end
+  end
 
+  context 'when destroy resource' do
     it 'destroys rates of that resource' do
-      expect(Rating::Rate.where(resource: article).count).to eq 0
+      expect(Rating::Rate.where(resource: article_1).count).to eq 4
+
+      article_1.destroy!
+
+      expect(Rating::Rate.where(resource: article_1).count).to eq 0
     end
   end
 end