rasteira 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 860a472e8ee099a7fe0c47a89ca7a9efac747d55
-  data.tar.gz: 274abd1b5e39129a011df5b5821440880152e1e4
+  metadata.gz: aeed51900ad2ffe7ba4fee9d657f48d8251b2f84
+  data.tar.gz: d06530ec00938070fc7ffd30557a87f8e8c6f0cd
 SHA512:
-  metadata.gz: 617692a78f56e64883653099f14ad4659a27ba99149f77b42c038bd7f8aa7fcbd09f8bddc488c2dfd395ec1d2f419278204311c692a0048cdd1c80b5e68dc189
-  data.tar.gz: 872e05a9264d6aab21f22572f809265032f7cfccf2e356a322a5fa82fb3794cfc52bde94f4e0588e01c8498a8fe4c4289482cc2cbcd2beea31bbb997fb67fd8c
+  metadata.gz: cec350b1668f401b1303d31235d13fb2712aab436252188125caaeff89ae31db6933a6b3e74696ec05f0bd8e8d930015a00691f892470532deb16aa5b2579446
+  data.tar.gz: fb2eb08b26b90a3ea1d510276b777b3b4faf065bf8407e6094e868e70a0a7d3ce27d7676b15190053f5852aff3116429b0550c33e0350a13ca88859dbb8b8979

data/.rubocop.yml

@@ -0,0 +1,48 @@
+AllCops:
+  TargetRubyVersion: 2.3
+  DisplayCopNames: true
+
+PercentLiteralDelimiters:
+  PreferredDelimiters:
+    '%':  ()
+    '%i': ()
+    '%q': ()
+    '%Q': ()
+    '%r': ()
+    '%s': ()
+    '%w': ()
+    '%W': ()
+    '%x': ()
+
+Metrics/BlockLength:
+  Enabled: false
+
+Metrics/LineLength:
+  Max: 128
+
+Metrics/ClassLength:
+  Enabled: false
+
+Metrics/MethodLength:
+  Enabled: false
+
+Style/IfUnlessModifier:
+  Enabled: false
+
+Style/GuardClause:
+  Enabled: false
+
+Layout/AlignArray:
+  Enabled: false
+
+Layout/AlignHash:
+  Enabled: false
+
+Layout/AlignParameters:
+  Enabled: false
+
+Lint/RescueWithoutErrorClass:
+  Enabled: false
+
+Naming/HeredocDelimiterNaming:
+  Enabled: false

data/.travis.yml

@@ -1,9 +1,6 @@
 sudo: false
 language: ruby
 rvm:
-  - 2.0
-  - 2.1
-  - 2.2
   - 2.3
   - 2.4
   - ruby-head

data/Gemfile

@@ -1,6 +1,8 @@
-source "https://rubygems.org"
+# frozen_string_literal: true
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+source 'https://rubygems.org'
+
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in rasteira.gemspec
 gemspec

data/Rakefile

@@ -1,6 +1,8 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/bin/console

@@ -1,7 +1,8 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
-require "bundler/setup"
-require "rasteira"
+require 'bundler/setup'
+require 'rasteira'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -10,5 +11,5 @@ require "rasteira"
 # require "pry"
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start(__FILE__)

data/example/hello_worker.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # To test with bin/console, execute like this:
 #
 # 2.4.0 :001 > m = Rasteira::EmbedWorker::Manager.run

data/lib/rasteira.rb

@@ -1,6 +1,9 @@
+# frozen_string_literal: true
+
 require 'rasteira/version'
 require 'rasteira/core/job'
 require 'rasteira/embed_worker/manager'
 
+# Top module of rasteira
 module Rasteira
 end

data/lib/rasteira/core/job.rb

@@ -1,7 +1,10 @@
+# frozen_string_literal: true
+
 module Rasteira
   module Core
+    # Job class that is executed by rasteira.
     class Job
-      attr_reader :worker_name, :worker_file_path, :args, :status
+      attr_reader :worker_class, :worker_file_path, :args, :status
 
       STATUSES = {
         ready: 0,
@@ -10,21 +13,29 @@ module Rasteira
         failed: 3
       }.freeze
 
-      def initialize(worker_name, options = {})
-        if !options[:worker_file_path].nil?
+      # The constructor of Rasteira::Core::Job
+      # @param [String, Class] worker_class The name or class of worker class or
+      # @param [Hash] options
+      # @option options [String] :worker_file_path The file path of worker_class.
+      #   If worker_file_path is set, Rasteira tries to load worker_class from worker_file_path
+      # @option options [String] :current_directory The root path of worker_file_path.
+      #   If current_directory and worker_file_path are set, Rasteira searches worker_file_path
+      #   with current_directory as current directory.
+      def initialize(worker_class, options = {})
+        unless options[:worker_file_path].nil?
           @worker_file_path = File.expand_path(options[:worker_file_path], options[:current_directory] || Dir.pwd)
-          unless File.exists?(@worker_file_path)
-            raise ArgumentError.new("#{@worker_file_path} could not be found")
+          unless File.exist?(@worker_file_path)
+            raise ArgumentError, "#{@worker_file_path} could not be found"
           end
 
           require(@worker_file_path)
         end
 
-        @worker_name = worker_name
+        @worker_class = worker_class
         @args = options[:args]
         @status = STATUSES[:ready]
       end
-    
+
       def start!
         @status = STATUSES[:in_process]
         begin
@@ -35,9 +46,13 @@ module Rasteira
           raise e
         end
       end
-    
+
       def worker
-        @worker ||= Object.const_get("::#{@worker_name}").new
+        @worker ||= if @worker_class.is_a?(String)
+                      Object.const_get("::#{@worker_class}").new
+                    else
+                      @worker_class.new
+                    end
       end
     end
   end

data/lib/rasteira/embed_worker/manager.rb

@@ -1,14 +1,17 @@
+# frozen_string_literal: true
+
 module Rasteira
   module EmbedWorker
+    # Manager class that manages the thread pool and executes jobs.
     class Manager
       attr_reader :job_pool
 
       def initialize
-        @job_pool = Array.new
-        @thread_pool = Array.new
+        @job_pool = []
+        @thread_pool = []
         @mutex = Mutex.new
       end
-      
+
       # Create manager instance and run
       # @return [Rasteira::EmbedWorker::Manager] an instance of a running manager
       def self.run
@@ -17,21 +20,21 @@ module Rasteira
         this
       end
 
-      # TODO to be specifiable
+      # TODO: to be specifiable
       MIN_THREAD_SIZE = 5
 
       # Create thread pool and start all threads
       # @return [nil]
       def run
-        @thread_pool = MIN_THREAD_SIZE.times.map do
+        @thread_pool = Array.new(MIN_THREAD_SIZE).map do
           Thread.start { worker_thread_process }
         end
-        
+
         @thread_manager = Thread.start do
           loop do
             @mutex.synchronize do
-              @thread_pool.reject! { |thread| !thread.alive? }
-              
+              @thread_pool.select!(&:alive?)
+
               (@thread_pool.size...MIN_THREAD_SIZE).each do
                 @thread_pool << Thread.start { worker_thread_process }
               end
@@ -54,14 +57,14 @@ module Rasteira
           @job_pool << ::Rasteira::Core::Job.new(worker_name, options)
         end
       end
-      
+
       # Kill all worker threads
       # @return nil
       def shutdown_workers!
         @thread_pool.each(&:kill)
         @thread_manager.kill
       end
-      
+
       # Return current worker threads id and status hashes
       # @return [Array<Hash>]
       def worker_statuses
@@ -69,7 +72,7 @@ module Rasteira
           { id: thread.object_id, status: thread.status }
         end
       end
-      
+
       private
 
       def worker_thread_process
@@ -85,7 +88,7 @@ module Rasteira
               sleep(3)
             end
           rescue => e
-            # TODO logging
+            # TODO: logging
             puts e.inspect
           end
         end

data/lib/rasteira/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Rasteira
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

data/rasteira.gemspec

@@ -1,4 +1,6 @@
-# coding: utf-8
+
+# frozen_string_literal: true
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'rasteira/version'
@@ -18,11 +20,13 @@ Gem::Specification.new do |spec|
     f.match(%r{^(test|spec|features)/})
   end
   spec.bindir        = 'exe'
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.executables   = spec.files.grep(%r(^exe/)) { |f| File.basename(f) }
   spec.require_paths = ['lib']
+  spec.required_ruby_version = '>= 2.3'
 
   spec.add_development_dependency 'bundler', '~> 1.15'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_development_dependency 'rubocop'
   spec.add_development_dependency 'yard'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rasteira
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Kazuhiro Serizawa
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-11-25 00:00:00.000000000 Z
+date: 2017-12-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -52,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -75,6 +89,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".ruby-version"
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
@@ -102,7 +117,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="