rapporteur 2.1.0 → 3.0.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    Y2MzZjBlZWExMWYyZGZhNDU1YTI2MTc2NzUxYjQ2YTg2N2IzMWQwMA==
+    NjZhNjRmZjgwNmMyZjAxMWMzNTAyYTZlYzYxNzI4NmI5ZDFkZWRiMQ==
   data.tar.gz: !binary |-
-    Mjk0ODE3NWFmMWE0Yzg5M2NiNTM5YWE1MDRjYTlmYTliOTk5NDFhZg==
+    Zjg4ZDViM2IwOTg3OTc3OWU5MmNkYTlmNjVhMjgxNDg5YWZlZWJiYg==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    MTc2M2M2ZDIxMzMzNjRlNGEyMmE4YjllZTZlZDkzMGQ0YTUyODNmNGMyMmIz
-    OTNiNzVjYjMzMTY1YWZlODg3YTcyMjY4NDFhNzI2MmE5YTVkY2VlOGVkMjI4
-    NmQzMWJmYTVmZjczNDY1YjEyYjcxOThkYjJhNzQyMGNkNmEwMTA=
+    ODMxNTQ2ZjY1MjlmMTE1NDY2OTM3ZGZlYzIxMDY0MDE0ZGE3NDBhY2NmZWVl
+    YjFlMWU2Zjg5ZmMwNDZhNjBmODc4YTFlMDNlODhmZDI2Yjg3MmEwNjRkOGFm
+    ODkxZTM1MTJhMWJjMjI5NTU0MjU5ZWNlMzI1MmJkZjM0NjY0MzU=
   data.tar.gz: !binary |-
-    MzEwMTc4Y2NjODViMGQ0ZmQ4ZjA0YjFlMTc0ZGFiMzY2Njg5MDM0NDY2ZTAz
-    M2I1MDdkOTlhYmZiMGZiYTNkNTBiZTA0NGJhMjZiMDAwYWQyZjRkOTBlZjA5
-    NTdjMTk4YzQ2YjFiNDhlN2RmZTc1ZDg1NjY3MTc2YTM4YTEzMTg=
+    ZjU5MWUwNzA5YjYwNmE1OTc3NmQ1MTM0ZmYxMjNhYjdlN2NjY2JlMDYxODU1
+    YWJkMWU4YmRmZmE3ODJhZWYyZmE1ZjIwOWU5MDBiNmEwMTNjMDI2MjIwNWRj
+    YjU4MGU0ZmVmYTA5ODg4MzZlNzI5MjQwMGI0ODA2NTA5YjljZmE=

data/.travis.yml

@@ -1,5 +1,6 @@
 language: ruby
 rvm:
+  - 1.8.7
   - 1.9.3
   - 2.0.0
   - jruby-19mode
@@ -7,6 +8,10 @@ gemfile:
   - gemfiles/rails3.1.gemfile
   - gemfiles/rails3.2.gemfile
   - gemfiles/rails4.0.gemfile
+matrix:
+  exclude:
+    - rvm: 1.8.7
+      gemfile: gemfiles/rails4.0.gemfile
 notifications:
   email: false
   campfire:

data/CHANGELOG.md

@@ -4,6 +4,25 @@
 
 * No significant changes.
 
+## [3.0.0][v3.0.0] / 2013-08-23
+
+* Fix/add Ruby 1.8 compatibility. Because this library was built to work with
+  Rails 3.1 and 3.2 (as well as 4.0), not supporting Ruby 1.8 was dishonest.
+  That has now been rectified.
+* Update message and error handling to allow for both I18n/Proc/String support
+  for both types of messages, by replacing ActiveModel::Errors with a local
+  message list. This provides better consistency between the error message and
+  success message implementations.
+* Use a customized check list registry to ensure order persistence and object
+  uniqueness across Ruby versions.
+* Upgrade Combustion development support gem to fix deprecations in Rails 4.0.
+
+### :boom: Backward incompatible changes
+
+* Attributes may now have multiple success messages bound to them for
+  reporting. This means that there are now, possibly, more than one message per
+  key.
+
 ## [2.1.0][v2.1.0] / 2013-06-28
 
 * Update the gemspec to allow for Rails 4.0 environments.

data/README.md

@@ -32,11 +32,26 @@ validations:
 
 ## Installation
 
+To install, add this line to your application's Gemfile:
+
+```ruby
+gem 'rapporteur'
+```
+
+And then execute:
+
+```bash
+$ bundle install
+```
+
+### Supported environments
+
 Supported Ruby versions:
 
 * MRI 2.0.0
 * MRI 1.9.3
 * MRI 1.9.2
+* MRI 1.8.7
 * JRuby 1.7.4
 
 Supported Rails versions:
@@ -45,18 +60,6 @@ Supported Rails versions:
 * Rails 3.2.x.
 * Rails 3.1.x.
 
-To install, add this line to your application's Gemfile:
-
-```ruby
-gem 'rapporteur'
-```
-
-And then execute:
-
-```bash
-$ bundle
-```
-
 ## Usage
 
 Simply adding the gem requirement to your Gemfile is enough to install and
@@ -137,24 +140,25 @@ happy with it, add an error to the given `checker` instance:
 ```ruby
 # config/initializers/rapporteur.rb
 
+# Define a simple check as a block:
 Rapporteur.add_check do |checker|
   checker.add_message(:paid, "too much")
 end
 
+# Make and use a reusable Proc or lambda:
 my_proc_check = lambda { |checker|
   checker.add_error(:luck, :bad) if rand(2) > 0
   checker.add_message(:luck, :good)
 }
-
 Rapporteur.add_check(my_proc_check)
 
+# Package a check into a Class:
 class MyClassCheck
   def self.call(checker)
     @@counter ||= 0
     checker.add_error(:count, :exceeded) if @@counter > 50
   end
 end
-
 Rapporteur.add_check(MyClassCheck)
 ```
 
@@ -199,23 +203,25 @@ Rapporteur::Revision.current = Rails.root.join("REVISION").read.strip
 # Force a particular directory and use Git
 Rapporteur::Revision.current = `cd "#{Rails.root}" && git rev-parse HEAD`.strip
 
-# Use an ENV variable (Heroku)
+# Use an ENV variable (Heroku Bamboo Stack)
 Rapporteur::Revision.current = ENV["REVISION"]
 
 # Do some crazy calculation
 Rapporteur::Revision.current = lambda { MyRevisionCalculator.execute! }
 ```
 
-### Customizing the error messages
+### Customizing the messages
 
-The error messages displayed in the event that application validations fail are
-all collected through I18n. There are default localization strings provided
-with the gem, but you may override them as necessary, simply by redefining them
-in a locales file within your local application.
+The success and error messages displayed in the event that application
+validations pass or fail are all optionally passed through I18n. There are
+default localization strings provided with the gem, but you may override them
+as necessary, by simply redefining the proper locale keys in a locale file
+within your local application.
 
 For example, to override the database check failure message:
 
 ```yaml
+# /config/locales/en.yml
 en:
   rapporteur:
     errors:
@@ -223,6 +229,25 @@ en:
         unavailable: "Something went wrong"
 ```
 
+If you created a custom checker which reports the current sky color, for
+example, and wanted the success messages to be localized, you could do the
+following:
+
+```ruby
+# /config/initializers/rapporteur.rb
+sky_check = lambda { |checker| checker.add_message(:sky, :blue) }
+Rapporteur.add_check(sky_check)
+```
+
+```yaml
+# /config/locales/fr.yml
+fr:
+  rapporteur:
+    messages:
+      sky:
+        blue: "bleu"
+```
+
 ## Contributing
 
 1. Fork it

data/Rakefile

@@ -3,4 +3,4 @@ require "rspec/core/rake_task"
 require 'appraisal'
 
 RSpec::Core::RakeTask.new(:spec)
-task default: :spec
+task :default => :spec

data/config/routes.rb

@@ -1,3 +1,3 @@
 Rails.application.routes.draw do
-  get 'status.json', to: 'statuses#show', defaults: {format: 'json'}, as: :status
+  get 'status.json', :to => 'statuses#show', :defaults => {:format => 'json'}, :as => :status
 end

data/lib/rapporteur.rb

@@ -5,9 +5,11 @@ require "rapporteur/version"
 # application status endpoint.
 #
 module Rapporteur
+  autoload :CheckList, 'rapporteur/check_list'
   autoload :Checker, 'rapporteur/checker'
   autoload :CheckerDeprecations, 'rapporteur/checker_deprecations'
   autoload :Checks, 'rapporteur/checks'
+  autoload :MessageList, 'rapporteur/message_list'
   autoload :Responder, 'rapporteur/responder'
   autoload :Revision, 'rapporteur/revision'
 

data/lib/rapporteur/check_list.rb

@@ -0,0 +1,61 @@
+module Rapporteur
+  # Manages a list of checks.
+  #
+  # The goals of this object are to store and return the check objects given to
+  # it in the same order they were given (in Ruby 1.8 and newer). And, to
+  # ensure that the same check is not added twice to be run.
+  #
+  # Previously, a native Ruby Set was used. However, Sets do not guarantee
+  # order, particularly in Ruby 1.8. A simple Array is possible, but loses the
+  # uniqueness constraint of the objects added.
+  #
+  class CheckList
+    # Public: Returns a new, empty CheckList instance.
+    #
+    def initialize
+      @list = Array.new
+    end
+
+
+    # Public: Add a new check to the list.
+    #
+    # Returns the CheckList instance.
+    #
+    def add(check)
+      @list << check unless @list.include?(check)
+      self
+    end
+
+    # Public: Empties all checks from the list. This functionally resets the
+    # list to an initial state.
+    #
+    # Returns the CheckList instance.
+    #
+    def clear
+      @list.clear
+      self
+    end
+
+    # Public: Iterates over all of the contained objects and yields them out,
+    # individually.
+    #
+    # Returns the CheckList instance.
+    #
+    def each(&block)
+      @list.each(&block)
+      self
+    end
+
+    # Public: Returns true if the list is empty.
+    #
+    def empty?
+      @list.empty?
+    end
+
+    # Public: Returns the objects in the list in an Array.
+    #
+    def to_a
+      @list.dup
+    end
+  end
+end

data/lib/rapporteur/checker.rb

@@ -1,18 +1,16 @@
-require 'set'
-
 module Rapporteur
   # The center of the Rapporteur library, Checker manages holding and running
   # the custom checks, holding any application error messages, and provides the
   # controller with that data for rendering.
   #
   class Checker
-    include ActiveModel::Validations
     extend CheckerDeprecations
 
 
     def initialize
-      @messages = Hash.new
-      @checks = Set.new
+      @messages = MessageList.new(:messages)
+      @errors = MessageList.new(:errors)
+      @check_list = CheckList.new
       reset
     end
 
@@ -36,9 +34,9 @@ module Rapporteur
     #
     def add_check(object_or_nil_with_block=nil, &block)
       if block_given?
-        @checks << block
+        @check_list.add(block)
       elsif object_or_nil_with_block.respond_to?(:call)
-        @checks << object_or_nil_with_block
+        @check_list.add(object_or_nil_with_block)
       else
         raise ArgumentError, "A check must respond to #call."
       end
@@ -53,7 +51,7 @@ module Rapporteur
     # Returns self.
     #
     def clear
-      @checks.clear
+      @check_list.clear
       self
     end
 
@@ -78,7 +76,7 @@ module Rapporteur
     #
     def run
       reset
-      @checks.each do |object|
+      @check_list.each do |object|
         object.call(self)
         break if @halted
       end
@@ -106,9 +104,7 @@ module Rapporteur
     # Returns self.
     #
     def add_error(key, message, options={})
-      options[:scope] = [:rapporteur, :errors, key]
-      options[:default] = [message, message.to_s.humanize]
-      errors.add(key, message, options)
+      @errors.add(key, message)
       self
     end
 
@@ -128,7 +124,7 @@ module Rapporteur
     # Returns self.
     #
     def add_message(name, message)
-      @messages[name] = message
+      @messages.add(name, message)
       self
     end
 
@@ -136,7 +132,14 @@ module Rapporteur
     # Internal: Returns a hash of messages suitable for conversion into JSON.
     #
     def as_json(args={})
-      @messages
+      @messages.to_hash
+    end
+
+    ##
+    # Internal: Used by Rails' JSON serialization to render error messages.
+    #
+    def errors
+      @errors
     end
 
     ##
@@ -156,7 +159,7 @@ module Rapporteur
     def reset
       @halted = false
       @messages.clear
-      errors.clear
+      @errors.clear
     end
   end
 end

data/lib/rapporteur/message_list.rb

@@ -0,0 +1,129 @@
+require 'forwardable'
+require 'set'
+
+module Rapporteur
+  # A container of keys and one or more messages per key. This acts similarly
+  # to an ActiveModel::Errors collection from Ruby on Rails.
+  #
+  class MessageList
+    extend Forwardable
+
+
+    def_delegator :@messages, :clear
+    def_delegator :@messages, :empty?
+
+
+    # Public: Initialize a new MessageList instance.
+    #
+    # list_type - A Symbol representing the type of this list. This Symbol is
+    #             used to determine the structure of the I18n key used when
+    #             translating the given message Symbols.
+    #             Allowed values: :messages or :errors.
+    #
+    # Returns a MessageList instance.
+    #
+    def initialize(list_type)
+      @list_type = list_type
+      @messages = Hash.new { |hash, key| hash[key] = Set.new }
+    end
+
+
+    # Public: Adds a new message to the list for the given attribute.
+    #
+    # attribute - A Symbol describing the category, attribute, or name to which
+    #             the message pertains.
+    # message - A Symbol, String, or Proc which contains the message for the
+    #           attribute.
+    #
+    #           If a String is given, it is directly used for the message.
+    #
+    #           If a Symbol is given, it is used to lookup the full message
+    #           from I18n, under the "rapporteur.<list_type>.<message Symbol>"
+    #           key. For instance, if this is a :messages list, and the
+    #           attribute is :time, then I18n would be queried for
+    #           "rapporteur.messages.time".
+    #
+    #           If a Proc is given, it is `.call`'d with no parameters. The
+    #           return value from the Proc is directly used for the message.
+    #
+    # Examples
+    #
+    #     list.add(:time, '2013-08-23T12:34:00Z')
+    #     list.add(:time, :too_late)
+    #     list.add(:time, lambda { Time.now.iso8601 })
+    #
+    # Returns the MessageList instance.
+    #
+    def add(attribute, message)
+      @messages[attribute.to_sym].add(normalize_message(attribute, message))
+      self
+    end
+
+    # Public: Generates an Array containing the combination of all of the added
+    # attributes and their messages.
+    #
+    # Examples
+    #
+    #     list.add(:time, 'is now')
+    #     list.add(:time, 'is valuable')
+    #     list.add(:day, 'is today')
+    #     list.full_messages
+    #     # => ["time is now", "time is valuable", "day is today"]
+    #
+    # Returns an Array containing Strings of messages.
+    #
+    def full_messages
+      @messages.map { |attribute, attribute_messages|
+        attribute_messages.collect { |message| "#{attribute} #{message}" }
+      }.flatten
+    end
+
+    # Public: Returns the added attributes and their messages as a Hash, keyed
+    # by the attribute, with either an Array containing all of the added
+    # messages or just the single attribute message.
+    #
+    # Examples
+    #
+    #     list.add(:time, 'is now')
+    #     list.add(:time, 'is valuable')
+    #     list.add(:day, 'is today')
+    #     list.full_messages
+    #     # => {:time => ["is now", "is valuable"], :day => "is today"}
+    #
+    # Returns a Hash instance.
+    #
+    def to_hash
+      hash = Hash.new
+      @messages.each_pair do |key, value|
+        if value.size == 1
+          hash[key] = value.first
+        else
+          hash[key] = value.to_a
+        end
+      end
+      hash
+    end
+
+
+    private
+
+
+    def generate_message(key, type)
+      I18n.translate(type, {
+        :default => [type, type.to_s],
+        :scope => [:rapporteur, @list_type, key]
+      })
+    end
+
+    def normalize_message(attribute, message)
+      case message
+      when Symbol
+        generate_message(attribute, message)
+      when Proc
+        message.call
+      else
+        message
+      end
+    end
+  end
+end

data/lib/rapporteur/responder.rb

@@ -21,11 +21,11 @@ module Rapporteur
 
     if Rails::VERSION::MAJOR == 3 && Rails::VERSION::MINOR == 1
       def display_errors
-        controller.render format => {errors: resource.errors}, status: :internal_server_error
+        controller.render format => {:errors => resource.errors}, :status => :internal_server_error
       end
     else
       def display_errors
-        controller.render format => resource_errors, status: :internal_server_error
+        controller.render format => resource_errors, :status => :internal_server_error
       end
     end
   end

data/lib/rapporteur/rspec.rb

@@ -59,7 +59,7 @@ end
 RSpec::Matchers.define :include_status_message do |name, message|
   match do |response|
     @body = JSON.parse(response.body)
-    @body.has_key?(name) && @body.fetch(name) == message
+    @body.has_key?(name) && @body.fetch(name).include?(message)
   end
 
   failure_message_for_should do |actual|

data/lib/rapporteur/version.rb

@@ -1,3 +1,3 @@
 module Rapporteur
-  VERSION = "2.1.0"
+  VERSION = "3.0.0"
 end

data/rapporteur.gemspec

@@ -18,12 +18,12 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
+  spec.add_dependency 'i18n', '~> 0.6'
   spec.add_dependency 'railties', '>= 3.1', '< 4.1'
-  spec.add_dependency 'activesupport'
 
   spec.add_development_dependency "appraisal", "~> 0.5"
   spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "combustion", "~> 0.5"
+  spec.add_development_dependency "combustion", "~> 0.5", ">= 0.5.1"
   spec.add_development_dependency "rails", ">= 3.1", "< 4.1"
   spec.add_development_dependency "rspec-rails", "~> 2.11"
 end

data/spec/models/check_list_spec.rb

@@ -0,0 +1,59 @@
+require 'spec_helper'
+
+describe Rapporteur::CheckList do
+  let(:list) { described_class.new }
+
+  context '#add' do
+    it 'adds the given object to the list' do
+      list.add(check = double)
+      expect(list.to_a).to include(check)
+    end
+
+    it 'does not return duplicate entries' do
+      list.add(check = double)
+      list.add(check)
+      expect(list.to_a).to have(1).check
+    end
+  end
+
+  context '#clear' do
+    it 'empties the list of objects' do
+      list.add(double)
+      expect { list.clear }.to change(list, :empty?).to(true)
+    end
+  end
+
+  context '#each' do
+    it 'yields each contained object in the order added' do
+      list.add(check0 = double)
+      list.add(check1 = double)
+      list.add(check2 = double)
+      returns = Array.new
+
+      list.each do |object|
+        returns << object
+      end
+
+      expect(returns[0]).to equal(check0)
+      expect(returns[1]).to equal(check1)
+      expect(returns[2]).to equal(check2)
+    end
+
+    it 'returns itself' do
+      expect(list.each).to equal(list)
+    end
+  end
+
+  context '#to_a' do
+    it 'returns an Array' do
+      expect(list.to_a).to be_an(Array)
+    end
+
+    it 'returns new different but equivalent Array instances' do
+      return1 = list.to_a
+      return2 = list.to_a
+      expect(return1).to_not equal(return2)
+      expect(return1).to eq(return2)
+    end
+  end
+end

data/spec/models/message_list_spec.rb

@@ -0,0 +1,82 @@
+require 'spec_helper'
+
+describe Rapporteur::MessageList do
+  let(:list) { Rapporteur::MessageList.new(:errors) }
+
+  before { I18n.backend.reload! }
+
+  context '#add' do
+    it 'returns the MessageList instance.' do
+      expect(list.add(:test, 'message')).to equal(list)
+    end
+
+    it 'adds a String message to the #full_messages' do
+      list.add(:test, 'message')
+      expect(list.full_messages).to include('test message')
+    end
+
+    it 'adds unrecognized Symbols as Strings to the #full_messages' do
+      list.add(:test, :message)
+      expect(list.full_messages).to include('test message')
+    end
+
+    it 'adds multiple messages to an attribute' do
+      list.add(:test, 'message 1')
+      list.add(:test, 'message 2')
+      expect(list.full_messages).to include('test message 1')
+      expect(list.full_messages).to include('test message 2')
+    end
+
+    it 'translates and adds recognized I18n keys in the #full_messages' do
+      add_translation(:errors, :test, :i18n_message, 'translated')
+      list.add(:test, :i18n_message)
+      expect(list.full_messages).to include('test translated')
+    end
+
+    it 'translates based on the initialized list type' do
+      add_translation(:string, :test, :i18n_message, 'strings')
+      add_translation(:messages, :test, :i18n_message, 'messages')
+      add_translation(:errors, :test, :i18n_message, 'errors')
+      message_list = Rapporteur::MessageList.new(:messages)
+      error_list = Rapporteur::MessageList.new(:errors)
+      message_list.add(:test, :i18n_message)
+      error_list.add(:test, :i18n_message)
+      expect(message_list.full_messages).to include('test messages')
+      expect(message_list.full_messages).not_to include('test errors')
+      expect(error_list.full_messages).to include('test errors')
+      expect(error_list.full_messages).not_to include('test messages')
+    end
+  end
+
+  context '#to_hash' do
+    it 'flattens key/value pairs with only one value' do
+      list.add(:test, 'message')
+      expect(list.to_hash).to eq({:test => 'message'})
+    end
+
+    it 'retains multiple values for a single key' do
+      list.add(:test, 'message1')
+      list.add(:test, 'message2')
+      result = list.to_hash
+      expect(result).to have_key(:test)
+      expect(result[:test]).to include('message1')
+      expect(result[:test]).to include('message2')
+    end
+
+    it 'returns a new, unique, but equivalent Hash with each call' do
+      list.add(:test, 'message')
+      return1 = list.to_hash
+      return2 = list.to_hash
+      expect(return1).not_to equal(return2)
+      expect(return1).to eq(return2)
+    end
+  end
+
+
+  private
+
+
+  def add_translation(type, key, message, string)
+    I18n.backend.store_translations('en', {:rapporteur => {type.to_sym => {key.to_sym => {message.to_sym => string}}}})
+  end
+end

data/spec/requests/revision_check_spec.rb

@@ -2,6 +2,7 @@ require 'spec_helper'
 
 describe 'A status request with a RevisionCheck' do
   before do
+    Rapporteur::Revision.stub(:current) { 'revisionidentifier' }
     Rapporteur.add_check(Rapporteur::Checks::RevisionCheck)
   end
 
@@ -10,10 +11,8 @@ describe 'A status request with a RevisionCheck' do
   it_behaves_like 'a successful status response'
 
   context 'the response payload' do
-    subject { get(status_path) ; JSON.parse(response.body) }
-
     it 'contains the current application revision' do
-      expect(subject.fetch('revision')).to(match(/^[a-f0-9]{40}$/))
+      expect(subject).to include_status_message('revision', 'revisionidentifier')
     end
   end
 end

data/spec/requests/time_check_spec.rb

@@ -10,13 +10,9 @@ describe 'A status request with a TimeCheck' do
   it_behaves_like 'a successful status response'
 
   context 'the response payload' do
-    subject { get(status_path) ; JSON.parse(response.body) }
-
-    it 'contains the current time in ISO8601' do
-      time = Time.now
-      Time.stub(:now).and_return(time)
-      expect(subject.fetch('time')).to(match(/^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z$/))
-      expect(subject.fetch('time')).to(eq(time.utc.iso8601))
+    it 'contains the time in ISO8601' do
+      Time.stub(:now).and_return(Time.gm(2013,8,23))
+      expect(subject).to include_status_message('time', Time.gm(2013,8,23).iso8601)
     end
   end
 end

data/spec/routing/routes_spec.rb

@@ -2,22 +2,22 @@ require 'spec_helper.rb'
 
 describe "status routes" do
   it 'routes /status.json to statuses#show' do
-    expect({ get: '/status.json'}).to route_to({
-      action: 'show',
-      controller: 'statuses',
-      format: 'json',
+    expect({ :get => '/status.json'}).to route_to({
+      :action => 'show',
+      :controller => 'statuses',
+      :format => 'json',
     })
   end
 
   it 'does not route /status' do
-    expect({ get: '/status'}).to_not be_routable
+    expect({ :get => '/status'}).to_not be_routable
   end
 
   it 'does not route /status.html' do
-    expect({ get: '/status.html'}).to_not be_routable
+    expect({ :get => '/status.html'}).to_not be_routable
   end
 
   it 'does not route /status.xml' do
-    expect({ get: '/status.xml'}).to_not be_routable
+    expect({ :get => '/status.xml'}).to_not be_routable
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rapporteur
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 3.0.0
 platform: ruby
 authors:
 - Envy Labs
@@ -9,42 +9,42 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-29 00:00:00.000000000 Z
+date: 2013-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: railties
+  name: i18n
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '3.1'
-    - - <
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '0.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '3.1'
-    - - <
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '0.6'
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: railties
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.1'
+    - - <
+      - !ruby/object:Gem::Version
+        version: '4.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.1'
+    - - <
+      - !ruby/object:Gem::Version
+        version: '4.1'
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement
@@ -80,6 +80,9 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.5'
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.5.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -87,6 +90,9 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.5'
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.5.1
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
@@ -145,11 +151,13 @@ files:
 - gemfiles/rails3.2.gemfile
 - gemfiles/rails4.0.gemfile
 - lib/rapporteur.rb
+- lib/rapporteur/check_list.rb
 - lib/rapporteur/checker.rb
 - lib/rapporteur/checker_deprecations.rb
 - lib/rapporteur/checks.rb
 - lib/rapporteur/checks/active_record_check.rb
 - lib/rapporteur/engine.rb
+- lib/rapporteur/message_list.rb
 - lib/rapporteur/responder.rb
 - lib/rapporteur/revision.rb
 - lib/rapporteur/rspec.rb
@@ -160,6 +168,8 @@ files:
 - spec/internal/db/schema.rb
 - spec/internal/log/.gitignore
 - spec/internal/public/favicon.ico
+- spec/models/check_list_spec.rb
+- spec/models/message_list_spec.rb
 - spec/requests/active_record_check_spec.rb
 - spec/requests/halt_spec.rb
 - spec/requests/messsage_addition_spec.rb
@@ -188,7 +198,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.0.7
 signing_key: 
 specification_version: 4
 summary: An engine that provides common status polling endpoint.
@@ -198,6 +208,8 @@ test_files:
 - spec/internal/db/schema.rb
 - spec/internal/log/.gitignore
 - spec/internal/public/favicon.ico
+- spec/models/check_list_spec.rb
+- spec/models/message_list_spec.rb
 - spec/requests/active_record_check_spec.rb
 - spec/requests/halt_spec.rb
 - spec/requests/messsage_addition_spec.rb