rapns_rails_2 3.5.1 → 3.6.1

data/spec/unit/daemon/apns/delivery_handler_spec.rb

@@ -1,59 +0,0 @@
-require File.expand_path("spec/unit_spec_helper")
-require File.dirname(__FILE__) + '/../delivery_handler_shared.rb'
-
-describe Rapns::Daemon::Apns::DeliveryHandler do
-  it_should_behave_like 'an DeliveryHandler subclass'
-
-  let(:host) { 'gateway.push.apple.com' }
-  let(:port) { 2195 }
-  let(:certificate) { double }
-  let(:password) { double }
-  let(:app) { double(:password => password, :certificate => certificate, :name => 'MyApp', :environment => 'production')}
-  let(:delivery_handler) { Rapns::Daemon::Apns::DeliveryHandler.new(app) }
-  let(:connection) { double(:connection, :select => false, :write => nil, :reconnect => nil, :close => nil, :connect => nil) }
-  let(:notification) { double(:notification) }
-  let(:batch) { double(:batch, :notification_processed => nil) }
-  let(:http) { double(:http, :shutdown => nil)}
-  let(:queue) { Queue.new }
-  let(:delivery) { double(:perform => nil) }
-
-  before do
-    Rapns::Daemon::Apns::Connection.stub(:new => connection)
-    Rapns::Daemon::Apns::Delivery.stub(:new => delivery)
-    delivery_handler.queue = queue
-    queue.push([notification, batch])
-  end
-
-  def run_delivery_handler
-    delivery_handler.start
-    delivery_handler.stop
-    delivery_handler.wakeup
-    delivery_handler.wait
-  end
-
-  it "instantiates a new connection" do
-    Rapns::Daemon::Apns::Connection.should_receive(:new).with(app, host, port)
-    run_delivery_handler
-  end
-
-  it "connects the socket" do
-    connection.should_receive(:connect)
-    run_delivery_handler
-  end
-
-  it 'performs delivery of an notification' do
-    Rapns::Daemon::Apns::Delivery.should_receive(:new).with(app, connection, notification, batch).and_return(delivery)
-    delivery.should_receive(:perform)
-    run_delivery_handler
-  end
-
-  it 'closes the connection stopped' do
-    connection.should_receive(:close)
-    run_delivery_handler
-  end
-
-  it 'does not attempt to close the connection if the connection was not established' do
-    connection.should_not_receive(:close)
-    delivery_handler.stop
-  end
-end

data/spec/unit/daemon/apns/delivery_spec.rb

@@ -1,101 +0,0 @@
-require File.expand_path("spec/unit_spec_helper")
-
-describe Rapns::Daemon::Apns::Delivery do
-  let(:app) { double(:name => 'MyApp') }
-  let(:notification) { double(:id => 123).as_null_object }
-  let(:batch) { double(:mark_failed => nil, :mark_delivered => nil) }
-  let(:logger) { double(:error => nil, :info => nil) }
-  let(:config) { double(:check_for_errors => true) }
-  let(:connection) { double(:select => false, :write => nil, :reconnect => nil, :close => nil, :connect => nil) }
-  let(:delivery) { Rapns::Daemon::Apns::Delivery.new(app, connection, notification, batch) }
-
-  def perform
-    begin
-      delivery.perform
-    rescue Rapns::DeliveryError, Rapns::Apns::DisconnectionError
-    end
-  end
-
-  before do
-    Rapns.stub(:config => config, :logger => logger)
-  end
-
-  it "sends the binary version of the notification" do
-    notification.stub(:to_binary => "hi mom")
-    connection.should_receive(:write).with("hi mom")
-    perform
-  end
-
-  it "logs the notification delivery" do
-    notification.stub(:id => 666, :device_token => 'abc123')
-    logger.should_receive(:info).with("[MyApp] 666 sent to abc123")
-    perform
-  end
-
-  it "marks the notification as delivered" do
-    batch.should_receive(:mark_delivered).with(notification)
-    perform
-  end
-
-  it 'does not check for errors if check_for_errors config option is false' do
-    config.stub(:check_for_errors => false)
-    delivery.should_not_receive(:check_for_error)
-    perform
-  end
-
-  describe "when delivery fails" do
-    before { connection.stub(:select => true, :read => [8, 4, 69].pack("ccN")) }
-
-    it "marks the notification as failed" do
-      batch.should_receive(:mark_failed).with(notification, 4, "Missing payload")
-      perform
-    end
-
-    it "logs the delivery error" do
-      # checking for the doublebed error doesn't work in jruby, but checking
-      # for the exception by class does.
-
-      #error = Rapns::DeliveryError.new(4, 12, "Missing payload")
-      #Rapns::DeliveryError.stub(:new => error)
-      #expect { delivery.perform }.to raise_error(error)
-
-      expect { delivery.perform }.to raise_error(Rapns::DeliveryError)
-    end
-
-    it "reads 6 bytes from the socket" do
-      connection.should_receive(:read).with(6).and_return(nil)
-      perform
-    end
-
-    it "does not attempt to read from the socket if the socket was not selected for reading after the timeout" do
-      connection.stub(:select => nil)
-      connection.should_not_receive(:read)
-      perform
-    end
-
-    it "reconnects the socket" do
-      connection.should_receive(:reconnect)
-      perform
-    end
-
-    it "logs that the connection is being reconnected" do
-      Rapns.logger.should_receive(:error).with("[MyApp] Error received, reconnecting...")
-      perform
-    end
-
-    context "when the APNs disconnects without returning an error" do
-      before do
-        connection.stub(:read => nil)
-      end
-
-      it 'raises a DisconnectError error if the connection is closed without an error being returned' do
-        expect { delivery.perform }.to raise_error(Rapns::Apns::DisconnectionError)
-      end
-
-      it 'marks the notification as failed' do
-        batch.should_receive(:mark_failed).with(notification, nil, "APNs disconnected without returning an error.")
-        perform
-      end
-    end
-  end
-end

data/spec/unit/daemon/apns/disconnection_error_spec.rb

@@ -1,18 +0,0 @@
-require File.expand_path("spec/unit_spec_helper")
-
-describe Rapns::Apns::DisconnectionError do
-  let(:error) { Rapns::Apns::DisconnectionError.new }
-
-  it 'returns a nil error code' do
-    error.code.should be_nil
-  end
-
-  it 'contains an error description' do
-    error.description
-  end
-
-  it 'returns a message' do
-    error.message
-    error.to_s
-  end
-end

data/spec/unit/daemon/apns/feedback_receiver_spec.rb

@@ -1,134 +0,0 @@
-require File.expand_path("spec/unit_spec_helper")
-
-describe Rapns::Daemon::Apns::FeedbackReceiver, 'check_for_feedback' do
-
-  let(:host) { 'feedback.push.apple.com' }
-  let(:port) { 2196 }
-  let(:poll) { 60 }
-  let(:certificate) { double }
-  let(:password) { double }
-  let(:app) { double(:name => 'my_app', :password => password, :certificate => certificate, :environment => 'production') }
-  let(:connection) { double(:connect => nil, :read => nil, :close => nil) }
-  let(:logger) { double(:error => nil, :info => nil) }
-  let(:receiver) { Rapns::Daemon::Apns::FeedbackReceiver.new(app, poll) }
-  let(:feedback) { double }
-
-  before do
-    receiver.stub(:interruptible_sleep)
-    Rapns.stub(:logger => logger)
-    Rapns::Daemon::Apns::Connection.stub(:new => connection)
-    receiver.instance_variable_set("@stop", false)
-    Rapns::Daemon.stub(:store => double(:create_apns_feedback => feedback))
-  end
-
-  def double_connection_read_with_tuple
-    connection.unstub(:read)
-
-    def connection.read(bytes)
-      if !@called
-        @called = true
-        "N\xE3\x84\r\x00 \x83OxfU\xEB\x9F\x84aJ\x05\xAD}\x00\xAF1\xE5\xCF\xE9:\xC3\xEA\a\x8F\x1D\xA4M*N\xB0\xCE\x17"
-      end
-    end
-  end
-
-  it 'instantiates a new connection' do
-    Rapns::Daemon::Apns::Connection.should_receive(:new).with(app, host, port)
-    receiver.check_for_feedback
-  end
-
-  it 'connects to the feeback service' do
-    connection.should_receive(:connect)
-    receiver.check_for_feedback
-  end
-
-  it 'closes the connection' do
-    connection.should_receive(:close)
-    receiver.check_for_feedback
-  end
-
-  it 'reads from the connection' do
-    connection.should_receive(:read).with(38)
-    receiver.check_for_feedback
-  end
-
-  it 'logs the feedback' do
-    double_connection_read_with_tuple
-    Rapns.logger.should_receive(:info).with("[my_app] [FeedbackReceiver] Delivery failed at 2011-12-10 16:08:45 UTC for 834f786655eb9f84614a05ad7d00af31e5cfe93ac3ea078f1da44d2a4eb0ce17.")
-    receiver.check_for_feedback
-  end
-
-  it 'creates the feedback' do
-    Rapns::Daemon.store.should_receive(:create_apns_feedback).with(Time.at(1323533325), '834f786655eb9f84614a05ad7d00af31e5cfe93ac3ea078f1da44d2a4eb0ce17', app)
-    double_connection_read_with_tuple
-    receiver.check_for_feedback
-  end
-
-  it 'logs errors' do
-    error = StandardError.new('bork!')
-    connection.stub(:read).and_raise(error)
-    Rapns.logger.should_receive(:error).with(error)
-    receiver.check_for_feedback
-  end
-
-  it 'sleeps for the feedback poll period' do
-    receiver.stub(:check_for_feedback)
-    sleeper = double(Rapns::Daemon::InterruptibleSleep, :sleep => false)
-    sleeper.should_receive(:sleep).with(60).at_least(:once)
-    receiver.stub :interruptible_sleep => sleeper
-    Thread.stub(:new).and_yield
-    receiver.stub(:loop).and_yield
-    receiver.start
-  end
-
-  it 'checks for feedback when started' do
-    sleeper = double(Rapns::Daemon::InterruptibleSleep, :sleep => false)
-    receiver.stub :interruptible_sleep => sleeper
-    receiver.should_receive(:check_for_feedback).at_least(:once)
-    Thread.stub(:new).and_yield
-    receiver.stub(:loop).and_yield
-    receiver.start
-  end
-
-  it 'interrupts sleep when stopped' do
-    sleeper = double(Rapns::Daemon::InterruptibleSleep, :sleep => false)
-    receiver.stub :interruptible_sleep => sleeper
-    receiver.stub(:check_for_feedback)
-    sleeper.should_receive(:interrupt_sleep)
-    receiver.stop
-  end
-
-  it 'reflects feedback was received' do
-    double_connection_read_with_tuple
-    receiver.should_receive(:reflect).with(:apns_feedback, feedback)
-    receiver.check_for_feedback
-  end
-
-  it 'calls the apns_feedback_callback when feedback is received and the callback is set' do
-    double_connection_read_with_tuple
-    Rapns.config.apns_feedback_callback = Proc.new {}
-    Rapns.config.apns_feedback_callback.should_receive(:call).with(feedback)
-    receiver.check_for_feedback
-  end
-
-  it 'catches exceptions in the apns_feedback_callback' do
-    error = StandardError.new('bork!')
-    double_connection_read_with_tuple
-    callback = Proc.new { raise error }
-    Rapns::Deprecation.muted do
-      Rapns.config.on_apns_feedback &callback
-    end
-    lambda { receiver.check_for_feedback }.should_not raise_error
-  end
-
-  it 'logs an exception from the apns_feedback_callback' do
-    error = StandardError.new('bork!')
-    double_connection_read_with_tuple
-    callback = Proc.new { raise error }
-    Rapns.logger.should_receive(:error).with(error)
-    Rapns::Deprecation.muted do
-      Rapns.config.on_apns_feedback &callback
-    end
-    receiver.check_for_feedback
-  end
-end

data/spec/unit/daemon/app_runner_shared.rb

@@ -1,83 +0,0 @@
-shared_examples_for "an AppRunner subclass" do
-  let(:queue) { double(:push => nil) }
-
-  before { Queue.stub(:new => queue) }
-  after { Rapns::Daemon::AppRunner.runners.clear }
-
-  describe 'start' do
-    it 'starts a delivery handler for each connection' do
-      handler.should_receive(:start)
-      runner.start
-    end
-
-    it 'adds the delivery handler to the collection' do
-      handler_collection.should_receive(:push).with(handler)
-      runner.start
-    end
-
-    it 'assigns the queue to the handler' do
-      handler.should_receive(:queue=).with(queue)
-      runner.start
-    end
-  end
-
-  describe 'enqueue' do
-    let(:notification) { double }
-    let(:batch) { double(:notifications => [notification]) }
-
-    it 'enqueues the batch' do
-      queue.should_receive(:push).with([notification, batch])
-      runner.enqueue(batch)
-    end
-
-    it 'reflects the notification has been enqueued' do
-      runner.should_receive(:reflect).with(:notification_enqueued, notification)
-      runner.enqueue(batch)
-    end
-  end
-
-  describe 'stop' do
-    before { runner.start }
-
-    it 'stops the delivery handlers' do
-      handler_collection.should_receive(:stop)
-      runner.stop
-    end
-  end
-
-  describe 'idle?' do
-    it 'is idle if all notifications have been processed' do
-      runner.batch = double(:complete? => true)
-      runner.idle?.should be_true
-    end
-
-    it 'is idle if the runner has no associated batch' do
-      runner.batch = nil
-      runner.idle?.should be_true
-    end
-
-    it 'is not idle if not all notifications have been processed' do
-      runner.batch = double(:complete? => false)
-      runner.idle?.should be_false
-    end
-  end
-
-  describe 'sync' do
-    before { runner.start }
-
-    it 'reduces the number of handlers if needed' do
-      handler_collection.should_receive(:pop)
-      new_app = app_class.new
-      new_app.stub(:connections => app.connections - 1)
-      runner.sync(new_app)
-    end
-
-    it 'increases the number of handlers if needed' do
-      runner.should_receive(:start_handler).and_return(handler)
-      handler_collection.should_receive(:push).with(handler)
-      new_app = app_class.new
-      new_app.stub(:connections => app.connections + 1)
-      runner.sync(new_app)
-    end
-  end
-end

data/spec/unit/daemon/app_runner_spec.rb

@@ -1,170 +0,0 @@
-require File.expand_path("spec/unit_spec_helper")
-
-describe Rapns::Daemon::AppRunner, 'stop' do
-  let(:runner) { double }
-  before { Rapns::Daemon::AppRunner.runners['app'] = runner }
-  after { Rapns::Daemon::AppRunner.runners.clear }
-
-  it 'stops all runners' do
-    runner.should_receive(:stop)
-    Rapns::Daemon::AppRunner.stop
-  end
-end
-
-describe Rapns::Daemon::AppRunner, 'enqueue' do
-  let(:runner) { double(:enqueue => nil) }
-  let(:notification1) { double(:app_id => 1) }
-  let(:notification2) { double(:app_id => 2) }
-  let(:logger) { double(:error => nil) }
-
-  before do
-    Rapns.stub(:logger => logger)
-    Rapns::Daemon::AppRunner.runners[1] = runner
-  end
-
-  after { Rapns::Daemon::AppRunner.runners.clear }
-
-  it 'batches notifications by app' do
-    batch = double
-    batch.stub!(:describe)
-    Rapns::Daemon::Batch.stub(:new => batch)
-    Rapns::Daemon::Batch.should_receive(:new).with([notification1])
-    Rapns::Daemon::Batch.should_receive(:new).with([notification2])
-    Rapns::Daemon::AppRunner.enqueue([notification1, notification2])
-  end
-
-  it 'enqueues each batch' do
-    runner.should_receive(:enqueue).with(kind_of(Rapns::Daemon::Batch))
-    Rapns::Daemon::AppRunner.enqueue([notification1])
-  end
-
-  it 'logs an error if there is no runner to deliver the notification' do
-    notification1.stub(:app_id => 2, :id => 123)
-    notification2.stub(:app_id => 2, :id => 456)
-    logger.should_receive(:error).with("No such app '#{notification1.app_id}' for notifications 123, 456.")
-    Rapns::Daemon::AppRunner.enqueue([notification1, notification2])
-  end
-end
-
-describe Rapns::Daemon::AppRunner, 'sync' do
-  let(:app) { Rapns::Apns::App.new }
-  let(:new_app) { Rapns::Apns::App.new }
-  let(:runner) { double(:sync => nil, :stop => nil, :start => nil) }
-  let(:logger) { double(:error => nil, :warn => nil) }
-  let(:queue) { Queue.new }
-
-  before do
-    app.stub(:id => 1)
-    new_app.stub(:id => 2)
-    Queue.stub(:new => queue)
-    Rapns::Daemon::AppRunner.runners[app.id] = runner
-    Rapns::App.stub(:all => [app])
-    Rapns.stub(:logger => logger)
-  end
-
-  after { Rapns::Daemon::AppRunner.runners.clear }
-
-  it 'loads all apps' do
-    Rapns::App.should_receive(:all)
-    Rapns::Daemon::AppRunner.sync
-  end
-
-  it 'instructs existing runners to sync' do
-    runner.should_receive(:sync).with(app)
-    Rapns::Daemon::AppRunner.sync
-  end
-
-  it 'starts a runner for a new app' do
-    Rapns::App.stub(:all => [app, new_app])
-    new_runner = double
-    Rapns::Daemon::Apns::AppRunner.should_receive(:new).with(new_app).and_return(new_runner)
-    new_runner.should_receive(:start)
-    Rapns::Daemon::AppRunner.sync
-  end
-
-  it 'deletes old apps' do
-    Rapns::App.stub(:all => [])
-    runner.should_receive(:stop)
-    Rapns::Daemon::AppRunner.sync
-  end
-
-  it 'logs an error if the app could not be started' do
-    Rapns::App.stub(:all => [app, new_app])
-    new_runner = double
-    Rapns::Daemon::Apns::AppRunner.should_receive(:new).with(new_app).and_return(new_runner)
-    new_runner.stub(:start).and_raise(StandardError)
-    Rapns.logger.should_receive(:error)
-    Rapns::Daemon::AppRunner.sync
-  end
-
-  it 'reflects errors if the app could not be started' do
-    Rapns::App.stub(:all => [app, new_app])
-    new_runner = double
-    Rapns::Daemon::Apns::AppRunner.should_receive(:new).with(new_app).and_return(new_runner)
-    e = StandardError.new
-    new_runner.stub(:start).and_raise(e)
-    Rapns::Daemon::AppRunner.should_receive(:reflect).with(:error, e)
-    Rapns::Daemon::AppRunner.sync
-  end
-end
-
-describe Rapns::Daemon::AppRunner, 'debug' do
-  let!(:app) { Rapns::Apns::App.create!(:name => 'test', :connections => 1,
-    :environment => 'development', :certificate => TEST_CERT) }
-  let(:logger) { double(:info => nil) }
-
-  before do
-    Rapns::Daemon.stub(:config => {})
-    Rapns::Daemon::Apns::FeedbackReceiver.stub(:new => double.as_null_object)
-    Rapns::Daemon::Apns::Connection.stub(:new => double.as_null_object)
-    Rapns.stub(:logger => logger)
-    Rapns::Daemon::AppRunner.sync
-  end
-
-  after { Rapns::Daemon::AppRunner.runners.clear }
-
-  it 'prints debug app states to the log' do
-    Rapns.logger.should_receive(:info).with("\ntest:\n  handlers: 1\n  queued: 0\n  batch size: 0\n  batch processed: 0\n  idle: true\n")
-    Rapns::Daemon::AppRunner.debug
-  end
-end
-
-describe Rapns::Daemon::AppRunner, 'idle' do
-  let!(:app) { Rapns::Apns::App.create!(:name => 'test', :connections => 1,
-    :environment => 'development', :certificate => TEST_CERT) }
-  let(:logger) { double(:info => nil) }
-
-  before do
-    Rapns.stub(:logger => logger)
-    Rapns::Daemon::Apns::FeedbackReceiver.stub(:new => double.as_null_object)
-    Rapns::Daemon::Apns::Connection.stub(:new => double.as_null_object)
-    Rapns::Daemon::AppRunner.sync
-  end
-
-  after { Rapns::Daemon::AppRunner.runners.clear }
-
-  it 'returns idle runners' do
-    runner = Rapns::Daemon::AppRunner.runners[app.id]
-    Rapns::Daemon::AppRunner.idle.should == [runner]
-  end
-end
-
-describe Rapns::Daemon::AppRunner, 'wait' do
-  let!(:app) { Rapns::Apns::App.create!(:name => 'test', :connections => 1,
-    :environment => 'development', :certificate => TEST_CERT) }
-  let(:logger) { double(:info => nil) }
-
-  before do
-    Rapns.stub(:logger => logger)
-    Rapns::Daemon::Apns::FeedbackReceiver.stub(:new => double.as_null_object)
-    Rapns::Daemon::Apns::Connection.stub(:new => double.as_null_object)
-    Rapns::Daemon::AppRunner.sync
-  end
-
-  after { Rapns::Daemon::AppRunner.runners.clear }
-
-  it 'waits until all runners are idle' do
-    Rapns::Daemon::AppRunner.runners.count.should == 1
-    Timeout.timeout(5) { Rapns::Daemon::AppRunner.wait }
-  end
-end