rapidfire 4.0.0 → 8.0.0

data/spec/dummy/tmp/storage--ruby-3.3.5/81/2n/812ne4iy4c40lvvdigsg8z02b1v1

@@ -0,0 +1 @@
+one

data/spec/dummy/tmp/storage--ruby-3.3.5/85/bs/85bsmaecej0491dey4t9jpci9yw3

@@ -0,0 +1 @@
+one

data/spec/dummy/tmp/storage--ruby-3.3.5/8y/7b/8y7bhqwxh5cad8xau7nfhtukxcsc

@@ -0,0 +1 @@
+two

data/spec/dummy/tmp/storage--ruby-3.3.5/93/z6/93z6nje4f921vgdwa3lkuf49xocr

@@ -0,0 +1 @@
+one

data/spec/dummy/tmp/storage--ruby-3.3.5/at/qk/atqksrev4s0ic4srii57aspu4o6z

@@ -0,0 +1 @@
+one

data/spec/dummy/tmp/storage--ruby-3.3.5/bi/j3/bij3puzjsfm39colnpqstpu6ggv7

@@ -0,0 +1 @@
+one

data/spec/dummy/tmp/storage--ruby-3.3.5/cx/4p/cx4pp9ugdv2xndwll28mo8jhjgig

@@ -0,0 +1 @@
+two

data/spec/dummy/tmp/storage--ruby-3.3.5/gv/9c/gv9cand9rqcew9sceoirbfm9l2bl

@@ -0,0 +1 @@
+two

data/spec/dummy/tmp/storage--ruby-3.3.5/m2/ce/m2cehdwpmdl0s5vgylxc1tcbxlr2

@@ -0,0 +1 @@
+one

data/spec/dummy/tmp/storage--ruby-3.3.5/md/rj/mdrjgxirkdtyfijfwdxn37dswspm

@@ -0,0 +1 @@
+one

data/spec/dummy/tmp/storage--ruby-3.3.5/xv/oi/xvoijswvk9a0blrua7x5yl94a6qw

@@ -0,0 +1 @@
+one

data/spec/dummy/tmp/storage--ruby-3.3.5/z6/cw/z6cw41euxe15z3ao5wkypp0y9liw

@@ -0,0 +1 @@
+two

data/spec/factories/answers_factory.rb

@@ -1,7 +1,7 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :answer, :class => "Rapidfire::Answer" do
-    attempt  { FactoryGirl.create(:attempt) }
-    question      { FactoryGirl.create(:q_long)       }
-    answer_text   "hello world"
+    attempt  { FactoryBot.create(:attempt) }
+    question      { FactoryBot.create(:q_long)       }
+    answer_text   { "hello world" }
   end
 end

data/spec/factories/attempts_factory.rb

@@ -1,5 +1,5 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :attempt, :class => "Rapidfire::Attempt" do
-    survey  { FactoryGirl.create(:survey) }
+    survey  { FactoryBot.create(:survey) }
   end
 end

data/spec/factories/questions_factory.rb

@@ -1,10 +1,10 @@
-FactoryGirl.define do
-  factory :question do
-    survey  { FactoryGirl.create(:survey) }
-    question_text   "Sample Question"
+FactoryBot.define do
+  factory :question, :class => "Rapidfire::Question" do
+    survey  { FactoryBot.create(:survey) }
+    question_text   { "Sample Question" }
 
     factory :q_checkbox, :class => "Rapidfire::Questions::Checkbox" do
-      answer_options  "hindi\r\ntelugu\r\nkannada\r\n"
+      answer_options  { "hindi\r\ntelugu\r\nkannada\r\n" }
     end
 
     factory :q_date, :class => "Rapidfire::Questions::Date" do
@@ -17,14 +17,20 @@ FactoryGirl.define do
     end
 
     factory :q_radio, :class => "Rapidfire::Questions::Radio" do
-      answer_options  "male\r\nfemale\r\n"
+      answer_options  { "male\r\nfemale\r\n" }
     end
 
     factory :q_select, :class => "Rapidfire::Questions::Select" do
-      answer_options  "mac\r\nwindows\r\n"
+      answer_options  { "mac\r\nwindows\r\n" }
     end
 
     factory :q_short, :class => "Rapidfire::Questions::Short" do
     end
+
+    factory :q_file, :class => "Rapidfire::Questions::File" do
+    end
+
+    factory :q_multifile, :class => "Rapidfire::Questions::MultiFile" do
+    end
   end
 end

data/spec/factories/surveys_factory.rb

@@ -1,6 +1,6 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :survey, :class => "Rapidfire::Survey" do
-    name  "Test Survey"
-    introduction "Please answer all the questions in this survey."
+    name  { "Test Survey" }
+    introduction { "Please answer all the questions in this survey." }
   end
 end

data/spec/factories/users_factory.rb

@@ -0,0 +1,5 @@
+FactoryBot.define do
+  factory :user do
+    name  { "Test User" }
+  end
+end

data/spec/features/rapidfire/answering_questions_spec.rb

@@ -1,21 +1,24 @@
 require 'spec_helper'
 
 describe "Surveys" do
-  let!(:survey) { FactoryGirl.create(:survey, name: "Question Set", introduction: "Some introduction") }
-  let!(:question1) { FactoryGirl.create(:q_long,  survey: survey, question_text: "Long Question", validation_rules: { presence: "1" })  }
-  let!(:question2) { FactoryGirl.create(:q_short, survey: survey, question_text: "Short Question") }
-  let!(:question3) { FactoryGirl.create(:q_checkbox, survey: survey, question_text: "Checkbox question") }
-  let!(:question4) { FactoryGirl.create(:q_checkbox, survey: survey, question_text: "Checkbox question", validation_rules: { presence: "1" }) }
+  let!(:survey) { FactoryBot.create(:survey, name: "Question Set", introduction: "Some introduction") }
 
-  before do
+  it "displays survey introduction" do
     visit rapidfire.new_survey_attempt_path(survey)
-  end
 
-  it "displays survey introduction" do
     expect(page).to have_content "Some introduction"
   end
 
   describe "Answering Questions" do
+    let!(:question1) { FactoryBot.create(:q_long,  survey: survey, question_text: "Long Question", validation_rules: { presence: "1" })  }
+    let!(:question2) { FactoryBot.create(:q_short, survey: survey, question_text: "Short Question") }
+    let!(:question3) { FactoryBot.create(:q_checkbox, survey: survey, question_text: "Checkbox question") }
+    let!(:question4) { FactoryBot.create(:q_checkbox, survey: survey, question_text: "Checkbox question", validation_rules: { presence: "1" }) }
+
+    before do
+      visit rapidfire.new_survey_attempt_path(survey)
+    end
+
     context "when all questions are answered" do
       before do
         fill_in "attempt_#{question1.id}_answer_text", with: "Long Answer"
@@ -53,7 +56,7 @@ describe "Surveys" do
         end
 
         it "shows error for missing answers" do
-          expect(page).to have_content("can't be blank", count: 2)
+          expect(page).to have_content("can't be blank", count: 3)
         end
 
         it "shows already populated answers" do
@@ -85,4 +88,58 @@ describe "Surveys" do
       end
     end
   end
+
+  if "#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}" >= "5.2"
+    describe "Answering File uploads" do
+      context "when the question is single file upload" do
+        let!(:question1) { FactoryBot.create(:q_file,  survey: survey, question_text: "Avatar")  }
+
+        it "persistes the file" do
+          visit rapidfire.new_survey_attempt_path(survey)
+
+          attach_file "attempt_#{question1.id}_file", file_fixture("one.txt")
+          click_button "Save"
+
+          answer = Rapidfire::Answer.first
+          expect(answer).to be_persisted
+          expect(answer.file.download).to eq("one\n")
+        end
+      end
+
+      context "when the question is multi file upload" do
+        let!(:question1) { FactoryBot.create(:q_multifile,  survey: survey, question_text: "Images")  }
+
+        it "persistes the file" do
+          visit rapidfire.new_survey_attempt_path(survey)
+
+          attach_file "attempt_#{question1.id}_files", [file_fixture("one.txt"), file_fixture("two.txt")]
+          click_button "Save"
+
+          answer = Rapidfire::Answer.first
+          expect(answer).to be_persisted
+          expect(answer.files.length).to eq 2
+
+          expect(answer.files[0].download).to eq("two\n")
+          expect(answer.files[1].download).to eq("one\n")
+        end
+      end
+
+      context "when persisting a file fails" do
+        let!(:question1) { FactoryBot.create(:q_file,  survey: survey, question_text: "Avatar")  }
+
+        it "bubbles up the error" do
+          visit rapidfire.new_survey_attempt_path(survey)
+
+          expect_any_instance_of(Rapidfire::Answer).to receive("file_attachment=") do
+            raise ActiveRecord::ActiveRecordError.new("Can't save the file")
+          end
+
+          attach_file "attempt_#{question1.id}_file", file_fixture("one.txt")
+          click_button "Save"
+
+          expect(page).to have_content("Can't save the file")
+        end
+      end
+    end
+  end
 end

data/spec/features/rapidfire/editing_answers_spec.rb

@@ -1,12 +1,12 @@
 require 'spec_helper'
 
 describe "Surveys" do
-  let(:survey)  { FactoryGirl.create(:survey, name: "Question Set") }
-  let(:question1)  { FactoryGirl.create(:q_long,  survey: survey, question_text: "Long Question", validation_rules: { presence: "1" })  }
-  let(:question2)  { FactoryGirl.create(:q_short, survey: survey, question_text: "Short Question") }
-  let(:attempt) { FactoryGirl.create(:attempt, survey: survey) }
-  let!(:answer1) { FactoryGirl.create(:answer, attempt: attempt, question: question1, answer_text: "Long Answer") }
-  let!(:answer2) { FactoryGirl.create(:answer, attempt: attempt, question: question2, answer_text: "Short Answer") }
+  let(:survey)  { FactoryBot.create(:survey, name: "Question Set") }
+  let(:question1)  { FactoryBot.create(:q_long,  survey: survey, question_text: "Long Question", validation_rules: { presence: "1" })  }
+  let(:question2)  { FactoryBot.create(:q_short, survey: survey, question_text: "Short Question") }
+  let(:attempt) { FactoryBot.create(:attempt, survey: survey) }
+  let!(:answer1) { FactoryBot.create(:answer, attempt: attempt, question: question1, answer_text: "Long Answer") }
+  let!(:answer2) { FactoryBot.create(:answer, attempt: attempt, question: question2, answer_text: "Short Answer") }
   before do
     visit rapidfire.edit_survey_attempt_path(survey, attempt)
   end

data/spec/features/rapidfire/managing_questions_spec.rb

@@ -1,9 +1,9 @@
 require 'spec_helper'
 
 describe "Questions" do
-  let(:survey)  { FactoryGirl.create(:survey, name: "Question Set") }
-  let(:question1)  { FactoryGirl.create(:q_long,  survey: survey, question_text: "Long Question")  }
-  let(:question2)  { FactoryGirl.create(:q_short, survey: survey, question_text: "Short Question") }
+  let(:survey)  { FactoryBot.create(:survey, name: "Question Set") }
+  let(:question1)  { FactoryBot.create(:q_long,  survey: survey, question_text: "Long Question")  }
+  let(:question2)  { FactoryBot.create(:q_short, survey: survey, question_text: "Short Question") }
   before do
     [question1, question2]
   end

data/spec/features/rapidfire/managing_surveys_spec.rb

@@ -4,9 +4,9 @@ describe "Surveys" do
   include Rapidfire::QuestionSpecHelper
   include Rapidfire::AnswerSpecHelper
 
-  let(:survey)  { FactoryGirl.create(:survey, name: "Question Set") }
-  let(:question1)  { FactoryGirl.create(:q_long,  survey: survey, question_text: "Long Question")  }
-  let(:question2)  { FactoryGirl.create(:q_short, survey: survey, question_text: "Short Question") }
+  let(:survey)  { FactoryBot.create(:survey, name: "Question Set") }
+  let(:question1)  { FactoryBot.create(:q_long,  survey: survey, question_text: "Long Question")  }
+  let(:question2)  { FactoryBot.create(:q_short, survey: survey, question_text: "Short Question") }
   before do
     [question1, question2]
   end
@@ -94,6 +94,21 @@ describe "Surveys" do
         expect(page).not_to have_link "New Survey"
       end
     end
+
+    context "when creating a survey fails" do
+      before do
+        allow_any_instance_of(ApplicationController).to receive(:can_administer?).and_return(true)
+      end
+
+      it "throws an error message" do
+        visit rapidfire.root_path
+        click_link "New Survey"
+
+        click_button "Create Survey"
+
+        expect(page).to have_content "Name can't be blank"
+      end
+    end
   end
 
   describe "EDITING Surveys" do

data/spec/fixtures/files/one.txt

@@ -0,0 +1 @@
+one

data/spec/fixtures/files/two.txt

@@ -0,0 +1 @@
+two

data/spec/models/rapidfire/answer_spec.rb

@@ -2,12 +2,12 @@ require 'spec_helper'
 
 describe Rapidfire::Answer do
   describe "Validations" do
-    subject { FactoryGirl.build(:answer) }
+    subject { FactoryBot.build(:answer) }
     it { is_expected.to validate_presence_of(:question)      }
     it { is_expected.to validate_presence_of(:attempt)  }
 
     context "when validations are run" do
-      let(:answer)  { FactoryGirl.build(:answer) }
+      let(:answer)  { FactoryBot.build(:answer) }
 
       it "delegates validation of answer text to question" do
         expect(answer.question).to receive(:validate_answer).with(answer).once

data/spec/models/rapidfire/attempt_spec.rb

@@ -3,7 +3,11 @@ require 'spec_helper'
 describe Rapidfire::Attempt do
   describe "Associations" do
     it { is_expected.to belong_to(:survey) }
-    it { is_expected.to belong_to(:user)    }
+    if Rails::VERSION::MAJOR >= 5
+      it { is_expected.to belong_to(:user).optional }
+    else
+      it { is_expected.to belong_to(:user) }
+    end
     it { is_expected.to have_many(:answers) }
   end
 end

data/spec/models/rapidfire/question_spec.rb

@@ -11,7 +11,7 @@ describe Rapidfire::Question do
   end
 
   describe "#rules" do
-    let(:question)  { FactoryGirl.create(:q_long, validation_rules: validation_rules) }
+    let(:question)  { FactoryBot.create(:q_long, validation_rules: validation_rules) }
 
     context "when there are no validation rules" do
       let(:validation_rules) { {} }
@@ -33,8 +33,8 @@ describe Rapidfire::Question do
   end
 
   describe "validate_answer" do
-    let(:question)  { FactoryGirl.create(:q_long, validation_rules: validation_rules) }
-    let(:answer)    { FactoryGirl.build(:answer, question: question, answer_text: answer_text) }
+    let(:question)  { FactoryBot.create(:q_long, validation_rules: validation_rules) }
+    let(:answer)    { FactoryBot.build(:answer, question: question, answer_text: answer_text) }
     before  { answer.valid? }
 
     context "when there are no validation rules" do

data/spec/models/rapidfire/questions/checkbox_spec.rb

@@ -6,7 +6,7 @@ describe Rapidfire::Questions::Checkbox do
   end
 
   describe "#options" do
-    let(:question)  { FactoryGirl.create(:q_select) }
+    let(:question)  { FactoryBot.create(:q_select) }
 
     it "returns options" do
       expect(question.options).to match_array(["mac", "windows"])
@@ -14,8 +14,8 @@ describe Rapidfire::Questions::Checkbox do
   end
 
   describe "validate_answer" do
-    let(:question)  { FactoryGirl.create(:q_checkbox, validation_rules: validation_rules) }
-    let(:answer)    { FactoryGirl.build(:answer, question: question, answer_text: answer_text) }
+    let(:question)  { FactoryBot.create(:q_checkbox, validation_rules: validation_rules) }
+    let(:answer)    { FactoryBot.build(:answer, question: question, answer_text: answer_text) }
     before  { answer.valid? }
 
     context "when there are no validation rules" do

data/spec/models/rapidfire/questions/date_spec.rb

@@ -2,8 +2,8 @@ require 'spec_helper'
 
 describe Rapidfire::Questions::Date do
   describe "validate_answer" do
-    let(:question)  { FactoryGirl.create(:q_date, validation_rules: validation_rules) }
-    let(:answer)    { FactoryGirl.build(:answer, question: question, answer_text: answer_text) }
+    let(:question)  { FactoryBot.create(:q_date, validation_rules: validation_rules) }
+    let(:answer)    { FactoryBot.build(:answer, question: question, answer_text: answer_text) }
     before  { answer.valid? }
 
     context "when there are no validation rules" do

data/spec/models/rapidfire/questions/file_spec.rb

@@ -0,0 +1,57 @@
+require 'spec_helper'
+
+def fixture_file_upload(path, mime_type)
+  Rack::Test::UploadedFile.new(Pathname.new(file_fixture_path).join(path), mime_type, false)
+end
+
+describe Rapidfire::Questions::File do
+  describe "Validations" do
+    it { is_expected.to validate_presence_of(:survey) }
+    it { is_expected.to validate_presence_of(:question_text)  }
+  end
+
+  describe "Associations" do
+    it { is_expected.to belong_to(:survey) }
+  end
+
+  if "#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}" >= "5.2"
+    describe "validate_answer" do
+      let(:question) { FactoryBot.create(:q_file, validation_rules: validation_rules) }
+      let(:answer) { FactoryBot.build(:answer, question: question, file: file) }
+      before  { answer.valid? }
+
+      context "when there are no validation rules" do
+        let(:validation_rules) { {} }
+        let(:file) { nil }
+
+        it "answer should pass validations" do
+          expect(answer.errors).to be_empty
+        end
+      end
+
+      context "when question needs a file attachment" do
+        let(:validation_rules) { { presence: "1" } }
+
+        context "when answer is empty" do
+          let(:file) { nil }
+
+          it "fails validations" do
+            expect(answer.errors).not_to be_empty
+          end
+
+          it "says answer should be present" do
+            expect(answer.errors[:file]).to include("can't be blank")
+          end
+        end
+
+        context "when answer is not empty" do
+          let(:file) { fixture_file_upload("one.txt", "text/plain") }
+
+          it "passes validations" do
+            expect(answer.errors).to be_empty
+          end
+        end
+      end
+    end
+  end
+end

data/spec/models/rapidfire/questions/multi_file_spec.rb

@@ -0,0 +1,60 @@
+require 'spec_helper'
+
+def fixture_file_upload(path, mime_type)
+  Rack::Test::UploadedFile.new(Pathname.new(file_fixture_path).join(path), mime_type, false)
+end
+
+describe Rapidfire::Questions::MultiFile do
+  describe "Validations" do
+    it { is_expected.to validate_presence_of(:survey) }
+    it { is_expected.to validate_presence_of(:question_text)  }
+  end
+
+  describe "Associations" do
+    it { is_expected.to belong_to(:survey) }
+  end
+
+  if "#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}" >= "5.2"
+    describe "validate_answer" do
+      let(:question) { FactoryBot.create(:q_multifile, validation_rules: validation_rules) }
+      let(:answer) { FactoryBot.build(:answer, question: question, files: files) }
+      before  { answer.valid? }
+
+      context "when there are no validation rules" do
+        let(:validation_rules) { {} }
+        let(:files) { [] }
+
+        it "answer should pass validations" do
+          expect(answer.errors).to be_empty
+        end
+      end
+
+      context "when question needs a file attachment" do
+        let(:validation_rules) { { presence: "1" } }
+
+        context "when answer is empty" do
+          let(:files) { [] }
+
+          it "fails validations" do
+            expect(answer.errors).not_to be_empty
+          end
+
+          it "says answer should be present" do
+            expect(answer.errors[:files]).to include("can't be blank")
+          end
+        end
+
+        context "when answer is not empty" do
+          let(:files) do
+            [fixture_file_upload("one.txt", "text/plain"),
+             fixture_file_upload("two.txt", "text/plain")]
+          end
+
+          it "passes validations" do
+            expect(answer.errors).to be_empty
+          end
+        end
+      end
+    end
+  end
+end

data/spec/models/rapidfire/questions/numeric_spec.rb

@@ -2,8 +2,8 @@ require 'spec_helper'
 
 describe Rapidfire::Questions::Numeric do
   describe "validate_answer" do
-    let(:question)  { FactoryGirl.create(:q_numeric, validation_rules: validation_rules) }
-    let(:answer)    { FactoryGirl.build(:answer, question: question, answer_text: answer_text) }
+    let(:question)  { FactoryBot.create(:q_numeric, validation_rules: validation_rules) }
+    let(:answer)    { FactoryBot.build(:answer, question: question, answer_text: answer_text) }
     before  { answer.valid? }
 
     context "when there are no validation rules" do

data/spec/models/rapidfire/questions/select_spec.rb

@@ -6,7 +6,7 @@ describe Rapidfire::Questions::Select do
   end
 
   describe "#options" do
-    let(:question)  { FactoryGirl.create(:q_select) }
+    let(:question)  { FactoryBot.create(:q_select) }
 
     it "returns options" do
       expect(question.options).to match_array(["mac", "windows"])
@@ -14,8 +14,8 @@ describe Rapidfire::Questions::Select do
   end
 
   describe "validate_answer" do
-    let(:question)  { FactoryGirl.create(:q_select, validation_rules: validation_rules) }
-    let(:answer)    { FactoryGirl.build(:answer, question: question, answer_text: answer_text) }
+    let(:question)  { FactoryBot.create(:q_select, validation_rules: validation_rules) }
+    let(:answer)    { FactoryBot.build(:answer, question: question, answer_text: answer_text) }
     before  { answer.valid? }
 
     context "when there are no validation rules" do

data/spec/models/rapidfire/survey_spec.rb

@@ -12,7 +12,7 @@ describe Rapidfire::Survey do
   end
 
   describe "factory" do
-    let(:survey) { FactoryGirl.create(:survey) }
+    let(:survey) { FactoryBot.create(:survey) }
 
     it "has a name" do
       expect(survey.name).to eql("Test Survey")

data/spec/serializers/rapidfire/question_result_serializer_spec.rb

@@ -4,7 +4,7 @@ describe Rapidfire::QuestionResultSerializer do
   include Rapidfire::QuestionSpecHelper
   include Rapidfire::AnswerSpecHelper
 
-  let(:survey) { FactoryGirl.create(:survey) }
+  let(:survey) { FactoryBot.create(:survey) }
   let(:results) do
     Rapidfire::SurveyResults.new(survey: survey).extract
   end