rapidfire 4.0.0 → 5.0.0

data/spec/dummy/tmp/storage-7.0.0-ruby-3.2.0/o9/2g/o92go6wavds5oht0dso6m1ybvbh4

@@ -0,0 +1 @@
+one

data/spec/dummy/tmp/storage-7.0.0-ruby-3.2.0/om/7f/om7frlle7xz8pybxbydeq1q20hro

@@ -0,0 +1 @@
+one

data/spec/dummy/tmp/storage-7.0.0-ruby-3.2.0/q6/78/q678f1u8v1nv07dbtm85knmw3b9q

@@ -0,0 +1 @@
+one

data/spec/dummy/tmp/storage-7.0.0-ruby-3.2.0/qq/kc/qqkciwi2vymum1556755n85po1j9

@@ -0,0 +1 @@
+two

data/spec/dummy/tmp/storage-7.0.0-ruby-3.2.0/r4/wp/r4wpzje2mix0dtl8r2f4akh18fm1

@@ -0,0 +1 @@
+two

data/spec/dummy/tmp/storage-7.0.0-ruby-3.2.0/v1/h9/v1h9cuuwtwvz8p6fl574qum6k4ig

@@ -0,0 +1 @@
+two

data/spec/dummy/tmp/storage-7.0.0-ruby-3.2.0/vb/mw/vbmwrl014lccj3jo61vojqscfxha

@@ -0,0 +1 @@
+two

data/spec/dummy/tmp/storage-7.0.0-ruby-3.2.0/wn/q4/wnq49hhhxvh4gnc2782lf4zzlz46

@@ -0,0 +1 @@
+one

data/spec/dummy/tmp/storage-7.0.0-ruby-3.2.0/ya/go/yago1kn4o7p8jfob0cxetrif714s

@@ -0,0 +1 @@
+one

data/spec/factories/questions_factory.rb

@@ -26,5 +26,11 @@ FactoryGirl.define do
 
     factory :q_short, :class => "Rapidfire::Questions::Short" do
     end
+
+    factory :q_file, :class => "Rapidfire::Questions::File" do
+    end
+
+    factory :q_multifile, :class => "Rapidfire::Questions::MultiFile" do
+    end
   end
 end

data/spec/factories/users_factory.rb

@@ -0,0 +1,5 @@
+FactoryGirl.define do
+  factory :user do
+    name  "Test User"
+  end
+end

data/spec/features/rapidfire/answering_questions_spec.rb

@@ -2,20 +2,23 @@ require 'spec_helper'
 
 describe "Surveys" do
   let!(:survey) { FactoryGirl.create(:survey, name: "Question Set", introduction: "Some introduction") }
-  let!(:question1) { FactoryGirl.create(:q_long,  survey: survey, question_text: "Long Question", validation_rules: { presence: "1" })  }
-  let!(:question2) { FactoryGirl.create(:q_short, survey: survey, question_text: "Short Question") }
-  let!(:question3) { FactoryGirl.create(:q_checkbox, survey: survey, question_text: "Checkbox question") }
-  let!(:question4) { FactoryGirl.create(:q_checkbox, survey: survey, question_text: "Checkbox question", validation_rules: { presence: "1" }) }
 
-  before do
+  it "displays survey introduction" do
     visit rapidfire.new_survey_attempt_path(survey)
-  end
 
-  it "displays survey introduction" do
     expect(page).to have_content "Some introduction"
   end
 
   describe "Answering Questions" do
+    let!(:question1) { FactoryGirl.create(:q_long,  survey: survey, question_text: "Long Question", validation_rules: { presence: "1" })  }
+    let!(:question2) { FactoryGirl.create(:q_short, survey: survey, question_text: "Short Question") }
+    let!(:question3) { FactoryGirl.create(:q_checkbox, survey: survey, question_text: "Checkbox question") }
+    let!(:question4) { FactoryGirl.create(:q_checkbox, survey: survey, question_text: "Checkbox question", validation_rules: { presence: "1" }) }
+
+    before do
+      visit rapidfire.new_survey_attempt_path(survey)
+    end
+
     context "when all questions are answered" do
       before do
         fill_in "attempt_#{question1.id}_answer_text", with: "Long Answer"
@@ -85,4 +88,41 @@ describe "Surveys" do
       end
     end
   end
+
+  if "#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}" >= "5.2"
+    describe "Answering File uploads" do
+      context "when the question is single file upload" do
+        let!(:question1) { FactoryGirl.create(:q_file,  survey: survey, question_text: "Avatar")  }
+
+        it "persistes the file" do
+          visit rapidfire.new_survey_attempt_path(survey)
+
+          attach_file "attempt_#{question1.id}_file", file_fixture("one.txt")
+          click_button "Save"
+
+          answer = Rapidfire::Answer.first
+          expect(answer).to be_persisted
+          expect(answer.file.download).to eq("one\n")
+        end
+      end
+
+      context "when the question is multi file upload" do
+        let!(:question1) { FactoryGirl.create(:q_multifile,  survey: survey, question_text: "Images")  }
+
+        it "persistes the file" do
+          visit rapidfire.new_survey_attempt_path(survey)
+
+          attach_file "attempt_#{question1.id}_files", [file_fixture("one.txt"), file_fixture("two.txt")]
+          click_button "Save"
+
+          answer = Rapidfire::Answer.first
+          expect(answer).to be_persisted
+          expect(answer.files.length).to eq 2
+
+          expect(answer.files[0].download).to eq("two\n")
+          expect(answer.files[1].download).to eq("one\n")
+        end
+      end
+    end
+  end
 end

data/spec/fixtures/files/one.txt

@@ -0,0 +1 @@
+one

data/spec/fixtures/files/two.txt

@@ -0,0 +1 @@
+two

data/spec/models/rapidfire/attempt_spec.rb

@@ -3,7 +3,11 @@ require 'spec_helper'
 describe Rapidfire::Attempt do
   describe "Associations" do
     it { is_expected.to belong_to(:survey) }
-    it { is_expected.to belong_to(:user)    }
+    if Rails::VERSION::MAJOR >= 5
+      it { is_expected.to belong_to(:user).optional }
+    else
+      it { is_expected.to belong_to(:user) }
+    end
     it { is_expected.to have_many(:answers) }
   end
 end

data/spec/models/rapidfire/questions/file_spec.rb

@@ -0,0 +1,57 @@
+require 'spec_helper'
+
+def fixture_file_upload(path, mime_type)
+  Rack::Test::UploadedFile.new(Pathname.new(file_fixture_path).join(path), mime_type, false)
+end
+
+describe Rapidfire::Questions::File do
+  describe "Validations" do
+    it { is_expected.to validate_presence_of(:survey) }
+    it { is_expected.to validate_presence_of(:question_text)  }
+  end
+
+  describe "Associations" do
+    it { is_expected.to belong_to(:survey) }
+  end
+
+  if "#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}" >= "5.2"
+    describe "validate_answer" do
+      let(:question) { FactoryGirl.create(:q_file, validation_rules: validation_rules) }
+      let(:answer) { FactoryGirl.build(:answer, question: question, file: file) }
+      before  { answer.valid? }
+
+      context "when there are no validation rules" do
+        let(:validation_rules) { {} }
+        let(:file) { nil }
+
+        it "answer should pass validations" do
+          expect(answer.errors).to be_empty
+        end
+      end
+
+      context "when question needs a file attachment" do
+        let(:validation_rules) { { presence: "1" } }
+
+        context "when answer is empty" do
+          let(:file) { nil }
+
+          it "fails validations" do
+            expect(answer.errors).not_to be_empty
+          end
+
+          it "says answer should be present" do
+            expect(answer.errors[:file]).to include("can't be blank")
+          end
+        end
+
+        context "when answer is not empty" do
+          let(:file) { fixture_file_upload("one.txt", "text/plain") }
+
+          it "passes validations" do
+            expect(answer.errors).to be_empty
+          end
+        end
+      end
+    end
+  end
+end

data/spec/models/rapidfire/questions/multi_file_spec.rb

@@ -0,0 +1,60 @@
+require 'spec_helper'
+
+def fixture_file_upload(path, mime_type)
+  Rack::Test::UploadedFile.new(Pathname.new(file_fixture_path).join(path), mime_type, false)
+end
+
+describe Rapidfire::Questions::MultiFile do
+  describe "Validations" do
+    it { is_expected.to validate_presence_of(:survey) }
+    it { is_expected.to validate_presence_of(:question_text)  }
+  end
+
+  describe "Associations" do
+    it { is_expected.to belong_to(:survey) }
+  end
+
+  if "#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}" >= "5.2"
+    describe "validate_answer" do
+      let(:question) { FactoryGirl.create(:q_multifile, validation_rules: validation_rules) }
+      let(:answer) { FactoryGirl.build(:answer, question: question, files: files) }
+      before  { answer.valid? }
+
+      context "when there are no validation rules" do
+        let(:validation_rules) { {} }
+        let(:files) { [] }
+
+        it "answer should pass validations" do
+          expect(answer.errors).to be_empty
+        end
+      end
+
+      context "when question needs a file attachment" do
+        let(:validation_rules) { { presence: "1" } }
+
+        context "when answer is empty" do
+          let(:files) { [] }
+
+          it "fails validations" do
+            expect(answer.errors).not_to be_empty
+          end
+
+          it "says answer should be present" do
+            expect(answer.errors[:files]).to include("can't be blank")
+          end
+        end
+
+        context "when answer is not empty" do
+          let(:files) do
+            [fixture_file_upload("one.txt", "text/plain"),
+             fixture_file_upload("two.txt", "text/plain")]
+          end
+
+          it "passes validations" do
+            expect(answer.errors).to be_empty
+          end
+        end
+      end
+    end
+  end
+end

data/spec/services/rapidfire/attempt_builder_spec.rb

@@ -1,5 +1,9 @@
 require 'spec_helper'
 
+def fixture_file_upload(path, mime_type)
+  Rack::Test::UploadedFile.new(Pathname.new(file_fixture_path).join(path), mime_type, false)
+end
+
 describe Rapidfire::AttemptBuilder do
   let(:survey)  { FactoryGirl.create(:survey) }
   let(:question1)  { FactoryGirl.create(:q_short, survey: survey) }
@@ -28,11 +32,6 @@ describe Rapidfire::AttemptBuilder do
     end
     let(:save_answers)  { builder.save }
 
-    before do
-      [question1, question2]
-      save_answers
-    end
-
     context "when all the answers are valid" do
       let(:answer_params) do
         {
@@ -46,6 +45,7 @@ describe Rapidfire::AttemptBuilder do
       end
 
       it "successfully saves answers" do
+        save_answers
         builder.answers.each do |answer|
           expect(answer).to be_persisted
           expect(question_ids).to include(answer.question_id)
@@ -66,21 +66,69 @@ describe Rapidfire::AttemptBuilder do
       end
 
       it "fails to save those answers" do
+        save_answers
         expect(Rapidfire::Answer.count).to eq(0)
       end
 
-      context "when requested to save without validations" do
-        let(:save_answers)  { builder.save(:validate => false) }
+      if Rails::VERSION::MAJOR < 5
+        context "when requested to save without validations" do
+          let(:save_answers)  { builder.save(:validate => false) }
+
+          it "returns true" do
+            expect(save_answers).to be_truthy
+          end
+
+          it "saves all the answers" do
+            save_answers
+            builder.answers.each do |answer|
+              expect(answer).to be_persisted
+              expect(question_ids).to include(answer.question_id)
+            end
+          end
+        end
+      end
+    end
+
+    if "#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}" >= "5.2"
+      context "with a single file upload question" do
+        let(:question3) { FactoryGirl.create(:q_file, survey: survey) }
 
-        it "returns true" do
+        let(:answer_params) do
+          {
+            question1.id.to_s => { :answer_text => "short answer" },
+            question2.id.to_s => { :answer_text => "long answer" },
+            question3.id.to_s => { :file => fixture_file_upload("one.txt", "text/plain") }
+          }
+        end
+
+        it "saves the file successfully" do
           expect(save_answers).to be_truthy
+
+          answer = Rapidfire::Answer.last
+          expect(answer).to be_persisted
+          expect(answer.file.download).to eq("one\n")
         end
+      end
 
-        it "saves all the answers" do
-          builder.answers.each do |answer|
-            expect(answer).to be_persisted
-            expect(question_ids).to include(answer.question_id)
-          end
+      context "with multiple files upload question" do
+        let(:question3) { FactoryGirl.create(:q_multifile, survey: survey) }
+
+        let(:answer_params) do
+          {
+            question1.id.to_s => { :answer_text => "short answer" },
+            question2.id.to_s => { :answer_text => "long answer" },
+            question3.id.to_s => { :files => [fixture_file_upload("one.txt", "text/plain"),
+                                              fixture_file_upload("two.txt", "text/plain")]}
+          }
+        end
+
+        it "saves the file successfully" do
+          expect(save_answers).to be_truthy
+
+          answer = Rapidfire::Answer.last
+          expect(answer).to be_persisted
+          expect(answer.files[0].download).to eq("one\n")
+          expect(answer.files[1].download).to eq("two\n")
         end
       end
     end