rapid-core 0.1 → 0.2.1

data/spec/rapid/skeleton/base_spec.rb

@@ -55,7 +55,7 @@ describe Rapid::Skeleton::Base do
     
     it "should accept a hash and load the settings with it" do
       @settings = mock('settings')
-      @settings.should_receive(:load_hash).with(:foo => "bar")
+      @settings.should_receive(:load).with(:foo => "bar")
       
       @skeleton = Rapid::Skeleton::Base.new @settings
       @skeleton.settings = {:foo => "bar"}
@@ -63,6 +63,35 @@ describe Rapid::Skeleton::Base do
     
   end
   
+  describe "check" do
+    
+    before do
+      @check = Rapid::Check.new ""
+      Rapid::Check.current = @check
+      
+      @skeleton = Rapid::Skeleton::Base.new
+    end
+    
+    it "should accept a check from options" do
+      @check2 = Rapid::Check.new ""
+      
+      @skeleton = Rapid::Skeleton::Base.new nil, :check => @check2
+      @skeleton.check.should == @check2
+    end
+    
+    it "should use the current check" do
+      @skeleton = Rapid::Skeleton::Base.new nil
+      @skeleton.check.should == Rapid::Check.current
+    end
+    
+    it "should build a check" do
+      Rapid::Check.current = nil
+      @skeleton = Rapid::Skeleton::Base.new nil, :console => true
+      @skeleton.check.console.should == true
+    end
+    
+  end
+  
   describe "push" do
     
     it "should know whether it's pushing" do
@@ -71,6 +100,16 @@ describe Rapid::Skeleton::Base do
       @skeleton.send(:pushing?).should == false
     end
     
+    it "should accept settings as a parameter" do
+      @settings = mock('settings', :valid? => true)
+      @settings.should_receive(:load, :foo => 'bar')
+      
+      @skeleton = Rapid::Skeleton::Base.new @settings
+      @skeleton.should_receive(:bones)
+      
+      @skeleton.push :foo => 'bar'
+    end
+    
     it "should raise a not implemented error" do
       @skeleton = Rapid::Skeleton::Base.new
       lambda { @skeleton.push }.should raise_error(NotImplementedError)
@@ -95,6 +134,16 @@ describe Rapid::Skeleton::Base do
       @skeleton.push!
     end
     
+    it "should accept settings as a parameter" do
+      @settings = mock('settings', :valid? => true)
+      @settings.should_receive(:load, :foo => 'bar')
+      
+      @skeleton = Rapid::Skeleton::Base.new @settings
+      @skeleton.should_receive(:bones)
+      
+      @skeleton.push! :foo => 'bar'
+    end
+    
   end
   
   describe "pull" do
@@ -119,11 +168,73 @@ describe Rapid::Skeleton::Base do
     
     it "should return false if it does not encounter an error" do
       @skeleton = Rapid::Skeleton::Base.new
-      Rapid::Check.should_receive(:encounters_error?).and_return(true)
+      @skeleton.check.should_receive(:encounters_error?).and_return(true)
       
       @skeleton.pull.should == false
     end
     
+    it "should log values" do
+      @settings = mock('settings')
+      @settings.should_receive(:[]=).with('foo', 'bar')
+      @skeleton = Rapid::Skeleton::Base.new @settings
+      
+      @skeleton.check.should_receive(:log_value).with(:info, "foo", "bar")
+      @skeleton["foo"] = "bar"
+    end
+    
+    it "should warn when setting to a different value during a pull" do
+      @settings = {'foo' => 'bar'}
+      @skeleton = Rapid::Skeleton::Base.new @settings
+      
+      @skeleton.check.should_receive(:log_value).with(:warning, 'foo', 'baz')
+      @skeleton.instance_variable_set(:@pulled_settings, ['foo'])
+      
+      @skeleton['foo'] = 'baz'
+    end
+    
+    it "should just log when a boolean setting from true to 'true'" do
+      @settings = mock('settings')
+      @settings.should_receive(:[]).with('foo').twice.and_return(true)
+      @settings.should_receive(:[]=).with('foo', 'true')
+      
+      @skeleton = Rapid::Skeleton::Base.new @settings
+      
+      @skeleton.check.should_receive(:log_value).with(:info, 'foo', 'true')
+      @skeleton.instance_variable_set(:@pulled_settings, ['foo'])
+      
+      @skeleton['foo'] = 'true'
+    end
+    
+    it "should log a warning when a namespace previously turned off is set to on" do
+      @ns = mock('namespace', :namespaces => [], :scalars => [])
+      @namespace = Rapid::Setting::Namespace::Instance.new @ns, @parent
+      
+      @settings = mock('settings')
+      @settings.should_receive(:[]).with('foo').twice.and_return(@namespace)
+      @settings.should_receive(:[]=).with('foo', 'true')
+      
+      # goes from on to off
+      @namespace.should_receive(:on?).and_return(true)
+      @namespace.should_receive(:on?).and_return(false)
+      
+      @skeleton = Rapid::Skeleton::Base.new @settings
+      
+      @skeleton.check.should_receive(:log_value).with(:warning, 'foo', 'true')
+      @skeleton.instance_variable_set(:@pulled_settings, ['foo'])
+      
+      @skeleton['foo'] = 'true'
+    end
+    
+    it "should just log info when setting it to the same value" do
+      @settings = {'foo' => 'bar'}
+      @skeleton = Rapid::Skeleton::Base.new @settings
+      
+      @skeleton.check.should_receive(:log_value).with(:info, 'foo', 'bar')
+      @skeleton.instance_variable_set(:@pulled_settings, ['foo'])
+      
+      @skeleton['foo'] = 'bar'
+    end
+    
   end
   
   describe "pull!" do
@@ -157,11 +268,6 @@ describe Rapid::Skeleton::Base do
       Rapid::Check.current = nil
     end
     
-    it "should raise an error if Rapid::Check.current is nil" do
-      Rapid::Check.current = nil
-      lambda { @skeleton.send(:ok, 'foo', 'bar') }.should raise_error
-    end
-    
     it "should delegate ok to Rapid::Check.current" do
       @check.should_receive(:ok).with('foo', 'bar')
       @skeleton.send(:ok, 'foo', 'bar')

data/spec/rapid/skeleton/helpers/directory_spec.rb

@@ -5,6 +5,8 @@ describe Rapid::Skeleton::Helpers::Directory do
   before do
     Object.class_eval do
       class MyClass
+        include Rapid::Skeleton::Helpers::IfSetting
+        include Rapid::Skeleton::Helpers::Files
         include Rapid::Skeleton::Helpers::Directory
         
         attr_accessor :templates_path, :project_path, :get_binding
@@ -32,17 +34,17 @@ describe Rapid::Skeleton::Helpers::Directory do
       @instance.send :directory, 'foo/bar'
     end
     
-    it "shouldn't push the directory if setting is false" do
-      FileUtils.should_not_receive(:mkdir_p)
+    it "should push the directory if the setting is true" do
+      @instance.should_receive(:make_project_directory).with('foo/bar')
       
-      @instance.should_receive(:set?).with('foo').and_return(false)
+      @instance.should_receive(:set?).with('foo').and_return(true)
       @instance.send :directory, 'foo/bar', :if => 'foo'
     end
     
-    it "should push the directory if the setting is true" do
-      FileUtils.should_receive(:mkdir_p).with('tmp/foo/bar')
+    it "should delete the directory if setting is false" do
+      @instance.should_receive(:delete_project_directory).with('foo/bar')
       
-      @instance.should_receive(:set?).with('foo').and_return(true)
+      @instance.should_receive(:set?).with('foo').and_return(false)
       @instance.send :directory, 'foo/bar', :if => 'foo'
     end
     

data/spec/rapid/skeleton/helpers/files_spec.rb

@@ -0,0 +1,93 @@
+require File.expand_path(File.dirname(__FILE__) + '/../../../spec_helper')
+
+describe Rapid::Skeleton::Helpers::Files do
+  
+  before do
+    Object.class_eval do
+      class MyClass
+        include Rapid::Skeleton::Helpers::Files
+        
+        attr_accessor :templates_path, :project_path
+      end
+    end
+    
+    @instance = MyClass.new
+    @instance.templates_path = 'tmp/test/templates'
+    @instance.project_path = 'tmp/test/project'
+    
+    FileUtils.mkdir_p @instance.templates_path
+    FileUtils.mkdir_p @instance.project_path
+  end
+  
+  after do
+    Object.send(:remove_const, :MyClass) rescue nil
+    FileUtils.rm_rf 'tmp/test'
+  end
+  
+  def create_file path, content
+    File.open(path, 'w') {|f| f.write content }
+  end
+  
+  it "should read a template file" do
+    create_file 'tmp/test/templates/foo.rb', 'foo'
+    @instance.send(:read_template_file, 'foo.rb').should == 'foo'
+  end
+  
+  it "should raise an error when reading a template file that doesn't exist" do
+    lambda { @instance.send(:read_template_file, 'foo.rb') }.should raise_error(Rapid::TemplateNotFoundError)
+  end
+  
+  it "should know if a project file exists" do
+    @instance.send(:project_file_exists?, "foo.rb").should == false
+    
+    create_file 'tmp/test/project/foo.rb', 'hi'
+    @instance.send(:project_file_exists?, "foo.rb").should == true
+  end
+  
+  it "should make a project directory" do
+    FileUtils.should_receive(:mkdir_p).with('tmp/foo')
+    @instance.project_path = 'tmp'
+    @instance.send(:make_project_directory, "foo")
+  end
+  
+  it "should delete a project directory" do
+    FileUtils.should_receive(:rm_rf).with('tmp/test')
+    FileUtils.should_receive(:rm_rf).with('tmp/foo')
+    @instance.project_path = 'tmp'
+    @instance.send(:delete_project_directory, "foo")
+  end
+  
+  it "should read a project file" do
+    create_file 'tmp/test/project/foo.rb', 'hi'
+    @instance.send(:read_project_file, "foo.rb").should == 'hi'
+  end
+  
+  it "should raise an error when reading a project file that doesn't exist" do
+    lambda { @instance.send(:read_project_file, "foo.rb") }.should raise_error(Rapid::ProjectFileNotFoundError)
+  end
+  
+  it "should write a project file" do
+    @instance.send(:write_project_file, "config/foo.rb", "hi")
+    @instance.send(:read_project_file, "config/foo.rb").should == "hi"
+  end
+  
+  it "should delete a project file" do
+    create_file "tmp/test/project/foo.rb", "hi"
+    @instance.send(:delete_project_file, "foo.rb")
+    File.exists?("tmp/test/project/foo.rb").should == false
+  end
+  
+  it "should not raise an error when deleting a project file that doesn't exist" do
+    @instance.send(:delete_project_file, "foo.rb")
+  end
+  
+  it "should chmod a file" do
+    File.should_receive(:chmod).with(0755, "tmp/test/project/foo.rb")
+    @instance.send(:chmod_project_file, 0755, "foo.rb")
+  end
+  
+  it "should raise an error when chmodding a file that doesn't exist" do
+    lambda { @instance.send(:chmod_project_file, 0755, "foo.rb") }.should raise_error(Rapid::ProjectFileNotFoundError)
+  end
+  
+end

data/spec/rapid/skeleton/helpers/gem_spec.rb

@@ -6,6 +6,7 @@ describe Rapid::Skeleton::Helpers::Gem do
     Object.class_eval do
       class MyClass
         include ActiveModel::Validations
+        include Rapid::Skeleton::Helpers::IfSetting
         include Rapid::Skeleton::Helpers::Gem
         
         attr_accessor :templates_path, :project_path, :get_binding
@@ -18,7 +19,8 @@ describe Rapid::Skeleton::Helpers::Gem do
   end
   
   def gemfile content
-    @gemfile = File.open(@instance.gemfile_path, 'w') {|f| f.write content }
+    @instance.stub!(:project_file_exists?).with("Gemfile").and_return(true)
+    @instance.stub!(:read_project_file).with("Gemfile").and_return(content)
   end
   
   it "should not be valid if the Gemfile does not exist" do
@@ -26,6 +28,7 @@ describe Rapid::Skeleton::Helpers::Gem do
     
     @instance = MyClass.new
     @instance.project_path = "tmp"
+    @instance.should_receive(:project_file_exists?).with("Gemfile").and_return(false)
     
     @instance.valid?
     @instance.errors[:gem].should == ["file does not exist"]
@@ -35,11 +38,9 @@ describe Rapid::Skeleton::Helpers::Gem do
     
     def push *args
       @instance.send :gem, *args
-      @gemfile = File.open(@instance.gemfile_path) {|f| f.read }
     end
     
     before do
-      FileUtils.mkdir_p 'tmp/test'
       @instance = MyClass.new
       @instance.project_path = 'tmp/test'
       
@@ -47,72 +48,90 @@ describe Rapid::Skeleton::Helpers::Gem do
       @instance.stub!(:pulling?).and_return(false)
     end
     
-    after do
-      FileUtils.rm_rf 'tmp/test'
-    end
-    
     it "should append the gem to the existing list" do
-      gemfile %(gem 'rails', '3.1.0')
+      @instance.should_receive(:write_project_file).with("Gemfile", %(\ngem 'rails', '3.1.0'\ngem 'kaminari'))
+      gemfile %(\ngem 'rails', '3.1.0')
       push 'kaminari'
-      @gemfile.should == %(gem 'rails', '3.1.0'\ngem 'kaminari')
     end
     
     it "should push a version" do
-      gemfile %(gem 'rails', '3.1.0')
+      @instance.should_receive(:write_project_file).with("Gemfile", %(\ngem 'rails', '3.1.0'\ngem 'kaminari', '1.0'))
+      
+      gemfile %(\ngem 'rails', '3.1.0')
       push 'kaminari', '1.0'
-      @gemfile.should == %(gem 'rails', '3.1.0'\ngem 'kaminari', '1.0')
     end
     
     it "should push options" do
-      gemfile %(gem 'rails', '3.1.0')
+      @instance.should_receive(:write_project_file).with("Gemfile", %(\ngem 'rails', '3.1.0'\ngem 'kaminari', :git => "git://somewhere"))
+      
+      gemfile %(\ngem 'rails', '3.1.0')
       push 'kaminari', :git => 'git://somewhere'
-      @gemfile.should == %(gem 'rails', '3.1.0'\ngem 'kaminari', :git => "git://somewhere")
     end
     
     it "should not append the gem if it already exists" do
-      gemfile %(gem 'rails', '3.1.0')
+      @instance.should_receive(:write_project_file).with("Gemfile", %(\ngem 'rails', '3.1.0'))
+      gemfile %(\ngem 'rails', '3.1.0')
       push 'rails'
-      @gemfile.should == %(gem 'rails', '3.1.0')
+      
+      @instance.should_receive(:write_project_file).with("Gemfile", %(\ngem 'rails', '3.1.0'))
+      push 'rails', '3.1.0'
     end
     
     it "should append to group block if available" do
-      gemfile %(gem 'rails', '3.1.0'\n\ngroup :development do\n  gem 'capistrano'\nend)
+      @instance.should_receive(:write_project_file).with("Gemfile", %(\ngem 'rails', '3.1.0'\n\ngroup :development do\n  gem 'capistrano'\n  gem 'capistrano-ext'\nend))
+      gemfile %(\ngem 'rails', '3.1.0'\n\ngroup :development do\n  gem 'capistrano'\nend)
       push 'capistrano-ext', :group => 'development'
-      @gemfile.should == %(gem 'rails', '3.1.0'\n\ngroup :development do\n  gem 'capistrano'\n  gem 'capistrano-ext'\nend)
     end
     
     it "should append with group option if group does not exist" do
-      gemfile %(gem 'rails', '3.1.0')
+      @instance.should_receive(:write_project_file).with("Gemfile", %(\ngem 'rails', '3.1.0'\ngem 'capistrano-ext', :group => :development))
+      gemfile %(\ngem 'rails', '3.1.0')
       push 'capistrano-ext', :group => 'development'
-      @gemfile.should == %(gem 'rails', '3.1.0'\ngem 'capistrano-ext', :group => :development)
     end
     
     it "should append to multiple groups block if available" do
-      gemfile %(gem 'rails', '3.1.0'\n\ngroup :development, :test do\n  gem 'capistrano'\nend)
+      @instance.should_receive(:write_project_file).with("Gemfile", %(\ngem 'rails', '3.1.0'\n\ngroup :development, :test do\n  gem 'capistrano'\n  gem 'capistrano-ext'\nend))
+      gemfile %(\ngem 'rails', '3.1.0'\n\ngroup :development, :test do\n  gem 'capistrano'\nend)
       push 'capistrano-ext', :groups => ['development', 'test']
-      @gemfile.should == %(gem 'rails', '3.1.0'\n\ngroup :development, :test do\n  gem 'capistrano'\n  gem 'capistrano-ext'\nend)
     end
     
     it "should append with multiple groups option if group does not exist" do
-      gemfile %(gem 'rails', '3.1.0')
+      @instance.should_receive(:write_project_file).with("Gemfile", %(\ngem 'rails', '3.1.0'\ngem 'capistrano-ext', :groups => [:development, :test]))
+      
+      gemfile %(\ngem 'rails', '3.1.0')
       push 'capistrano-ext', :groups => ['development', 'test']
-      @gemfile.should == %(gem 'rails', '3.1.0'\ngem 'capistrano-ext', :groups => [:development, :test])
     end
     
     it "should push when :if is true" do
+      @instance.should_receive(:write_project_file).with("Gemfile", %(\ngem 'rails', '3.1.0'\ngem 'capistrano-ext'))
       @instance.should_receive(:set?).with('foo').and_return(true)
-      gemfile %(gem 'rails', '3.1.0')
       
+      gemfile %(\ngem 'rails', '3.1.0')
       push 'capistrano-ext', :if => 'foo'
-      @gemfile.should == %(gem 'rails', '3.1.0'\ngem 'capistrano-ext')
     end
     
-    it "should not push when :if is false" do
+    it "should remove the gem :if is false" do
+      @instance.should_receive(:write_project_file).with("Gemfile", %(\ngem 'rails', '3.1.0'))
       @instance.should_receive(:set?).with('foo').and_return(false)
-      gemfile %(gem 'rails', '3.1.0')
       
+      gemfile %(\ngem 'rails', '3.1.0'\ngem 'capistrano-ext')
       push 'capistrano-ext', :if => 'foo'
-      @gemfile.should == %(gem 'rails', '3.1.0')
+    end
+    
+    it "should remove the gem :if is false and the gem is in a group" do
+      @instance.should_receive(:write_project_file).with("Gemfile", %(\ngem 'rails', '3.1.0'))
+      @instance.should_receive(:set?).with('foo').and_return(false)
+      
+      gemfile %(\ngem 'rails', '3.1.0'\ngem 'capistrano-ext', :group => :development)
+      push 'capistrano-ext', :group => :development, :if => 'foo'
+    end
+    
+    it "should remove the gem :if is false and the gem is in a group block" do
+      @instance.should_receive(:write_project_file).with("Gemfile", %(\ngem 'rails', '3.1.0'\n\ngroup :development do\n  gem 'capistrano'\nend))
+      @instance.should_receive(:set?).with('foo').and_return(false)
+      
+      gemfile %(\ngem 'rails', '3.1.0'\n\ngroup :development do\n  gem 'capistrano'\n  gem 'capistrano-ext'\nend)
+      push 'capistrano-ext', :group => :development, :if => 'foo'
     end
     
   end
@@ -120,7 +139,6 @@ describe Rapid::Skeleton::Helpers::Gem do
   describe "pull_gem" do
     
     before do
-      FileUtils.mkdir_p 'tmp/test'
       @instance = MyClass.new
       @instance.project_path = 'tmp/test'
       
@@ -128,10 +146,6 @@ describe Rapid::Skeleton::Helpers::Gem do
       @instance.stub!(:pulling?).and_return(true)
     end
     
-    after do
-      FileUtils.rm_rf 'tmp/test'
-    end
-    
     it "should report an error it doesn't know where the Gemfile is" do
       @instance.project_path = nil
       @instance.should_receive(:error).with("kaminari", "Unknown Gemfile location")
@@ -140,20 +154,35 @@ describe Rapid::Skeleton::Helpers::Gem do
     end
     
     it "should report an error when the gemfile doesn't exist" do
+      @instance.should_receive(:project_file_exists?).with("Gemfile").and_return(false)
       @instance.should_receive(:error).with("kaminari", "Gemfile doesn't exist")
       
       @instance.send :gem, 'kaminari'
     end
     
     it "should report an error when the gem isn't in the gem file" do
-      gemfile %()
+      gemfile %(\n)
       @instance.should_receive(:error).with("kaminari", "isn't in your Gemfile")
       
       @instance.send :gem, 'kaminari'
     end
     
+    it "should report an error when the gem is in the Gemfile, but commented out" do
+      gemfile %(\n# gem 'kaminari')
+      @instance.should_receive(:error).with("kaminari", "isn't in your Gemfile")
+      
+      @instance.send :gem, 'kaminari'
+    end
+    
+    it "should not be tricked by the same gem in the file twice, once commented, once not" do
+      gemfile %(\n# gem 'kaminari'\ngem 'kaminari')
+      @instance.should_receive(:ok).with("kaminari", "is in your Gemfile")
+      
+      @instance.send :gem, 'kaminari'
+    end
+    
     it "should report ok when the gem is in the gem file" do
-      gemfile %(gem 'kaminari')
+      gemfile %(\ngem 'kaminari')
       @instance.should_receive(:ok).with("kaminari", "is in your Gemfile")
       
       @instance.send :gem, 'kaminari'
@@ -168,7 +197,7 @@ describe Rapid::Skeleton::Helpers::Gem do
     end
     
     it "should set the 'if' setting true" do
-      gemfile %(gem 'kaminari')
+      gemfile %(\ngem 'kaminari')
       @instance.should_receive(:ok).with('kaminari', "is in your Gemfile")
       @instance.should_receive(:[]=).with('foo', true)