rantly 1.2.0 → 2.0.0

data/lib/rantly/property.rb

@@ -3,10 +3,10 @@ require 'pp'
 require 'stringio'
 
 class Rantly::Property
-  attr_reader :failed_data, :shrunk_failed_data, :io
+  attr_reader :failed_data, :shrunk_failed_data
 
-  VERBOSITY = ENV.fetch('RANTLY_VERBOSE'){ 1 }.to_i
-  RANTLY_COUNT = ENV.fetch('RANTLY_COUNT'){ 100 }.to_i
+  VERBOSITY = ENV.fetch('RANTLY_VERBOSE') { 1 }.to_i
+  RANTLY_COUNT = ENV.fetch('RANTLY_COUNT') { 100 }.to_i
 
   def io
     @io ||= if VERBOSITY >= 1
@@ -24,46 +24,43 @@ class Rantly::Property
     @property = property
   end
 
-  def check(n=RANTLY_COUNT,limit=10,&assertion)
+  def check(n = RANTLY_COUNT, limit = 10, &assertion)
     i = 0
     test_data = nil
     begin
-      Rantly.singleton.generate(n,limit,@property) do |val|
+      Rantly.singleton.generate(n, limit, @property) do |val|
         test_data = val
-        assertion.call(val) if assertion
-        io.puts "" if i % 100 == 0
-        io.print "." if i % 10 == 0
+        yield(val) if assertion
+        io.puts '' if (i % 100).zero?
+        io.print '.' if (i % 10).zero?
         i += 1
       end
       io.puts
-      io.puts "success: #{i} tests"
+      io.puts "SUCCESS - #{i} successful tests"
     rescue Rantly::TooManyTries => e
       io.puts
-      io.puts "too many tries: #{e.tries}"
-      raise e
+      io.puts "FAILURE - #{i} successful tests, too many tries: #{e.tries}"
+      raise e.exception("#{i} successful tests, too many tries: #{e.tries} (limit: #{e.limit})")
     rescue Exception => boom
       io.puts
-      io.puts "failure: #{i} tests, on:"
+      io.puts "FAILURE - #{i} successful tests, failed on:"
       pretty_print test_data
       @failed_data = test_data
       if @failed_data.respond_to?(:shrink)
         @shrunk_failed_data, @depth = shrinkify(assertion, @failed_data)
-        io.puts "minimal failed data (depth #{@depth}) is:"
+        io.puts "Minimal failed data (depth #{@depth}) is:"
         pretty_print @shrunk_failed_data
       end
-      raise $!, "failure: #{i} tests, on:\n#{test_data}\n\n#{boom}\n", $@
+      raise boom.exception("#{i} successful tests, failed on:\n#{test_data}\n\n#{boom}\n")
     end
   end
 
   # Explore the failures tree
-  def shrinkify(assertion, data, depth=0, iteration=0)
-    io.puts "Shrinking at depth #{depth}:"
-    pretty_print data
-
+  def shrinkify(assertion, data, depth = 0, iteration = 0)
     min_data = data
     max_depth = depth
     if data.shrinkable?
-      while iteration < 1024 do
+      while iteration < 1024
         # We assume that data.shrink is non-destructive
         shrunk_data = data.shrink
         begin
@@ -76,9 +73,9 @@ class Rantly::Property
             max_depth = branch_depth
           end
         end
-        break if !data.retry?
+        break unless data.retry?
       end
     end
-    return min_data, max_depth, iteration
+    [min_data, max_depth, iteration]
   end
 end

data/lib/rantly/shrinks.rb

@@ -2,17 +2,17 @@
 class Integer
   def shrink
     shrunk = if self > 8
-      self / 2
-    elsif self > 0
-      self - 1
-    elsif self < -8
-      (self + 1) / 2
-    elsif self < 0
-      self + 1
-    else
-      0
+               self / 2
+             elsif self > 0
+               self - 1
+             elsif self < -8
+               (self + 1) / 2
+             elsif self < 0
+               self + 1
+             else
+               0
     end
-    return shrunk
+    shrunk
   end
 
   def retry?
@@ -27,12 +27,12 @@ end
 # String : shrink to ""
 class String
   def shrink
-    shrunk = self.dup
-    if self.size > 0
-      idx = Random::rand(self.size)
-      shrunk[idx] = ""
+    shrunk = dup
+    unless empty?
+      idx = Random.rand(size)
+      shrunk[idx] = ''
     end
-    return shrunk
+    shrunk
   end
 
   def retry?
@@ -40,7 +40,7 @@ class String
   end
 
   def shrinkable?
-    self != ""
+    self != ''
   end
 end
 
@@ -64,39 +64,36 @@ class Tuple
   end
 
   def size
-    self.length
+    length
   end
 
   def to_s
-    @array.to_s.insert(1, "T ")
+    @array.to_s.insert(1, 'T ')
   end
 
   def inspect
-    self.to_s
+    to_s
   end
 
   def each(&block)
     @array.each(&block)
   end
 
-  def array
-    return @array
-  end
+  attr_reader :array
 
   def shrink
     shrunk = @array.dup
     while @position >= 0
       e = @array.at(@position)
-      if e.respond_to?(:shrinkable?) && e.shrinkable?
-        break
-      end
+      break if e.respond_to?(:shrinkable?) && e.shrinkable?
+
       @position -= 1
     end
     if @position >= 0
       shrunk[@position] = e.shrink
       @position -= 1
     end
-    return Tuple.new(shrunk)
+    Tuple.new(shrunk)
   end
 
   def retry?
@@ -104,7 +101,7 @@ class Tuple
   end
 
   def shrinkable?
-    @array.any? {|e| e.respond_to?(:shrinkable?) && e.shrinkable? }
+    @array.any? { |e| e.respond_to?(:shrinkable?) && e.shrinkable? }
   end
 end
 
@@ -128,24 +125,22 @@ class Deflating
   end
 
   def size
-    self.length
+    length
   end
 
   def to_s
-    @array.to_s.insert(1, "D ")
+    @array.to_s.insert(1, 'D ')
   end
 
   def inspect
-    self.to_s
+    to_s
   end
 
   def each(&block)
     @array.each(&block)
   end
 
-  def array
-    return @array
-  end
+  attr_reader :array
 
   def shrink
     shrunk = @array.dup
@@ -158,7 +153,7 @@ class Deflating
       end
       @position -= 1
     end
-    return Deflating.new(shrunk)
+    Deflating.new(shrunk)
   end
 
   def retry?
@@ -172,24 +167,24 @@ end
 
 class Hash
   def shrink
-    if self.any?{|_,v| v.respond_to?(:shrinkable?) && v.shrinkable? }
-      key,_ = self.detect{|_,v| v.respond_to?(:shrinkable?) && v.shrinkable? }
-      clone = self.dup
+    if any? { |_, v| v.respond_to?(:shrinkable?) && v.shrinkable? }
+      key, = detect { |_, v| v.respond_to?(:shrinkable?) && v.shrinkable? }
+      clone = dup
       clone[key] = clone[key].shrink
-      return clone
-    elsif !self.empty?
-      key = self.keys.first
-      h2 = self.dup
+      clone
+    elsif !empty?
+      key = keys.first
+      h2 = dup
       h2.delete(key)
-      return h2
+      h2
     else
-      return self
+      self
     end
   end
 
   def shrinkable?
-    self.any?{|_,v| v.respond_to?(:shrinkable?) && v.shrinkable? } ||
-      !self.empty?
+    any? { |_, v| v.respond_to?(:shrinkable?) && v.shrinkable? } ||
+      !empty?
   end
 
   def retry?

data/lib/rantly/silly.rb

@@ -8,18 +8,17 @@ module Rantly::Silly
 end
 
 module Rantly::Silly::Love
+  def letter(n = 3)
+    body = array(n) { paragraph }.join "\n\n"
+    <<~EOS
+      #{address}:
 
-  def letter(n=3)
-    body = array(n){paragraph}.join "\n\n"
-    <<-EOS
-#{address}:
+      #{body}
 
-#{body}
+      #{sign}
 
-#{sign}
-
-#{post_script}
-EOS
+      #{post_script}
+    EOS
   end
 
   def address
@@ -27,31 +26,34 @@ EOS
   end
 
   def extremifier
-    choose "most","ultimate","unbelievable","incredible","burning"
+    choose 'most', 'ultimate', 'unbelievable', 'incredible', 'burning'
   end
 
   def pedestal_label
-    choose "beloved","desire","dove","virgin goddess","existential solution","lighthouse","beacon","holy mother","queen","mistress"
+    choose 'beloved', 'desire', 'dove', 'virgin goddess', 'existential solution', 'lighthouse', 'beacon', 'holy mother', 'queen', 'mistress'
   end
 
   def double_plus_good
-    choose "holy","shiny","glittering","joyous","delicious"
+    choose 'holy', 'shiny', 'glittering', 'joyous', 'delicious'
   end
 
   def how_i_feel
-    choose "my heart aches","my spine pines","my spirit wanders and wonders","my soul is awed","my loin burns"
+    choose 'my heart aches', 'my spine pines', 'my spirit wanders and wonders', 'my soul is awed', 'my loin burns'
   end
 
   def paragraph
-    array(range(2,4)){ sentence}.join " "
+    array(range(2, 4)) { sentence }.join ' '
   end
 
   def sentence
     freq \
-    Proc.new { "when #{how_i_feel}, my #{pedestal_label}, i feel the need to #{stalk_action}, but this is not because #{how_i_feel}, but rather a symptom of my being your #{whoami}." },
-    Proc.new { "because you are my #{pedestal_label}, and i am your #{whoami}, no, rather your #{whoami}, #{fragment}."},
-    Proc.new { "do not think that saying '#{how_i_feel}' suffices to show the depth of how #{how_i_feel}, because more than that, #{fantasy}"},
-    Proc.new { "as a #{whoami}, that #{how_i_feel} is never quite enough for you, my #{double_plus_good} #{pedestal_label}."}
+      proc {
+        "when #{how_i_feel}, my #{pedestal_label}, i feel the need to #{stalk_action},"\
+             "but this is not because #{how_i_feel}, but rather a symptom of my being your #{whoami}."
+      },
+      proc { "because you are my #{pedestal_label}, and i am your #{whoami}, no, rather your #{whoami}, #{fragment}." },
+      proc { "do not think that saying '#{how_i_feel}' suffices to show the depth of how #{how_i_feel}, because more than that, #{fantasy}" },
+      proc { "as a #{whoami}, that #{how_i_feel} is never quite enough for you, my #{double_plus_good} #{pedestal_label}." }
   end
 
   def fragment
@@ -59,8 +61,7 @@ EOS
     choose "i hope to god #{fun}", "i believe #{fun}", "i will that #{fun}"
   end
 
-  def caused_by
-  end
+  def caused_by; end
 
   def whoami
     "#{extremifier} #{humbleizer} #{groveler}"
@@ -71,11 +72,11 @@ EOS
   end
 
   def humbleizer
-    choose "undeserving","insignificant","unremarkable","fearful","menial"
+    choose 'undeserving', 'insignificant', 'unremarkable', 'fearful', 'menial'
   end
 
   def groveler
-    choose "slave","servant","captive","lapdog"
+    choose 'slave', 'servant', 'captive', 'lapdog'
   end
 
   def post_script
@@ -88,27 +89,28 @@ EOS
 
   def fantasy
     freq \
-    Proc.new {
-      make = choose "raise","nurture","bring into the world"
-      babies = choose "brood of babies","#{double_plus_good} angels"
-      good = double_plus_good
-      effect = choose "the world becomes all the more #{good}",
-                      "we may at the end of our lives rest in #{good} peace.",
-                      "you, my #{pedestal_label}, would continue to live."
-      "we would #{make} #{babies}, so #{effect}."
-    },
-    Proc.new {
-      do_thing = choose "kiss","hug","read poetry to each other","massage","whisper empty nothings into each others' ears","be with each other, and oblivious to the entire world"
-      affect = choose "joy", "mindfulness", "calm", "sanctity"
-      "we would #{do_thing} with #{double_plus_good} #{affect}"
-    }
+      proc {
+        make = choose 'raise', 'nurture', 'bring into the world'
+        babies = choose 'brood of babies', "#{double_plus_good} angels"
+        good = double_plus_good
+        effect = choose "the world becomes all the more #{good}",
+                        "we may at the end of our lives rest in #{good} peace.",
+                        "you, my #{pedestal_label}, would continue to live."
+        "we would #{make} #{babies}, so #{effect}."
+      },
+      proc {
+        do_thing = choose('kiss', 'hug', 'read poetry to each other', 'massage', "whisper empty nothings into each others' ears",
+                          'be with each other, and oblivious to the entire world')
+        affect = choose 'joy', 'mindfulness', 'calm', 'sanctity'
+        "we would #{do_thing} with #{double_plus_good} #{affect}"
+      }
   end
 
   def stalk_action
-    choose "think of you","dream of us together","look at your picture and sigh"
+    choose 'think of you', 'dream of us together', 'look at your picture and sigh'
   end
 
   def time_duration
-    choose "once in a while","night","day","hour","minute"
+    choose 'once in a while', 'night', 'day', 'hour', 'minute'
   end
 end

data/lib/rantly/spec.rb

@@ -1,10 +1,10 @@
 require 'rantly'
 module Rantly::Check
-  def check(n=100,&block)
-    Rantly.gen.each(n,&block)
+  def check(n = 100, &block)
+    Rantly.gen.each(n, &block)
   end
 
-  def sample(n=100,&block)
-    Rantly.gen.map(n,&block)
+  def sample(n = 100, &block)
+    Rantly.gen.map(n, &block)
   end
 end

data/rantly.gemspec

@@ -1,47 +1,42 @@
 Gem::Specification.new do |s|
-  s.name             = "rantly"
-  s.summary          = "Ruby Imperative Random Data Generator and Quickcheck"
-  s.homepage         = "https://github.com/rantly-rb/rantly"
-  s.version          = "1.2.0"
-  s.license          = "MIT"
-  s.require_paths    = ["lib"]
-  s.authors          = ["Ana María Martínez Gómez", "Howard Yeh", "Anthony Bargnesi", "Eric Bischoff"]
-  s.email            = ["anamma06@gmail.com", "hayeah@gmail.com", "abargnesi@gmail.com", "ebischoff@nerim.net"]
+  s.name             = 'rantly'
+  s.summary          = 'Ruby Imperative Random Data Generator and Quickcheck'
+  s.homepage         = 'https://github.com/rantly-rb/rantly'
+  s.version          = '2.0.0'
+  s.license          = 'MIT'
+  s.require_paths    = ['lib']
+  s.authors          = ['Ana María Martínez Gómez', 'Howard Yeh', 'Anthony Bargnesi', 'Eric Bischoff']
+  s.email            = ['anamma06@gmail.com', 'hayeah@gmail.com', 'abargnesi@gmail.com', 'ebischoff@nerim.net']
   s.extra_rdoc_files = [
-    "LICENSE",
-    "README.md",
-    "CHANGELOG.md"
+    'LICENSE',
+    'README.md',
+    'CHANGELOG.md'
   ]
-  s.files            = [
-    ".document",
-    ".travis.yml",
-    "Gemfile",
-    "LICENSE",
-    "README.md",
-    "CHANGELOG.md",
-    "Rakefile",
-    "VERSION.yml",
-    "lib/rantly.rb",
-    "lib/rantly/data.rb",
-    "lib/rantly/generator.rb",
-    "lib/rantly/minitest.rb",
-    "lib/rantly/minitest_extensions.rb",
-    "lib/rantly/property.rb",
-    "lib/rantly/rspec.rb",
-    "lib/rantly/rspec_extensions.rb",
-    "lib/rantly/shrinks.rb",
-    "lib/rantly/silly.rb",
-    "lib/rantly/spec.rb",
-    "lib/rantly/testunit_extensions.rb",
-    "rantly.gemspec",
-    "test/rantly_test.rb",
-    "test/shrinks_test.rb",
-    "test/test_helper.rb"
+  s.files = [
+    '.document',
+    '.travis.yml',
+    'Gemfile',
+    'LICENSE',
+    'README.md',
+    'CHANGELOG.md',
+    'Rakefile',
+    'VERSION.yml',
+    'lib/rantly.rb',
+    'lib/rantly/data.rb',
+    'lib/rantly/generator.rb',
+    'lib/rantly/minitest.rb',
+    'lib/rantly/minitest_extensions.rb',
+    'lib/rantly/property.rb',
+    'lib/rantly/rspec.rb',
+    'lib/rantly/rspec_extensions.rb',
+    'lib/rantly/shrinks.rb',
+    'lib/rantly/silly.rb',
+    'lib/rantly/spec.rb',
+    'lib/rantly/testunit_extensions.rb',
+    'rantly.gemspec',
+    'test/rantly_test.rb',
+    'test/shrinks_test.rb',
+    'test/test_helper.rb'
   ]
-
-  s.add_development_dependency('rake',      '~> 12.0.0')
-  s.add_development_dependency('minitest',  '~> 5.10.0')
-  s.add_development_dependency('simplecov', '>= 0')
-  s.add_development_dependency('coveralls', '>= 0')
+  s.required_ruby_version = '>= 2.4.0'
 end
-