ransack 4.4.1 → 4.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9174f26f96f894e12f75427d0bc4fee92d3cda026ed899f2356b42973d1fb3bf
-  data.tar.gz: aa87e6f2d75557369ca2cf1e7821aaf833490c2793380535d9e5514823ebd117
+  metadata.gz: 4de514e3bd66dcd465c8253260a52e8fa9e40476a6e1d12b09dae4ed1ec8aaaf
+  data.tar.gz: 2f156ce6c2bde6adca76eec24e59cf625e2e53b6922d5a0de370d7a1be75354c
 SHA512:
-  metadata.gz: cdb319a97b23b03a24ac010136212ac53460f03b208e5dff1efae8ff32833256dff1222abbce533e704320740a5bd1cd1d56e14d35d7264a733d0bc1aa75e918
-  data.tar.gz: 12dd3eae7f2cd9bf78d30ab4ae76e5a3ffc80f33ddb3737856cabf3cfb395adf8b9af83eb5feb4e131c8ffd5294e7bf81870da42f7cdbc734288f086902aab96
+  metadata.gz: f4c4983ce0a10d9afc2f538666f98eeee0eb8f9da168fcd30800ded495cff71807d456e1c462530866d7e5c7954a737fd7127f3badcdb511d48bc9eab22b5d89
+  data.tar.gz: 83403fc8e6cfce559597fa844e0ff79b45623dfd285382a2d0d84547263bd8c95f59998c226b7bd5b4c4745e6d70ddf45c6d5e1fd75c9b7278ae4b09592ef150

data/lib/ransack/adapters/active_record/context.rb

@@ -64,6 +64,8 @@ module Ransack
         end
 
         def attribute_method?(str, klass = @klass)
+          return false unless key_within_depth_limit?(str)
+
           exists = false
           if ransackable_attribute?(str, klass)
             exists = true
@@ -237,6 +239,8 @@ module Ransack
         end
 
         def get_parent_and_attribute_name(str, parent = @base)
+          return [parent, nil] unless key_within_depth_limit?(str)
+
           attr_name = nil
 
           if ransackable_attribute?(str, klassify(parent))

data/lib/ransack/constants.rb

@@ -50,6 +50,15 @@ module Ransack
 
     DISTINCT = 'DISTINCT '.freeze
 
+    # The most `_`-separated segments a single condition or sort key may have
+    # before Ransack rejects it as invalid instead of parsing it. Working out
+    # whether a key is an attribute, an `_and_`/`_or_` compound or a path
+    # through associations is superlinear in this count, and the key comes
+    # straight from the query string, so an unbounded one is a CPU-exhaustion
+    # denial of service (GHSA-j3f8-w227-4hh8). No real search key is this
+    # long: OR-ing every column of a very wide table stays well under it.
+    MAX_KEY_DEPTH = 200
+
     DERIVED_PREDICATES = [
       [CONT, {
         arel_predicate: 'matches'.freeze,

data/lib/ransack/context.rb

@@ -47,6 +47,15 @@ module Ransack
       @base = @join_dependency.instance_variable_get(:@join_root)
     end
 
+    # False when a key has more `_`-separated segments than Ransack will
+    # parse. The attribute / association / predicate parsing that follows is
+    # superlinear in the segment count and the key is attacker-controlled, so
+    # an over-long key is treated as unknown rather than parsed
+    # (GHSA-j3f8-w227-4hh8).
+    def key_within_depth_limit?(key)
+      key.to_s.count(Constants::UNDERSCORE) <= Constants::MAX_KEY_DEPTH
+    end
+
     def bind_pair_for(key)
       @bind_pairs ||= {}
 
@@ -124,6 +133,8 @@ module Ransack
     end
 
     def association_path(str, base = @base)
+      return ''.freeze unless key_within_depth_limit?(str)
+
       base = klassify(base)
       str ||= ''.freeze
       path = []

data/lib/ransack/nodes/grouping.rb

@@ -122,6 +122,8 @@ module Ransack
       end
 
       def attribute_method?(name)
+        return false unless @context.key_within_depth_limit?(name)
+
         stripped_name = strip_predicate_and_index(name)
         return true if @context.attribute_method?(stripped_name) ||
                        @context.attribute_method?(name)

data/lib/ransack/search.rb

@@ -160,19 +160,31 @@ module Ransack
       end
     end
 
+    # The largest position a multiparameter key (`created_at(1i)`) may carry.
+    # Rails' date and time selects emit at most six, year to second. The
+    # position indexes an array, so an unbounded one from a crafted query
+    # string would allocate an array that size (GHSA-vxc9-rm8f-p56j).
+    MULTIPARAMETER_POSITION_LIMIT = 16
+
+    # Folds `created_at(1i)`, `created_at(2i)`, ... into `created_at` as an
+    # array of cast values, the way Active Record does for form input. The
+    # keys are untrusted, so a malformed one is dropped rather than raised
+    # on: no position (`created_at(`), a position outside 1 to the limit,
+    # or a fragment for an attribute that was also given as a plain value.
     def collapse_multiparameter_attributes!(attrs)
       attrs.keys.each do |k|
         if k.include?(Constants::LEFT_PARENTHESIS)
           real_attribute, position = k.split(/\(|\)/)
-          cast =
-          if Constants::A_S_I.include?(position.last)
-            position.last
-          else
-            nil
-          end
-          position = position.to_i - 1
           value = attrs.delete(k)
+          next if position.nil?
+
+          cast = Constants::A_S_I.include?(position.last) ? position.last : nil
+          position = position.to_i - 1
+          next if position < 0 || position >= MULTIPARAMETER_POSITION_LIMIT
+
           attrs[real_attribute] ||= []
+          next unless attrs[real_attribute].is_a?(Array)
+
           attrs[real_attribute][position] =
           if cast
             if value.blank? && cast == Constants::I

data/lib/ransack/version.rb

@@ -1,3 +1,3 @@
 module Ransack
-  VERSION = '4.4.1'
+  VERSION = '4.4.3'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ransack
 version: !ruby/object:Gem::Version
-  version: 4.4.1
+  version: 4.4.3
 platform: ruby
 authors:
 - Ernie Miller
@@ -11,7 +11,7 @@ authors:
 - David Rodríguez
 bindir: bin
 cert_chain: []
-date: 2025-09-29 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -130,34 +130,6 @@ files:
 - lib/ransack/translate.rb
 - lib/ransack/version.rb
 - lib/ransack/visitor.rb
-- spec/console.rb
-- spec/factories/articles.rb
-- spec/factories/comments.rb
-- spec/factories/notes.rb
-- spec/factories/people.rb
-- spec/factories/tags.rb
-- spec/helpers/polyamorous_helper.rb
-- spec/helpers/ransack_helper.rb
-- spec/polyamorous/activerecord_compatibility_spec.rb
-- spec/polyamorous/join_association_spec.rb
-- spec/polyamorous/join_dependency_spec.rb
-- spec/polyamorous/join_spec.rb
-- spec/ransack/adapters/active_record/base_spec.rb
-- spec/ransack/adapters/active_record/context_spec.rb
-- spec/ransack/configuration_spec.rb
-- spec/ransack/helpers/form_builder_spec.rb
-- spec/ransack/helpers/form_helper_spec.rb
-- spec/ransack/invalid_search_error_spec.rb
-- spec/ransack/nodes/condition_spec.rb
-- spec/ransack/nodes/grouping_spec.rb
-- spec/ransack/nodes/value_spec.rb
-- spec/ransack/predicate_spec.rb
-- spec/ransack/ransacker_spec.rb
-- spec/ransack/search_spec.rb
-- spec/ransack/translate_spec.rb
-- spec/spec_helper.rb
-- spec/support/en.yml
-- spec/support/schema.rb
 homepage: https://github.com/activerecord-hackery/ransack
 licenses:
 - MIT
@@ -177,35 +149,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Object-based searching for Active Record.
-test_files:
-- spec/console.rb
-- spec/factories/articles.rb
-- spec/factories/comments.rb
-- spec/factories/notes.rb
-- spec/factories/people.rb
-- spec/factories/tags.rb
-- spec/helpers/polyamorous_helper.rb
-- spec/helpers/ransack_helper.rb
-- spec/polyamorous/activerecord_compatibility_spec.rb
-- spec/polyamorous/join_association_spec.rb
-- spec/polyamorous/join_dependency_spec.rb
-- spec/polyamorous/join_spec.rb
-- spec/ransack/adapters/active_record/base_spec.rb
-- spec/ransack/adapters/active_record/context_spec.rb
-- spec/ransack/configuration_spec.rb
-- spec/ransack/helpers/form_builder_spec.rb
-- spec/ransack/helpers/form_helper_spec.rb
-- spec/ransack/invalid_search_error_spec.rb
-- spec/ransack/nodes/condition_spec.rb
-- spec/ransack/nodes/grouping_spec.rb
-- spec/ransack/nodes/value_spec.rb
-- spec/ransack/predicate_spec.rb
-- spec/ransack/ransacker_spec.rb
-- spec/ransack/search_spec.rb
-- spec/ransack/translate_spec.rb
-- spec/spec_helper.rb
-- spec/support/en.yml
-- spec/support/schema.rb
+test_files: []

data/spec/console.rb

@@ -1,13 +0,0 @@
-Bundler.setup
-require 'factory_bot'
-require 'faker'
-require 'ransack'
-
-Dir[File.expand_path('../../spec/{helpers,support,factories}/*.rb', __FILE__)]
-.each do |f|
-  require f
-end
-
-Faker::Config.random = Random.new(0)
-
-Schema.create

data/spec/factories/articles.rb

@@ -1,7 +0,0 @@
-FactoryBot.define do
-  factory :article do
-    association :person
-    title { Faker::Lorem.sentence }
-    body { Faker::Lorem.paragraph }
-  end
-end

data/spec/factories/comments.rb

@@ -1,7 +0,0 @@
-FactoryBot.define do
-  factory :comment do
-    association :article
-    association :person
-    body { Faker::Lorem.paragraph }
-  end
-end

data/spec/factories/notes.rb

@@ -1,13 +0,0 @@
-FactoryBot.define do
-  factory :note do
-    note { Faker::Lorem.words(number: 7).join(' ') }
-    
-    trait :for_person do
-      association :notable, factory: :person
-    end
-    
-    trait :for_article do
-      association :notable, factory: :article
-    end
-  end
-end

data/spec/factories/people.rb

@@ -1,10 +0,0 @@
-FactoryBot.define do
-  factory :person do
-    name { Faker::Name.name }
-    email { "test@example.com" }
-    sequence(:salary) { |n| 30000 + (n * 1000) }
-    only_sort { Faker::Lorem.words(number: 3).join(' ') }
-    only_search { Faker::Lorem.words(number: 3).join(' ') }
-    only_admin { Faker::Lorem.words(number: 3).join(' ') }
-  end
-end

data/spec/factories/tags.rb

@@ -1,5 +0,0 @@
-FactoryBot.define do
-  factory :tag do
-    name { Faker::Lorem.words(number: 3).join(' ') }
-  end
-end

data/spec/helpers/polyamorous_helper.rb

@@ -1,13 +0,0 @@
-module PolyamorousHelper
-  def new_join_association(reflection, children, klass)
-    Polyamorous::JoinAssociation.new reflection, children, klass
-  end
-
-  def new_join_dependency(klass, associations = {})
-    Polyamorous::JoinDependency.new klass, klass.arel_table, associations, Polyamorous::InnerJoin
-  end
-
-  def new_join(name, type = Polyamorous::InnerJoin, klass = nil)
-    Polyamorous::Join.new name, type, klass
-  end
-end

data/spec/helpers/ransack_helper.rb

@@ -1,9 +0,0 @@
-module RansackHelper
-  def quote_table_name(table)
-    ActiveRecord::Base.connection.quote_table_name(table)
-  end
-
-  def quote_column_name(column)
-    ActiveRecord::Base.connection.quote_column_name(column)
-  end
-end

data/spec/polyamorous/activerecord_compatibility_spec.rb

@@ -1,15 +0,0 @@
-require 'spec_helper'
-
-module Polyamorous
-  describe "ActiveRecord Compatibility" do
-    it 'works with self joins and includes' do
-      trade_account = Account.create!
-      Account.create!(trade_account: trade_account)
-
-      accounts = Account.joins(:trade_account).includes(:trade_account, :agent_account)
-      account = accounts.first
-
-      expect(account.agent_account).to be_nil
-    end
-  end
-end

data/spec/polyamorous/join_association_spec.rb

@@ -1,29 +0,0 @@
-require 'spec_helper'
-
-module Polyamorous
-  describe JoinAssociation do
-    let(:join_dependency) { new_join_dependency Note, {} }
-    let(:reflection) { Note.reflect_on_association(:notable) }
-    let(:parent) { join_dependency.send(:join_root) }
-    let(:join_association) {
-      new_join_association(reflection, parent.children, Article)
-    }
-
-    subject { new_join_association(reflection, parent.children, Person) }
-
-    it 'leaves the original reflection intact for thread safety' do
-      reflection.instance_variable_set(:@klass, Article)
-      join_association
-      .swapping_reflection_klass(reflection, Person) do |new_reflection|
-        expect(new_reflection.options).not_to equal reflection.options
-        expect(new_reflection.options).not_to have_key(:polymorphic)
-        expect(new_reflection.klass).to eq(Person)
-        expect(reflection.klass).to eq(Article)
-      end
-    end
-
-    it 'sets the polymorphic option to true after initializing' do
-      expect(join_association.reflection.options[:polymorphic]).to be true
-    end
-  end
-end

data/spec/polyamorous/join_dependency_spec.rb

@@ -1,80 +0,0 @@
-require 'spec_helper'
-
-module Polyamorous
-  describe JoinDependency do
-    context 'with symbol joins' do
-      subject { new_join_dependency Person, articles: :comments }
-
-      specify { expect(subject.send(:join_root).drop(1).size)
-        .to eq(2) }
-      specify { expect(subject.send(:join_root).drop(1).map(&:join_type).uniq)
-        .to eq [Polyamorous::InnerJoin] }
-    end
-
-    context 'with has_many :through association' do
-      subject { new_join_dependency Person, :authored_article_comments }
-
-      specify { expect(subject.send(:join_root).drop(1).size)
-        .to eq 1 }
-      specify { expect(subject.send(:join_root).drop(1).first.table_name)
-        .to eq 'comments' }
-    end
-
-    context 'with outer join' do
-      subject { new_join_dependency Person, new_join(:articles, :outer) }
-
-      specify { expect(subject.send(:join_root).drop(1).size)
-        .to eq 1 }
-      specify { expect(subject.send(:join_root).drop(1).first.join_type)
-        .to eq Polyamorous::OuterJoin }
-    end
-
-    context 'with nested outer joins' do
-      subject { new_join_dependency Person,
-        new_join(:articles, :outer) => new_join(:comments, :outer) }
-
-      specify { expect(subject.send(:join_root).drop(1).size)
-        .to eq 2 }
-      specify { expect(subject.send(:join_root).drop(1).map(&:join_type))
-        .to eq [Polyamorous::OuterJoin, Polyamorous::OuterJoin] }
-      specify { expect(subject.send(:join_root).drop(1).map(&:join_type).uniq)
-        .to eq [Polyamorous::OuterJoin] }
-    end
-
-    context 'with polymorphic belongs_to join' do
-      subject { new_join_dependency Note, new_join(:notable, :inner, Person) }
-
-      specify { expect(subject.send(:join_root).drop(1).size)
-        .to eq 1 }
-      specify { expect(subject.send(:join_root).drop(1).first.join_type)
-        .to eq Polyamorous::InnerJoin }
-      specify { expect(subject.send(:join_root).drop(1).first.table_name)
-        .to eq 'people' }
-    end
-
-    context 'with polymorphic belongs_to join and nested symbol join' do
-      subject { new_join_dependency Note,
-        new_join(:notable, :inner, Person) => :comments }
-
-      specify { expect(subject.send(:join_root).drop(1).size)
-        .to eq 2 }
-      specify { expect(subject.send(:join_root).drop(1).map(&:join_type).uniq)
-        .to eq [Polyamorous::InnerJoin] }
-      specify { expect(subject.send(:join_root).drop(1).first.table_name)
-        .to eq 'people' }
-      specify { expect(subject.send(:join_root).drop(1)[1].table_name)
-        .to eq 'comments' }
-    end
-
-    context 'with polymorphic belongs_to join and nested join' do
-      subject { new_join_dependency Note,
-        new_join(:notable, :outer, Person) => :comments }
-      specify { expect(subject.send(:join_root).drop(1).size).to eq 2 }
-      specify { expect(subject.send(:join_root).drop(1).map(&:join_type)).to eq [Polyamorous::OuterJoin, Polyamorous::InnerJoin] }
-      specify { expect(subject.send(:join_root).drop(1).first.table_name)
-        .to eq 'people' }
-      specify { expect(subject.send(:join_root).drop(1)[1].table_name)
-        .to eq 'comments' }
-    end
-  end
-end

data/spec/polyamorous/join_spec.rb

@@ -1,19 +0,0 @@
-require 'spec_helper'
-
-module Polyamorous
-  describe Join do
-    it 'is a tree node' do
-      join = new_join(:articles, :outer)
-      expect(join).to be_kind_of(TreeNode)
-    end
-
-    it 'can be added to a tree' do
-      join = new_join(:articles, :outer)
-
-      tree_hash = {}
-      join.add_to_tree(tree_hash)
-
-      expect(tree_hash[join]).to be {}
-    end
-  end
-end