ransack 1.8.4 → 3.2.1

data/spec/ransack/nodes/condition_spec.rb

@@ -3,6 +3,19 @@ require 'spec_helper'
 module Ransack
   module Nodes
     describe Condition do
+      context 'bug report #1245' do
+        it 'preserves tuple behavior' do
+          ransack_hash = {
+              m: 'and',
+              g: [
+                { title_type_in: ['["title 1", ""]'] }
+              ]
+            }
+
+          sql = Article.ransack(ransack_hash).result.to_sql
+          expect(sql).to include("IN (('title 1', ''))")
+        end
+      end
 
       context 'with an alias' do
         subject {

data/spec/ransack/nodes/grouping_spec.rb

@@ -80,7 +80,7 @@ module Ransack
                 'a' => {
                   '0' => {
                     'name' => 'with_arguments',
-                    'ransacker_args' => [1,2]
+                    'ransacker_args' => [1, 2]
                   }
                 },
                 'p' => 'eq',
@@ -90,7 +90,7 @@ module Ransack
                 'a' => {
                   '0' => {
                     'name' => 'with_arguments',
-                    'ransacker_args' => [3,4]
+                    'ransacker_args' => [3, 4]
                   }
                 },
                 'p' => 'eq',

data/spec/ransack/nodes/value_spec.rb

@@ -0,0 +1,115 @@
+require 'spec_helper'
+
+module Ransack
+  module Nodes
+    describe Value do
+      let(:context) { Context.for(Person) }
+
+      subject do
+        Value.new(context, raw_value)
+      end
+
+      context "with a date value" do
+        let(:raw_value) { "2022-05-23" }
+
+        [:date].each do |type|
+          it "should cast #{type} correctly" do
+            result = subject.cast(type)
+
+            expect(result).to be_a_kind_of(Date)
+            expect(result).to eq(Date.parse(raw_value))
+          end
+        end
+      end
+
+      context "with a timestamp value" do
+        let(:raw_value) { "2022-05-23 10:40:02 -0400" }
+
+        [:datetime, :timestamp, :time, :timestamptz].each do |type|
+          it "should cast #{type} correctly" do
+            result = subject.cast(type)
+
+            expect(result).to be_a_kind_of(Time)
+            expect(result).to eq(Time.zone.parse(raw_value))
+          end
+        end
+      end
+
+      Constants::TRUE_VALUES.each do |value|
+        context "with a true boolean value (#{value})" do
+          let(:raw_value) { value.to_s }
+
+          it "should cast boolean correctly" do
+            result = subject.cast(:boolean)
+            expect(result).to eq(true)
+          end
+        end
+      end
+
+      Constants::FALSE_VALUES.each do |value|
+        context "with a false boolean value (#{value})" do
+          let(:raw_value) { value.to_s }
+
+          it "should cast boolean correctly" do
+            result = subject.cast(:boolean)
+
+            expect(result).to eq(false)
+          end
+        end
+      end
+
+      ["12", "101.5"].each do |value|
+        context "with an integer value (#{value})" do
+          let(:raw_value) { value }
+
+          it "should cast #{value} to integer correctly" do
+            result = subject.cast(:integer)
+
+            expect(result).to be_an(Integer)
+            expect(result).to eq(value.to_i)
+          end
+        end
+      end
+
+      ["12", "101.5"].each do |value|
+        context "with a float value (#{value})" do
+          let(:raw_value) { value }
+
+          it "should cast #{value} to float correctly" do
+            result = subject.cast(:float)
+
+            expect(result).to be_an(Float)
+            expect(result).to eq(value.to_f)
+          end
+        end
+      end
+
+      ["12", "101.5"].each do |value|
+        context "with a decimal value (#{value})" do
+          let(:raw_value) { value }
+
+          it "should cast #{value} to decimal correctly" do
+            result = subject.cast(:decimal)
+
+            expect(result).to be_a(BigDecimal)
+            expect(result).to eq(value.to_d)
+          end
+        end
+      end
+
+      ["12", "101.513"].each do |value|
+        context "with a money value (#{value})" do
+          let(:raw_value) { value }
+
+          it "should cast #{value} to money correctly" do
+            result = subject.cast(:money)
+
+            expect(result).to be_a(String)
+            expect(result).to eq(value.to_f.to_s)
+          end
+        end
+      end
+
+    end
+  end
+end

data/spec/ransack/predicate_spec.rb

@@ -126,7 +126,7 @@ module Ransack
         (if ActiveRecord::Base.connection.adapter_name == "PostgreSQL"
           /"people"."name" ILIKE '%\\%\\.\\_\\\\%'/
         elsif ActiveRecord::Base.connection.adapter_name == "Mysql2"
-          /`people`.`name` LIKE '%\\\\%\\\\.\\\\_\\\\\\\\%'/
+          /`people`.`name` LIKE '%\\\\%.\\\\_\\\\\\\\%'/
         else
          /"people"."name" LIKE '%%._\\%'/
         end) do
@@ -145,7 +145,7 @@ module Ransack
         (if ActiveRecord::Base.connection.adapter_name == "PostgreSQL"
           /"people"."name" NOT ILIKE '%\\%\\.\\_\\\\%'/
         elsif ActiveRecord::Base.connection.adapter_name == "Mysql2"
-          /`people`.`name` NOT LIKE '%\\\\%\\\\.\\\\_\\\\\\\\%'/
+          /`people`.`name` NOT LIKE '%\\\\%.\\\\_\\\\\\\\%'/
         else
          /"people"."name" NOT LIKE '%%._\\%'/
         end) do
@@ -159,6 +159,44 @@ module Ransack
       end
     end
 
+    describe 'i_cont' do
+      it_has_behavior 'wildcard escaping', :name_i_cont,
+        (if ActiveRecord::Base.connection.adapter_name == "PostgreSQL"
+          /"people"."name" ILIKE '%\\%\\.\\_\\\\%'/
+        elsif ActiveRecord::Base.connection.adapter_name == "Mysql2"
+          /LOWER\(`people`.`name`\) LIKE '%\\\\%.\\\\_\\\\\\\\%'/
+        else
+         /LOWER\("people"."name"\) LIKE '%%._\\%'/
+        end) do
+        subject { @s }
+      end
+
+      it 'generates a LIKE query with LOWER(column) and value surrounded by %' do
+        @s.name_i_cont = 'Ric'
+        field = "#{quote_table_name("people")}.#{quote_column_name("name")}"
+        expect(@s.result.to_sql).to match /[LOWER\(]?#{field}\)? I?LIKE '%ric%'/
+      end
+    end
+
+    describe 'not_i_cont' do
+      it_has_behavior 'wildcard escaping', :name_not_i_cont,
+        (if ActiveRecord::Base.connection.adapter_name == "PostgreSQL"
+          /"people"."name" NOT ILIKE '%\\%\\.\\_\\\\%'/
+        elsif ActiveRecord::Base.connection.adapter_name == "Mysql2"
+          /LOWER\(`people`.`name`\) NOT LIKE '%\\\\%.\\\\_\\\\\\\\%'/
+        else
+         /LOWER\("people"."name"\) NOT LIKE '%%._\\%'/
+        end) do
+        subject { @s }
+      end
+
+      it 'generates a NOT LIKE query with LOWER(column) and value surrounded by %' do
+        @s.name_not_i_cont = 'Ric'
+        field = "#{quote_table_name("people")}.#{quote_column_name("name")}"
+        expect(@s.result.to_sql).to match /[LOWER\(]?#{field}\)? NOT I?LIKE '%ric%'/
+      end
+    end
+
     describe 'start' do
       it 'generates a LIKE query with value followed by %' do
         @s.name_start = 'Er'
@@ -381,6 +419,20 @@ module Ransack
       end
     end
 
+    context "defining custom predicates" do
+      describe "with 'not_in' arel predicate" do
+        before do
+          Ransack.configure { |c| c.add_predicate "not_in_csv", arel_predicate: "not_in", formatter: proc { |v| v.split(",") } }
+        end
+
+        it 'generates a value IS NOT NULL query' do
+          @s.name_not_in_csv = ["a", "b"]
+          field = "#{quote_table_name("people")}.#{quote_column_name("name")}"
+          expect(@s.result.to_sql).to match /#{field} NOT IN \('a', 'b'\)/
+        end
+      end
+    end
+
     private
 
       def test_boolean_equality_for(boolean_value)