ranked-model 0.4.8 → 0.4.11

data/lib/ranked-model/version.rb

@@ -1,3 +1,3 @@
 module RankedModel
-  VERSION = "0.4.8"
+  VERSION = "0.4.11"
 end

data/ranked-model.gemspec

@@ -13,7 +13,9 @@ Gem::Specification.new do |s|
   s.description = %q{ranked-model is a modern row sorting library built for Rails 4.2+. It uses ARel aggressively and is better optimized than most other libraries.}
   s.license     = 'MIT'
 
-  s.add_dependency "activerecord", ">= 4.2"
+  s.metadata["funding_uri"] = "https://github.com/sponsors/brendon"
+
+  s.add_dependency "activerecord", ">= 5.2"
   s.add_development_dependency "rspec", "~> 3"
   s.add_development_dependency "rspec-its"
   s.add_development_dependency "mocha"

data/spec/duck-model/inferred_ducks_spec.rb

@@ -0,0 +1,71 @@
+require "spec_helper"
+
+describe Duck do
+  before do
+    5.times do |i|
+      Duck.create(name: "Duck #{i + 1}")
+    end
+  end
+
+  describe "updating a duck order with last" do
+    it "should maintain the order after creating a new duck" do
+      duck = Duck.first
+      duck.update(row_position: :last)
+      expect(duck.row_rank).to eq(4)
+
+      Duck.create(name: "Wacky")
+
+      expect(duck.row_rank).to eq(4)
+
+      duck.update(pond: 'Shin')
+      expect(duck.row_rank).to eq(4)
+    end
+  end
+
+  describe "updating a duck order with first" do
+    it "should maintain the order after creating a new duck" do
+      duck = Duck.last
+      duck.update(row_position: :first)
+      expect(duck.row_rank).to eq(0)
+
+      Duck.create(name: "Wacky")
+
+      expect(duck.row_rank).to eq(0)
+
+      duck.update(pond: 'Shin')
+      expect(duck.row_rank).to eq(0)
+    end
+  end
+
+  describe "updating a duck order with up" do
+    it "should maintain the order after creating a new duck" do
+      duck_id = Duck.ranker(:row).with(Duck.new).current_at_position(2).instance.id
+      duck = Duck.find(duck_id)
+      duck.update(row_position: :up)
+      expect(duck.row_rank).to eq(1)
+
+      Duck.create(name: "Wacky")
+
+      expect(duck.row_rank).to eq(1)
+
+      duck.update(pond: 'Shin')
+      expect(duck.row_rank).to eq(1)
+    end
+  end
+
+  describe "updating a duck order with down" do
+    it "should maintain the order after creating a new duck" do
+      duck_id = Duck.ranker(:row).with(Duck.new).current_at_position(2).instance.id
+      duck = Duck.find(duck_id)
+      duck.update(row_position: :down)
+      expect(duck.row_rank).to eq(3)
+
+      Duck.create(name: "Wacky")
+
+      expect(duck.row_rank).to eq(3)
+
+      duck.update(pond: 'Shin')
+      expect(duck.row_rank).to eq(3)
+    end
+  end
+end

data/spec/notifications_spec.rb

@@ -0,0 +1,89 @@
+require "spec_helper"
+
+describe "notifications" do
+  before do
+    @notifications_count = 0
+    @notification_payloads = []
+
+    ActiveSupport::Notifications.subscribe("ranked_model.ranks_updated") do |name, start, finish, id, payload|
+      @notifications_count += 1
+      @notification_payloads << payload
+    end
+  end
+
+  after do
+    ActiveSupport::Notifications.unsubscribe("ranked_model.ranks_updated")
+  end
+
+  context "when rearranging" do
+    it "notifies subscribers with the instance" do
+      Number.create(order: RankedModel::MAX_RANK_VALUE)
+      second_number = Number.create(order: RankedModel::MAX_RANK_VALUE)
+
+      expect(@notifications_count).to eq(1)
+      expect(@notification_payloads.last[:instance]).to eq(second_number)
+    end
+
+    context "with scope" do
+      it "notifies subscribers with the instance and scope" do
+        Duck.create(size: RankedModel::MAX_RANK_VALUE, pond: "Shin")
+        second_duck = Duck.create(size: RankedModel::MAX_RANK_VALUE, pond: "Shin")
+
+        expect(@notifications_count).to eq(1)
+        expect(@notification_payloads.last[:instance]).to eq(second_duck)
+        expect(@notification_payloads.last[:scope]).to eq(:in_shin_pond)
+      end
+    end
+
+    context "with with_same" do
+      it "notifies subscribers with the instance and with_same" do
+        Duck.create(age: RankedModel::MAX_RANK_VALUE, pond: "Shin")
+        second_duck = Duck.create(age: RankedModel::MAX_RANK_VALUE, pond: "Shin")
+
+        expect(@notifications_count).to eq(1)
+        expect(@notification_payloads.last[:instance]).to eq(second_duck)
+        expect(@notification_payloads.last[:with_same]).to eq(:pond)
+      end
+    end
+  end
+
+  context "when rebalancing" do
+    it "notifies subscribers with the instance" do
+      31.times { Number.create }
+      thirty_second_number = Number.create
+
+      expect(@notifications_count).to eq(1)
+      expect(@notification_payloads.last[:instance]).to eq(thirty_second_number)
+    end
+
+    context "with scope" do
+      it "notifies subscribers with the instance and scope" do
+        31.times { Duck.create(pond: "Shin") }
+        thirty_second_duck = Duck.create(pond: "Shin")
+
+        expect(@notifications_count).to eq(4) # Duck has four ranks
+        expect(@notification_payloads.last[:instance]).to eq(thirty_second_duck)
+        expect(@notification_payloads.map { |p| p[:scope] }).to include(:in_shin_pond)
+      end
+    end
+
+    context "with with_same" do
+      it "notifies subscribers with the instance and with_same" do
+        31.times { Duck.create(pond: "Shin") }
+        thirty_second_duck = Duck.create(pond: "Shin")
+
+        expect(@notifications_count).to eq(4)
+        expect(@notification_payloads.last[:instance]).to eq(thirty_second_duck)
+        expect(@notification_payloads.map { |p| p[:with_same] }).to include(:pond)
+      end
+    end
+  end
+
+  context "when not rearranging or rebalancing" do
+    it "does not notify subscribers" do
+      Number.create
+
+      expect(@notifications_count).to eq(0)
+    end
+  end
+end

data/spec/support/database.yml

@@ -6,6 +6,7 @@ sqlite:
 
 mysql:
   adapter: mysql2
+  host: 127.0.0.1
   database: ranked_model_test
   pool: 5
   timeout: 5000
@@ -14,6 +15,7 @@ mysql:
 
 postgresql:
   adapter: postgresql
+  host: 127.0.0.1
   database: ranked_model_test
   pool: 5
   timeout: 5000

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ranked-model
 version: !ruby/object:Gem::Version
-  version: 0.4.8
+  version: 0.4.11
 platform: ruby
 authors:
 - Matthew Beale
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-07 00:00:00.000000000 Z
+date: 2024-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.2'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -130,20 +130,22 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/FUNDING.yml"
+- ".github/dependabot.yml"
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
 - Appraisals
+- CHANGELOG.md
 - Gemfile
 - LICENSE
 - Rakefile
 - Readme.mkd
-- gemfiles/rails_4_2.gemfile
-- gemfiles/rails_5_0.gemfile
-- gemfiles/rails_5_1.gemfile
 - gemfiles/rails_5_2.gemfile
 - gemfiles/rails_6_0.gemfile
 - gemfiles/rails_6_1.gemfile
+- gemfiles/rails_7_0.gemfile
 - lib/ranked-model.rb
 - lib/ranked-model/railtie.rb
 - lib/ranked-model/ranker.rb
@@ -152,9 +154,11 @@ files:
 - ranked-model.gemspec
 - spec/duck-model/column_default_ducks_spec.rb
 - spec/duck-model/duck_spec.rb
+- spec/duck-model/inferred_ducks_spec.rb
 - spec/duck-model/lots_of_ducks_spec.rb
 - spec/duck-model/wrong_ducks_spec.rb
 - spec/ego-model/ego_spec.rb
+- spec/notifications_spec.rb
 - spec/number-model/number_spec.rb
 - spec/player-model/records_already_exist_spec.rb
 - spec/ranked-model/ranker_spec.rb
@@ -168,7 +172,8 @@ files:
 homepage: https://github.com/mixonic/ranked-model
 licenses:
 - MIT
-metadata: {}
+metadata:
+  funding_uri: https://github.com/sponsors/brendon
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -191,9 +196,11 @@ summary: An acts_as_sortable replacement built for Rails 4.2+
 test_files:
 - spec/duck-model/column_default_ducks_spec.rb
 - spec/duck-model/duck_spec.rb
+- spec/duck-model/inferred_ducks_spec.rb
 - spec/duck-model/lots_of_ducks_spec.rb
 - spec/duck-model/wrong_ducks_spec.rb
 - spec/ego-model/ego_spec.rb
+- spec/notifications_spec.rb
 - spec/number-model/number_spec.rb
 - spec/player-model/records_already_exist_spec.rb
 - spec/ranked-model/ranker_spec.rb

data/gemfiles/rails_4_2.gemfile

@@ -1,23 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "activerecord", "~> 4.2.0"
-
-group :sqlite do
-  gem "sqlite3", "~> 1.3.13", platform: :ruby
-  gem "activerecord-jdbcsqlite3-adapter", "~> 1.3.24", platform: :jruby
-end
-
-group :postgresql do
-  gem "pg", "~> 0.18.4", platform: :ruby
-  gem "activerecord-jdbcpostgresql-adapter", "~> 1.3.24", platform: :jruby
-end
-
-group :mysql do
-  gem "mysql2", "~> 0.4.0", platform: :ruby
-  gem "jdbc-mysql", "~> 5.1.47", platform: :jruby
-  gem "activerecord-jdbcmysql-adapter", "~> 1.3.24", platform: :jruby
-end
-
-gemspec path: "../"

data/gemfiles/rails_5_0.gemfile

@@ -1,22 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "activerecord", "~> 5.0.0"
-
-group :sqlite do
-  gem "sqlite3", "~> 1.3.13", platform: :ruby
-  gem "activerecord-jdbcsqlite3-adapter", "~> 50.0", platform: :jruby
-end
-
-group :postgresql do
-  gem "pg", "~> 1.2.0", platform: :ruby
-  gem "activerecord-jdbcpostgresql-adapter", "~> 50.0", platform: :jruby
-end
-
-group :mysql do
-  gem "mysql2", "~> 0.5.0", platform: :ruby
-  gem "activerecord-jdbcmysql-adapter", "~> 50.0", platform: :jruby
-end
-
-gemspec path: "../"

data/gemfiles/rails_5_1.gemfile

@@ -1,22 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "activerecord", "~> 5.1.0"
-
-group :sqlite do
-  gem "sqlite3", "~> 1.3.13", platform: :ruby
-  gem "activerecord-jdbcsqlite3-adapter", "~> 51.0", platform: :jruby
-end
-
-group :postgresql do
-  gem "pg", "~> 1.2.0", platform: :ruby
-  gem "activerecord-jdbcpostgresql-adapter", "~> 51.0", platform: :jruby
-end
-
-group :mysql do
-  gem "mysql2", "~> 0.5.0", platform: :ruby
-  gem "activerecord-jdbcmysql-adapter", "~> 51.0", platform: :jruby
-end
-
-gemspec path: "../"