randpass 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 64d1df5909d0a6d92321fddb99e997280e97ca98b02b96ba58e3a22e95ba6ff1
-  data.tar.gz: 020db401b7394baf1edeb26c224bba110ea61216dd5d2f0b56df8486fe5b8ed5
+  metadata.gz: 56fe4a3d0922ef73687911332685af59657369380b77514e533ede43854cee86
+  data.tar.gz: 6f9adf346eb9fc6339964201aee71563ec41ce7b3c68b8e4a82fbaa90c94e924
 SHA512:
-  metadata.gz: 1a38b3a3e9d8f19ef6759b5d031b7f41a657930d98bf56835887cc1b6e789ba8d3a0dfc03ba1d4bb5db46efaebc39a79cc2e936ba04d4f8d7de3e130b2c681e5
-  data.tar.gz: 728d609352f004349c6bb8a8c62101973378febfe200f815c4a8ac30d9c5c30f7a433c022d02827123106aaf4d588e933afec61ece7da14817e762dac65ce31c
+  metadata.gz: 938d2f69909daca1f9488c8ea23837a29caa25a995039a7b526e6a1d9c5ce66035fde1a62135544f52950028e55c952cc8b8aa077f8ed4b68d9521a5c914ba15
+  data.tar.gz: b7ec2a62282de7423cc955b4073fd0acf9a43dc7494721a6bc7b111a753557de8b5bac6b9b90e71a947f633f5285bc579549329a139b3e8b554d6040d568dc5e

data/README.md

@@ -22,20 +22,20 @@ git clone https://www.github.com/alx3dev/randpass \
 cd randpass && bundle install
 ```
 
-To build your own gem, run `rake bundle`, and install it locally with `gem install pkg/randpass-0.1.1.gem`
+To build your own gem, run `rake bundle`, and install it locally with `gem install pkg/randpass-0.1.3.gem`
 
 ## How to use:
 
  - use from terminal
 
 ```
-# default 18 characters
+# default 22 characters
 randpass
- => 3!J_GApnCy4Mor1hMPbI?LhT
+ => W4fkGVdXx6pzk$O?VP11!wWs
 
 # or add number of characters as argument
-randpass 30
- => zBv2BXVB/X2WJMqzSE%VRe#Sg!/0_wYpvJC1gyHU
+randpass 33
+ => etkK$YW1R_PXK8FsjnGHr+%w2cTBbMTOTej3s8je?2ya
  
  # install from rubygems, or build your own version, otherwise you need to run:
  bin/randpass
@@ -48,7 +48,7 @@ require 'randpass'
 Randpass[20]
 # or
 Randpass.randpass 20
- => "0!ZNiAUZCbjo!#hHeX+XX$eAC=!p"
+ => "1L3Jk$S850Np=ikQ7zeqb44qaBC9"
 ```
 
 Randpass is a module with both class and instance methods `#randpass`, so you can include/extend it in your class.

data/bin/randpass

@@ -4,7 +4,7 @@
 require_relative '../lib/randpass'
 
 pass = if ARGV.empty?
-         Randpass[18]
+         Randpass[22]
        else
          Randpass.randpass ARGV[0].to_i
        end

data/lib/randpass/random.rb

@@ -6,27 +6,33 @@ require 'securerandom'
 # random special characters. Method #randpass is defined as
 # class and instance method, so you can call it or include it.
 #
-# @note Always shuffle #base64 if it has less than 16 chars, because they end with '=='
-#
 module Randpass
-  #
+  # Allowed specials. xxx is just a flag for #add_special_chars
+  ARRAY = %w[! # * $ % _ @ xxx].freeze
+
   # Random number of times try to add random special character.
-  # Transform to array, shuffle, and join back to string
+  # Transform to array, shuffle, and join back to string.
+  #
+  # Provide number of characters for password as argument,
+  # default value is **22**.
   #
-  # @param [Integer] number_of_chars **Required**. Number of password characters.
+  # @param [Integer] number_of_chars Optional. Number of password characters.
   # @return [String]
   #
-  def randpass(number_of_chars)
+  def randpass(number_of_chars = nil)
     Randpass[number_of_chars]
   end
 
   class << self
     # @return [String]
-    def randpass(number_of_chars)
-      param = SecureRandom.base64(number_of_chars)
-      rand(5..10).times do
-        param = add_special_chars(param)
+    def randpass(number_of_chars = 20)
+      # slice string made with base64, to number of characters we want
+      param = SecureRandom.base64(number_of_chars)[0...number_of_chars]
+
+      rand(param.size / 2).times do
+        param = add_special_characters(param)
       end
+
       param.split('').shuffle.join
     end
 
@@ -34,25 +40,12 @@ module Randpass
 
     private
 
-    # rubocop:disable Metrics/MethodLength
-    def add_special_chars(param)
-      # bigger number than options - we don't want
-      # same number of special chars each time
-      count = SecureRandom.random_number 15_000
-
-      char = case count
-             when 1...1000    then '_'
-             when 1000...2000 then '!'
-             when 2000...3000 then '#'
-             when 3000...4000 then '$'
-             when 4000...5000 then '%'
-             when 6000...7000 then '?'
-             else return param
-             end
-
-      param[rand(param.size)] = char
+    def add_special_characters(param)
+      char = ARRAY.shuffle[rand(ARRAY.size)]
+      return param if char == 'xxx'
+
+      param[rand(param.size)] = char.to_s
       param
     end
-    # rubocop:enable Metrics/MethodLength
   end
 end

data/lib/randpass/version.rb

@@ -2,5 +2,5 @@
 
 module Randpass
   # gem version
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: randpass
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - alx3dev
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-21 00:00:00.000000000 Z
+date: 2022-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -62,7 +62,7 @@ metadata:
   source_code_uri: https://github.com/alx3dev/randpass
   bug_tracker_uri: https://github.com/alx3dev/randpass/issues
   changelog_uri: https://github.com/alx3dev/randpass/changelog.md
-  documentation_uri: https://rubydoc.info/gems/randpass/0.1.2
+  documentation_uri: https://rubydoc.info/gems/randpass/0.1.3
   rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []