random_name_generator 4.0.1 → 4.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f728099d28460a59f2c78c3d43ca48deed8588040141a0ba14fc52b0c8285185
-  data.tar.gz: 32174e3c901a12ab6da5eaf23a4ebf6671f07679869e061b953e0460326f8a67
+  metadata.gz: d7374613642f2111c5c4f4cff427d6ee2c88a99cacc5d4755b2eed1584c293b7
+  data.tar.gz: 78e17730bcaa7e74632f7c2063caeb0f4b31cc7f8de61435ca872969dede788c
 SHA512:
-  metadata.gz: 0bd991d716f21b3fd88d62766d8afbfe9dd8edc086dd14577ab5ad7f87fbd04d9b45fc2eb689cc8e54d6cb062cc34bb414f6602e8538c2f28f17e7cd7584dd2d
-  data.tar.gz: a78b01b414bbf735775449d67a7888c41f8193158cd8b3314a62b65459a609c1e3e8782c1672371880f36a4cb50fb9b5e666a528fe33778ec79c639fd687aa05
+  metadata.gz: 409911e7d194ebabe10d1d88d44df023a6025092100885db770742f0f4a1b1fe3a538a37f67a20fb966a67f7d415c5d541311c232ab981bed751c387f4e7b231
+  data.tar.gz: b60b0794a0fb21bfd45c3b641bc16a9a5f38fe9d105a86ca73e63ad80a6e130376ad377a124b76df5d148037b9503a963caafbbe143150c511c377da3e834add

data/.github/workflows/ruby.yml

@@ -28,7 +28,7 @@ jobs:
           - ruby-version: head
             allow-failure: true
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:

data/AI-BOM.md

@@ -0,0 +1,85 @@
+# AI Bill of Materials — random_name_generator
+
+_Last updated: 2026-07-19 · random_name_generator v4.0.2_
+
+An inventory of every AI component associated with this repository — development
+tools used to build it, AI-generated content shipped within it, and external AI
+services it integrates with (current or planned). Modeled on the SBOM concept
+applied to AI systems.
+
+**AI was first used in the `4.0.0` release.** Everything through the `3.x` line
+was authored without AI assistance.
+
+---
+
+## 1. Development Tools
+
+AI tools used to author this codebase. Not part of the shipped gem, but relevant
+to provenance.
+
+| Tool | Vendor | Role | Notes |
+|------|--------|------|-------|
+| Claude Code | Anthropic | AI coding assistant | Introduced in 4.0.0; drives the [`lang-gen`](./.claude/skills/lang-gen/SKILL.md) skill and general maintenance |
+
+---
+
+## 2. AI Audits
+
+Formal code reviews performed by AI models. Full reports in `docs/`.
+
+| Date | Model | Report | Version |
+|------|-------|--------|---------|
+| 2026-07-19 | Claude Fable 5 | [`docs/AUDIT_Fable_5.md`](./docs/AUDIT_Fable_5.md) | v4.0.2 |
+
+---
+
+## 3. AI-Generated Content
+
+Syllable data and tooling produced with AI assistance and shipped in the gem.
+All output was human-reviewed before commit.
+
+| Artifact | Type | Tool | Notes |
+|----------|------|------|-------|
+| [`lang-gen`](./.claude/skills/lang-gen/SKILL.md) | Claude Code skill | — | Generates a fully integrated language from a plain-English theme |
+| [German Curse](./lib/languages/experimental/german-curse.txt) (`GERMAN_CURSE`) | Language syllable file | `lang-gen` | Experimental; seeded from real roots, extended with invented syllables |
+| [Demonic](./lib/languages/experimental/demonic.txt) (`DEMONIC`) | Language syllable file | `lang-gen` | Experimental; completed from infernal-name source lists |
+| [Portable lang-gen prompt](./docs/superpowers/specs/2026-07-19-lang-gen-portable-prompt.md) | Text prompt | — | LLM-agnostic version of the skill |
+
+---
+
+## 4. Algorithms Implemented
+
+Generative logic built directly into the gem. **No machine-learning models and
+no external ML dependencies** — all name generation is deterministic,
+in-process, and driven by plain syllable-adjacency rules.
+
+| Algorithm | Location | Notes |
+|-----------|----------|-------|
+| Probabilistic syllable composition | `RandomNameGenerator::Generator` | Random prefix/middle/suffix assembly honoring `+v`/`+c`/`-v`/`-c` adjacency flags |
+| Syllable parsing / classification | `RandomNameGenerator::Syllable` | Parses each language-file line into a flagged syllable |
+
+This is a rules-based random generator, not an AI/ML system. It is listed here
+for completeness so the boundary between "AI-assisted authoring" and "AI at
+runtime" is explicit.
+
+---
+
+## 5. External AI Integrations
+
+random_name_generator ships **zero external AI service dependencies**. It makes
+no network calls and requires no API keys. None are planned.
+
+| Service | Type | Status |
+|---------|------|--------|
+| — | — | None (current or planned) |
+
+---
+
+## 6. References
+
+| Document | Purpose |
+|----------|---------|
+| [`docs/AUDIT_Fable_5.md`](./docs/AUDIT_Fable_5.md) | Full-codebase audit with empirically verified findings |
+| [`.claude/skills/lang-gen/SKILL.md`](./.claude/skills/lang-gen/SKILL.md) | The lang-gen language-generation skill |
+| [`README.md`](./README.md) | Project overview, including the lang-gen workflow |
+| [`docs/superpowers/specs/2026-07-19-lang-gen-portable-prompt.md`](./docs/superpowers/specs/2026-07-19-lang-gen-portable-prompt.md) | Paste-into-any-LLM version of the prompt |

data/Gemfile

@@ -7,14 +7,13 @@ gemspec
 
 gem "pry"
 gem "rake", "~> 13.4"
-gem "slop", "~> 4.10.1"
 
 group :development do
+  gem "logger" # logger leaves the default gems in Ruby 4.0; Reek (via dry-core) requires it implicitly.
   gem "reek"
   gem "rspec", "~> 3.12.0"
   gem "rubocop"
   gem "rubocop-rake", require: false
   gem "rubocop-rspec", require: false
-  # tsort left the default gems in Ruby 4.1; RuboCop requires it implicitly.
-  gem "tsort"
+  gem "tsort" # tsort left the default gems in Ruby 4.1; RuboCop requires it implicitly.
 end

data/Gemfile.lock

@@ -1,7 +1,8 @@
 PATH
   remote: .
   specs:
-    random_name_generator (4.0.1)
+    random_name_generator (4.0.3)
+      slop (~> 4.10)
 
 GEM
   remote: https://rubygems.org/
@@ -40,6 +41,7 @@ GEM
       zeitwerk (~> 2.6)
     json (2.7.2)
     language_server-protocol (3.17.0.3)
+    logger (1.7.0)
     method_source (1.1.0)
     parallel (1.26.3)
     parser (3.3.5.0)
@@ -100,6 +102,7 @@ PLATFORMS
   x86_64-linux
 
 DEPENDENCIES
+  logger
   pry
   rake (~> 13.4)
   random_name_generator!
@@ -108,7 +111,6 @@ DEPENDENCIES
   rubocop
   rubocop-rake
   rubocop-rspec
-  slop (~> 4.10.1)
   tsort
 
 BUNDLED WITH

data/README.md

@@ -4,6 +4,7 @@
 [![Build and Test](https://github.com/folkengine/random_name_generator/actions/workflows/ruby.yml/badge.svg)](https://github.com/folkengine/random_name_generator/actions/workflows/ruby.yml)
 [![Code Climate](https://codeclimate.com/github/folkengine/random_name_generator/badges/gpa.svg)](https://codeclimate.com/github/folkengine/random_name_generator)
 [![Inline docs](http://inch-ci.org/github/folkengine/random_name_generator.svg?branch=master)](http://inch-ci.org/github/folkengine/random_name_generator)
+[![AI BOM](https://img.shields.io/badge/AI--BOM-tracked-blueviolet)](./AI-BOM.md)
 
 Ruby port of
 [java-random-name-generator](https://github.com/folkengine/java-random-name-generator),
@@ -40,7 +41,7 @@ Or install it yourself as:
 generate a first and last name for you:
 
 ```shell
-$> exe/random_name_generator [-egrfcxß?]
+$> exe/random_name_generator [-egrkfcxdß?]
 ```
 
 You can also install it so that it's instantly available to you:
@@ -57,12 +58,13 @@ RandomNameGenerator comes with several styles of syllable files:
 [Elven](https://github.com/folkengine/random_name_generator/blob/master/lib/languages/elven.txt),
 [Fantasy](https://github.com/folkengine/random_name_generator/blob/master/lib/languages/fantasy.txt),
 [Goblin](https://github.com/folkengine/random_name_generator/blob/master/lib/languages/goblin.txt),
+[Roman](https://github.com/folkengine/random_name_generator/blob/master/lib/languages/roman.txt),
 and
-[Roman](https://github.com/folkengine/random_name_generator/blob/master/lib/languages/roman.txt).
+[Klingon](https://github.com/folkengine/random_name_generator/blob/master/lib/languages/klingon.txt).
 By default it uses Fantasy. Instantiate RandomNameGenerator and then
 call compose on the object to generate a random name. If you don't pass
 in the number of syllables you want for your name to compose, it will
-randomly pick between 3 and 6.
+randomly pick between 2 and 5.
 
 ```ruby
 require 'random_name_generator'
@@ -99,7 +101,9 @@ for the required specification.
 Edgier, less curated syllable sets live under `lib/languages/experimental/`
 and are opt-in via their own constants:
 [Curse](https://github.com/folkengine/random_name_generator/blob/master/lib/languages/experimental/curse.txt)
-(`RandomNameGenerator::CURSE`) and
+(`RandomNameGenerator::CURSE`),
+[Demonic](https://github.com/folkengine/random_name_generator/blob/master/lib/languages/experimental/demonic.txt)
+(`RandomNameGenerator::DEMONIC`), and
 [German Curse](https://github.com/folkengine/random_name_generator/blob/master/lib/languages/experimental/german-curse.txt)
 (`RandomNameGenerator::GERMAN_CURSE`).
 
@@ -149,9 +153,9 @@ https://github.com/folkengine/random_name_generator.
 This ships with a skill designed to work with [Claude Code](https://claude.com/claude-code) 
 and other LLMs under `.claude/skills/`.
 
-- [lang-gen](.claude/skills/lang-gen/SKILL.md) — Generate a new random_name_generator language from a free-text theme (e.g. "german curse words") — assembles flagged pre/mid/sur syllable collections, registers the File constant, adds a smoke spec and README entry, and samples names to verify.
+- [lang-gen](.claude/skills/lang-gen/SKILL.md): Generate a new random_name_generator language from a free-text theme (e.g. "german curse words"), assembles flagged pre/mid/sur syllable collections, registers the File constant, adds a smoke spec and README entry, and samples names to verify.
 
-There is also [a text version](docs/superpowers/specs/2026-07-19-lang-gen-portable-prompt.md) of the prompt that can be pasted into an LLM. 
+There is also [a text version](docs/superpowers/specs/2026-07-19-lang-gen-portable-prompt.md) of the prompt that can be pasted into an LLM.
 
 ### lang-gen
 

data/docs/AUDIT_Fable_5.md

@@ -0,0 +1,151 @@
+# random_name_generator Repository Audit — Claude Fable 5
+
+_Date:_ 2026-07-19
+_Repo:_ `random_name_generator` v4.0.2 (working tree, including the in-flight Demonic language and CLI additions)
+_Model:_ Claude Fable 5 (`claude-fable-5`)
+_Audit basis:_ Full codebase read + empirical verification — every defect below was reproduced with a live repro before being reported.
+
+> **Remediation:** all nine findings were fixed on 2026-07-19, immediately following
+> this audit, with regression specs added for each (suite grew from 61 to 168
+> examples). The findings below describe the codebase as audited.
+
+---
+
+## Executive Summary
+
+`random_name_generator` is a small, clean, dependency-light gem that does what it says: green test suite (61 examples, 0 failures), RuboCop clean at repo settings (11 files, no offenses), no runtime gem dependencies, and a simple two-class core (`Generator`, `Syllable`) that is easy to hold in your head.
+
+The audit found **3 high-severity defects** — one packaging, two runtime — and a cluster of medium/low issues concentrated in `Syllable`'s letter classification and error paths. None affect the happy path exercised by the specs, which is precisely why they have survived: the suite tests that names compose, not what happens at the edges.
+
+| # | Finding | Severity | Effort to fix |
+|---|---------|----------|---------------|
+| 1 | CLI requires `slop`, but the gemspec declares no runtime dependency on it | High | Low |
+| 2 | `compose(1)` crashes (`String#map`) despite documented single-syllable support | High | Low |
+| 3 | Unsatisfiable adjacency flags hang the process in an infinite loop | High | Medium |
+| 4 | Blank line in a language file crashes `Generator#refresh` | Medium | Low |
+| 5 | Documented `Syllable` clone constructor crashes | Medium | Low |
+| 6 | Cyrillic letters are in neither letter set — all flags in the four `-ru` files are silent no-ops | Medium | Medium |
+| 7 | Empty-syllable guard is doubly broken (unreachable + malformed `raise`) | Low | Low |
+| 8 | `y` classified as both vowel and consonant | Low | Low |
+| 9 | Documentation drift on syllable-count range (README vs code vs spec) | Low | Low |
+
+---
+
+## Scope and Method
+
+**Verified by direct read (complete files):**
+
+- `lib/random_name_generator.rb`
+- `lib/random_name_generator/syllable.rb`
+- `lib/random_name_generator/version.rb`
+- `exe/random_name_generator`
+- `spec/random_name_generator_spec.rb` and both spec fixture languages
+- `random_name_generator.gemspec`, `Gemfile`, `Rakefile`
+- `.github/workflows/ruby.yml`
+- All 13 language files (curated, `-ru`, and experimental)
+
+**Verified empirically:** every High/Medium finding was reproduced by executing the failing call under the bundle, including a `Timeout`-guarded repro for the infinite loop and a crafted two-line language file for the blank-line crash (which was also hit organically during this session, completing the WIP `demonic.txt`).
+
+**Health signals:**
+
+- `bundle exec rspec`: **61 examples, 0 failures**
+- `bundle exec rubocop`: **11 files inspected, no offenses**
+- `bundle exec rake` (default: spec + rubocop): green
+- Runtime dependencies: none declared (see Finding 1 for the catch)
+
+---
+
+## Findings
+
+### 1. Missing runtime dependency: the installed CLI cannot start (High)
+
+`exe/random_name_generator` line 6 does `require "slop"`, but `slop` is declared only in the **Gemfile** (`gem "slop", "~> 4.10.1"`), which end users never see. The gemspec's dependency section is an empty template comment.
+
+Consequence: after `gem install random_name_generator`, running `random_name_generator` raises `LoadError: cannot load such file -- slop` on any machine that doesn't coincidentally have slop installed. Every CI run and local dev invocation goes through Bundler, so this is invisible to the test suite by construction.
+
+**Fix (low effort):** add `spec.add_dependency "slop", "~> 4.10"` to the gemspec and remove it from the Gemfile.
+
+### 2. `compose(1)` crashes despite documented support (High)
+
+`syllable.rb`'s header documentation states: *"In case of 1 syllable, name will be chosen from amongst the prefixes."* The code disagrees:
+
+- `Generator#compose_array` (`lib/random_name_generator.rb:89`) returns a **String** (`@pre.to_s.capitalize`) when `count < 2`, an Array otherwise.
+- `Generator#compose` (`lib/random_name_generator.rb:97`) unconditionally calls `.map` on that result.
+
+Repro: `RandomNameGenerator.new(ELVEN).compose(1)` → `NoMethodError: undefined method 'map' for an instance of String`.
+
+The type-splitting return also makes `compose_array(1)` a misnomer — callers get a String from a method named `_array`. **Fix:** have `compose_array` return `[@pre]` for `count < 2`; both bugs disappear and the return type becomes honest.
+
+### 3. Unsatisfiable flag combinations hang the process (High)
+
+`Generator#determine_next_syllable` (`lib/random_name_generator.rb:126-133`) is a bare `loop` that resamples until it draws a compatible syllable. If **no** syllable in the target bucket is compatible, it spins forever.
+
+Repro (hangs, killed by timeout): a language whose only prefix is `-ba +v` (next must start with a vowel) and whose only suffix is `+kar`. Since the README explicitly invites users to supply their own syllable files, this is reachable input, not just an authoring mistake — one bad file freezes the host application with no diagnostic.
+
+**Fix (medium effort):** track attempts (or pre-filter the bucket by compatibility) and raise a descriptive error when no compatible syllable exists.
+
+### 4. Blank lines in language files crash loading (Medium)
+
+`Generator#refresh` (`lib/random_name_generator.rb:138`) guards with `line.empty?`, but lines from `readlines` retain `"\n"`, so the guard never fires; `Syllable#parse_args` then splits the whitespace-only string into `[]` and calls `nil.empty?` (`syllable.rb:137`) → `NoMethodError`.
+
+This is not hypothetical: the committed WIP `demonic.txt` used blank lines as bucket separators and crashed on load — likely part of why that file sat unfinished. **Fix:** `line.strip.empty?` in `refresh` (one word), or skip whitespace-only lines in `Syllable`.
+
+### 5. Documented `Syllable` clone constructor crashes (Medium)
+
+The `Syllable` header advertises `Syllable.new(syllable)` as a cloning idiom, and `initialize` has an explicit `args.is_a?(Syllable)` branch for it (`syllable.rb:56-60`). But line 49 — `@raw = args.strip` — executes first, and `Syllable` defines no `strip`.
+
+Repro: `Syllable.new(Syllable.new("-foo +c"))` → `NoMethodError: undefined method 'strip' for an instance of RandomNameGenerator::Syllable`. The clone path is dead code; nothing in the gem or specs exercises it. **Fix:** `@raw = args.to_s.strip` (Syllable already implements `to_s`), plus a spec.
+
+### 6. Adjacency flags are silent no-ops for Cyrillic (Medium)
+
+`Syllable::VOWELS` and `CONSONANTS` (`syllable.rb:45-46`) contain only Latin/IPA characters. For a Cyrillic syllable, `vowel_first?`, `consonant_first?`, `vowel_last?`, and `consonant_last?` are all **false** (verified: `-анг` reports neither vowel- nor consonant-final).
+
+Consequence: in `next_incompatible?`/`previous_incompatible?`, nothing can ever be incompatible, so every `+v/+c/-v/-c` flag in the four `-ru` language files — and all four carry them — is dead weight. Names still generate; they just ignore constraints the language authors wrote, silently. **Fix:** add Cyrillic vowels (а е ё и о у ы э ю я) and consonants to the sets, or classify by Unicode-aware rules.
+
+### 7. The empty-syllable guard is doubly broken (Low)
+
+`syllable.rb:137`: `raise ArgumentError "Empty String is not allowed." if syll.empty?`
+
+- **Unreachable as intended:** an empty or whitespace input produces `args[0] == nil`, so `syll.empty?` raises `NoMethodError` on `nil` before the guard can act (this is the crash surfacing in Findings 4 and the `Syllable.new("")` repro).
+- **Malformed if it were reached:** the missing comma means `ArgumentError "…"` is parsed as a method call, which would itself raise `NoMethodError`, not the intended `ArgumentError`.
+
+**Fix:** `raise ArgumentError, "…" if syll.nil? || syll.empty?`.
+
+### 8. `y` is both a vowel and a consonant (Low)
+
+`y` appears in both letter sets, so `+v` and `+c` flags each accept y-initial syllables. Linguistically defensible for a semivowel, but it's undocumented and asymmetric (no other letter is dual-classified). Worth a comment if intentional.
+
+### 9. Documentation drift on syllable counts (Low)
+
+Three sources disagree with the code (`pick_number_of_syllables` samples from a weighted 2–5 distribution):
+
+- README: "it will randomly pick between 3 and 6"
+- Module doc in `random_name_generator.rb`: "between 2 and 5" ✓ (correct)
+- Spec title: "returns an integer between 1 and 6" (assertion actually checks 1..5)
+
+Also cosmetic: the CLI help text spells "syllable" as "eyllable" in four option descriptions.
+
+---
+
+## Test Coverage Assessment
+
+The suite is a smoke suite: it proves every bundled language loads and composes, and that syllable counts come out right. It does **not** cover:
+
+- Adjacency-flag semantics (no spec would catch Finding 6 — the flags could be deleted entirely and the suite stays green)
+- Any error path (Findings 2, 4, 5, 7 are all crashes in paths with zero coverage)
+- The CLI (`exe/` has no test at all; Finding 1 ships silently)
+
+The fixture languages (`test-micro.txt`, `test-tiny.txt`) are well-designed for flag testing — `test-tiny.txt` deliberately exercises every flag combination — but no assertion actually inspects flag behavior.
+
+---
+
+## Recommendations (priority order)
+
+1. **Gemspec:** declare the `slop` runtime dependency. One line; unbreaks the installed CLI.
+2. **`compose_array`:** return `[@pre]` for `count < 2`. Fixes `compose(1)` and the return-type lie.
+3. **`refresh`:** strip lines before the empty check. Fixes blank-line crashes and makes hand-authored files forgiving.
+4. **`determine_next_syllable`:** bound the retry loop with a clear error. Turns a hang into a diagnosis.
+5. **Letter sets:** add Cyrillic ranges so the `-ru` flags do what their authors intended; add a flag-behavior spec pinned to `test-tiny.txt`.
+6. **Cleanups:** fix the `raise` syntax and clone constructor, correct the README/spec-title ranges, fix "eyllable".
+
+None of these threaten the gem's architecture, which is sound for its size. The pattern across all findings is the same: the edges were never walked. A dozen targeted specs would lock in every fix above.

data/exe/random_name_generator

@@ -8,12 +8,14 @@ require "slop"
 lang = RandomNameGenerator::FANTASY
 
 opts = Slop.parse do |o|
-  o.bool "-e", "--elven", "Use Elven eyllable file"
-  o.bool "-g", "--goblin", "Use Goblin eyllable file"
-  o.bool "-r", "--roman", "Use Roman eyllable file"
+  o.bool "-e", "--elven", "Use Elven syllable file"
+  o.bool "-g", "--goblin", "Use Goblin syllable file"
+  o.bool "-r", "--roman", "Use Roman syllable file"
+  o.bool "-k", "--klingon", "Use Klingon syllable file"
   o.bool "-f", "--flipmode", "Flip mode in effect"
   o.bool "-c", "--cyrillic", "Use Cyrillic mode"
   o.bool "-x", "--xrated", "Generate Curse words [NEEDS WORK]"
+  o.bool "-d", "--demonic", "Generate Demonic names"
   o.bool "-ß", "--german-curse", "Generate German Curse words [NEEDS WORK]"
   o.bool "-?", "--help", "How to"
 end
@@ -27,7 +29,9 @@ else
   lang = RandomNameGenerator::ELVEN if opts.elven?
   lang = RandomNameGenerator::GOBLIN if opts.goblin?
   lang = RandomNameGenerator::ROMAN if opts.roman?
+  lang = RandomNameGenerator::KLINGON if opts.klingon?
   lang = RandomNameGenerator::CURSE if opts.xrated?
+  lang = RandomNameGenerator::DEMONIC if opts.demonic?
   lang = RandomNameGenerator::GERMAN_CURSE if opts.german_curse?
 end