random-rails 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 742b88b0a7c5aade166e3bb2d4729fc094955432503683d57aa102a16887cdd9
-  data.tar.gz: fa97f1b124d647cb874c41f2ffa6f1f3188d817f6e093bc1f081eddc8c646c29
+  metadata.gz: 353a1c5d2a49d22d293032ea70253cb1bf711173c01fab5f6d528a0c3ed2661a
+  data.tar.gz: 864bb5abd310a796055a5d3a0f3648ad01a2115f8e1eedd9b8be09819b430f72
 SHA512:
-  metadata.gz: 37c0f1ebecdde3365155e49d9e60cf5345a0c60880ede8e15de4bf64759e587240a5267cc4b3a1b941a3a7d8ef58a8bf095200a41ac9c5136ba4e2302d5ba16e
-  data.tar.gz: 33238f0df65b20e6395205ee33834627f47b62f4022a5112a4d46f5cd964558d463a1c0535aa1068a095a2de2151733559a8f216e074b5b616bd3799c6d3e047
+  metadata.gz: 8a939b36e74e9bb6904544089ad7f16ab3adb546755b0736ff56e4fdbd47f39213b8914b3c77f25316dd76f8df4b17baed3f7a8b822702aa96234c86621f9867
+  data.tar.gz: ddb9675cbca82dd3602272c991c194aef7034e564760cec346e0e3563bad0309d9f0d6e06165d5dcd0e5848063205429ef32ddb2189843dac475d9882cb4ccd8

data/CHANGELOG.md

@@ -1,3 +1,32 @@
+## [1.0.2] - 2025-10-06
+
+### Maintenance Release - Code Quality & CI Improvements
+
+#### Fixed
+
+- **Floating-point precision bug**: Replaced direct float equality comparison (`precision == 1.0`) with epsilon-based comparison (`(precision - 1.0).abs < Float::EPSILON`) to avoid floating-point precision issues
+- **Code formatting**: Improved code consistency and readability with proper parentheses around ternary operators and aligned variable assignments
+
+#### Added
+
+- **Enhanced test matrix**: Added Ruby 3.2.9, 3.3.9, and Rails 8.0.3 to CI test matrix for better compatibility testing
+- **Improved .gitignore**: Added missing `*.gem` pattern to prevent accidental gem file commits
+
+#### Changed
+
+- **Code style improvements**:
+  - Added parentheses around ternary operator conditions for better readability
+  - Aligned variable assignments for consistent formatting
+  - Updated string quotations to use double quotes consistently in specs
+  - Removed unused `cache_key` variable
+  - Added missing blank lines for better code organization
+
+#### Technical Improvements
+
+- Better floating-point comparison to prevent precision-related bugs
+- More robust code style following Ruby best practices
+- Enhanced CI coverage with additional Ruby and Rails versions
+
 ## [1.0.1] - 2025-09-30
 
 ### Major Release - Multi-Database Support & Performance Optimizations

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    random-rails (1.0.1)
+    random-rails (1.0.2)
       activerecord (>= 4.0, < 8.1)
       activesupport (>= 6.1.5, < 8.1)
 

data/lib/random-rails/adapters/active_record/base.rb

@@ -24,7 +24,7 @@ module RandomRails
           end
 
           # Return single object for count=1, relation for count>1
-          count == 1 ? relation.take : relation
+          (count == 1) ? relation.take : relation
         end
 
         private
@@ -45,7 +45,7 @@ module RandomRails
             # PostgreSQL supports TABLESAMPLE for large tables, offset for smaller ones
             estimated_count = estimate_table_size
 
-            estimated_count > RandomRails.configuration.tablesample_threshold ? :tablesample : :offset
+            (estimated_count > RandomRails.configuration.tablesample_threshold) ? :tablesample : :offset
           when "mysql", "mysql2"
             # MySQL doesn't have TABLESAMPLE, use offset method
             :offset
@@ -62,7 +62,8 @@ module RandomRails
         def tablesample_random(precision:, count:)
           if connection.adapter_name.downcase == "postgresql"
             # Use configured precision if not specified
-            precision = RandomRails.configuration.precision if precision == 1.0
+            # using Float::EPSILON to avoid floating point precision issues
+            precision = RandomRails.configuration.precision if (precision - 1.0).abs < Float::EPSILON
 
             from("#{table_name} TABLESAMPLE BERNOULLI(#{precision})").limit(count)
           else
@@ -78,8 +79,8 @@ module RandomRails
           return limit(count) if total_count == 0
 
           # Generate random offset, ensuring we always have an offset clause
-          max_offset = [total_count - count, 0].max
-          random_offset = max_offset > 0 ? rand(max_offset + 1) : 0
+          max_offset    = [total_count - count, 0].max
+          random_offset = (max_offset > 0) ? rand(max_offset + 1) : 0
 
           # Always apply offset, even if it's 0, to ensure consistent SQL structure
           offset(random_offset).limit(count)
@@ -101,8 +102,6 @@ module RandomRails
 
         # Estimate table size efficiently
         def estimate_table_size
-          cache_key = "#{table_name}_count_estimate"
-
           if RandomRails.configuration.cache_table_sizes && @estimated_count
             return @estimated_count
           end
@@ -111,13 +110,13 @@ module RandomRails
             case connection.adapter_name.downcase
             when "postgresql", "pg"
               # Use pg_class for fast estimate
-              sql = "SELECT reltuples::INTEGER FROM pg_class WHERE relname = '#{table_name}'"
+              sql    = "SELECT reltuples::INTEGER FROM pg_class WHERE relname = '#{table_name}'"
               result = connection.execute(sql).first
 
               result ? result["reltuples"].to_i : count
             when "mysql", "mysql2"
               # Use information_schema for fast estimate
-              sql = "SELECT table_rows FROM information_schema.tables WHERE table_name = '#{table_name}'"
+              sql    = "SELECT table_rows FROM information_schema.tables WHERE table_name = '#{table_name}'"
               result = connection.execute(sql).first
 
               result ? result[0].to_i : count

data/lib/random-rails/configuration.rb

@@ -5,10 +5,10 @@ module RandomRails
     attr_accessor :default_strategy, :tablesample_threshold, :cache_table_sizes, :precision
 
     def initialize
-      @default_strategy = :auto
+      @default_strategy      = :auto
       @tablesample_threshold = 10_000 # Use TABLESAMPLE for tables larger than this
-      @cache_table_sizes = true # Cache table size estimates
-      @precision = 1.0 # Default precision for TABLESAMPLE
+      @cache_table_sizes     = true # Cache table size estimates
+      @precision             = 1.0 # Default precision for TABLESAMPLE
     end
   end
 

data/lib/random-rails/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RandomRails
-  VERSION = "1.0.1"
+  VERSION = "1.0.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: random-rails
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - loqimean