random-port 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 9a3960a47566f1625908e17fe12c37553c20e431
-  data.tar.gz: a7533bbd55eb0e11ba25e9477634889eeca20168
+SHA256:
+  metadata.gz: 1dbc9a31f4b53484b240f4f2bb37c7f1ed9208bc1e5e31b09df8c95c9aa909d1
+  data.tar.gz: 9d6f1d3e5a912ffa03ac3a168bc47d1492775435276a709a33d918b5b103ec00
 SHA512:
-  metadata.gz: 78f107699b64c07926eb503c8a3253aa8756adcc5436abb76e3661b78251f9a50ce3fd21c39e73d299000e68679132c173bdca575a5b7d2ca0561fddaff3984a
-  data.tar.gz: 669969cd33c4523be191195e983245acce4e24ba25b912ba577d4c4708812f10ebb69a75e7e70c38a1af346e35c059c3b09b3c8c9f23d8b622262b5a1f53c271
+  metadata.gz: d382bafa4db3b722d8ebefda93d5c5460a3e61581bab49646cc804841f4f7edafb9203c2006557c16ef6aa6b6111ed9db011cd68f3a104b1a165fc8834e31f40
+  data.tar.gz: d1318acea077ce7df07d2d514c6b9f676581c8d2b69ddb43337cc148567cdeb16f7c1584559723833319053ae287dbba6ca228a9d236493d6bd52b9433441d3d

data/README.md

@@ -46,7 +46,21 @@ RandomPort::Pool::SINGLETON.acquire do |port|
 end
 ```
 
-The pool is thread-safe.
+The pool is _not_ thread-safe.
+
+# How to contribute
+
+Read [these guidelines](https://www.yegor256.com/2014/04/15/github-guidelines.html).
+Make sure you build is green before you contribute
+your pull request. You will need to have [Ruby](https://www.ruby-lang.org/en/) 2.3+ and
+[Bundler](https://bundler.io/) installed. Then:
+
+```
+$ bundle update
+$ rake
+```
+
+If it's clean and you don't see any error messages, submit your pull request.
 
 # License
 

data/lib/random-port/pool.rb

@@ -26,38 +26,36 @@ require 'socket'
 
 module RandomPort
   # Pool of TPC ports.
+  #
+  # The class is NOT thread-safe!
+  #
   # Author:: Yegor Bugayenko (yegor256@gmail.com)
   # Copyright:: Copyright (c) 2018 Yegor Bugayenko
   # License:: MIT
   class Pool
     def initialize
       @ports = []
-      @mutex = Mutex.new
     end
 
     # Application wide pool of ports
     SINGLETON = Pool.new
 
     def acquire
-      @mutex.synchronize do
-        loop do
-          server = TCPServer.new('127.0.0.1', 0)
-          port = server.addr[1]
-          server.close
-          next if @ports.include?(port)
-          @ports << port
-          return port unless block_given?
-          yield port
-          @ports.delete(port)
-          break
-        end
+      loop do
+        server = TCPServer.new('127.0.0.1', 0)
+        port = server.addr[1]
+        server.close
+        next if @ports.include?(port)
+        @ports << port
+        return port unless block_given?
+        yield port
+        @ports.delete(port)
+        break
       end
     end
 
     def release(port)
-      @mutex.synchronize do
-        @ports.delete(port)
-      end
+      @ports.delete(port)
     end
   end
 end

data/random-port.gemspec

@@ -31,7 +31,7 @@ Gem::Specification.new do |s|
   s.rubygems_version = '2.3.3'
   s.required_ruby_version = '>=2.3'
   s.name = 'random-port'
-  s.version = '0.2.0'
+  s.version = '0.3.0'
   s.license = 'MIT'
   s.summary = 'Random TCP port'
   s.description = 'Reserves a random TCP port'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: random-port
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Yegor Bugayenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-04 00:00:00.000000000 Z
+date: 2018-10-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -121,7 +121,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 2
 summary: Random TCP port