rambulance 3.1.0 → 3.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 71f3781bf725a20d74a6f2d8d2320672072044e5ecee1aa4e4000739ef15581e
-  data.tar.gz: e6d8fac7b73d483f4033f15643d5e38d0f9643a21d843318087550979434cfb0
+  metadata.gz: 9370918184eb1f9f6429fa18b2ef6f08d845050f98271184abd941679f8cb4cf
+  data.tar.gz: 9e0270f66522474c1b2ef50a0685f7133cb9c2985367b836cc4070b9bb92ada0
 SHA512:
-  metadata.gz: c9f0f56788587ddc1057df037a3adf384e1ae1edd7613244d174f7c851ca22ddc056f118ea2489c1c5ca86aa20e724eee215457b6b118fe9b31a6ea0936cf532
-  data.tar.gz: 56c981eb197bb799e4a809c2a1477bfb5b60c5a24ea5a93d8972d3df92c9256552fe4962c016d29419599dd6bf911e48b75005c400d63015d04095d0a41ab89e
+  metadata.gz: bd7673e1a6197f39ef3e70786c7334e1933eb02ce6b44095ab8ff0c0dc30d8d04bbef6ec4c351fae7c7ad0e30aef05caf538029210098d41776865521183d97f
+  data.tar.gz: 8e8bde197754afddfbda3049f0863fb743c6f99df536c5bba3d803543aed957f89092323a44a8bf6ef185d4d50edc195ba9091e3d938780f8de190d2d0a1a8c3

data/.github/workflows/tests.yml

@@ -115,7 +115,7 @@ jobs:
     env:
       BUNDLE_GEMFILE: ${{ matrix.gemfile }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
@@ -130,7 +130,7 @@ jobs:
     env:
       BUNDLE_GEMFILE: gemfiles/rails_edge.gemfile
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
@@ -153,7 +153,7 @@ jobs:
     env:
       BUNDLE_GEMFILE: ${{ matrix.gemfile }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:

data/Appraisals

@@ -49,12 +49,16 @@ appraise "rails_71" do
   gem "railties", "~> 7.1.0"
 end
 
+appraise "rails_72" do
+  gem "activesupport", "~> 7.2.0"
+  gem "actionpack", "~> 7.2.0"
+  gem "railties", "~> 7.2.0"
+end
+
 appraise "rails_edge" do
   git 'https://github.com/rails/rails.git' do
     gem "activesupport", require: 'active_support'
     gem "actionpack", require: 'action_pack'
     gem "railties"
   end
-
-  gem 'minitest', '~> 5.3.4'
 end

data/CHANGELOG.md

@@ -1,11 +1,39 @@
-## v3.1.0
+## v3.3.0
 
-_<sup>released at 2024-01-04 10:04:32 UTC</sup>_
+_<sup>Unreleased</sup>_
 
 #### New Features
 
-- The test helper is now compatible with Rails Edge (8.0) (#73, #75)
-- Add support for Ruby 3.3 (#74)
+- Add support for Rails 7.1 ([<tt>e6d42b51</tt>](https://github.com/yuki24/rambulance/commit/e6d42b514d0bdbc2ea5b1603f85ecc9fa24b819a))
+
+## [v3.2.0](https://github.com/yuki24/rambulance/tree/v3.2.0)
+
+_<sup>released at 2024-08-04 03:04:26 UTC</sup>_
+
+This release includes a **breaking change**. Please read the details below carefully.
+
+#### New Features
+
+- Fixed compatibility with Rack (see [rack/rack#2137](https://github.com/rack/rack/pull/2137)) ([#77](https://github.com/yuki24/rambulance/issues/77) [@tmaier](https://github.com/tmaier), [#78](https://github.com/yuki24/rambulance/pull/78))
+
+#### Breaking Changes
+
+The Rack compatibility fix is related to Rack becoming more compliant with the IANA HTTP Status Code Registry.
+As a result:
+
+- `unprocessable_entity` has been renamed to `unprocessable_content`.
+- Rambulance will redirect any request from `unprocessable_entity` to `unprocessable_content` for backward compatibility.
+- Users **must** rename the view file from `app/views/errors/unprocessable_entity.html.erb` to `app/views/errors/unprocessable_content.html.erb`.
+- Users **should** update the hash values in their configurations: Change `unprocessable_entity` to `unprocessable_content` in `config.rescue_responses`/`config.action_dispatch.rescue_responses`
+
+## [v3.1.0](https://github.com/yuki24/rambulance/tree/v3.1.0)
+
+_<sup>released at 2024-01-04 10:08:11 UTC</sup>_
+
+#### New Features
+
+- The test helper is now compatible with Rails Edge (8.0) ([#73](https://github.com/yuki24/rambulance/pull/73), [#75](https://github.com/yuki24/rambulance/pull/75))
+- Add support for Ruby 3.3 ([#74](https://github.com/yuki24/rambulance/pull/74))
 
 ## [v3.0.0](https://github.com/yuki24/rambulance/tree/v3.0.0)
 

data/Gemfile

@@ -2,3 +2,4 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in rambulance.gemspec
 gemspec
+gem 'minitest', '< 5.25.0'

data/README.md

@@ -48,12 +48,21 @@ Then do the following:
 ```ruby
 # config/initializers/rambulance.rb
 config.rescue_responses = {
-  "ActiveRecord::RecordNotUnique" => :unprocessable_entity,
+  "ActiveRecord::RecordNotUnique" => :unprocessable_content,
   "CanCan::AccessDenied"          => :forbidden,
   "YourCustomException"           => :not_found
 }
 ```
 
+## Special case `unprocessable_entity`/`unprocessable_content` (HTTP Status 422)
+
+Rack renamed `unprocessable_entity` to `unprocessable_content`.
+
+Rambulance supports both, but defaults to `unprocessable_content` with version 3.2.0 and later.
+`unprocessable_entity` is supported with a redirect to `unprocessable_content`.
+
+This means the view file is called `app/views/errors/unprocessable_content.html.erb`, not `app/views/errors/unprocessable_entity.html.erb`.
+
 ## Local Development
 
 ### Open `localhost:3000/rambulance/***` in Your Browser
@@ -123,8 +132,8 @@ Note that testing error pages is not encouraged in Rails as it leads to overuse
 
 ## Supported Versions
 
-* Ruby 2.3, 2,4, 2,5, 2.6, 2.7, 3.0, 3.1, and JRuby 9.3
-* Rails 4.2, 5.0, 5.1, 5.2, 6.0, 6.1, 7.0 and edge
+* Ruby 2.5, 2.6, 2.7, 3.0, 3.1, 3.2, 3.3 and JRuby 9.3, 9.4
+* Rails 4.2, 5.0, 5.1, 5.2, 6.0, 6.1, 7.0, 7.1 and edge
 
 Rambulance doesn't work with Rails 3.1 and below since they don't provide a way to use a custom exceptions app.
 

data/gemfiles/rails_42.gemfile

@@ -2,9 +2,9 @@
 
 source "https://rubygems.org"
 
+gem "minitest", "~> 5.3.4"
 gem "activesupport", "~> 4.2.0"
 gem "actionpack", "~> 4.2.0"
 gem "railties", "~> 4.2.0"
-gem "minitest", "~> 5.3.4"
 
 gemspec path: "../"

data/gemfiles/rails_50.gemfile

@@ -2,9 +2,9 @@
 
 source "https://rubygems.org"
 
+gem "minitest", "~> 5.3.4"
 gem "activesupport", "~> 5.0.0"
 gem "actionpack", "~> 5.0.0"
 gem "railties", "~> 5.0.0"
-gem "minitest", "~> 5.3.4"
 
 gemspec path: "../"

data/gemfiles/rails_51.gemfile

@@ -2,6 +2,7 @@
 
 source "https://rubygems.org"
 
+gem "minitest", "< 5.25.0"
 gem "activesupport", "~> 5.1.0"
 gem "actionpack", "~> 5.1.0"
 gem "railties", "~> 5.1.0"

data/gemfiles/rails_52.gemfile

@@ -2,6 +2,7 @@
 
 source "https://rubygems.org"
 
+gem "minitest", "< 5.25.0"
 gem "activesupport", "~> 5.2.0"
 gem "actionpack", "~> 5.2.0"
 gem "railties", "~> 5.2.0"

data/gemfiles/rails_60.gemfile

@@ -2,6 +2,7 @@
 
 source "https://rubygems.org"
 
+gem "minitest", "< 5.25.0"
 gem "activesupport", "~> 6.0.0"
 gem "actionpack", "~> 6.0.0"
 gem "railties", "~> 6.0.0"

data/gemfiles/rails_61.gemfile

@@ -2,6 +2,7 @@
 
 source "https://rubygems.org"
 
+gem "minitest", "< 5.25.0"
 gem "activesupport", "~> 6.1.0"
 gem "actionpack", "~> 6.1.0"
 gem "railties", "~> 6.1.0"

data/gemfiles/rails_70.gemfile

@@ -2,6 +2,7 @@
 
 source "https://rubygems.org"
 
+gem "minitest", "< 5.25.0"
 gem "activesupport", "~> 7.0.0"
 gem "actionpack", "~> 7.0.0"
 gem "railties", "~> 7.0.0"

data/gemfiles/rails_71.gemfile

@@ -2,6 +2,7 @@
 
 source "https://rubygems.org"
 
+gem "minitest", "< 5.25.0"
 gem "activesupport", "~> 7.1.0"
 gem "actionpack", "~> 7.1.0"
 gem "railties", "~> 7.1.0"

data/gemfiles/rails_72.gemfile

@@ -0,0 +1,10 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "minitest", "< 5.25.0"
+gem "activesupport", "~> 7.2.0"
+gem "actionpack", "~> 7.2.0"
+gem "railties", "~> 7.2.0"
+
+gemspec path: "../"

data/gemfiles/rails_edge.gemfile

@@ -8,6 +8,6 @@ git "https://github.com/rails/rails.git" do
   gem "railties"
 end
 
-gem "minitest", "~> 5.3.4"
+gem "minitest", "< 5.25.0"
 
 gemspec path: "../"

data/lib/generators/rambulance/templates/exceptions_app.rb

@@ -11,6 +11,6 @@ class ExceptionsApp < Rambulance::ExceptionsApp
   def not_found
   end
 
-  def unprocessable_entity
+  def unprocessable_content
   end
 end

data/lib/generators/rambulance/templates/rambulance.rb

@@ -15,7 +15,7 @@ Rambulance.setup do |config|
   # If Rambulance receives an exception that is not listed here, it'll render
   # the internal server error template and return 500 as http status.
   config.rescue_responses = {
-    # "ActiveRecord::RecordNotUnique" => :unprocessable_entity,
+    # "ActiveRecord::RecordNotUnique" => :unprocessable_content,
     # "CanCan::AccessDenied"          => :forbidden,
     # "Pundit::NotAuthorizedError"    => :forbidden,
     # "YourCustomException"           => :not_found

data/lib/generators/rambulance/templates/views/{unprocessable_entity.html.erb → unprocessable_content.html.erb}

@@ -49,7 +49,7 @@
   }
 </style>
 
-<!-- This file lives in app/views/errors/unprocessable_entity.html.erb -->
+<!-- This file lives in app/views/errors/unprocessable_content.html.erb -->
 <div class="dialog">
   <div>
     <h1>The change you wanted was rejected.</h1>

data/lib/rambulance/exceptions_app.rb

@@ -38,7 +38,11 @@ module Rambulance
         end
       end
 
-      action(status_in_words).call(env)
+      if exception.nil? && status_in_words == :unprocessable_entity
+        [302, { "Location" => "/rambulance/unprocessable_content" }, [""]]
+      else
+        action(status_in_words).call(env)
+      end
     end
 
     def self.local_prefixes
@@ -53,6 +57,12 @@ module Rambulance
       ACTION
     end
 
+    def unprocessable_entity
+      unprocessable_content_path = error_path(:unprocessable_content)
+
+      render(template_exists?(unprocessable_content_path) ? unprocessable_content_path : error_path(:internal_server_error))
+    end
+
     def process(action, *args)
       if action.to_s.empty?
         action = request.env["PATH_INFO"][1..-1].to_sym

data/lib/rambulance/version.rb

@@ -1,3 +1,3 @@
 module Rambulance
-  VERSION = "3.1.0"
+  VERSION = "3.3.0"
 end

data/test/exceptions_app_test.rb

@@ -6,4 +6,10 @@ class ExeptionsAppTest < ActionDispatch::IntegrationTest
 
     assert_equal 404, response.status
   end
+
+  test 'returns 302 for unprocessable_entity' do
+    get '/rambulance/unprocessable_entity', headers: { 'Accept' => '*/*'  }
+
+    assert_redirected_to '/rambulance/unprocessable_content'
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rambulance
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.3.0
 platform: ruby
 authors:
 - Yuki Nishijima
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-01-04 00:00:00.000000000 Z
+date: 2024-08-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -164,6 +164,7 @@ files:
 - gemfiles/rails_61.gemfile
 - gemfiles/rails_70.gemfile
 - gemfiles/rails_71.gemfile
+- gemfiles/rails_72.gemfile
 - gemfiles/rails_edge.gemfile
 - lib/generators/rambulance/exceptions_app_generator.rb
 - lib/generators/rambulance/install_generator.rb
@@ -178,8 +179,8 @@ files:
 - lib/generators/rambulance/templates/views/not_acceptable.text.erb
 - lib/generators/rambulance/templates/views/not_found.html.erb
 - lib/generators/rambulance/templates/views/not_found.json.jbuilder
-- lib/generators/rambulance/templates/views/unprocessable_entity.html.erb
-- lib/generators/rambulance/templates/views/unprocessable_entity.json.jbuilder
+- lib/generators/rambulance/templates/views/unprocessable_content.html.erb
+- lib/generators/rambulance/templates/views/unprocessable_content.json.jbuilder
 - lib/rambulance.rb
 - lib/rambulance/engine.rb
 - lib/rambulance/exceptions_app.rb
@@ -223,7 +224,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.22
+rubygems_version: 3.5.11
 signing_key:
 specification_version: 4
 summary: Simple and safe way to dynamically generate error pages