rambulance 3.0.0 → 3.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6572a6a2e77dbc135e1fb9bb830b6ef43af6e302b7ec0db304577f74a0cef088
-  data.tar.gz: 9f1fc8a6204ef86c00525f4cfb9e71a80285a89e2f7b1b4aa82e6c10b56496b4
+  metadata.gz: d258a488889e8469aee921802e1ec980209878a709e6b7baa7a34111b13164c3
+  data.tar.gz: 3177f6eafb2e69b5744b4bdb73b00ab7a19c2b0b31257527e3aa07d286fa6934
 SHA512:
-  metadata.gz: cdd6de274dbe0607bba3a0c63bd24ca733bde12cc1cfde13f7eccc2cfa560d6dee2efca1ff444cd9e6445d9a15ba17234683c7a3ef7c7a957245fd40f80af8ed
-  data.tar.gz: 660ce18b77d8e10a3d042cc34768c802e4069633e966d32f7e240162eddb5a359d1a533e06d78cbaf28e288f92a8b5e2c88055da0b947fc9c4d6bbcf42c0a32a
+  metadata.gz: 58c01d13e0bdf2026c515b79696d72efdddb9cef89847e4a90db6189fe5a516d6786fdb594db3e36dbbaf87f4de44abe39b51fc044f7b08feee4ac052990c407
+  data.tar.gz: d2b980e56e9533a4d0a0ffc95c27aec009b822a307176be0341e08e255961c141120825f0dd25b208ee74fb97be5c8f7c31d7b74fe06c67620982ac4988d6823

data/.github/workflows/tests.yml

@@ -8,6 +8,7 @@ jobs:
     strategy:
       matrix:
         ruby_version:
+          - '3.3'
           - '3.2'
           - '3.1'
           - '3.0'
@@ -17,6 +18,7 @@ jobs:
           - 'jruby-9.3'
           - 'jruby-9.4'
         gemfile:
+          - gemfiles/rails_71.gemfile
           - gemfiles/rails_70.gemfile
           - gemfiles/rails_61.gemfile
           - gemfiles/rails_60.gemfile
@@ -25,6 +27,18 @@ jobs:
           - gemfiles/rails_50.gemfile
           - gemfiles/rails_42.gemfile
         exclude:
+          - ruby_version: '3.3'
+            gemfile: gemfiles/rails_61.gemfile
+          - ruby_version: '3.3'
+            gemfile: gemfiles/rails_60.gemfile
+          - ruby_version: '3.3'
+            gemfile: gemfiles/rails_52.gemfile
+          - ruby_version: '3.3'
+            gemfile: gemfiles/rails_51.gemfile
+          - ruby_version: '3.3'
+            gemfile: gemfiles/rails_50.gemfile
+          - ruby_version: '3.3'
+            gemfile: gemfiles/rails_42.gemfile
           - ruby_version: '3.2'
             gemfile: gemfiles/rails_61.gemfile
           - ruby_version: '3.2'
@@ -55,6 +69,8 @@ jobs:
             gemfile: gemfiles/rails_50.gemfile
           - ruby_version: '3.0'
             gemfile: gemfiles/rails_42.gemfile
+          - ruby_version: '2.7'
+            gemfile: gemfiles/rails_71.gemfile
           - ruby_version: '2.7'
             gemfile: gemfiles/rails_70.gemfile
           - ruby_version: '2.7'
@@ -65,12 +81,18 @@ jobs:
             gemfile: gemfiles/rails_50.gemfile
           - ruby_version: '2.7'
             gemfile: gemfiles/rails_42.gemfile
+          - ruby_version: '2.6'
+            gemfile: gemfiles/rails_71.gemfile
           - ruby_version: '2.6'
             gemfile: gemfiles/rails_70.gemfile
           - ruby_version: '2.6'
             gemfile: gemfiles/rails_42.gemfile
+          - ruby_version: '2.5'
+            gemfile: gemfiles/rails_71.gemfile
           - ruby_version: '2.5'
             gemfile: gemfiles/rails_70.gemfile
+          - ruby_version: 'jruby-9.3'
+            gemfile: gemfiles/rails_71.gemfile
           - ruby_version: 'jruby-9.3'
             gemfile: gemfiles/rails_70.gemfile
           - ruby_version: 'jruby-9.3'
@@ -93,7 +115,7 @@ jobs:
     env:
       BUNDLE_GEMFILE: ${{ matrix.gemfile }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
@@ -108,11 +130,11 @@ jobs:
     env:
       BUNDLE_GEMFILE: gemfiles/rails_edge.gemfile
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 3.2
+          ruby-version: 3.3
           bundler-cache: true
       - run: bundle exec rake
 
@@ -126,12 +148,12 @@ jobs:
           - 'jruby-head'
         gemfile:
           - gemfiles/rails_edge.gemfile
-          - gemfiles/rails_70.gemfile
+          - gemfiles/rails_71.gemfile
     runs-on: ubuntu-22.04
     env:
       BUNDLE_GEMFILE: ${{ matrix.gemfile }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:

data/Appraisals

@@ -44,9 +44,9 @@ appraise "rails_70" do
 end
 
 appraise "rails_71" do
-  gem "activesupport", "~> 7.1.0.beta1"
-  gem "actionpack", "~> 7.1.0.beta1"
-  gem "railties", "~> 7.1.0.beta1"
+  gem "activesupport", "~> 7.1.0"
+  gem "actionpack", "~> 7.1.0"
+  gem "railties", "~> 7.1.0"
 end
 
 appraise "rails_edge" do

data/CHANGELOG.md

@@ -1,12 +1,31 @@
-## v3.0.0
+## v3.2.0
+
+_<sup>unreleased</sup>_
+
+#### New Features
+
+- Fix the compatibility with Rack (see https://github.com/rack/rack/pull/2137) (#77 @tmaier, #78)
+#
+# [v3.1.0](https://github.com/yuki24/rambulance/tree/v3.1.0)
+
+_<sup>released at 2024-01-04 10:08:11 UTC</sup>_
+
+#### New Features
+
+- The test helper is now compatible with Rails Edge (8.0) ([#73](https://github.com/yuki24/rambulance/pull/73), [#75](https://github.com/yuki24/rambulance/pull/75))
+- Add support for Ruby 3.3 ([#74](https://github.com/yuki24/rambulance/pull/74))
+
+## [v3.0.0](https://github.com/yuki24/rambulance/tree/v3.0.0)
+
+_<sup>released at 2023-09-22 14:47:24 UTC</sup>_
 
 #### New Features
 
-- Add support for Rails 7.1 (`be6f129d`)
+- Add support for Rails 7.1 ([<tt>be6f129</tt>](https://github.com/yuki24/rambulance/commit/be6f129dd4c1d190e90a3036f7f1099028ef4a1e))
 
 #### Breaking Changes
 
-- Drop support for Ruby 2.3 and 2.4 (`c0d3439d`)
+- Drop support for Ruby 2.3 and 2.4 ([<tt>c0d3439</tt>](https://github.com/yuki24/rambulance/commit/c0d3439d64552a88cb934d57bc57d2c06ff593c9))
 
 ## [v2.3.0](https://github.com/yuki24/rambulance/tree/v2.3.0)
 

data/README.md

@@ -48,7 +48,7 @@ Then do the following:
 ```ruby
 # config/initializers/rambulance.rb
 config.rescue_responses = {
-  "ActiveRecord::RecordNotUnique" => :unprocessable_entity,
+  "ActiveRecord::RecordNotUnique" => :unprocessable_content,
   "CanCan::AccessDenied"          => :forbidden,
   "YourCustomException"           => :not_found
 }
@@ -83,7 +83,7 @@ If you want to do some more things in a exceptions app, you can also write your
 $ rails g rambulance:exceptions_app
 ```
 
-It will generate your own custom exceptions app. You can use whatever techniques you want to use in controllers like `before_filter` and `flash[:notice] = "message..."` since it's a grandchild of `ActionController::Base`!
+It will generate your own custom exceptions app. You can use most techniques you want to use in controllers like `before_filter` and rendering views since it's a grandchild of `ActionController::Base`! However there are still some restrictions, e.g. setting a flash notice works when rendering directly but not when redirecting because the ActionDispatch::Flash middleware is never hit.
 
 **Heavily customizing the exceptions app is strongly discouraged as there would be no guard against bugs that occur in the exceptions app.**
 
@@ -123,8 +123,8 @@ Note that testing error pages is not encouraged in Rails as it leads to overuse
 
 ## Supported Versions
 
-* Ruby 2.3, 2,4, 2,5, 2.6, 2.7, 3.0, 3.1, and JRuby 9.3
-* Rails 4.2, 5.0, 5.1, 5.2, 6.0, 6.1, 7.0 and edge
+* Ruby 2.5, 2.6, 2.7, 3.0, 3.1, 3.2, 3.3 and JRuby 9.3, 9.4
+* Rails 4.2, 5.0, 5.1, 5.2, 6.0, 6.1, 7.0, 7.1 and edge
 
 Rambulance doesn't work with Rails 3.1 and below since they don't provide a way to use a custom exceptions app.
 

data/gemfiles/rails_71.gemfile

@@ -2,8 +2,8 @@
 
 source "https://rubygems.org"
 
-gem "activesupport", "~> 7.1.0.beta1"
-gem "actionpack", "~> 7.1.0.beta1"
-gem "railties", "~> 7.1.0.beta1"
+gem "activesupport", "~> 7.1.0"
+gem "actionpack", "~> 7.1.0"
+gem "railties", "~> 7.1.0"
 
 gemspec path: "../"

data/lib/generators/rambulance/templates/exceptions_app.rb

@@ -11,6 +11,6 @@ class ExceptionsApp < Rambulance::ExceptionsApp
   def not_found
   end
 
-  def unprocessable_entity
+  def unprocessable_content
   end
 end

data/lib/generators/rambulance/templates/rambulance.rb

@@ -15,7 +15,7 @@ Rambulance.setup do |config|
   # If Rambulance receives an exception that is not listed here, it'll render
   # the internal server error template and return 500 as http status.
   config.rescue_responses = {
-    # "ActiveRecord::RecordNotUnique" => :unprocessable_entity,
+    # "ActiveRecord::RecordNotUnique" => :unprocessable_content,
     # "CanCan::AccessDenied"          => :forbidden,
     # "Pundit::NotAuthorizedError"    => :forbidden,
     # "YourCustomException"           => :not_found

data/lib/generators/rambulance/templates/views/{unprocessable_entity.html.erb → unprocessable_content.html.erb}

@@ -49,7 +49,7 @@
   }
 </style>
 
-<!-- This file lives in app/views/errors/unprocessable_entity.html.erb -->
+<!-- This file lives in app/views/errors/unprocessable_content.html.erb -->
 <div class="dialog">
   <div>
     <h1>The change you wanted was rejected.</h1>

data/lib/rambulance/exceptions_app.rb

@@ -38,7 +38,11 @@ module Rambulance
         end
       end
 
-      action(status_in_words).call(env)
+      if exception.nil? && status_in_words == :unprocessable_entity
+        [302, { "Location" => "/rambulance/unprocessable_content" }, [""]]
+      else
+        action(status_in_words).call(env)
+      end
     end
 
     def self.local_prefixes
@@ -53,6 +57,12 @@ module Rambulance
       ACTION
     end
 
+    def unprocessable_entity
+      unprocessable_content_path = error_path(:unprocessable_content)
+
+      render(template_exists?(unprocessable_content_path) ? unprocessable_content_path : error_path(:internal_server_error))
+    end
+
     def process(action, *args)
       if action.to_s.empty?
         action = request.env["PATH_INFO"][1..-1].to_sym

data/lib/rambulance/test_helper.rb

@@ -28,7 +28,12 @@ module Rambulance #:nodoc:
       org_show_exceptions          = Rails.application.env_config['action_dispatch.show_exceptions']
 
       Rails.application.env_config['action_dispatch.show_detailed_exceptions'] = !enabled
-      Rails.application.env_config['action_dispatch.show_exceptions']          = enabled
+
+      if ActionDispatch::ExceptionWrapper.instance_methods.include?(:show?)
+        Rails.application.env_config['action_dispatch.show_exceptions'] = enabled ? :all : :none
+      else
+        Rails.application.env_config['action_dispatch.show_exceptions'] = enabled
+      end
 
       yield
     ensure
@@ -37,4 +42,3 @@ module Rambulance #:nodoc:
     end
   end
 end
-

data/lib/rambulance/version.rb

@@ -1,3 +1,3 @@
 module Rambulance
-  VERSION = "3.0.0"
+  VERSION = "3.2.0"
 end

data/test/exceptions_app_test.rb

@@ -6,4 +6,10 @@ class ExeptionsAppTest < ActionDispatch::IntegrationTest
 
     assert_equal 404, response.status
   end
+
+  test 'returns 302 for unprocessable_entity' do
+    get '/rambulance/unprocessable_entity', headers: { 'Accept' => '*/*'  }
+
+    assert_redirected_to '/rambulance/unprocessable_content'
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rambulance
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.2.0
 platform: ruby
 authors:
 - Yuki Nishijima
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-09-22 00:00:00.000000000 Z
+date: 2024-08-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -178,8 +178,8 @@ files:
 - lib/generators/rambulance/templates/views/not_acceptable.text.erb
 - lib/generators/rambulance/templates/views/not_found.html.erb
 - lib/generators/rambulance/templates/views/not_found.json.jbuilder
-- lib/generators/rambulance/templates/views/unprocessable_entity.html.erb
-- lib/generators/rambulance/templates/views/unprocessable_entity.json.jbuilder
+- lib/generators/rambulance/templates/views/unprocessable_content.html.erb
+- lib/generators/rambulance/templates/views/unprocessable_content.json.jbuilder
 - lib/rambulance.rb
 - lib/rambulance/engine.rb
 - lib/rambulance/exceptions_app.rb
@@ -223,7 +223,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.19
+rubygems_version: 3.5.11
 signing_key:
 specification_version: 4
 summary: Simple and safe way to dynamically generate error pages