rambulance 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 17bc50582db6ee389d7b677e43fcea58bdc91c758fdc953b39fa2fae52d7ae6c
-  data.tar.gz: 1fdd148f730d07b03ce03f4722dd2c151d4291de58f515ed2084a347f66854d6
+  metadata.gz: 82265aa18e23300634878ce073d6b72effb62a3a8326832f603d9b17b7640634
+  data.tar.gz: 67abe21526c25ab05b2faada53dbadafd62bf414638752cdec3450256e326e3a
 SHA512:
-  metadata.gz: 4238686586fb7e22c95230a00d6e7fabf28312f43b018d750a0008590205a40b64413777f6a43559d26c045501f4e82cb7ef814204cb07ea9432a5f06f9c9606
-  data.tar.gz: a36d6333ec57c8706b3b5fb304362d0d1f1288b684009ee28842299bfb4daa015be58f93206eb146344d163d9e896166ce4dd4dc611af6d2e683124b742d30ab
+  metadata.gz: 97932a0989390b458d8b697cb3be797f0441b623898a34d03e1920ff50f1d298b6ec5c03650b63adf6191a18ed22e66efda0c71686022691e48dab3cd5bcc836
+  data.tar.gz: 2af8602230f377774c17cb1f2ce0e1861a28880f7e5682807d135772fb51d9f69c8613f772866b082efccdfc8e5158971acfeedce16bbfb95c24afc812d77053

data/CHANGELOG.md

@@ -1,3 +1,19 @@
+## v1.1.1 (unreleased)
+
+- Fixes a bug where a malformed `Content-Type` header could break the exceptions app (#55, @gingerlime)
+
+## [v1.1.0](https://github.com/yuki24/rambulance/tree/v1.1.0)
+
+_<sup>released at 2020-05-23 02:52:27 UTC</sup>_
+
+#### Features
+
+- Add support for Ruby 2.7 ([<tt>718531c</tt>](https://github.com/yuki24/rambulance/commit/718531c45b61d01dce91f401fd81dd6aefdefb31))
+
+#### Bug fixes
+
+- Fixes a bug where malformed MIME type in HTTP headers could break the exceptions app ([#53](https://github.com/yuki24/rambulance/issues/53), [#54](https://github.com/yuki24/rambulance/pull/54), [@gingerlime](https://github.com/gingerlime))
+
 ## [v1.0.3](https://github.com/yuki24/rambulance/tree/v1.0.3)
 
 _<sup>released at 2019-10-03 03:39:17 UTC</sup>_

data/lib/rambulance/exceptions_app.rb

@@ -55,6 +55,12 @@ module Rambulance
     private
 
     def process_action(*)
+      begin
+        request.content_mime_type
+      rescue Mime::Type::InvalidMimeType
+        request.env["MALFORMED_CONTENT_TYPE"], request.env["CONTENT_TYPE"] = request.env["CONTENT_TYPE"], "text/plain"
+      end
+
       begin
         request.GET
       rescue ActionController::BadRequest

data/lib/rambulance/version.rb

@@ -1,3 +1,3 @@
 module Rambulance
-  VERSION = "1.1.0"
+  VERSION = "1.1.1"
 end

data/test/requests/error_json_test.rb

@@ -55,6 +55,25 @@ class ErrorJsonTest < ActionDispatch::IntegrationTest
     end
   end
 
+  test 'returns an appropriate status based on the rails version when the HTTP Content-type header is malformed' do
+    if Rails::VERSION::STRING >= '5.1.0'
+      post '/users', headers: { "CONTENT_TYPE" => "charset=gbk" }
+    else
+      post '/users', nil, "CONTENT_TYPE" => "charset=gbk"
+    end
+
+    if Rails::VERSION::STRING >= '6.0.0'
+      assert_equal 406, response.status
+      assert_equal "The requested content type is not acceptable.\n", response.body
+    elsif Rails::VERSION::STRING >= '5.2.0'
+      assert_equal 422, response.status
+    elsif Rails::VERSION::STRING >= '5.1.0'
+      assert_equal 500, response.status
+    elsif Rails::VERSION::STRING >= '4.2.0'
+      assert_equal 201, response.status
+    end
+  end
+
   private
 
   def without_layouts
@@ -67,12 +86,12 @@ class ErrorJsonTest < ActionDispatch::IntegrationTest
     `mv error.html.erb test/fake_app/app/views/layouts/`
   end
 
-  def get(path)
+  def get(path, params: {}, headers: {})
     without_layouts do
       if Rails::VERSION::STRING >= '5.1.0'
-        super path, headers: { "CONTENT_TYPE" => "application/json", "HTTP_ACCEPT" => "application/json" }
+        super path, params: params, headers: { "CONTENT_TYPE" => "application/json", "HTTP_ACCEPT" => "application/json" }.merge(headers)
       else
-        super path, nil, "CONTENT_TYPE" => "application/json", "HTTP_ACCEPT" => "application/json"
+        super path, params, { "CONTENT_TYPE" => "application/json", "HTTP_ACCEPT" => "application/json" }.merge(headers)
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rambulance
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Yuki Nishijima
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-23 00:00:00.000000000 Z
+date: 2020-05-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport