rambulance 1.0.3 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7e269fee25c5c5b5d087d8d3ef0ff34153dbeda65a6af3fbff3ae7dec07a19a3
-  data.tar.gz: 905fe5bb0bdd960845f068ee9446a5ff3ae3444e14862586045deb8caf702a1b
+  metadata.gz: 17bc50582db6ee389d7b677e43fcea58bdc91c758fdc953b39fa2fae52d7ae6c
+  data.tar.gz: 1fdd148f730d07b03ce03f4722dd2c151d4291de58f515ed2084a347f66854d6
 SHA512:
-  metadata.gz: ccff6fd760b1f6b3cb8fbd27e5312ac4765beedc9dbb5525915cf5d8f30aac392b4a6c81c853592583e6c6620cf16b7be85db872dd24470886104854fb6af43f
-  data.tar.gz: ba59cd558bc18a510a678e5ac306d2f0970a19882aab85797cf376443e94cb57a7015af47832b0e665020ec32acde67fc5c5cfecf53b94268c5b146cc94c58bc
+  metadata.gz: 4238686586fb7e22c95230a00d6e7fabf28312f43b018d750a0008590205a40b64413777f6a43559d26c045501f4e82cb7ef814204cb07ea9432a5f06f9c9606
+  data.tar.gz: a36d6333ec57c8706b3b5fb304362d0d1f1288b684009ee28842299bfb4daa015be58f93206eb146344d163d9e896166ce4dd4dc611af6d2e683124b742d30ab

data/.travis.yml

@@ -11,11 +11,12 @@ before_install:
 
 rvm:
   - 2.3.8
-  - 2.4.6
-  - 2.5.5
-  - 2.6.3
+  - 2.4.10
+  - 2.5.8
+  - 2.6.6
+  - 2.7.1
   - ruby-head
-  - jruby-9.2.7.0
+  - jruby-9.2.11.1
   - jruby-head
 
 gemfile:
@@ -32,20 +33,30 @@ matrix:
       gemfile: gemfiles/rails_60.gemfile
     - rvm: 2.3.8
       gemfile: gemfiles/rails_edge.gemfile
-    - rvm: 2.4.6
+    - rvm: 2.4.10
       gemfile: gemfiles/rails_60.gemfile
-    - rvm: 2.4.6
+    - rvm: 2.4.10
       gemfile: gemfiles/rails_edge.gemfile
-    - rvm: 2.6.3
+    - rvm: 2.6.6
       gemfile: gemfiles/rails_42.gemfile
+    - rvm: 2.7.1
+      gemfile: gemfiles/rails_42.gemfile
+    - rvm: 2.7.1
+      gemfile: gemfiles/rails_50.gemfile
+    - rvm: 2.7.1
+      gemfile: gemfiles/rails_51.gemfile
+    - rvm: 2.7.1
+      gemfile: gemfiles/rails_52.gemfile
     - rvm: ruby-head
       gemfile: gemfiles/rails_42.gemfile
     - rvm: ruby-head
       gemfile: gemfiles/rails_50.gemfile
     - rvm: ruby-head
       gemfile: gemfiles/rails_51.gemfile
+    - rvm: ruby-head
+      gemfile: gemfiles/rails_52.gemfile
   allow_failures:
     - rvm: ruby-head
-    - rvm: jruby-9.2.7.0
+    - rvm: jruby-9.2.11.1
     - rvm: jruby-head
     - gemfile: gemfiles/rails_edge.gemfile

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## [v1.0.3](https://github.com/yuki24/rambulance/tree/v1.0.3)
+
+_<sup>released at 2019-10-03 03:39:17 UTC</sup>_
+
+#### Fixes
+
+- Fixes a bug where custom exceptions app can not be loaded properly on Rails 6 and Zeitwerk ([#52](https://github.com/yuki24/rambulance/issues/52), [@sho918](https://github.com/sho918))
+
 ## [v1.0.2](https://github.com/yuki24/rambulance/tree/v1.0.2)
 
 _<sup>released at 2019-06-06 23:39:38 UTC</sup>_
@@ -58,7 +66,7 @@ _<sup>released at 2018-01-02 21:36:02 UTC</sup>_
 #### Breaking changes & deprecations
 
 - Drop support for Ruby 1.9.3
-- Drop support for generating Haml and Slim templates on `rails g rambulance:install`
+- Drop support for Haml and Slim templates
 
 #### Bug fixes
 

data/lib/rambulance/exceptions_app.rb

@@ -67,6 +67,12 @@ module Rambulance
         request.env["MALFORMED_BODY"], request.env["rack.input"] = request.env["rack.input"], StringIO.new
       end
 
+      begin
+        request.accepts
+      rescue Mime::Type::InvalidMimeType
+        request.env["MALFORMED_HTTP_ACCEPT"], request.env["HTTP_ACCEPT"] = request.env["HTTP_ACCEPT"], "*/*"
+      end
+
       # The #formats method needs to be called after the sanitization above.
       request.formats << Mime::Type.lookup('text/plain')
 

data/lib/rambulance/version.rb

@@ -1,3 +1,3 @@
 module Rambulance
-  VERSION = "1.0.3"
+  VERSION = "1.1.0"
 end

data/test/fake_app/rails_app.rb

@@ -8,6 +8,7 @@ class TestApp < Rails::Application
   config.eager_load = false
   config.root = File.dirname(__FILE__)
   config.autoload_paths += ["#{config.root}/lib"] if ENV["CUSTOM_EXCEPTIONS_APP"]
+  config.hosts = "www.example.com"
 
   if Rails::VERSION::STRING >= "5.2"
     config.action_controller.default_protect_from_forgery = true
@@ -50,6 +51,7 @@ class ApplicationController < ActionController::Base
     raise "This is a bad filter."
   end
 end
+
 class UsersController < ApplicationController
   if self.respond_to? :skip_before_action
     skip_before_action :bad_filter, except: :show
@@ -79,6 +81,7 @@ class UsersController < ApplicationController
     raise ForbiddenException
   end
 end
+
 class ProjectsController < ApplicationController
   if self.respond_to?(:skip_forgery_protection)
     skip_forgery_protection

data/test/requests/error_json_test.rb

@@ -36,6 +36,25 @@ class ErrorJsonTest < ActionDispatch::IntegrationTest
     assert_equal "Something went wrong", json_response['message']
   end
 
+  test 'returns an appropriate status based on the rails version when the HTTP Accept header is malformed' do
+    if Rails::VERSION::STRING >= '5.1.0'
+      post '/users', headers: { "HTTP_ACCEPT" => "image/apng*/*" }
+    else
+      post '/users', nil, "HTTP_ACCEPT" => "image/apng*/*"
+    end
+
+    if Rails::VERSION::STRING >= '6.0.0'
+      assert_equal 406, response.status
+      assert_equal "The requested content type is not acceptable.\n", response.body
+    elsif Rails::VERSION::STRING >= '5.2.0'
+      assert_equal 422, response.status
+    elsif Rails::VERSION::STRING >= '5.1.0'
+      assert_equal 500, response.status
+    elsif Rails::VERSION::STRING >= '4.2.0'
+      assert_equal 201, response.status
+    end
+  end
+
   private
 
   def without_layouts

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rambulance
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.1.0
 platform: ruby
 authors:
 - Yuki Nishijima
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-10-03 00:00:00.000000000 Z
+date: 2020-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -222,7 +222,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.3
 signing_key: 
 specification_version: 4
 summary: Simple and safe way to dynamically generate error pages