rambulance 0.6.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 56cafb27235f043f1b05600421ba5a01671aa3cd10d9f56beea8b29554e158a9
-  data.tar.gz: 78329235f2a74d2250f33cf80ab32c1312a507808a056a74a1b12c8fe956cdd3
+  metadata.gz: 82265aa18e23300634878ce073d6b72effb62a3a8326832f603d9b17b7640634
+  data.tar.gz: 67abe21526c25ab05b2faada53dbadafd62bf414638752cdec3450256e326e3a
 SHA512:
-  metadata.gz: 6d64689dae226f3d81305cf569f8de5ea5d90a261de6dd305441dfb231b5565f3821681de0d88895019953d2db6b50829b3c2dde3dcd8c919b4b430f844d3cff
-  data.tar.gz: 3783088dae915e9ac27897858dedb939017fc82d4bda229db4d10ea629bad01e1d14cdfef195e1c04877bee893fda0ae4e258df507d4f0f7552b5c992b05dba3
+  metadata.gz: 97932a0989390b458d8b697cb3be797f0441b623898a34d03e1920ff50f1d298b6ec5c03650b63adf6191a18ed22e66efda0c71686022691e48dab3cd5bcc836
+  data.tar.gz: 2af8602230f377774c17cb1f2ce0e1861a28880f7e5682807d135772fb51d9f69c8613f772866b082efccdfc8e5158971acfeedce16bbfb95c24afc812d77053

data/.travis.yml

@@ -1,94 +1,62 @@
 language: ruby
-script:   bundle exec rake
 cache:    bundler
 sudo:     false
 
+script:
+  - bundle exec rake
+
 before_install:
   - gem update --system
-  - gem pristine bundler
+  - gem install bundler
 
 rvm:
-  - 2.0.0
-  - 2.1
-  - 2.2.9
-  - 2.3.6
-  - 2.4.3
-  - 2.5.0
+  - 2.3.8
+  - 2.4.10
+  - 2.5.8
+  - 2.6.6
+  - 2.7.1
   - ruby-head
-  - jruby-9.1.16.0
+  - jruby-9.2.11.1
   - jruby-head
 
 gemfile:
-  - gemfiles/rails_32.gemfile
-  - gemfiles/rails_40.gemfile
-  - gemfiles/rails_41.gemfile
   - gemfiles/rails_42.gemfile
   - gemfiles/rails_50.gemfile
   - gemfiles/rails_51.gemfile
   - gemfiles/rails_52.gemfile
+  - gemfiles/rails_60.gemfile
   - gemfiles/rails_edge.gemfile
 
 matrix:
   exclude:
-    - rvm: 2.0.0
-      gemfile: gemfiles/rails_50.gemfile
-    - rvm: 2.0.0
-      gemfile: gemfiles/rails_51.gemfile
-    - rvm: 2.0.0
-      gemfile: gemfiles/rails_52.gemfile
-    - rvm: 2.0.0
+    - rvm: 2.3.8
+      gemfile: gemfiles/rails_60.gemfile
+    - rvm: 2.3.8
       gemfile: gemfiles/rails_edge.gemfile
-    - rvm: 2.1
+    - rvm: 2.4.10
+      gemfile: gemfiles/rails_60.gemfile
+    - rvm: 2.4.10
+      gemfile: gemfiles/rails_edge.gemfile
+    - rvm: 2.6.6
+      gemfile: gemfiles/rails_42.gemfile
+    - rvm: 2.7.1
+      gemfile: gemfiles/rails_42.gemfile
+    - rvm: 2.7.1
       gemfile: gemfiles/rails_50.gemfile
-    - rvm: 2.1
+    - rvm: 2.7.1
       gemfile: gemfiles/rails_51.gemfile
-    - rvm: 2.1
+    - rvm: 2.7.1
       gemfile: gemfiles/rails_52.gemfile
-    - rvm: 2.1
-      gemfile: gemfiles/rails_edge.gemfile
-    - rvm: 2.2.9
-      gemfile: gemfiles/rails_32.gemfile
-    - rvm: 2.2.9
-      gemfile: gemfiles/rails_51.gemfile
-    - rvm: 2.2.9
-      gemfile: gemfiles/rails_edge.gemfile
-    - rvm: 2.3.6
-      gemfile: gemfiles/rails_32.gemfile
-    - rvm: 2.3.6
-      gemfile: gemfiles/rails_edge.gemfile
-    - rvm: 2.4.3
-      gemfile: gemfiles/rails_32.gemfile
-    - rvm: 2.4.3
-      gemfile: gemfiles/rails_40.gemfile
-    - rvm: 2.4.3
-      gemfile: gemfiles/rails_41.gemfile
-    - rvm: 2.5.0
-      gemfile: gemfiles/rails_32.gemfile
-    - rvm: 2.5.0
-      gemfile: gemfiles/rails_40.gemfile
-    - rvm: 2.5.0
-      gemfile: gemfiles/rails_41.gemfile
     - rvm: ruby-head
-      gemfile: gemfiles/rails_32.gemfile
+      gemfile: gemfiles/rails_42.gemfile
     - rvm: ruby-head
-      gemfile: gemfiles/rails_40.gemfile
+      gemfile: gemfiles/rails_50.gemfile
     - rvm: ruby-head
-      gemfile: gemfiles/rails_41.gemfile
-    - rvm: jruby-9.1.16.0
-      gemfile: gemfiles/rails_32.gemfile
-    - rvm: jruby-9.1.16.0
-      gemfile: gemfiles/rails_40.gemfile
-    - rvm: jruby-9.1.16.0
-      gemfile: gemfiles/rails_41.gemfile
-    - rvm: jruby-head
-      gemfile: gemfiles/rails_32.gemfile
-    - rvm: jruby-head
-      gemfile: gemfiles/rails_40.gemfile
-    - rvm: jruby-head
-      gemfile: gemfiles/rails_41.gemfile
+      gemfile: gemfiles/rails_51.gemfile
+    - rvm: ruby-head
+      gemfile: gemfiles/rails_52.gemfile
   allow_failures:
     - rvm: ruby-head
-    - rvm: jruby-9.1.16.0
+    - rvm: jruby-9.2.11.1
     - rvm: jruby-head
     - gemfile: gemfiles/rails_edge.gemfile
-    - gemfile: gemfiles/rails_32.gem

data/Appraisals

@@ -43,9 +43,15 @@ appraise "rails_51" do
 end
 
 appraise "rails_52" do
-  gem "activesupport", "~> 5.2.0.rc1"
-  gem "actionpack", "~> 5.2.0.rc1"
-  gem "railties", "~> 5.2.0.rc1"
+  gem "activesupport", "~> 5.2.0"
+  gem "actionpack", "~> 5.2.0"
+  gem "railties", "~> 5.2.0"
+end
+
+appraise "rails_60" do
+  gem "activesupport", "~> 6.0.0.rc1"
+  gem "actionpack", "~> 6.0.0.rc1"
+  gem "railties", "~> 6.0.0.rc1"
 end
 
 appraise "rails_edge" do

data/CHANGELOG.md

@@ -1,3 +1,75 @@
+## v1.1.1 (unreleased)
+
+- Fixes a bug where a malformed `Content-Type` header could break the exceptions app (#55, @gingerlime)
+
+## [v1.1.0](https://github.com/yuki24/rambulance/tree/v1.1.0)
+
+_<sup>released at 2020-05-23 02:52:27 UTC</sup>_
+
+#### Features
+
+- Add support for Ruby 2.7 ([<tt>718531c</tt>](https://github.com/yuki24/rambulance/commit/718531c45b61d01dce91f401fd81dd6aefdefb31))
+
+#### Bug fixes
+
+- Fixes a bug where malformed MIME type in HTTP headers could break the exceptions app ([#53](https://github.com/yuki24/rambulance/issues/53), [#54](https://github.com/yuki24/rambulance/pull/54), [@gingerlime](https://github.com/gingerlime))
+
+## [v1.0.3](https://github.com/yuki24/rambulance/tree/v1.0.3)
+
+_<sup>released at 2019-10-03 03:39:17 UTC</sup>_
+
+#### Fixes
+
+- Fixes a bug where custom exceptions app can not be loaded properly on Rails 6 and Zeitwerk ([#52](https://github.com/yuki24/rambulance/issues/52), [@sho918](https://github.com/sho918))
+
+## [v1.0.2](https://github.com/yuki24/rambulance/tree/v1.0.2)
+
+_<sup>released at 2019-06-06 23:39:38 UTC</sup>_
+
+#### Fixes
+
+- Fixes a bug where `ExceptionsApp` is not loaded when action controller is not loaded ([<tt>ec9d9e5</tt>](https://github.com/yuki24/rambulance/commit/ec9d9e5de98eeec501042a0bbb95ae8ac8d7b4e3))
+
+## [v1.0.1](https://github.com/yuki24/rambulance/tree/v1.0.1)
+
+_<sup>released at 2019-06-04 16:30:38 UTC</sup>_
+
+#### Fixes
+
+- Fixes an issue where `ExceptionsApp` prevents Rails from booting up ([#49](https://github.com/yuki24/rambulance/issues/49))
+
+## [v1.0.0](https://github.com/yuki24/rambulance/tree/v1.0.0)
+
+_<sup>released at 2019-06-03 05:01:14 UTC</sup>_
+
+#### Features
+
+- Add support for Ruby 2.6
+- Add support for Rails 6.0
+
+#### Bug fixes
+
+- Fixes a bug where POST requests cause the exceptions app to throw an `ActionController::InvalidAuthenticityToken` error on Rails 5.2 ([<tt>d68d677</tt>](https://github.com/yuki24/rambulance/commit/d68d677de75059fa09f70e37c97f4bae95885c53), [#48](https://github.com/yuki24/rambulance/issues/48), [@adrianhuna](https://github.com/adrianhuna))
+
+#### Breaking Changes
+
+- Drop support for Ruby \<= 2.2
+- Drop support for Rails \<= 4.1
+
+## [v0.6.0](https://github.com/yuki24/rambulance/tree/v0.6.0)
+
+_<sup>released at 2018-03-08 18:36:16 UTC</sup>_
+
+#### New features
+
+- Add support for Rails 5.2
+- Add a test helper method `#with_exceptions_app` for easier testing ([<tt>f5c16b9</tt>](https://github.com/yuki24/rambulance/commit/f5c16b90ecf5eb4903faa30d760bf5863441e9c5), [#27](https://github.com/yuki24/rambulance/pull/27), [@kbaba1001](https://github.com/kbaba1001))
+
+#### Bug fixes
+
+- Fixed a bug where an `ActionController::UnknownFormat` error could cause a number of issues ([<tt>1b824e6</tt>](https://github.com/yuki24/rambulance/commit/1b824e6c170479ed90e24df1680dd2dec7c98160), [#41](https://github.com/yuki24/rambulance/issues/41), [#42](https://github.com/yuki24/rambulance/pull/42), [@willnet](https://github.com/willnet), [@joker-777](https://github.com/joker-777))
+- Fixed a bug where the methods on the `ExceptionApp` weren't easily inspectable ([<tt>6b4c834</tt>](https://github.com/yuki24/rambulance/commit/6b4c834bb0b8e81f619d9f598310ce68f4f9c66b))
+
 ## [v0.5.0](https://github.com/yuki24/rambulance/tree/v0.5.0)
 
 _<sup>released at 2018-01-02 21:36:02 UTC</sup>_

data/Dangerfile

@@ -0,0 +1,13 @@
+# Sometimes it's a README fix, or something like that - which isn't relevant for
+# including in a project's CHANGELOG for example
+declared_trivial = github.pr_title.include? "#trivial"
+
+# Make it more obvious that a PR is a work in progress and shouldn't be merged yet
+warn("PR is classed as Work in Progress") if github.pr_title.include? "WIP"
+
+# Warn when there is a big PR
+warn("Big PR") if git.lines_of_code > 500
+
+# Don't let testing shortcuts get into master by accident
+fail("fdescribe left in tests") if `grep -r fdescribe test/ `.length > 1
+fail("fit left in tests") if `grep -r fit test/ `.length > 1

data/README.md

@@ -1,6 +1,6 @@
-# Rambulance [![Build Status](https://travis-ci.org/yuki24/rambulance.svg?branch=master)](https://travis-ci.org/yuki24/rambulance)
+# Rambulance [![Build Status](https://travis-ci.org/yuki24/rambulance.svg?branch=master)](https://travis-ci.org/yuki24/rambulance) [![Gem Version](https://badge.fury.io/rb/rambulance.svg)](https://rubygems.org/gems/rambulance)
 
-Rambulance provides a simple and safe way to dynamically render error pages for Rails apps.
+A simple and safe way to dynamically render error pages for Rails apps.
 
 ## Features
 
@@ -10,7 +10,7 @@ Rambulance's exceptions app is simple, skinny and well-tested. It  inherits from
 
 ### Flexible
 
-You have full control of showing a specific error page for a specific exception. It can also render json responses. It even provides a way to create a custom exceptions app.
+You have full control of which error page to show for a specific exception. It also json rendering (perfect for API apps). It even provides a way to create a custom exceptions app.
 
 ### Easy installation and development
 
@@ -30,7 +30,7 @@ And then execute:
 $ rails g rambulance:install
 ```
 
-Rambulance only has support for `erb`. If you would like to use haml or slim templates, please see [How to Convert Your `.erb` to `.slim`](https://github.com/slim-template/slim/wiki/Template-Converters-ERB-to-SLIM) or [html2haml](https://github.com/haml/html2haml).
+Rambulance's generator can only generate `erb` templates. If you want to use haml or slim templates, please see [How to Convert Your `.erb` to `.slim`](https://github.com/slim-template/slim/wiki/Template-Converters-ERB-to-SLIM) or [html2haml](https://github.com/haml/html2haml).
 
 Now you can start editing templates like `app/views/errors/not_found.html.erb`. Edit, run `rails server` and open [`localhost:3000/rambulance/not_found`](http://localhost:3000/rambulance/not_found)!
 
@@ -56,19 +56,10 @@ config.rescue_responses = {
 
 ## Local Development
 
-There are 2 ways of editing the templates.
-
-<!---
-### Open [`localhost:3000/rambulance`](http://localhost:3000/rambulance) in Your Browser
-
-This page tells all the error pages as well as all the pairs of exceptions/corresponding http status. This is useful when you want to edit templates without changing Rails configuration. Click on one of the links in the page to see what the error page looks like.
-
-**This feature hasn't been implemented yet.**
--->
-
 ### Open `localhost:3000/rambulance/***` in Your Browser
 
-Just go to one of the error pages via Rambulance:
+Just open one of the error pages via Rambulance:
+
  * [`localhost:3000/rambulance/not_found`](http://localhost:3000/rambulance/not_found) or
  * [`localhost:3000/rambulance/internal_server_error`](http://localhost:3000/rambulance/internal_server_error)
 
@@ -92,13 +83,13 @@ If you want to do some more things in a exceptions app, you can also write your
 $ rails g rambulance:exceptions_app
 ```
 
-It'll generate your own custom exceptions app. You can use whatever techniques you use in controllers like `before_filter` and `flash[:notice] = "message..."` since it's a grandchild of `ActionController::Base`!
+It will generate your own custom exceptions app. You can use whatever techniques you want to use in controllers like `before_filter` and `flash[:notice] = "message..."` since it's a grandchild of `ActionController::Base`!
 
-**Keep in mind that you shouldn't do too many things because something already went wrong with your application!**
+**Heavily customizing the exceptions app is strongly discouraged as there would be no guard against bugs that occur in the exceptions app.**
 
 ## Testing
 
-Ramnurance ships with a test helper that allows you to test an error page generated by Rails. All you have to do is to `include Rambulance::TestHelper` and you will be able to use the `with_exceptions_app` DSDL:
+Rambulance ships with a test helper that allows you to test an error page generated by Rails. All you have to do is to `include Rambulance::TestHelper` and you will be able to use the `with_exceptions_app` DSDL:
 
 Rspec:
 
@@ -132,8 +123,8 @@ Note that testing error pages is not encouraged in Rails as it leads to overuse
 
 ## Supported Versions
 
-* Ruby 2.0.0, 2.1, 2.2, 2.3, 2,4, 2,5, trunk,  JRuby 9.1.16.0, and JRuby head
-* Rails 3.2, 4.0, 4.1, 4.2, 5.0, 5,1, 5,2 and edge
+* Ruby 2.3, 2,4, 2,5, 2.6, trunk, JRuby 9.2, and JRuby head
+* Rails 4.2, 5.0, 5.1, 5.2, 6.0 and edge
 
 Rambulance doesn't work with Rails 3.1 and below since they don't provide a way to use a custom exceptions app.
 

data/gemfiles/rails_52.gemfile

@@ -2,8 +2,8 @@
 
 source "https://rubygems.org"
 
-gem "activesupport", "~> 5.2.0.rc1"
-gem "actionpack", "~> 5.2.0.rc1"
-gem "railties", "~> 5.2.0.rc1"
+gem "activesupport", "~> 5.2.0"
+gem "actionpack", "~> 5.2.0"
+gem "railties", "~> 5.2.0"
 
 gemspec path: "../"

data/gemfiles/rails_60.gemfile

@@ -0,0 +1,9 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activesupport", "~> 6.0.0.rc1"
+gem "actionpack", "~> 6.0.0.rc1"
+gem "railties", "~> 6.0.0.rc1"
+
+gemspec path: "../"

data/lib/generators/rambulance/templates/rambulance.rb

@@ -22,12 +22,12 @@ Rambulance.setup do |config|
   }
 
   # The template name for the layout of the error pages. The default value is
-  # 'error'. For exmaple, if this value is set to "error_page", Rambulance uses
+  # 'error'. For example, if this value is set to "error_page", Rambulance uses
   # 'app/views/layout/error_page.html.erb' as a layout for all the error pages.
   config.layout_name = "error"
 
   # The directry name to organize error page templates. The default value is
-  # 'errors'. For exmaple, if this value is set to "error_pages", Rambulance
+  # 'errors'. For example, if this value is set to "error_pages", Rambulance
   # uses e.g. 'app/views/error_pages/not_found.html.erb'.
   config.view_path = "errors"
 

data/lib/rambulance/exceptions_app.rb

@@ -12,11 +12,11 @@ module Rambulance
   class ExceptionsApp < ActionController::Base
     layout :layout_name
 
-    BAD_REQUEST_EXCEPTION = begin
-                              ActionController::BadRequest
-                            rescue NameError
-                              TypeError # Rails 3.2 doesn't know about ActionController::BadRequest
-                            end
+    begin
+      skip_forgery_protection
+    rescue
+      # ignore errors from #skip_forgery_protection since older Rails adds this method later.
+    end
 
     def self.call(env)
       exception       = env["action_dispatch.exception"]
@@ -33,7 +33,7 @@ module Rambulance
 
     def self.local_prefixes
       [Rambulance.view_path]
-    end if ActionPack::VERSION::STRING >= "4.2.0"
+    end
 
     ERROR_HTTP_STATUSES.values.each do |status_in_words|
       eval <<-ACTION, nil, __FILE__, __LINE__ + 1
@@ -55,26 +55,33 @@ module Rambulance
     private
 
     def process_action(*)
+      begin
+        request.content_mime_type
+      rescue Mime::Type::InvalidMimeType
+        request.env["MALFORMED_CONTENT_TYPE"], request.env["CONTENT_TYPE"] = request.env["CONTENT_TYPE"], "text/plain"
+      end
+
       begin
         request.GET
-      rescue BAD_REQUEST_EXCEPTION
+      rescue ActionController::BadRequest
         request.env["MALFORMED_QUERY_STRING"], request.env["QUERY_STRING"] = request.env["QUERY_STRING"], ""
       end
 
       begin
         request.POST
-      rescue BAD_REQUEST_EXCEPTION, ArgumentError
+      rescue ActionController::BadRequest
         request.env["MALFORMED_BODY"], request.env["rack.input"] = request.env["rack.input"], StringIO.new
       end
 
-      # The #formats method needs to be called after the sanitization above.
-      if request.respond_to?(:formats)
-        request.formats << Mime::Type.lookup('text/plain')
-      elsif request.respond_to?(:format) && status == 406
-        # TODO: Remove this conditional when dropping support for Rails 3.2
-        request.format = Mime::Type.lookup('text/plain')
+      begin
+        request.accepts
+      rescue Mime::Type::InvalidMimeType
+        request.env["MALFORMED_HTTP_ACCEPT"], request.env["HTTP_ACCEPT"] = request.env["HTTP_ACCEPT"], "*/*"
       end
 
+      # The #formats method needs to be called after the sanitization above.
+      request.formats << Mime::Type.lookup('text/plain')
+
       super
     end
 

data/lib/rambulance/railtie.rb

@@ -1,14 +1,30 @@
 module Rambulance
   class Railtie < Rails::Railtie
     initializer 'rambulance', after: :prepend_helpers_path do |app|
-      require "rambulance/exceptions_app"
+      ActiveSupport.on_load(:action_controller) do
+        require "rambulance/exceptions_app"
+      end
 
       app.config.exceptions_app =
-        begin
-          ActiveSupport::Dependencies.load_missing_constant(Object, :ExceptionsApp)
-          ->(env){ ::ExceptionsApp.call(env) }
-        rescue NameError
-          ::Rambulance::ExceptionsApp
+        if app.config.respond_to?(:autoloader) && app.config.autoloader == :classic
+          ->(env) {
+            begin
+              ActiveSupport::Dependencies.load_missing_constant(Object, :ExceptionsApp)
+              ::ExceptionsApp.call(env)
+            rescue NameError
+              require "rambulance/exceptions_app" if !defined?(::Rambulance::ExceptionsApp)
+              ::Rambulance::ExceptionsApp.call(env)
+            end
+          }
+        else
+          ->(env) {
+            begin
+              ::ExceptionsApp.call(env)
+            rescue NameError
+              require "rambulance/exceptions_app" if !defined?(::Rambulance::ExceptionsApp)
+              ::Rambulance::ExceptionsApp.call(env)
+            end
+          }
         end
 
       ActiveSupport.on_load(:after_initialize) do

data/lib/rambulance/version.rb

@@ -1,3 +1,3 @@
 module Rambulance
-  VERSION = "0.6.0"
+  VERSION = "1.1.1"
 end

data/test/fake_app/rails_app.rb

@@ -8,6 +8,11 @@ class TestApp < Rails::Application
   config.eager_load = false
   config.root = File.dirname(__FILE__)
   config.autoload_paths += ["#{config.root}/lib"] if ENV["CUSTOM_EXCEPTIONS_APP"]
+  config.hosts = "www.example.com"
+
+  if Rails::VERSION::STRING >= "5.2"
+    config.action_controller.default_protect_from_forgery = true
+  end
 end
 Rails.backtrace_cleaner.remove_silencers!
 Rails.application.initialize!
@@ -15,7 +20,7 @@ Rails.application.initialize!
 # routes
 Rails.application.routes.draw do
   resources :users
-  resources :projects, only: :index
+  resources :projects, only: [:index, :create]
 end
 
 # custom exception class
@@ -46,6 +51,7 @@ class ApplicationController < ActionController::Base
     raise "This is a bad filter."
   end
 end
+
 class UsersController < ApplicationController
   if self.respond_to? :skip_before_action
     skip_before_action :bad_filter, except: :show
@@ -75,12 +81,18 @@ class UsersController < ApplicationController
     raise ForbiddenException
   end
 end
+
 class ProjectsController < ApplicationController
+  if self.respond_to?(:skip_forgery_protection)
+    skip_forgery_protection
+  end
+
   if self.respond_to? :skip_before_action
-    skip_before_action :bad_filter
+    skip_before_action :bad_filter, except: :create
   else
-    skip_filter :bad_filter
+    skip_filter :bad_filter, except: :create
   end
 
   def index; end
+  def create; end
 end

data/test/requests/error_json_test.rb

@@ -29,6 +29,51 @@ class ErrorJsonTest < ActionDispatch::IntegrationTest
     assert_equal "Page not found", json_response['message']
   end
 
+  test 'renders an error page on a POST request' do
+    post '/projects.json'
+
+    assert_equal 500, response.status
+    assert_equal "Something went wrong", json_response['message']
+  end
+
+  test 'returns an appropriate status based on the rails version when the HTTP Accept header is malformed' do
+    if Rails::VERSION::STRING >= '5.1.0'
+      post '/users', headers: { "HTTP_ACCEPT" => "image/apng*/*" }
+    else
+      post '/users', nil, "HTTP_ACCEPT" => "image/apng*/*"
+    end
+
+    if Rails::VERSION::STRING >= '6.0.0'
+      assert_equal 406, response.status
+      assert_equal "The requested content type is not acceptable.\n", response.body
+    elsif Rails::VERSION::STRING >= '5.2.0'
+      assert_equal 422, response.status
+    elsif Rails::VERSION::STRING >= '5.1.0'
+      assert_equal 500, response.status
+    elsif Rails::VERSION::STRING >= '4.2.0'
+      assert_equal 201, response.status
+    end
+  end
+
+  test 'returns an appropriate status based on the rails version when the HTTP Content-type header is malformed' do
+    if Rails::VERSION::STRING >= '5.1.0'
+      post '/users', headers: { "CONTENT_TYPE" => "charset=gbk" }
+    else
+      post '/users', nil, "CONTENT_TYPE" => "charset=gbk"
+    end
+
+    if Rails::VERSION::STRING >= '6.0.0'
+      assert_equal 406, response.status
+      assert_equal "The requested content type is not acceptable.\n", response.body
+    elsif Rails::VERSION::STRING >= '5.2.0'
+      assert_equal 422, response.status
+    elsif Rails::VERSION::STRING >= '5.1.0'
+      assert_equal 500, response.status
+    elsif Rails::VERSION::STRING >= '4.2.0'
+      assert_equal 201, response.status
+    end
+  end
+
   private
 
   def without_layouts
@@ -41,12 +86,12 @@ class ErrorJsonTest < ActionDispatch::IntegrationTest
     `mv error.html.erb test/fake_app/app/views/layouts/`
   end
 
-  def get(path)
+  def get(path, params: {}, headers: {})
     without_layouts do
       if Rails::VERSION::STRING >= '5.1.0'
-        super path, headers: { "CONTENT_TYPE" => "application/json", "HTTP_ACCEPT" => "application/json" }
+        super path, params: params, headers: { "CONTENT_TYPE" => "application/json", "HTTP_ACCEPT" => "application/json" }.merge(headers)
       else
-        super path, nil, "CONTENT_TYPE" => "application/json", "HTTP_ACCEPT" => "application/json"
+        super path, params, { "CONTENT_TYPE" => "application/json", "HTTP_ACCEPT" => "application/json" }.merge(headers)
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rambulance
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Yuki Nishijima
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-08 00:00:00.000000000 Z
+date: 2020-05-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -148,6 +148,7 @@ files:
 - ".travis.yml"
 - Appraisals
 - CHANGELOG.md
+- Dangerfile
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -161,6 +162,7 @@ files:
 - gemfiles/rails_50.gemfile
 - gemfiles/rails_51.gemfile
 - gemfiles/rails_52.gemfile
+- gemfiles/rails_60.gemfile
 - gemfiles/rails_edge.gemfile
 - lib/generators/rambulance/exceptions_app_generator.rb
 - lib/generators/rambulance/install_generator.rb
@@ -220,8 +222,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.1.3
 signing_key: 
 specification_version: 4
 summary: Simple and safe way to dynamically generate error pages