rally_rest_api 0.7.5 → 0.7.6

data/lib/rally_rest_api/rally_rest.rb

@@ -3,6 +3,10 @@ require 'uri'
 require 'rexml/document'
 require 'ostruct'
 
+module Rally
+  class NotAuthenticatedError < StandardError; end
+end
+
 #
 # RallyRestAPI - A Ruby-ized interface to Rally's REST webservice API
 #

data/lib/rally_rest_api/rest_builder.rb

@@ -87,10 +87,10 @@ class RestBuilder # :nodoc:
     http.use_ssl = true if url.scheme == "https"
     http.verify_mode = OpenSSL::SSL::VERIFY_NONE
     debug  "RestBuilder#send_request req = #{req.inspect} -- #{url}"
-    body = http.start { |http| http.request(req) }.body
-    debug  "RestBuilder#send_request result = #{body}"
-    check_for_errors(body)
-    body
+    response = http.start { |http| http.request(req) }
+    debug  "RestBuilder#send_request result = #{response.body}"
+    check_for_errors(response)
+    response.body
   end
   
   def create_builder
@@ -99,10 +99,16 @@ class RestBuilder # :nodoc:
     b
   end
 
-  def check_for_errors(s)
-    document = REXML::Document.new s
-    node = REXML::XPath.first document, '//Errors'
-    raise node.to_s if node && node.has_elements?
+  def check_for_errors(response)
+    case response
+    when Net::HTTPUnauthorized
+      raise Rally::NotAuthenticatedError.new("Invalid Username or Password.")
+    else
+      s = response.body
+      document = REXML::Document.new s
+      node = REXML::XPath.first document, '//Errors'
+      raise node.to_s if node && node.has_elements?
+    end
   end
 
   def camel_case_word(sym)

data/lib/rally_rest_api/version.rb

@@ -2,7 +2,7 @@ module RallyRestVersion #:nodoc:
   module LIBRARY_VERSION #:nodoc:
     MAJOR = 0
     MINOR = 7
-    TINY  = 5
+    TINY  = 6
 
     STRING = [MAJOR, MINOR, TINY].join('.')
   end

data/test/custom_http_header_spec.rb

@@ -5,8 +5,8 @@ describe "A CustomHttpHeader" do
   before(:each) do
     @custom_http_header = CustomHttpHeader.new
     @sample_values = {
-      :library  => RallyRestVersion::LIBRARY_VERSION::STRING,
-      :platform => RUBY_VERSION,
+      :library  => "RallyRestAPI version #{RallyRestVersion::LIBRARY_VERSION::STRING}",
+      :platform => "Ruby #{RUBY_VERSION}",
       :os       => RUBY_PLATFORM,
       :name     => 'Guacamole',
       :vendor   => "The Big Enchilda's Burrito Company",

data/test/rest_builder_spec.rb

@@ -46,4 +46,16 @@ describe "a RestBuilder " do
 			 }, @username, @password)
   end
 
+  it "should raise an error if the response contains an Error element" do
+    body = "<xml><Errors><Error/></Errors></xml>"
+    response = mock("response")
+    response.should_receive(:body).and_return(body)
+    lambda { @builder.check_for_errors(response) }.should raise_error(StandardError)
+  end
+
+  it "should raise a NotAuthenticatedError when a 401 response is returned" do
+    response = Net::HTTPUnauthorized.new("1.1", "401", "message")
+    lambda { @builder.check_for_errors(response) }.should raise_error(Rally::NotAuthenticatedError, /Invalid Username or Password/)
+  end
+
 end

data/test/test_helper.rb

@@ -1,4 +1,5 @@
 require 'test/unit'
 require 'rubygems'
 require 'spec'
+require 'net/http'
 require File.dirname(__FILE__) + '/../lib/rally_rest_api'

metadata

@@ -3,8 +3,8 @@ rubygems_version: 0.9.2
 specification_version: 1
 name: rally_rest_api
 version: !ruby/object:Gem::Version 
-  version: 0.7.5
-date: 2007-10-29 00:00:00 -06:00
+  version: 0.7.6
+date: 2007-11-21 00:00:00 -07:00
 summary: A ruby-ized interface to Rally's REST webservices API
 require_paths: 
 - lib