rakuten_web_service 1.4.1 → 1.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1eb72352ce1d5a3438ff53f83c36beed80fe1c2e
-  data.tar.gz: 6b367c56add033e81ddebafa35ed0c3d6212c2b8
+  metadata.gz: b14f637d234a8bb4962e0ca46a76b171a7a8918d
+  data.tar.gz: 315b2c8f96b6b630b626cfd6299650a59ce3801e
 SHA512:
-  metadata.gz: 59a3290303696eccf35353c7e957e1391bdae96686cfd2b6dde48dae0fd67663587c3b41368fc42b32bf1cc02ea240a442e0bf4cc5565783472938a9f8857303
-  data.tar.gz: caccbdebffb9fcad8ba7fc6f8585a60287ab85af7729cd763e72bae8ccccd5d6d69bcc0e688e42e765cd803c6090f78560dd0f604f6471d95c96419d2204a0d3
+  metadata.gz: 2e85f855a001112c676e8b17e41c445a67a46060c3bf2a7e9780ed29b11ab0286fe78162128cd198df987bafd079d088ce1cc8d0d57c4f8b8a7f6b519674ae24
+  data.tar.gz: 1f5f80be05c450def2e4e1592e40d0e1f4cd5e17979ff2af8081e67903ef9b05050c8b8ef25bd47ddc734539aae6cf3be0b26c4c2166a95c3d2561733af16c6e

data/.travis.yml

@@ -1,8 +1,9 @@
 language: ruby
 rvm:
   - 2.1.10
-  - 2.2.5
-  - 2.3.1
+  - 2.2.6
+  - 2.3.3
+  - 2.4.0
   - ruby-head
 
 cache: bundler
@@ -25,6 +26,6 @@ addons:
 
 notifications:
   email: false
-  hipchat:
-    rooms:
-      secure: RYuIFjh/T6Hlj9nJ0RjmlTlES+9ZWcDNe1o2KRqMdH8cK1epIEgcEzMsFP6wKPRMQqOVw6Tu5gBMltDgu26sAW8HkTnMlzYtF6AVeOgsC6VVO9XzdaoVWWQX5J/Xn21vNV1vcncuOuMByz6dmzWngZv3T0u1mcvPje00EDNo27M=
+  webhooks:
+    urls:
+      - https://webhooks.gitter.im/e/059b85fcc75550b7bc39

data/CHANGELOG.md

@@ -1,3 +1,17 @@
+# v1.4.2 (2017/01/22)
+
+## Bug Fixes
+
+* `Net::HTTP` is NOT `reuquire`d anywhere in the codebase. [#67](https://github.com/rakuten-ws/rws-ruby-sdk/pull/67)
+
+   The version 1.4.1 or earlier of this gem doesn't `require 'net/http'` by itself.
+   @gouf found the bug report in [teratail](https://teratail.com/questions/62804) and made a pull-request to fix it. Thanks!
+
+## Improvements
+
+* `debug_mode` has come again! if you want to see responses from Rakuten Web Service APIs, you can see the ones by set `debug_mode` `true`. [#56](https://github.com/rakuten-ws/rws-ruby-sdk/pull/56)
+* Refactoring: use new Hash syntax as supporting ruby 1.9 series has been stopped already. [#60](https://github.com/rakuten-ws/rws-ruby-sdk/pull/60)
+
 # v1.4.1 (2016/11/22)
 
 ## Bug Fix
@@ -6,7 +20,7 @@
 
 ## Thanks
 
-I'm pleased to say thanks to @sho-yamane since he reporeted the bug #53. If he didn't do it, I would find the bug much later.
+I'm pleased to say thanks to @sho-yamane since he reported the bug #53. If he didn't do it, I would find the bug much later.
 Thanks, @sho-yamane.
 
 

data/Gemfile

@@ -4,6 +4,6 @@ source 'https://rubygems.org'
 gemspec
 
 group :test do
+  gem "simplecov", require: false
   gem "codeclimate-test-reporter", '~> 1.0.0'
-  gem "coveralls", require: nil
 end

data/README.md

@@ -2,8 +2,9 @@
 
 [![Build Status](https://travis-ci.org/rakuten-ws/rws-ruby-sdk.svg?branch=master)](https://travis-ci.org/rakuten-ws/rws-ruby-sdk)
 [![Gem Version](https://badge.fury.io/rb/rakuten_web_service.svg)](https://badge.fury.io/rb/rakuten_web_service)
-[![Coverage Status](https://coveralls.io/repos/github/rakuten-ws/rws-ruby-sdk/badge.svg?branch=master)](https://coveralls.io/github/rakuten-ws/rws-ruby-sdk?branch=master)
+[![Test Coverage](https://codeclimate.com/github/rakuten-ws/rws-ruby-sdk/badges/coverage.svg)](https://codeclimate.com/github/rakuten-ws/rws-ruby-sdk/coverage)
 [![Code Climate](https://codeclimate.com/github/rakuten-ws/rws-ruby-sdk/badges/gpa.svg)](https://codeclimate.com/github/rakuten-ws/rws-ruby-sdk)
+[![Gitter](https://badges.gitter.im/rakuten-ws/rws-ruby-sdk.svg)](https://gitter.im/rakuten-ws/rws-ruby-sdk?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge)
 
 This gem provides a client for easily accessing [Rakuten Web Service APIs](https://webservice.rakuten.co.jp/).
 

data/examples/books_item_search.rb

@@ -1,8 +1,8 @@
-# This is a sample script of Rakuten Books APIs. 
-# RWS Ruby SDK supports Books API. The inteface is similar to ones Ichiba API. 
-# If you want to search CDs dealt in Rakuten Books, you can do it with `RakutenWebService::Books::CD`. 
-# As for other resources, there are `RakutenWebService::Books::Book`, `RakutenWebService::Books::DVD` and so on. 
-# Please refer to the following documents if you want more detail of input/output parameters: 
+# This is a sample script of Rakuten Books APIs.
+# RWS Ruby SDK supports Books API. The inteface is similar to ones Ichiba API.
+# If you want to search CDs dealt in Rakuten Books, you can do it with `RakutenWebService::Books::CD`.
+# As for other resources, there are `RakutenWebService::Books::Book`, `RakutenWebService::Books::DVD` and so on.
+# Please refer to the following documents if you want more detail of input/output parameters:
 #   http://webservice.rakuten.co.jp/document/
 #
 
@@ -15,7 +15,7 @@ RakutenWebService.configure do |c|
   c.application_id = application_id
 end
 
-cds = RakutenWebService::Books::CD.search(:title => keyword)
+cds = RakutenWebService::Books::CD.search(title: keyword)
 
 cds.first(10).each do |cd|
   puts "#{cd.title} (#{cd.title_kana}):\n\t #{cd.play_list}"

data/examples/gora_search.rb

@@ -16,7 +16,7 @@ RakutenWebService.configure do |c|
   c.application_id = application_id
 end
 
-c = RakutenWebService::Gora::Course.search(:keyword => keyword).first
+c = RakutenWebService::Gora::Course.search(keyword: keyword).first
 id = c.golf_course_id
 puts id
 puts c.golf_course_name
@@ -35,7 +35,7 @@ end
 
 next_week = Date.today + 7
 chiba_and_kanagawa = '12,14'
-plans = RWS::Gora::Plan.search(:areaCode => chiba_and_kanagawa, :playDate => next_week.strftime('%Y-%m-%d'))
+plans = RWS::Gora::Plan.search(areaCode: chiba_and_kanagawa, playDate: next_week.strftime('%Y-%m-%d'))
 plans.first(5).each { |p|
   puts "#{p.golf_course_id}, #{p.golf_course_name}"
   p.plan_info.each { |pi|

data/examples/ichiba_item_search.rb

@@ -7,7 +7,7 @@ RakutenWebService.configure do |c|
   c.application_id = application_id
 end
 
-items = RakutenWebService::Ichiba::Item.search(:keyword => keyword)
+items = RakutenWebService::Ichiba::Item.search(keyword: keyword)
 
 items.first(10).each do |item|
   puts "#{item['itemName']}, #{item['itemPrice']} yen"

data/lib/rakuten_web_service/books/genre.rb

@@ -12,7 +12,7 @@ module RakutenWebService
       root_id '000'
 
       def search(params={})
-        params = params.merge(:booksGenreId => self.id)
+        params = params.merge(booksGenreId: self.id)
         resource = Books::Resource.find_resource_by_genre_id(self.id)
         resource.search(params)
       end

data/lib/rakuten_web_service/client.rb

@@ -1,4 +1,5 @@
 require 'uri'
+require 'net/http'
 require 'cgi'
 require 'json'
 require 'rakuten_web_service/response'
@@ -29,6 +30,9 @@ module RakutenWebService
     def request(path, params)
       http = Net::HTTP.new(@url.host, @url.port)
       http.use_ssl = true
+      if RakutenWebService.configuration.debug_mode?
+        http.set_debug_output($stderr)
+      end
       path = "#{path}?#{params.map { |k, v| "#{k}=#{CGI.escape(v.to_s)}" }.join('&')}"
       header = {
         'User-Agent' => "RakutenWebService SDK for Ruby v#{RWS::VERSION}(ruby-#{RUBY_VERSION} [#{RUBY_PLATFORM}])"

data/lib/rakuten_web_service/ichiba/genre.rb

@@ -17,7 +17,7 @@ module RakutenWebService
       end
 
       def products(options={})
-        options = options.merge(:genre_id => self.id)
+        options = options.merge(genre_id: self.id)
         RakutenWebService::Ichiba::Product.search(options)
       end
     end

data/lib/rakuten_web_service/ichiba/shop.rb

@@ -7,7 +7,7 @@ module RakutenWebService
       attribute :shopName, :shopCode, :shopUrl, :shopAffiliateUrl
 
       def items(options={})
-        options = options.merge(:shop_code => self.code)
+        options = options.merge(shop_code: self.code)
         RakutenWebService::Ichiba::Item.search(options)
       end
     end

data/lib/rakuten_web_service/search_result.rb

@@ -47,8 +47,8 @@ module RakutenWebService
                            "+#{key}"
                          end
       elsif options.to_s == 'standard'
-        new_params[:sort] = 'standard' 
-      else 
+        new_params[:sort] = 'standard'
+      else
         raise ArgumentError, "Invalid Sort Option: #{options.inspect}"
       end
       self.class.new(new_params, @resource_class)
@@ -68,11 +68,11 @@ module RakutenWebService
     end
 
     def next_page
-      search(:page => response.page + 1)
+      search(page: response.page + 1)
     end
 
     def page(num)
-      search(:page => num)
+      search(page: num)
     end
 
     def genre_information
@@ -81,7 +81,7 @@ module RakutenWebService
 
     private
     def ensure_retries(max_retries=RakutenWebService.configuration.max_retries)
-      begin 
+      begin
         yield
       rescue RWS::TooManyRequests => e
         if max_retries > 0

data/lib/rakuten_web_service/version.rb

@@ -1,3 +1,3 @@
 module RakutenWebService
-  VERSION = "1.4.1".freeze
+  VERSION = "1.4.2".freeze
 end

data/spec/rakuten_web_service/books/book_spec.rb

@@ -6,9 +6,9 @@ describe RakutenWebService::Books::Book do
   let(:application_id) { 'dummy_application_id' }
   let(:expected_query) do
     {
-      :affiliateId => affiliate_id,
-      :applicationId => application_id,
-      :title => 'Ruby'
+      affiliateId: affiliate_id,
+      applicationId: application_id,
+      title: 'Ruby'
     }
   end
 
@@ -23,18 +23,18 @@ describe RakutenWebService::Books::Book do
     before do
       response = JSON.parse(fixture('books/book_search_with_keyword_Ruby.json'))
       @expected_request = stub_request(:get, endpoint).
-        with(:query => expected_query).to_return(:body => response.to_json)
+        with(query: expected_query).to_return(body: response.to_json)
 
       response['page'] = 2
       response['first'] = 31
       response['last'] = 60
       @second_request = stub_request(:get, endpoint).
-        with(:query => expected_query.merge(:page => 2)).
-        to_return(:body => response.to_json)
+        with(query: expected_query.merge(page: 2)).
+        to_return(body: response.to_json)
     end
 
     specify 'call endpoint when accessing results' do
-      books = RakutenWebService::Books::Book.search(:title => 'Ruby')
+      books = RakutenWebService::Books::Book.search(title: 'Ruby')
       expect(@expected_request).to_not have_been_made
 
       books.first
@@ -46,7 +46,7 @@ describe RakutenWebService::Books::Book do
     before do
       response = JSON.parse(fixture('books/book_search_with_keyword_Ruby.json'))
       @expected_request = stub_request(:get, endpoint).
-        with(:query => expected_query).to_return(:body => response.to_json)
+        with(query: expected_query).to_return(body: response.to_json)
     end
 
     subject { RakutenWebService::Books::Book.search(title: 'Ruby') }
@@ -76,11 +76,11 @@ describe RakutenWebService::Books::Book do
       res['last'] = 30
 
       stub_request(:get, endpoint).
-        with(:query => expected_query).to_return(:body => res.to_json)
+        with(query: expected_query).to_return(body: res.to_json)
     end
 
     specify 'genretes RWS::Books::Genre object' do
-      book = RWS::Books::Book.search(:title => 'Ruby').first
+      book = RWS::Books::Book.search(title: 'Ruby').first
 
       expect(RWS::Books::Genre).to receive(:new).with(response['Items'][0]['Item']['booksGenreId'])
       expect(book.genre).to be_a(Array)
@@ -88,24 +88,24 @@ describe RakutenWebService::Books::Book do
 
     specify 'generate an array of Books::Genre object if books_genre_id includes 2 ids' do
       genre_id = '001004008007/001021001010'
-      book = RWS::Books::Book.new(:booksGenreId => genre_id) 
+      book = RWS::Books::Book.new(booksGenreId: genre_id)
       genre_id.split('/').each do |id|
         expect(RWS::Books::Genre).to receive(:new).with(id)
       end
-      
+
       expect(book.genres).to be_a(Array)
     end
   end
 
   context 'When using Books::Total.search' do
     let(:book) do
-      RWS::Books::Book.new(:isbn => '12345')
+      RWS::Books::Book.new(isbn: '12345')
     end
 
     before do
       @expected_request = stub_request(:get, endpoint).
-        with(:query => { :affiliateId => affiliate_id, :applicationId => application_id, :isbn => '12345' }).
-        to_return(:body => { :Items => [ { :Item => { :title => 'foo' } } ] }.to_json)
+        with(query: { affiliateId: affiliate_id, applicationId: application_id, isbn: '12345' }).
+        to_return(body: { Items: [ { Item: { title: 'foo' } } ] }.to_json)
     end
 
     specify 'retrieves automatically if accessing the value of lack attribute' do

data/spec/rakuten_web_service/books/cd_spec.rb

@@ -6,9 +6,9 @@ describe RakutenWebService::Books::CD do
   let(:application_id) { 'dummy_application_id' }
   let(:expected_query) do
     {
-      :affiliateId => affiliate_id,
-      :applicationId => application_id,
-      :keyword => 'Ruby'
+      affiliateId: affiliate_id,
+      applicationId: application_id,
+      keyword: 'Ruby'
     }
   end
 
@@ -23,18 +23,18 @@ describe RakutenWebService::Books::CD do
     before do
       response = JSON.parse(fixture('books/cd_search_with_keyword_Ruby.json'))
       @expected_request = stub_request(:get, endpoint).
-        with(:query => expected_query).to_return(:body => response.to_json)
+        with(query: expected_query).to_return(body: response.to_json)
 
       response['page'] = 2
       response['first'] = 31
       response['last'] = 60
       @second_request = stub_request(:get, endpoint).
-        with(:query => expected_query.merge(:page => 2)).
-        to_return(:body => response.to_json)
+        with(query: expected_query.merge(page: 2)).
+        to_return(body: response.to_json)
     end
 
     specify 'call endpoint when accessing results' do
-      cds = RakutenWebService::Books::CD.search(:keyword => 'Ruby')
+      cds = RakutenWebService::Books::CD.search(keyword: 'Ruby')
       expect(@expected_request).to_not have_been_made
 
       cd = cds.first
@@ -45,13 +45,13 @@ describe RakutenWebService::Books::CD do
 
   context 'When using Books::Total.search' do
     let(:cd) do
-      RWS::Books::CD.new(:jan => '12345')
+      RWS::Books::CD.new(jan: '12345')
     end
 
     before do
       @expected_request = stub_request(:get, endpoint).
-        with(:query => { :affiliateId => affiliate_id, :applicationId => application_id, :jan => '12345' }).
-        to_return(:body => { :Items => [ { :Item => { :title => 'foo' } } ] }.to_json)
+        with(query: { affiliateId: affiliate_id, applicationId: application_id, jan: '12345' }).
+        to_return(body: { Items: [ { Item: { title: 'foo' } } ] }.to_json)
     end
 
     specify 'retrieves automatically if accessing the value of lack attribute' do

data/spec/rakuten_web_service/books/dvd_spec.rb

@@ -6,9 +6,9 @@ describe RakutenWebService::Books::DVD do
   let(:application_id) { 'dummy_application_id' }
   let(:expected_query) do
     {
-      :affiliateId => affiliate_id,
-      :applicationId => application_id,
-      :keyword => 'Ruby'
+      affiliateId: affiliate_id,
+      applicationId: application_id,
+      keyword: 'Ruby'
     }
   end
 
@@ -23,18 +23,18 @@ describe RakutenWebService::Books::DVD do
     before do
       response = JSON.parse(fixture('books/dvd_search_with_keyword_Ruby.json'))
       @expected_request = stub_request(:get, endpoint).
-        with(:query => expected_query).to_return(:body => response.to_json)
+        with(query: expected_query).to_return(body: response.to_json)
 
       response['page'] = 2
       response['first'] = 31
       response['last'] = 60
       @second_request = stub_request(:get, endpoint).
-        with(:query => expected_query.merge(:page => 2)).
-        to_return(:body => response.to_json)
+        with(query: expected_query.merge(page: 2)).
+        to_return(body: response.to_json)
     end
 
     specify 'call endpoint when accessing results' do
-      dvds = RakutenWebService::Books::DVD.search(:keyword => 'Ruby')
+      dvds = RakutenWebService::Books::DVD.search(keyword: 'Ruby')
       expect(@expected_request).to_not have_been_made
 
       dvd = dvds.first
@@ -45,13 +45,13 @@ describe RakutenWebService::Books::DVD do
 
   context 'When using Books::Total.search' do
     let(:dvd) do
-      RWS::Books::DVD.new(:jan => '12345')
+      RWS::Books::DVD.new(jan: '12345')
     end
 
     before do
       @expected_request = stub_request(:get, endpoint).
-        with(:query => { :affiliateId => affiliate_id, :applicationId => application_id, :jan => '12345' }).
-        to_return(:body => { :Items => [ { :Item => { :title => 'foo' } } ] }.to_json)
+        with(query: { affiliateId: affiliate_id, applicationId: application_id, jan: '12345' }).
+        to_return(body: { Items: [ { Item: { title: 'foo' } } ] }.to_json)
     end
 
     specify 'retrieves automatically if accessing the value of lack attribute' do

data/spec/rakuten_web_service/books/foreign_book_spec.rb

@@ -6,9 +6,9 @@ describe RakutenWebService::Books::ForeignBook do
   let(:application_id) { 'dummy_application_id' }
   let(:expected_query) do
     {
-      :affiliateId => affiliate_id,
-      :applicationId => application_id,
-      :keyword => 'Ruby'
+      affiliateId: affiliate_id,
+      applicationId: application_id,
+      keyword: 'Ruby'
     }
   end
 
@@ -23,18 +23,18 @@ describe RakutenWebService::Books::ForeignBook do
     before do
       response = JSON.parse(fixture('books/foreign_book_search_with_keyword_Ruby.json'))
       @expected_request = stub_request(:get, endpoint).
-        with(:query => expected_query).to_return(:body => response.to_json)
+        with(query: expected_query).to_return(body: response.to_json)
 
       response['page'] = 2
       response['first'] = 31
       response['last'] = 60
       @second_request = stub_request(:get, endpoint).
-        with(:query => expected_query.merge(:page => 2)).
-        to_return(:body => response.to_json)
+        with(query: expected_query.merge(page: 2)).
+        to_return(body: response.to_json)
     end
 
     specify 'call endpoint when accessing results' do
-      books = RakutenWebService::Books::ForeignBook.search(:keyword => 'Ruby')
+      books = RakutenWebService::Books::ForeignBook.search(keyword: 'Ruby')
       expect(@expected_request).to_not have_been_made
 
       books.first
@@ -44,13 +44,13 @@ describe RakutenWebService::Books::ForeignBook do
 
   context 'When using Books::Total.search' do
     let(:book) do
-      RWS::Books::ForeignBook.new(:isbn => '12345')
+      RWS::Books::ForeignBook.new(isbn: '12345')
     end
 
     before do
       @expected_request = stub_request(:get, endpoint).
-        with(:query => { :affiliateId => affiliate_id, :applicationId => application_id, :isbn => '12345' }).
-        to_return(:body => { :Items => [ { :Item => { :title => 'foo' } } ] }.to_json)
+        with(query: { affiliateId: affiliate_id, applicationId: application_id, isbn: '12345' }).
+        to_return(body: { Items: [ { Item: { title: 'foo' } } ] }.to_json)
     end
 
     specify 'retrieves automatically if accessing the value of lack attribute' do