rakuten_web_service 1.4.1 → 1.4.2

data/spec/rakuten_web_service/books/game_spec.rb

@@ -6,9 +6,9 @@ describe RakutenWebService::Books::Game do
   let(:application_id) { 'dummy_application_id' }
   let(:expected_query) do
     {
-      :affiliateId => affiliate_id,
-      :applicationId => application_id,
-      :keyword => 'Ruby'
+      affiliateId: affiliate_id,
+      applicationId: application_id,
+      keyword: 'Ruby'
     }
   end
 
@@ -23,11 +23,11 @@ describe RakutenWebService::Books::Game do
     before do
       response = JSON.parse(fixture('books/game_search_with_keyword_Ruby.json'))
       @expected_request = stub_request(:get, endpoint).
-        with(:query => expected_query).to_return(:body => response.to_json)
+        with(query: expected_query).to_return(body: response.to_json)
     end
 
     specify 'call endpoint when accessing results' do
-      games = RakutenWebService::Books::Game.search(:keyword => 'Ruby')
+      games = RakutenWebService::Books::Game.search(keyword: 'Ruby')
       expect(@expected_request).to_not have_been_made
 
       game = games.first
@@ -38,13 +38,13 @@ describe RakutenWebService::Books::Game do
 
   context 'When using Books::Total.search' do
     let(:game) do
-      RWS::Books::Game.new(:jan => '12345')
+      RWS::Books::Game.new(jan: '12345')
     end
 
     before do
       @expected_request = stub_request(:get, endpoint).
-        with(:query => { :affiliateId => affiliate_id, :applicationId => application_id, :jan => '12345' }).
-        to_return(:body => { :Items => [ { :Item => { :title => 'foo' } } ] }.to_json)
+        with(query: { affiliateId: affiliate_id, applicationId: application_id, jan: '12345' }).
+        to_return(body: { Items: [ { Item: { title: 'foo' } } ] }.to_json)
     end
 
     specify 'retrieves automatically if accessing the value of lack attribute' do

data/spec/rakuten_web_service/books/genre_spec.rb

@@ -7,9 +7,9 @@ describe RWS::Books::Genre do
   let(:genre_id) { '000' }
   let(:expected_query) do
     {
-      :affiliateId => affiliate_id,
-      :applicationId => application_id,
-      :booksGenreId => genre_id
+      affiliateId: affiliate_id,
+      applicationId: application_id,
+      booksGenreId: genre_id
     }
   end
   let(:expected_json) do
@@ -22,8 +22,8 @@ describe RWS::Books::Genre do
 
   before do
     @expected_request = stub_request(:get, endpoint).
-      with(:query => expected_query).
-      to_return(:body => expected_json.to_json)
+      with(query: expected_query).
+      to_return(body: expected_json.to_json)
 
     RakutenWebService.configure do |c|
       c.affiliate_id = affiliate_id
@@ -33,7 +33,7 @@ describe RWS::Books::Genre do
 
   describe '.search' do
     before do
-      @genre = RWS::Books::Genre.search(:booksGenreId => genre_id).first
+      @genre = RWS::Books::Genre.search(booksGenreId: genre_id).first
     end
 
     specify 'call the endpoint once' do
@@ -57,11 +57,11 @@ describe RWS::Books::Genre do
     let(:genre_id) { '007' }
     let(:expected_json) do
       {
-        :current => {
-          :booksGenreId => genre_id,
-          :booksGenreName => 'DummyGenre',
-          :genreLevel => '2'
-        }
+        current: {
+                  booksGenreId: genre_id,
+                  booksGenreName: 'DummyGenre',
+                  genreLevel: '2'
+                }
       }
     end
 
@@ -91,7 +91,7 @@ describe RWS::Books::Genre do
   describe '#children' do
     context 'When get search method' do
       before do
-        @genre = RWS::Books::Genre.search(:booksGenreId => genre_id).first
+        @genre = RWS::Books::Genre.search(booksGenreId: genre_id).first
       end
 
       specify 'are Books::Genre objects' do
@@ -104,7 +104,7 @@ describe RWS::Books::Genre do
 
     context 'when the genre object has no children information' do
       specify 'call the endpoint to get children' do
-        genre = RWS::Books::Genre.new(:booksGenreId => genre_id)
+        genre = RWS::Books::Genre.new(booksGenreId: genre_id)
         genre.children
 
         expect(@expected_request).to have_been_made.once
@@ -114,14 +114,14 @@ describe RWS::Books::Genre do
 
   describe '#search' do
     before do
-      @genre = RWS::Books::Genre.new(:booksGenreId => genre_id)
+      @genre = RWS::Books::Genre.new(booksGenreId: genre_id)
     end
 
     context 'if the genre_id starts with "001"' do
       let(:genre_id) { '001001' }
 
       specify 'delegate Books::Book.search' do
-        expect(RWS::Books::Book).to receive(:search).with(:booksGenreId => genre_id)
+        expect(RWS::Books::Book).to receive(:search).with(booksGenreId: genre_id)
 
         @genre.search
       end
@@ -131,7 +131,7 @@ describe RWS::Books::Genre do
       let(:genre_id) { '002101' }
 
       specify 'delegate Books::CD.search' do
-        expect(RWS::Books::CD).to receive(:search).with(:booksGenreId => genre_id)
+        expect(RWS::Books::CD).to receive(:search).with(booksGenreId: genre_id)
 
         @genre.search
       end
@@ -141,7 +141,7 @@ describe RWS::Books::Genre do
       let(:genre_id) { '003201' }
 
       specify 'delegate Books::DVD.search' do
-        expect(RWS::Books::DVD).to receive(:search).with(:booksGenreId => genre_id)
+        expect(RWS::Books::DVD).to receive(:search).with(booksGenreId: genre_id)
 
         @genre.search
       end
@@ -151,7 +151,7 @@ describe RWS::Books::Genre do
       let(:genre_id) { '004301' }
 
       specify 'delegate Books::Software.search' do
-        expect(RWS::Books::Software).to receive(:search).with(:booksGenreId => genre_id)
+        expect(RWS::Books::Software).to receive(:search).with(booksGenreId: genre_id)
 
         @genre.search
       end
@@ -161,7 +161,7 @@ describe RWS::Books::Genre do
       let(:genre_id) { '005401' }
 
       specify 'delegate Books::ForeignBook.search' do
-        expect(RWS::Books::ForeignBook).to receive(:search).with(:booksGenreId => genre_id)
+        expect(RWS::Books::ForeignBook).to receive(:search).with(booksGenreId: genre_id)
 
         @genre.search
       end
@@ -171,17 +171,17 @@ describe RWS::Books::Genre do
       let(:genre_id) { '006501' }
 
       specify 'delegate Books::Game.search' do
-        expect(RWS::Books::Game).to receive(:search).with(:booksGenreId => genre_id)
+        expect(RWS::Books::Game).to receive(:search).with(booksGenreId: genre_id)
 
         @genre.search
       end
     end
-    
+
     context 'if the genre_id starts with "007"' do
       let(:genre_id) { '007601' }
 
       specify 'delegate Books::Magazine.search' do
-        expect(RWS::Books::Magazine).to receive(:search).with(:booksGenreId => genre_id)
+        expect(RWS::Books::Magazine).to receive(:search).with(booksGenreId: genre_id)
 
         @genre.search
       end

data/spec/rakuten_web_service/books/magazine_spec.rb

@@ -6,9 +6,9 @@ describe RakutenWebService::Books::Magazine do
   let(:application_id) { 'dummy_application_id' }
   let(:expected_query) do
     {
-      :affiliateId => affiliate_id,
-      :applicationId => application_id,
-      :keyword => 'Ruby'
+      affiliateId: affiliate_id,
+      applicationId: application_id,
+      keyword: 'Ruby'
     }
   end
 
@@ -23,11 +23,11 @@ describe RakutenWebService::Books::Magazine do
     before do
       response = JSON.parse(fixture('books/magazine_search_with_keyword_Ruby.json'))
       @expected_request = stub_request(:get, endpoint).
-        with(:query => expected_query).to_return(:body => response.to_json)
+        with(query: expected_query).to_return(body: response.to_json)
     end
 
     specify 'call endpoint when accessing results' do
-      magazines = RakutenWebService::Books::Magazine.search(:keyword => 'Ruby')
+      magazines = RakutenWebService::Books::Magazine.search(keyword: 'Ruby')
       expect(@expected_request).to_not have_been_made
 
       magazine = magazines.first
@@ -38,13 +38,13 @@ describe RakutenWebService::Books::Magazine do
 
   context 'When using Books::Total.search' do
     let(:magazine) do
-      RWS::Books::Magazine.new(:jan => '12345')
+      RWS::Books::Magazine.new(jan: '12345')
     end
 
     before do
       @expected_request = stub_request(:get, endpoint).
-        with(:query => { :affiliateId => affiliate_id, :applicationId => application_id, :jan => '12345' }).
-        to_return(:body => { :Items => [ { :Item => { :title => 'foo' } } ] }.to_json)
+        with(query: { affiliateId: affiliate_id, applicationId: application_id, jan: '12345' }).
+        to_return(body: { Items: [ { Item: { title: 'foo' } } ] }.to_json)
     end
 
     specify 'retrieves automatically if accessing the value of lack attribute' do

data/spec/rakuten_web_service/books/software_spec.rb

@@ -6,9 +6,9 @@ describe RakutenWebService::Books::Software do
   let(:application_id) { 'dummy_application_id' }
   let(:expected_query) do
     {
-      :affiliateId => affiliate_id,
-      :applicationId => application_id,
-      :keyword => 'Ruby'
+      affiliateId: affiliate_id,
+      applicationId: application_id,
+      keyword: 'Ruby'
     }
   end
 
@@ -23,11 +23,11 @@ describe RakutenWebService::Books::Software do
     before do
       response = JSON.parse(fixture('books/software_search_with_keyword_Ruby.json'))
       @expected_request = stub_request(:get, endpoint).
-        with(:query => expected_query).to_return(:body => response.to_json)
+        with(query: expected_query).to_return(body: response.to_json)
     end
 
     specify 'call endpoint when accessing results' do
-      softwares = RakutenWebService::Books::Software.search(:keyword => 'Ruby')
+      softwares = RakutenWebService::Books::Software.search(keyword: 'Ruby')
       expect(@expected_request).to_not have_been_made
 
       software = softwares.first
@@ -38,13 +38,13 @@ describe RakutenWebService::Books::Software do
 
   context 'When using Books::Total.search' do
     let(:software) do
-      RWS::Books::Software.new(:jan => '12345')
+      RWS::Books::Software.new(jan: '12345')
     end
 
     before do
       @expected_request = stub_request(:get, endpoint).
-        with(:query => { :affiliateId => affiliate_id, :applicationId => application_id, :jan => '12345' }).
-        to_return(:body => { :Items => [ { :Item => { :title => 'foo' } } ] }.to_json)
+        with(query: { affiliateId: affiliate_id, applicationId: application_id, jan: '12345' }).
+        to_return(body: { Items: [ { Item: { title: 'foo' } } ] }.to_json)
     end
 
     specify 'retrieves automatically if accessing the value of lack attribute' do

data/spec/rakuten_web_service/books/total_spec.rb

@@ -6,9 +6,9 @@ describe RakutenWebService::Books::Total do
   let(:application_id) { 'dummy_application_id' }
   let(:expected_query) do
     {
-      :affiliateId => affiliate_id,
-      :applicationId => application_id,
-      :keyword => 'Ruby'
+      affiliateId: affiliate_id,
+      applicationId: application_id,
+      keyword: 'Ruby'
     }
   end
 
@@ -23,11 +23,11 @@ describe RakutenWebService::Books::Total do
     before do
       response = JSON.parse(fixture('books/total_search_with_keyword_Ruby.json'))
       @expected_request = stub_request(:get, endpoint).
-        with(:query => expected_query).to_return(:body => response.to_json)
+        with(query: expected_query).to_return(body: response.to_json)
     end
 
     specify 'call endpoint when accessing results' do
-      items = RakutenWebService::Books::Total.search(:keyword => 'Ruby')
+      items = RakutenWebService::Books::Total.search(keyword: 'Ruby')
       expect(@expected_request).to_not have_been_made
 
       item = items.first

data/spec/rakuten_web_service/client_spec.rb

@@ -9,10 +9,10 @@ describe RakutenWebService::Client do
   let(:application_id) { 'default_application_id' }
   let(:affiliate_id) { 'default_affiliate_id' }
   let(:expected_query) do
-    { :affiliateId => affiliate_id, :applicationId => application_id }
+    { affiliateId: affiliate_id, applicationId: application_id }
   end
   let(:expected_response) do
-    { :body => '{"status":"ok"}' }
+    { body: '{"status":"ok"}' }
   end
 
   before do
@@ -43,8 +43,8 @@ describe RakutenWebService::Client do
       let(:application_id) { 'latest_application_id' }
 
       before do
-        client.get(:affiliate_id => affiliate_id,
-                   :application_id => application_id)
+        client.get(affiliate_id: affiliate_id,
+                   application_id: application_id)
       end
 
       specify 'call endpoint with given parameters' do
@@ -85,9 +85,9 @@ describe RakutenWebService::Client do
   describe 'about exceptions' do
     context 'parameter error' do
       let(:expected_response) do
-        { :status => 400,
-          :body => '{"error": "wrong_parameter",
-                     "error_description": "specify valid applicationId"}'
+        { status: 400,
+          body: '{"error": "wrong_parameter",
+                               "error_description": "specify valid applicationId"}'
         }
       end
 
@@ -99,9 +99,9 @@ describe RakutenWebService::Client do
 
     context 'Too many requests' do
       let(:expected_response) do
-        { :status => 429,
-          :body => '{ "error": "too_many_requests",
-            "error_description": "number of allowed requests has been exceeded for this API. please try again soon." }'
+        { status: 429,
+          body: '{ "error": "too_many_requests",
+                      "error_description": "number of allowed requests has been exceeded for this API. please try again soon." }'
         }
       end
 
@@ -113,9 +113,9 @@ describe RakutenWebService::Client do
 
     context 'Internal error in Rakuten Web Service' do
       let(:expected_response) do
-        { :status => 500,
-          :body => '{ "error": "system_error",
-                      "error_description": "api logic error" }'
+        { status: 500,
+          body: '{ "error": "system_error",
+                                "error_description": "api logic error" }'
         }
       end
 
@@ -126,9 +126,9 @@ describe RakutenWebService::Client do
 
     context 'Unavaiable due to maintainance or overloaded' do
       let(:expected_response) do
-        { :status => 503,
-          :body => '{ "error": "service_unavailable",
-                      "error_description": "XXX/XXX is under maintenance" }'
+        { status: 503,
+          body: '{ "error": "service_unavailable",
+                                "error_description": "XXX/XXX is under maintenance" }'
         }
       end
 
@@ -139,9 +139,9 @@ describe RakutenWebService::Client do
 
     context 'The specified genre has no ranking data' do
       let(:expected_response) do
-        { :status => 404,
-          :body => '{ "error": "not_found",
-                      "error_description": "This genre data does not exist"}'
+        { status: 404,
+          body: '{ "error": "not_found",
+                                "error_description": "This genre data does not exist"}'
         }
       end
 

data/spec/rakuten_web_service/gora/course_detail_spec.rb

@@ -6,9 +6,9 @@ describe RakutenWebService::Gora::CourseDetail do
   let(:application_id) { 'dummy_application_id' }
   let(:expected_query) do
     {
-        :affiliateId => affiliate_id,
-        :applicationId => application_id,
-        :golfCourseId => 120092
+        affiliateId: affiliate_id,
+        applicationId: application_id,
+        golfCourseId: 120092
     }
   end
 
@@ -23,7 +23,7 @@ describe RakutenWebService::Gora::CourseDetail do
     before do
       response = JSON.parse(fixture('gora/course_detail_search.json'))
       @expected_request = stub_request(:get, endpoint).
-          with(:query => expected_query).to_return(:body => response.to_json)
+          with(query: expected_query).to_return(body: response.to_json)
     end
 
     context 'call the find method' do

data/spec/rakuten_web_service/gora/course_spec.rb

@@ -6,9 +6,9 @@ describe RakutenWebService::Gora::Course do
   let(:application_id) { 'dummy_application_id' }
   let(:expected_query) do
     {
-        :affiliateId => affiliate_id,
-        :applicationId => application_id,
-        :keyword => '軽井沢'
+        affiliateId: affiliate_id,
+        applicationId: application_id,
+        keyword: '軽井沢'
     }
   end
 
@@ -23,19 +23,19 @@ describe RakutenWebService::Gora::Course do
     before do
       response = JSON.parse(fixture('gora/course_search_with_Karuizawa.json'))
       @expected_request = stub_request(:get, endpoint).
-          with(:query => expected_query).to_return(:body => response.to_json)
+          with(query: expected_query).to_return(body: response.to_json)
 
       response['page'] = 2
       response['first'] = 31
       response['last'] = 60
       @second_request = stub_request(:get, endpoint).
-          with(:query => expected_query.merge(:page => 2)).
-          to_return(:body => response.to_json)
+          with(query: expected_query.merge(page: 2)).
+          to_return(body: response.to_json)
     end
 
     context 'just call the search method' do
       before do
-        @courses = RakutenWebService::Gora::Course.search(:keyword => '軽井沢')
+        @courses = RakutenWebService::Gora::Course.search(keyword: '軽井沢')
       end
 
       specify 'endpoint should not be called' do

data/spec/rakuten_web_service/gora/plan_spec.rb

@@ -6,10 +6,10 @@ describe RakutenWebService::Gora::Plan do
   let(:application_id) { 'dummy_application_id' }
   let(:expected_query) do
     {
-        :affiliateId => affiliate_id,
-        :applicationId => application_id,
-        :areaCode => '12,14',
-        :playDate => '2016-04-24',
+        affiliateId: affiliate_id,
+        applicationId: application_id,
+        areaCode: '12,14',
+        playDate: '2016-04-24',
     }
   end
 
@@ -24,7 +24,7 @@ describe RakutenWebService::Gora::Plan do
     before do
       response = JSON.parse(fixture('gora/plan_search_with_area_code.json'))
       @expected_request = stub_request(:get, endpoint).
-          with(:query => expected_query).to_return(:body => response.to_json)
+          with(query: expected_query).to_return(body: response.to_json)
     end
 
     specify 'endpoint should not be called' do
@@ -33,7 +33,7 @@ describe RakutenWebService::Gora::Plan do
 
     context 'just call the search method' do
       before do
-        @plans = RakutenWebService::Gora::Plan.search(:areaCode => expected_query[:areaCode], :playDate => expected_query[:playDate])
+        @plans = RakutenWebService::Gora::Plan.search(areaCode: expected_query[:areaCode], playDate: expected_query[:playDate])
       end
 
       specify 'endpoint should not be called' do