rakuten_web_service 1.6.0 → 1.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2b7e9359a37bfbfdc0fecfa7bc6703cb5999cdf9
-  data.tar.gz: 2fb1c01c9fe67685e5197738aacd52256ccaefe9
+  metadata.gz: 5aeee894eae4b8fd7ae21d2962ed0fe90eee73cf
+  data.tar.gz: bebc76e67f7bbc00a0f89d2f1e68efbdc5fc6767
 SHA512:
-  metadata.gz: f5b11a26d32bbbd50e323655ba0b520b2f646b806f500631575e537710c2dcd812eedb956df9d409ae96b5da37282067472962c850d0fca05e72257d80151d5f
-  data.tar.gz: 5571f19189be5961d120da068dd5af6c3ba70739c50ca6e97577023fc32325969d951456e728d97d2c4e914c071aaa97bd130b48e53c8b7c2d8ce8dcaf58277b
+  metadata.gz: c3df84fcdd99a3fa8ee8a1b9703bb96516e3055ca9ba653ef6c822834218b53e7e150526af7e1c3f750ce391e0f26575b648c4b8388ca2631ef9c2964f31bc63
+  data.tar.gz: 3f1a9b2d21d91452c422cf7e8b8e6dee43b8bf7a84fab897da16ef87a3706cb0831ee02ce991cec93f5628043f0c680329b14bb6729f71bc0155d75747be20a6

data/.vscode/launch.json

@@ -25,6 +25,16 @@
             "args": [
                 "${file}"
             ]
+        },
+        {
+            "name": "RSpec - active spec line only",
+            "type": "Ruby",
+            "request": "launch",
+            "cwd": "${workspaceRoot}",
+            "program": "${workspaceRoot}/bin/rspec",
+            "args": [
+                "${file}:${lineNumber}"
+            ]
         }
     ]
 }

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+# v1.6.1 (2017/08/21)
+
+## Bug Fix
+
+* `RakutenWebService::Ichiba::Genre#brothers` always returns an empty array. [#75](https://github.com/rakuten-ws/rws-ruby-sdk/pull/75)
+
 # v1.6.0 (2017/08/16)
 
 ## Improvements

data/lib/rakuten_web_service/ichiba/genre.rb

@@ -5,7 +5,7 @@ require 'rakuten_web_service/ichiba/product'
 module RakutenWebService
   module Ichiba
     class Genre < RakutenWebService::BaseGenre
-      endpoint 'https://app.rakuten.co.jp/services/api/IchibaGenre/Search/20120723'
+      endpoint 'https://app.rakuten.co.jp/services/api/IchibaGenre/Search/20140222'
 
       attribute :genreId, :genreName, :genreLevel, :itemCount
 

data/lib/rakuten_web_service/version.rb

@@ -1,3 +1,3 @@
 module RakutenWebService
-  VERSION = "1.6.0".freeze
+  VERSION = "1.6.1".freeze
 end

data/spec/rakuten_web_service/genre_spec.rb

@@ -0,0 +1,185 @@
+require "spec_helper"
+
+describe RakutenWebService::BaseGenre do
+  let(:dummy_endpoint) { 'https://api.example.com/dummy_genre' }
+  let(:genre_id) { "1" }
+  let(:expected_response) do
+    {
+      'current' => {
+        dummyGenreId: 1,
+        dummyGenreName: "CurrentGenre",
+        genreLevel: 2
+      },
+      'children' => [
+        {
+          dummyGenreId: 2,
+          dummyGenreName: "ChildOne",
+          genreLevel: 3
+        },
+        {
+          dummyGenreId: 3,
+          dummyGenreName: "ChildTwo",
+          genreLevel: 3
+        }
+      ],
+      'parents' => [
+        {
+          dummyGenreId: 0,
+          dummyGenreName: "TopGenre",
+          genreLevel: 1
+        }
+      ],
+      'brothers' => [
+        {
+          dummyGenreId: 4,
+          dummyGenreName: "BrotherOne",
+          genreLevel: 1
+        }
+      ]
+    }
+  end
+  let!(:genre_class) do
+
+    Class.new(RakutenWebService::BaseGenre) do
+      endpoint "https://api.example.com/dummy_genre"
+      set_resource_name 'dummy_genre'
+      root_id 0
+      attribute :dummyGenreId, :dummyGenreName, :genreLevel
+    end
+  end
+
+  let!(:expected_request) do
+    stub_request(:get, dummy_endpoint).
+      with(query: {
+        applicationId: "DUMMY_APPLICATION_ID",
+        affiliateId: "DUMMY_AFFILIATE_ID",
+        formatVersion: 2,
+        dummyGenreId: genre_id
+      }).
+      to_return(body: expected_response.to_json)
+  end
+
+  before do
+    RakutenWebService.configure do |c|
+      c.application_id = "DUMMY_APPLICATION_ID"
+      c.affiliate_id = "DUMMY_AFFILIATE_ID"
+    end
+  end
+
+  after do
+    RakutenWebService::BaseGenre.instance_variable_set(:@repository, {})
+  end
+
+  describe ".genre_id_key" do
+    it { expect(genre_class.genre_id_key).to be_eql(:dummy_genre_id) }
+  end
+
+  describe ".root_id" do
+    it { expect(genre_class.root_id).to be_eql(0) }
+  end
+
+  describe ".new" do
+    context "When given string or integer" do
+      specify "should call search" do
+        genre_class.new(genre_id)
+
+        expect(expected_request).to have_been_made.once
+      end
+
+      specify "should call once if the same instance was initialized twice" do
+        2.times { genre_class.new(genre_id) }
+
+        expect(expected_request).to have_been_made.once
+      end
+    end
+
+    context "When a Hash is given" do
+      subject { genre_class.new(dummyGenreId: 10, dummyGenreName: "NewGenre") }
+
+      specify "API request should not been called" do
+        expect(expected_request).to_not have_been_made
+      end
+      it "shoud respond apropriate attributes" do
+        expect(subject.id).to be_eql(10)
+        expect(subject.name).to be_eql("NewGenre")
+      end
+    end
+  end
+
+  describe ".[]" do
+    specify "should call search only once as intializing twice" do
+      2.times { genre_class[genre_id] }
+
+      expect(expected_request).to have_been_made.once
+    end
+  end
+
+  describe "#children" do
+    subject { genre_class.new(genre_id).children }
+
+    it { is_expected.to_not be_empty }
+
+    context "children's children" do
+      before do
+        subject
+      end
+
+      it "should search again" do
+        expect(genre_class).to receive(:search).
+          with(dummy_genre_id: 2).
+          and_return([
+            double(:genre, children: [])
+          ])
+
+        expect(subject.first.children).to_not be_nil
+        expect(subject.first.children).to be_empty
+      end
+    end
+  end
+
+  describe "#parents" do
+    subject { genre_class.new(genre_id).children }
+
+    it { is_expected.to_not be_empty }
+
+    context "children's parents" do
+      before do
+        subject
+      end
+
+      it "should search again" do
+        expect(genre_class).to receive(:search).
+          with(dummy_genre_id: 2).
+          and_return([
+            double(:genre, parents: [])
+          ])
+
+        expect(subject.first.parents).to be_empty
+        expect(subject.first.parents).to_not be_nil
+      end
+    end
+  end
+
+  describe "#brothers" do
+    subject { genre_class.new(genre_id).children }
+
+    it { is_expected.to_not be_empty }
+
+    context "children's brothers" do
+      before do
+        subject
+      end
+
+      it "should search again" do
+        expect(genre_class).to receive(:search).
+          with(dummy_genre_id: 2).
+          and_return([
+            double(:genre, brothers: [])
+          ])
+
+        expect(subject.first.brothers).to be_empty
+        expect(subject.first.brothers).to_not be_nil
+      end
+    end
+  end
+end

data/spec/rakuten_web_service/ichiba/genre_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe RakutenWebService::Ichiba::Genre do
-  let(:endpoint) { 'https://app.rakuten.co.jp/services/api/IchibaGenre/Search/20120723' }
+  let(:endpoint) { 'https://app.rakuten.co.jp/services/api/IchibaGenre/Search/20140222' }
   let(:affiliate_id) { 'dummy_affiliate_id' }
   let(:application_id) { 'dummy_application_id' }
   let(:genre_id) { 0 }
@@ -13,14 +13,15 @@ describe RakutenWebService::Ichiba::Genre do
       genreId: genre_id
     }
   end
+  let(:fixture_file) { 'ichiba/genre_search.json' }
   let(:expected_json) do
-    JSON.parse(fixture('ichiba/genre_search.json'))
+    JSON.parse(fixture(fixture_file))
   end
 
   before do
     @expected_request = stub_request(:get, endpoint).
       with(query: expected_query).
-      to_return(body: fixture('ichiba/genre_search.json'))
+      to_return(body: fixture(fixture_file))
 
     RakutenWebService.configure do |c|
       c.affiliate_id = affiliate_id
@@ -166,22 +167,16 @@ describe RakutenWebService::Ichiba::Genre do
   end
 
   describe "#brothers" do
-    let(:genre_id) { 559887 }
+    let(:genre_id) { 201351 }
     let(:genre) { RakutenWebService::Ichiba::Genre.new(genre_id) }
-
-    before do
-      stub_request(:get, endpoint).with(
-        query: {
-          affiliateId: affiliate_id,
-          aplicationId: application_id,
-          genreId: genre_id
-        }
-      ).to_return(body: fixture('ichiba/parents_genre_search.json'))
-    end
+    let(:fixture_file) { 'ichiba/parents_genre_search.json' }
 
     specify "should respond an array of brother Genres" do
       expect(genre.brothers).to be_a(Array)
     end
+    specify "should have some brothers" do
+      expect(genre.brothers).to_not be_empty
+    end
   end
 
   describe '#ranking' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rakuten_web_service
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.6.1
 platform: ruby
 authors:
 - Tatsuya Sato
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-16 00:00:00.000000000 Z
+date: 2017-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -203,6 +203,7 @@ files:
 - spec/rakuten_web_service/client_spec.rb
 - spec/rakuten_web_service/configuration_spec.rb
 - spec/rakuten_web_service/genre_information_spec.rb
+- spec/rakuten_web_service/genre_spec.rb
 - spec/rakuten_web_service/gora/course_detail_spec.rb
 - spec/rakuten_web_service/gora/course_spec.rb
 - spec/rakuten_web_service/gora/plan_spec.rb
@@ -237,7 +238,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Ruby Client for Rakuten Web Service
@@ -275,6 +276,7 @@ test_files:
 - spec/rakuten_web_service/client_spec.rb
 - spec/rakuten_web_service/configuration_spec.rb
 - spec/rakuten_web_service/genre_information_spec.rb
+- spec/rakuten_web_service/genre_spec.rb
 - spec/rakuten_web_service/gora/course_detail_spec.rb
 - spec/rakuten_web_service/gora/course_spec.rb
 - spec/rakuten_web_service/gora/plan_spec.rb