rakuten_web_service 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 36494ec875153de05cd30a11c266d9c2c7d12b09
-  data.tar.gz: dafab6e790770ec344dca796d261a4896c741b54
+  metadata.gz: 1eb72352ce1d5a3438ff53f83c36beed80fe1c2e
+  data.tar.gz: 6b367c56add033e81ddebafa35ed0c3d6212c2b8
 SHA512:
-  metadata.gz: ffddb30af4da3756f6ef0baa4e2ad49c0967d06264eaf39e29c3a1bbb4a109cb7868e63335be9203006f631c4e24ba97144e899532fb2d15a223a7ede2022f2a
-  data.tar.gz: 9464a7badbc80252dfadb8c42104e0deefa028858eb9d09f91ee6545b05bd43cbb27b4ab1071a8e4e0ee08b4d7e28bcb5c1818da190aee180f7281661b240ddd
+  metadata.gz: 59a3290303696eccf35353c7e957e1391bdae96686cfd2b6dde48dae0fd67663587c3b41368fc42b32bf1cc02ea240a442e0bf4cc5565783472938a9f8857303
+  data.tar.gz: caccbdebffb9fcad8ba7fc6f8585a60287ab85af7729cd763e72bae8ccccd5d6d69bcc0e688e42e765cd803c6090f78560dd0f604f6471d95c96419d2204a0d3

data/CHANGELOG.md

@@ -1,3 +1,15 @@
+# v1.4.1 (2016/11/22)
+
+## Bug Fix
+
+* Fixed: `WrongParameter` raises when giving any `sort` option to `RakutenWebService::Resource.serch`. [#54](https://github.com/rakuten-ws/rws-ruby-sdk/pull/54)
+
+## Thanks
+
+I'm pleased to say thanks to @sho-yamane since he reporeted the bug #53. If he didn't do it, I would find the bug much later.
+Thanks, @sho-yamane.
+
+
 # v1.4.0 (2016/11/11)
 
 ## Enhancements

data/lib/rakuten_web_service/client.rb

@@ -1,4 +1,5 @@
 require 'uri'
+require 'cgi'
 require 'json'
 require 'rakuten_web_service/response'
 require 'rakuten_web_service/error'
@@ -28,7 +29,7 @@ module RakutenWebService
     def request(path, params)
       http = Net::HTTP.new(@url.host, @url.port)
       http.use_ssl = true
-      path = "#{path}?#{params.map { |k, v| "#{k}=#{URI.encode(v.to_s)}" }.join('&')}"
+      path = "#{path}?#{params.map { |k, v| "#{k}=#{CGI.escape(v.to_s)}" }.join('&')}"
       header = {
         'User-Agent' => "RakutenWebService SDK for Ruby v#{RWS::VERSION}(ruby-#{RUBY_VERSION} [#{RUBY_PLATFORM}])"
       }

data/lib/rakuten_web_service/version.rb

@@ -1,3 +1,3 @@
 module RakutenWebService
-  VERSION = "1.4.0".freeze
+  VERSION = "1.4.1".freeze
 end

data/spec/rakuten_web_service/client_spec.rb

@@ -51,6 +51,35 @@ describe RakutenWebService::Client do
         expect(@expected_request).to have_been_made.once
       end
     end
+
+    context "giving 'sort' option" do
+      let(:expected_query) do
+        {
+          applicationId: application_id,
+          affiliateId: affiliate_id,
+          sort: sort_option
+        }
+      end
+
+      before do
+        client.get(sort: sort_option)
+      end
+
+      context "Specifying asceding order" do
+        let(:sort_option) { '+itemPrice' }
+
+        specify "encodes '+' in sort option" do
+          expect(@expected_request).to have_been_made.once
+        end
+      end
+      context "Specifying descending order" do
+        let(:sort_option) { '-itemPrice' }
+
+        specify "encodes '+' in sort option" do
+          expect(@expected_request).to have_been_made.once
+        end
+      end
+    end
   end
 
   describe 'about exceptions' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rakuten_web_service
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: ruby
 authors:
 - Tatsuya Sato
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-11 00:00:00.000000000 Z
+date: 2016-11-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -206,7 +206,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Ruby Client for Rakuten Web Service