rakuten_web_service 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 99b714dfe2d0bd4009d95f2ca806dbf446c8ed5d
-  data.tar.gz: a1597c3749f7eb7f0d6cff37261583939661c233
+  metadata.gz: f79961bad825f4fb30452d991970455ea06c3dfe
+  data.tar.gz: 3fe13d653a47429b7a4423f49cfa92a8bc48e41e
 SHA512:
-  metadata.gz: e8eaeb445ef960ad736b11c545af488fdde4e700306b4221de66f3b88eebb88b7a1a7059c364a9d8044900ee514049b8be51b0db0093f6f75ef50e5f5645f17a
-  data.tar.gz: 055e6f2dacdd6baee0868ea136897742bcdb4aaee6e0c64953509c201c66960b6d87d0a45b8d2f41033709f421c61c64c80d4db59da5ea4066cdb50478f68381
+  metadata.gz: 417d44418dccbcbb5ba5c7cce48168b9204b2d4fa56790119bcc9864abed6e9dfedd8c7738dca523dbc4e733825063f6fe1116da728b281ca0c64bd98748f738
+  data.tar.gz: 64ac7fb9c11bc7754eae3127ea522234289a3f664e4fa274e3297b0883927dacdcb95c0a7db4c45f6910c1324f3bc28ad18e49ddb0af655e646783ad486fa72f

data/.codeclimate.yml

@@ -0,0 +1,16 @@
+engines:
+  rubocop:
+    enabled: true
+  duplication:
+    enabled: true
+    config:
+      languages:
+        - ruby
+
+ratings:
+  paths:
+    - lib/**/*.rb
+
+exclude_paths:
+  - spec/**/*
+  - examples/*.rb

data/.travis.yml

@@ -1,5 +1,4 @@
 language: ruby
-
 rvm:
   - 2.1.10
   - 2.2.5
@@ -11,6 +10,10 @@ cache: bundler
 before_install:
   - gem install bundler
 
+script:
+  - bundle exec rake
+  - bundle exec codeclimate-test-reporter
+
 matrix:
   allow_failures:
   - rvm: ruby-head
@@ -19,3 +22,9 @@ addons:
   code_climate:
     repo_token:
       secure: Z23O936LoCDGJ/OyYsLzxTUI+CMWyrfeN1PtQdCNMdF4vxwaCsAHr3ulTdudGhKMrVZGENSEK6fq0Xal3o3oPaH9aGM9sUQ/ibRM+J94Lx6Owu4okTsIHoEy4vFeW+A/62aiwxPcoi7PFrvC8FOfaZg+b+vvYAQcitVe6qwBHiE=
+
+notifications:
+  email: false
+  hipchat:
+    rooms:
+      secure: RYuIFjh/T6Hlj9nJ0RjmlTlES+9ZWcDNe1o2KRqMdH8cK1epIEgcEzMsFP6wKPRMQqOVw6Tu5gBMltDgu26sAW8HkTnMlzYtF6AVeOgsC6VVO9XzdaoVWWQX5J/Xn21vNV1vcncuOuMByz6dmzWngZv3T0u1mcvPje00EDNo27M=

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+# v1.3.0 (2016/11/08)
+
+## Enhancements
+
+* Loads Application ID and Affiliate ID from environment varaibles `RWS_APPLICATION_ID` and `RWS_AFFILIATE_ID` respectively. [#47](https://github.com/rakuten-ws/rws-ruby-sdk/pull/47)
+
+## Improvements
+
+* Upgraded `codeclimate-test-reporter`. [#48](https://github.com/rakuten-ws/rws-ruby-sdk/pull/48)
+
 # v1.2.0 (2016/10/25)
 
 ## Ehancements

data/Gemfile

@@ -4,6 +4,6 @@ source 'https://rubygems.org'
 gemspec
 
 group :test do
-  gem "codeclimate-test-reporter", require: nil
+  gem "codeclimate-test-reporter", '~> 1.0.0'
   gem "coveralls", require: nil
 end

data/README.md

@@ -59,6 +59,8 @@ If you have not got it, register your application [here](https://webservice.raku
 
 At first, you have to specify your application's key. And you can tell the client your afiiliate id with `RakutenWebService.configuration`.
 
+#### In Your Code
+
 ```ruby
   RakutenWebService.configuration do |c|
     # (Required) Appliction ID for your application.
@@ -81,6 +83,11 @@ At first, you have to specify your application's key. And you can tell the clien
 
 Please note that you need to replace `'YOUR_APPLICATION_ID'` and `'YOUR_AFFILIATE_ID'` with actual ones you have.
 
+#### Environment Variables
+
+You can configure `application_id` and `affiliate_id` by defining environment variables `RWS_APPLICATION_ID` and `RWS_AFFILIATION_ID`.
+
+
 ### Search Ichiba Items
 
 ```ruby

data/lib/rakuten_web_service/configuration.rb

@@ -1,10 +1,10 @@
-require 'logger'
-
 module RakutenWebService
   class Configuration
     attr_accessor :application_id, :affiliate_id, :max_retries, :debug
 
     def initialize
+      @application_id = ENV['RWS_APPLICATION_ID']
+      @affiliate_id = ENV['RWS_AFFILIATE_ID']
       @max_retries = 5
     end
 

data/lib/rakuten_web_service/version.rb

@@ -1,3 +1,3 @@
 module RakutenWebService
-  VERSION = "1.2.0".freeze
+  VERSION = "1.3.0".freeze
 end

data/spec/rakuten_web_service/configuration_spec.rb

@@ -2,6 +2,27 @@ require 'spec_helper'
 require 'rakuten_web_service/configuration'
 
 describe RakutenWebService::Configuration do
+  describe '#initialize' do
+    context "environment variable RWS_APPLICATION_ID and RWS_AFFILIATE_ID are defined" do
+      before do
+        ENV['RWS_APPLICATION_ID'] = 'env_application_id'
+        ENV['RWS_AFFILIATE_ID'] = 'env_affiliate_id'
+      end
+
+      after do
+        ENV.delete 'RWS_APPLICATION_ID'
+        ENV.delete 'RWS_AFFILIATE_ID'
+      end
+
+      subject { RakutenWebService::Configuration.new }
+
+      specify "the application id is set by the environment variable" do
+        expect(subject.application_id).to eq 'env_application_id'
+        expect(subject.affiliate_id).to eq 'env_affiliate_id'
+      end
+    end
+  end
+
   describe '.configure' do
     context 'given block has one arity' do
       before do

data/spec/spec_helper.rb

@@ -1,7 +1,4 @@
 if ENV['CI']
-  require 'codeclimate-test-reporter'
-  CodeClimate::TestReporter.start
-
   require 'coveralls'
   Coveralls.wear!
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rakuten_web_service
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Tatsuya Sato
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-25 00:00:00.000000000 Z
+date: 2016-11-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -87,6 +87,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
 - ".coveralls.yml"
 - ".gitignore"
 - ".travis.yml"