rakuten_web_service 1.13.0 → 1.13.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bdb4eed0f6b4075f460d74c30218551f0345c9bc12cda1a433bdcf9525e4ff64
-  data.tar.gz: ce188517ae7113a4322b35b271c9c5fccda23f0bb5694a8047bea1afdbf25a0c
+  metadata.gz: 77a989e998fd6a3271a5f1e999a0a42f6858ea20cacd06ebd05753212d97aee3
+  data.tar.gz: 90ceb9449c4aeb5c3bf01b46f7660d3f76a603fd8a28bd102f1fa33d66d45bae
 SHA512:
-  metadata.gz: 8b996cb29aa1fc0dd7634ee33dced0386e0d320711a42e98a20af695815df35709778d2150327551fa2dffe27a69407eb04f0aa4a3c72d01ba485e8e6ac172b7
-  data.tar.gz: 265354c69faacb14e9fe3aa3565b44d9813a8011562b913a3fe4ee017ea3e18bc4cf4df0e1f97295a5eb5c235a3beecc75e9efa37ecb89543fee5543c8e49307
+  metadata.gz: f083fede7c88df4046d4ca2c2f41429b1f37c9b4a814dace5e7b8b7ace92636a06cc3ce72ab06808dfc1fbf8758a89a167cd70ad276a0a826e5e139a1fe2307c
+  data.tar.gz: c97f6fcd7762134d830743fc92e77e26c66057a9f86671c338d1a5d95e0fc835d923419e8f593d8e1f7d68ca336e053eb684080b2eab60ea026f45c582c818ad

data/.github/workflows/ci.yml

@@ -0,0 +1,30 @@
+name: CI
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        ruby-version:
+          - 2.5
+          - 2.6
+          - 2.7
+          - "3.0"
+
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ruby/setup-ruby@v1
+        env:
+          BUNDLE_WITHOUT: vscode
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true
+      - name: Run test
+        run: bundle exec rake

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # CHANGELOG
 
+## v1.13.1 (2021/09/02)
+
+### Improvements
+
+- Fixed the issue when item can't be found by specifying elements [#132](https://github.com/rakuten-ws/rws-ruby-sdk/pull/132)
+- Removed abolished methods from sample codes in README [#131](https://github.com/rakuten-ws/rws-ruby-sdk/pull/131)
+- Migrated CI for this repo from Travis CI to GitHub Actions [#130](https://github.com/rakuten-ws/rws-ruby-sdk/pull/130)
+- Add ruby 3.0 support [#129](https://github.com/rakuten-ws/rws-ruby-sdk/pull/129)
+
 ## v1.13.0 (2020/10/15)
 
 ### Enhancements

data/README.ja.md

@@ -93,7 +93,7 @@ gem install rakuten_web_service
   last_items = items.page(3) # 3ページ目の情報を取る
 
   # 最後のページまでスキップする
-  while last_items.has_next_page?
+  while last_items.next_page?
     last_items = last_items.next_page
   end
 

data/README.md

@@ -1,5 +1,5 @@
 # RakutenWebService
-
+[![CI](https://github.com/rakuten-ws/rws-ruby-sdk/workflows/CI/badge.svg)](https://github.com/rakuten-ws/rws-ruby-sdk/actions?query=workflow%3ACI+branch%3Amaster)
 [![Build Status](https://travis-ci.org/rakuten-ws/rws-ruby-sdk.svg?branch=master)](https://travis-ci.org/rakuten-ws/rws-ruby-sdk)
 [![Gem Version](https://badge.fury.io/rb/rakuten_web_service.svg)](https://badge.fury.io/rb/rakuten_web_service)
 [![Test Coverage](https://codeclimate.com/github/rakuten-ws/rws-ruby-sdk/badges/coverage.svg)](https://codeclimate.com/github/rakuten-ws/rws-ruby-sdk/coverage)
@@ -113,7 +113,7 @@ Responses of resources' `search` such as `RakutenWebService::Ichiba::Item.search
   last_items = items.page(3) # Skips first 2 pages.
 
   # Go to the last page
-  while last_items.has_next_page?
+  while last_items.next_page?
     last_items = last_items.next_page
   end
 

data/lib/rakuten_web_service/ichiba/item.rb

@@ -18,7 +18,7 @@ module RakutenWebService
       endpoint 'https://app.rakuten.co.jp/services/api/IchibaItem/Search/20170706'
 
       parser do |response|
-        response['Items'].map { |item| Item.new(item) }
+        (response['Items'] || []).map { |item| Item.new(item) }
       end
 
       attribute :itemName, :catchcopy, :itemCode, :itemPrice,

data/lib/rakuten_web_service/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RakutenWebService
-  VERSION = '1.13.0'.freeze
+  VERSION = '1.13.1'
 end

data/spec/fixtures/ichiba/item_search_with_no_items.json

@@ -0,0 +1,8 @@
+{
+  "count": 0,
+  "page": 1,
+  "first": 0,
+  "last": 0,
+  "hits": 0,
+  "pageCount": 0
+}

data/spec/rakuten_web_service/ichiba/item_spec.rb

@@ -130,6 +130,19 @@ describe RakutenWebService::Ichiba::Item do
     end
   end
 
+  describe '.search(no items)' do
+    before do
+      response = JSON.parse(fixture('ichiba/item_search_with_no_items.json'))
+      @expected_request = stub_request(:get, endpoint).with(query: expected_query).to_return(body: response.to_json)
+    end
+
+    subject { RakutenWebService::Ichiba::Item.search(keyword: 'Ruby').first(1) }
+    specify '' do
+      expect { subject }.to_not raise_error
+    end
+    it { is_expected.to eq [] }
+  end
+
   describe '.all' do
     before do
       response = JSON.parse(fixture('ichiba/item_search_with_keyword_Ruby.json'))

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rakuten_web_service
 version: !ruby/object:Gem::Version
-  version: 1.13.0
+  version: 1.13.1
 platform: ruby
 authors:
 - Tatsuya Sato
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-10-15 00:00:00.000000000 Z
+date: 2021-09-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -131,8 +131,8 @@ extra_rdoc_files: []
 files:
 - ".codeclimate.yml"
 - ".github/FUNDING.yml"
+- ".github/workflows/ci.yml"
 - ".gitignore"
-- ".travis.yml"
 - ".vscode/launch.json"
 - ".vscode/tasks.json"
 - CHANGELOG.md
@@ -211,6 +211,7 @@ files:
 - spec/fixtures/gora/plan_search_with_area_code.json
 - spec/fixtures/ichiba/genre_search.json
 - spec/fixtures/ichiba/item_search_with_keyword_Ruby.json
+- spec/fixtures/ichiba/item_search_with_no_items.json
 - spec/fixtures/ichiba/parents_genre_search.json
 - spec/fixtures/ichiba/product_search.json
 - spec/fixtures/ichiba/ranking_search.json
@@ -276,7 +277,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.6
 signing_key:
 specification_version: 4
 summary: Ruby Client for Rakuten Web Service
@@ -295,6 +296,7 @@ test_files:
 - spec/fixtures/gora/plan_search_with_area_code.json
 - spec/fixtures/ichiba/genre_search.json
 - spec/fixtures/ichiba/item_search_with_keyword_Ruby.json
+- spec/fixtures/ichiba/item_search_with_no_items.json
 - spec/fixtures/ichiba/parents_genre_search.json
 - spec/fixtures/ichiba/product_search.json
 - spec/fixtures/ichiba/ranking_search.json

data/.travis.yml

@@ -1,33 +0,0 @@
-language: ruby
-rvm:
-  - 2.5
-  - 2.6
-  - 2.7
-  - ruby-head
-
-group: travis_lts
-
-cache: bundler
-
-before_install:
-  - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
-  - chmod +x ./cc-test-reporter
-  - ./cc-test-reporter before-build
-  - gem install bundler
-  - bundle config set without 'vscode'
-
-script:
-  - bundle exec rake
-
-after_script:
-  - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT
-
-matrix:
-  allow_failures:
-  - rvm: ruby-head
-
-notifications:
-  email: false
-  webhooks:
-    urls:
-      - https://webhooks.gitter.im/e/059b85fcc75550b7bc39