rakuten_web_service 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b7f33b3d1527b11476b4da96985d7be2806a46af
-  data.tar.gz: a1968049850a302e5f66f6e3dc53233be5565287
+  metadata.gz: 7e2855adb7ca963009ff82d05b90aeddd2935155
+  data.tar.gz: e21538cc0291246f23e5c034becaae09ed77d843
 SHA512:
-  metadata.gz: 0695e2c151da45d995de251b2db22af6ed087d90f3c65345c768214107e5bcf7a58cb33bb5a3a609ac88a6857d14dbff913fe71d3b5742910db1f25835010ba9
-  data.tar.gz: 60612ca32c7f9b5cdac8133869d4a38674cf78f2af5c6e04d75932675ef08fad92e9e65eb25a45f74a7fee1027c9585cf2b9f1dd947f59164290406db93fdddf
+  metadata.gz: d7d85a610f4cbfc9dcb823912b3c99fccd2cb0495d665d0ea504a658b27b91018dd0de9768c0d21e2ca88367d8e1cd956f92c4f484916abff365c0f6ef606bac
+  data.tar.gz: 15d281c03306b0dd15a85627870c727505b34547197fc19648032bfda68af3229fded98b5dc43bb97a3f20f82efecebb271589b2d4d3456d21b8222620c41e64

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+# v1.1.1 (2016/09/12)
+
+## Bug Fix
+
+* Fixed `RakutenWebService::Ichiba::Genre#ranking` ignores given options to be passed to Ichiba Ranking API. [#43](https://github.com/rakuten-ws/rws-ruby-sdk/pull/43)
+
 # v1.1.0 (2016/09/12)
 
 ## Enhancements

data/examples/books_item_search.rb

@@ -1,6 +1,4 @@
-# encoding: utf-8
-#
-# This is a sample script f Rakuten Books APIs. 
+# This is a sample script of Rakuten Books APIs. 
 # RWS Ruby SDK supports Books API. The inteface is similar to ones Ichiba API. 
 # If you want to search CDs dealt in Rakuten Books, you can do it with `RakutenWebService::Books::CD`. 
 # As for other resources, there are `RakutenWebService::Books::Book`, `RakutenWebService::Books::DVD` and so on. 

data/examples/gora_search.rb

@@ -1,6 +1,4 @@
-# encoding: utf-8
-#
-# This is a sample script f Rakuten Gora APIs.
+# This is a sample script of Rakuten Gora APIs.
 # RWS Ruby SDK supports Gora API. The inteface is similar to ones Ichiba API.
 # If you want to search courses dealt in Rakuten Gora, you can do it with `RakutenWebService::Gora::Course`.
 # As for other resources, there are `RakutenWebService::Gora::CourseDetail`, `RakutenWebService::Gora::Plan` and so on.

data/lib/rakuten_web_service/gora/course_detail.rb

@@ -34,7 +34,7 @@ module RakutenWebService
 
       class Rating < Resource
         class << self
-          def search(options)
+          def search(_options)
             raise 'There is no API endpoint for this resource.'
           end
         end
@@ -44,7 +44,7 @@ module RakutenWebService
 
       class Plan < Resource
         class << self
-          def search(options)
+          def search(_options)
             raise 'There is no API endpoint for this resource.'
           end
         end

data/lib/rakuten_web_service/gora/plan.rb

@@ -19,7 +19,7 @@ module RakutenWebService
 
       class PlanInfo < Resource
         class << self
-          def search(options)
+          def search(_options)
             raise 'There is no API endpoint for this resource.'
           end
         end
@@ -35,7 +35,7 @@ module RakutenWebService
 
         class CallInfo < Resource
           class << self
-            def search(options)
+            def search(_options)
               raise 'There is no API endpoint for this resource.'
             end
           end

data/lib/rakuten_web_service/ichiba/genre.rb

@@ -12,7 +12,8 @@ module RakutenWebService
       root_id 0
 
       def ranking(options={})
-        RakutenWebService::Ichiba::RankingItem.search(:genre_id => self.id)
+        options = options.merge(genre_id: self.id)
+        RakutenWebService::Ichiba::RankingItem.search(options)
       end
 
       def products(options={})

data/lib/rakuten_web_service/kobo/ebook.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 require 'rakuten_web_service/resource'
 
 module RakutenWebService

data/lib/rakuten_web_service/version.rb

@@ -1,3 +1,3 @@
 module RakutenWebService
-  VERSION = "1.1.0".freeze
+  VERSION = "1.1.1".freeze
 end

data/spec/rakuten_web_service/gora/course_detail_spec.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 require 'spec_helper'
 
 describe RakutenWebService::Gora::CourseDetail do

data/spec/rakuten_web_service/gora/course_spec.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 require 'spec_helper'
 
 describe RakutenWebService::Gora::Course do

data/spec/rakuten_web_service/gora/plan_spec.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 require 'spec_helper'
 
 describe RakutenWebService::Gora::Plan do

data/spec/rakuten_web_service/ichiba/genre_spec.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 require 'spec_helper'
 
 describe RakutenWebService::Ichiba::Genre do
@@ -155,6 +153,10 @@ describe RakutenWebService::Ichiba::Genre do
       expect(RakutenWebService::Ichiba::RankingItem).to receive(:search).with(:genre_id => genre_id)
       expect { genre.ranking }.to_not raise_error
     end
+    specify "should call RankingItem's search with genre_id and given options" do
+      expect(RakutenWebService::Ichiba::RankingItem).to receive(:search).with(genre_id: genre_id, age: 10)
+      expect { genre.ranking(age: 10) }.to_not raise_error
+    end
   end
 
   describe '#products' do

data/spec/rakuten_web_service/ichiba/item_spec.rb

@@ -1,4 +1,4 @@
-# encoding: utf-8
+
 
 require 'spec_helper'
 

data/spec/rakuten_web_service/ichiba/product_search_spec.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 require 'spec_helper'
 
 describe RakutenWebService::Ichiba::Product do

data/spec/rakuten_web_service/kobo/ebook_spec.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 require 'spec_helper'
 
 describe RakutenWebService::Kobo::Ebook do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rakuten_web_service
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Tatsuya Sato