rakuten_web_service 1.0.0.rc1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b44c66119bf5c9b8fa5dc6b6de6ffac8ca51530d
-  data.tar.gz: 32c3815fb9e4e4d2304df63142cbb7dfa0bef592
+  metadata.gz: cdc0f4711fe39be535cfe9b4bd83cf03fc7244eb
+  data.tar.gz: adaab1f25a06aa9d7910605361c8d740ebf5b08d
 SHA512:
-  metadata.gz: 7ecd020582c74f06fdadb1ce977248998f5aaba06f2db8fe94c93412bdbf8de0a7c7a8867bf8470d602923684c36943d6f351a0fced044baced6f02df342ada6
-  data.tar.gz: 81cc1e9e67ad04c7116f817b882d7718046ad7c4a49dbb096c89855804f4f43570d13b9924f3cc3be83f65cd1f4e120508b46216060c297ddb892d18b91ab10d
+  metadata.gz: 0ee1fcaa7e933d364b77fe00a60166448b1c207d7d55c5714acaef28bff6ea27f8536848c1a20514d720d0e70a2b8f4ab150479094adefef177f905a800aba5b
+  data.tar.gz: cca0e966fb91d68e25d650024eb6bfc71b37a5be0fc71ed79341818435572eee47099412d64b8e7a112c130eb04856291b0a95be3c1a948736cc56cb61fac8fb

data/CHANGELOG.md

@@ -1,18 +1,31 @@
+# v1.0.0
+
+## Enhancements
+
+* Upgrade the version of RSpec and refactoring the configuration. [#36](https://github.com/rakuten-ws/rws-ruby-sdk/pull/36) and [#37](https://github.com/rakuten-ws/rws-ruby-sdk/pull/36)
+
 # v1.0.0.rc1
 
 ## Enhancements
 
-* Start supporting Gora APIs. Thank you for your contribution @kamatama41 .[#29](https://github.com/rakuten-ws/rws-ruby-sdk/pull/29)
-* Start supporting Recipe APIs.
-* Update versions of supported Rakuten Web Service APIs.
+* Started supporting Gora APIs by @kamatama41 .[#29](https://github.com/rakuten-ws/rws-ruby-sdk/pull/29)
+* Started supporting Recipe APIs. [#31](https://github.com/rakuten-ws/rws-ruby-sdk/pull/31)
+* Updated versions of supported Rakuten Web Service APIs.
 
 ## Compatibility Changes
 
-* Supported Ruby versions are 2.1.0 or later
+* Updated supported Ruby versions to 2.1.0 or later
 * Any resource's `search` such as `RakutenWebService::Ichiba::Item` returns Enumerator which provides resources fetched at one page.
   It used to provide all resources by auto-pagerize. From this version provides methods for pagerizing. Please refer to [the sample in README](https://github.com/rakuten-ws/rws-ruby-sdk/blob/master/README.md#pagerizing).
+* Deprecated calling `RakutenWebService.configuration` with a block, recommending to use `RakutenWebService.configure`.
+
+## Thanks
+
+At first, I should appreciate all users of the gems.
+One of the enhancements, supporting Gora APIs, is realized by @kamatama41 's seminal work.
+Thank you for your contribution!
 
-# v0.6.3 
+# v0.6.3
 
 * Update a gem dependency by @45deg
 * Fix typo by @45deg

data/README.md

@@ -83,7 +83,7 @@ Please note that you need to replace `'YOUR_APPLICATION_ID'` and `'YOUR_AFFILIAT
 ### Search Ichiba Items
 
 ```ruby
-  items = RakutenWebService::Ichiba::Item.search(:keyword => 'Ruby') # This returns Enumerable object
+  items = RakutenWebService::Ichiba::Item.search(keyword: 'Ruby') # This returns Enumerable object
   items.first(10).each do |item|
     puts "#{item['itemName']}, #{item.price} yen" # You can refer to values as well as Hash.
   end
@@ -109,7 +109,8 @@ Responses of resources' `search` such as `RakutenWebService::Ichiba::Item.search
     puts item.name
   end
 
-  items.all do |item|
+  # Easier way to fetch all resources page 3 and latter
+  items.page(3).all do |item|
     puts item.name
   end
 ```

data/lib/rakuten_web_service/version.rb

@@ -1,3 +1,3 @@
 module RakutenWebService
-  VERSION = "1.0.0.rc1".freeze
+  VERSION = "1.0.0".freeze
 end

data/rakuten_web_service.gemspec

@@ -25,6 +25,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "webmock", "~> 1.20.4"
-  spec.add_development_dependency "rspec", '~> 2.14.1'
+  spec.add_development_dependency "rspec", '~> 3.5.0'
   spec.add_development_dependency "tapp"
 end

data/spec/rakuten_web_service/books/book_spec.rb

@@ -58,7 +58,7 @@ describe RakutenWebService::Books::Book do
     specify 'genretes RWS::Books::Genre object' do
       book = RWS::Books::Book.search(:title => 'Ruby').first
 
-      RWS::Books::Genre.should_receive(:new).with(response['Items'][0]['Item']['booksGenreId'])
+      expect(RWS::Books::Genre).to receive(:new).with(response['Items'][0]['Item']['booksGenreId'])
       expect(book.genre).to be_a(Array)
     end
 
@@ -66,7 +66,7 @@ describe RakutenWebService::Books::Book do
       genre_id = '001004008007/001021001010'
       book = RWS::Books::Book.new(:booksGenreId => genre_id) 
       genre_id.split('/').each do |id|
-        RWS::Books::Genre.should_receive(:new).with(id)
+        expect(RWS::Books::Genre).to receive(:new).with(id)
       end
       
       expect(book.genres).to be_a(Array)

data/spec/rakuten_web_service/books/genre_spec.rb

@@ -82,7 +82,7 @@ describe RWS::Books::Genre do
 
   describe '.root' do
     specify 'alias of constructor with the root genre id "000"' do
-      RWS::Books::Genre.should_receive(:new).with('000')
+      expect(RWS::Books::Genre).to receive(:new).with('000')
 
       RWS::Books::Genre.root
     end
@@ -97,7 +97,7 @@ describe RWS::Books::Genre do
       specify 'are Books::Genre objects' do
         expect(@genre.children).to be_all { |child| child.is_a? RWS::Books::Genre }
         expect(@genre.children).to be_all do |child|
-          expected_json['children'].is_any? { |c| c['booksGenreId'] == child['booksGenreId'] }
+          expected_json['children'].any? { |c| c['child']['booksGenreId'] == child['booksGenreId'] }
         end
       end
     end
@@ -121,7 +121,7 @@ describe RWS::Books::Genre do
       let(:genre_id) { '001001' }
 
       specify 'delegate Books::Book.search' do
-        RWS::Books::Book.should_receive(:search).with(:booksGenreId => genre_id)
+        expect(RWS::Books::Book).to receive(:search).with(:booksGenreId => genre_id)
 
         @genre.search
       end
@@ -131,7 +131,7 @@ describe RWS::Books::Genre do
       let(:genre_id) { '002101' }
 
       specify 'delegate Books::CD.search' do
-        RWS::Books::CD.should_receive(:search).with(:booksGenreId => genre_id)
+        expect(RWS::Books::CD).to receive(:search).with(:booksGenreId => genre_id)
 
         @genre.search
       end
@@ -141,7 +141,7 @@ describe RWS::Books::Genre do
       let(:genre_id) { '003201' }
 
       specify 'delegate Books::DVD.search' do
-        RWS::Books::DVD.should_receive(:search).with(:booksGenreId => genre_id)
+        expect(RWS::Books::DVD).to receive(:search).with(:booksGenreId => genre_id)
 
         @genre.search
       end
@@ -151,7 +151,7 @@ describe RWS::Books::Genre do
       let(:genre_id) { '004301' }
 
       specify 'delegate Books::Software.search' do
-        RWS::Books::Software.should_receive(:search).with(:booksGenreId => genre_id)
+        expect(RWS::Books::Software).to receive(:search).with(:booksGenreId => genre_id)
 
         @genre.search
       end
@@ -161,7 +161,7 @@ describe RWS::Books::Genre do
       let(:genre_id) { '005401' }
 
       specify 'delegate Books::ForeignBook.search' do
-        RWS::Books::ForeignBook.should_receive(:search).with(:booksGenreId => genre_id)
+        expect(RWS::Books::ForeignBook).to receive(:search).with(:booksGenreId => genre_id)
 
         @genre.search
       end
@@ -171,7 +171,7 @@ describe RWS::Books::Genre do
       let(:genre_id) { '006501' }
 
       specify 'delegate Books::Game.search' do
-        RWS::Books::Game.should_receive(:search).with(:booksGenreId => genre_id)
+        expect(RWS::Books::Game).to receive(:search).with(:booksGenreId => genre_id)
 
         @genre.search
       end
@@ -181,7 +181,7 @@ describe RWS::Books::Genre do
       let(:genre_id) { '007601' }
 
       specify 'delegate Books::Magazine.search' do
-        RWS::Books::Magazine.should_receive(:search).with(:booksGenreId => genre_id)
+        expect(RWS::Books::Magazine).to receive(:search).with(:booksGenreId => genre_id)
 
         @genre.search
       end

data/spec/rakuten_web_service/configuration_spec.rb

@@ -13,8 +13,15 @@ describe RakutenWebService::Configuration do
 
       subject { RakutenWebService.configuration }
 
-      its(:affiliate_id) { should eq('dummy_affiliate_id') }
-      its(:application_id) { should eq('dummy_application_id') }
+      describe '#affiliate_id' do
+        subject { super().affiliate_id }
+        it { is_expected.to eq('dummy_affiliate_id') }
+      end
+
+      describe '#application_id' do
+        subject { super().application_id }
+        it { is_expected.to eq('dummy_application_id') }
+      end
     end
 
     context 'given block has more or less one arity' do
@@ -70,7 +77,7 @@ describe RakutenWebService::Configuration do
 
       it 'should return true' do
         expect(configuration).to be_debug_mode
-        expect(configuration.debug).to be_false
+        expect(configuration.debug).to be_falsey
       end
     end
   end

data/spec/rakuten_web_service/gora/course_detail_spec.rb

@@ -37,13 +37,17 @@ describe RakutenWebService::Gora::CourseDetail do
 
         subject { RakutenWebService::Gora::CourseDetail.find(expected_query[:golfCourseId]) }
 
-        it { should be_a RakutenWebService::Gora::CourseDetail }
+        it { is_expected.to be_a RakutenWebService::Gora::CourseDetail }
 
         specify 'should be accessed by key' do
           expect(subject['golfCourseName']).to eq(expected_json['golfCourseName'])
           expect(subject['golf_course_name']).to eq(expected_json['golfCourseName'])
         end
-        its(:golf_course_name) { should eq(expected_json['golfCourseName']) }
+
+        describe '#golf_course_name' do
+          subject { super().golf_course_name }
+          it { is_expected.to eq(expected_json['golfCourseName']) }
+        end
 
         specify 'should be accessed to ratings' do
           expect(subject.ratings.size).to eq(expected_json['ratings'].size)

data/spec/rakuten_web_service/gora/course_spec.rb

@@ -52,12 +52,16 @@ describe RakutenWebService::Gora::Course do
 
         subject { @courses.first }
 
-        it { should be_a RakutenWebService::Gora::Course }
+        it { is_expected.to be_a RakutenWebService::Gora::Course }
         specify 'should be accessed by key' do
           expect(subject['golfCourseName']).to eq(expected_json['golfCourseName'])
           expect(subject['golf_course_name']).to eq(expected_json['golfCourseName'])
         end
-        its(:golf_course_name) { should eq(expected_json['golfCourseName']) }
+
+        describe '#golf_course_name' do
+          subject { super().golf_course_name }
+          it { is_expected.to eq(expected_json['golfCourseName']) }
+        end
       end
 
       context 'after that, call each' do

data/spec/rakuten_web_service/gora/plan_spec.rb

@@ -50,12 +50,16 @@ describe RakutenWebService::Gora::Plan do
 
         subject { @plans.first }
 
-        it { should be_a RakutenWebService::Gora::Plan }
+        it { is_expected.to be_a RakutenWebService::Gora::Plan }
         specify 'should be accessed by key' do
           expect(subject['golfCourseId']).to eq(expected_json['golfCourseId'])
           expect(subject['golf_course_id']).to eq(expected_json['golfCourseId'])
         end
-        its(:golf_course_id) { should eq(expected_json['golfCourseId']) }
+
+        describe '#golf_course_id' do
+          subject { super().golf_course_id }
+          it { is_expected.to eq(expected_json['golfCourseId']) }
+        end
       end
     end
   end

data/spec/rakuten_web_service/ichiba/genre_spec.rb

@@ -44,7 +44,11 @@ describe RakutenWebService::Ichiba::Genre do
       expect(subject['genreName']).to eq(expected_json['current']['genreName'])
       expect(subject['genre_name']).to eq(expected_json['current']['genreName'])
     end
-    its(:name) { should eq(expected_json['current']['genreName']) }
+
+    describe '#name' do
+      subject { super().name }
+      it { is_expected.to eq(expected_json['current']['genreName']) }
+    end
   end
 
   describe '.new' do
@@ -148,7 +152,7 @@ describe RakutenWebService::Ichiba::Genre do
     end
 
     specify "should call RankingItem's search with genre_id option" do
-      RakutenWebService::Ichiba::RankingItem.should_receive(:search).with(:genre_id => genre_id)
+      expect(RakutenWebService::Ichiba::RankingItem).to receive(:search).with(:genre_id => genre_id)
       expect { genre.ranking }.to_not raise_error
     end
   end
@@ -162,7 +166,7 @@ describe RakutenWebService::Ichiba::Genre do
     end
 
     specify "should call Product search with genre_id option" do
-      RakutenWebService::Ichiba::Product.should_receive(:search).with(:genre_id => genre_id)
+      expect(RakutenWebService::Ichiba::Product).to receive(:search).with(:genre_id => genre_id)
       expect { genre.products }.to_not raise_error
     end
   end

data/spec/rakuten_web_service/ichiba/item_spec.rb

@@ -52,12 +52,16 @@ describe RakutenWebService::Ichiba::Item do
 
         subject { @items.first }
 
-        it { should be_a RakutenWebService::Ichiba::Item }
+        it { is_expected.to be_a RakutenWebService::Ichiba::Item }
         specify 'shoud be access by key' do
           expect(subject['itemName']).to eq(expected_json['itemName'])
           expect(subject['item_name']).to eq(expected_json['itemName'])
         end 
-        its(:name) { should eq(expected_json['itemName']) }
+
+        describe '#name' do
+          subject { super().name }
+          it { is_expected.to eq(expected_json['itemName']) }
+        end
         specify 'should have xxx? method if the object has xxx_flag' do
           expect(subject.tax?).to eq(expected_json['taxFlag'] == 1)
         end
@@ -110,7 +114,7 @@ describe RakutenWebService::Ichiba::Item do
       context 'When TooManyRequest error raised' do
         let(:client) do 
           c = double('client')
-          c.stub(:get).and_raise(RWS::TooManyRequests)
+          allow(c).to receive(:get).and_raise(RWS::TooManyRequests)
           c
         end
 
@@ -151,7 +155,7 @@ describe RakutenWebService::Ichiba::Item do
 
   describe '.ranking' do
     before do
-      RakutenWebService::Ichiba::RankingItem.should_receive(:search).with({})
+      expect(RakutenWebService::Ichiba::RankingItem).to receive(:search).with({})
     end
 
     specify "call RakutenWebService::Ichiba::RankingItem's search" do
@@ -167,7 +171,7 @@ describe RakutenWebService::Ichiba::Item do
         to_return(:body => response.to_json)
 
       expected_item = response['Items'][0]['Item']
-      RakutenWebService::Ichiba::Genre.should_receive('new').with(expected_item['genreId']) 
+      expect(RakutenWebService::Ichiba::Genre).to receive('new').with(expected_item['genreId']) 
     end
 
     subject { RakutenWebService::Ichiba::Item.search(:keyword => 'Ruby').first.genre }

data/spec/rakuten_web_service/ichiba/product_search_spec.rb

@@ -38,7 +38,7 @@ describe RakutenWebService::Ichiba::Product do
     subject { RakutenWebService::Ichiba::Product.search(:keyword => 'Ruby') }
 
     specify '' do
-      expect(subject).to have(30).things
+      expect(subject.count).to eq(30)
     end
 
     describe 'For an response' do

data/spec/rakuten_web_service/ichiba/ranking_spec.rb

@@ -41,8 +41,16 @@ describe RakutenWebService::Ichiba::RankingItem do
       expect(subject['itemName']).to eq(expected_json['itemName'])
       expect(subject['item_name']).to eq(expected_json['itemName'])
     end
-    its(:rank) { should eq(1) }
-    its(:name) { should eq(expected_json['itemName']) }
+
+    describe '#rank' do
+      subject { super().rank }
+      it { is_expected.to eq(1) }
+    end
+
+    describe '#name' do
+      subject { super().name }
+      it { is_expected.to eq(expected_json['itemName']) }
+    end
   end
 
 end

data/spec/rakuten_web_service/kobo/ebook_spec.rb

@@ -46,7 +46,7 @@ describe RakutenWebService::Kobo::Ebook do
         to_return(:body => response.to_json)
 
       expected_item = response['Items'][0]['Item']
-      RakutenWebService::Kobo::Genre.should_receive('new').with(expected_item['koboGenreId'])
+      expect(RakutenWebService::Kobo::Genre).to receive('new').with(expected_item['koboGenreId'])
 
       RakutenWebService::Kobo::Ebook.search(:title => 'Ruby').first.genre
     end

data/spec/rakuten_web_service/recipe_spec.rb

@@ -21,7 +21,7 @@ describe RakutenWebService::Recipe do
 
   describe '.search' do
     it 'should not be called' do
-      expect { RWS::Recipe.search(category_id: '10') }.to raise_error
+      expect { RWS::Recipe.search(category_id: '10') }.to raise_error(NoMethodError)
     end
   end
 

data/spec/spec_helper.rb

@@ -10,7 +10,7 @@ require File.expand_path(File.join(__dir__, '..', 'lib', 'rakuten_web_service'))
 
 require 'webmock/rspec'
 
-Dir[File.expand_path(File.join(File.dirname(__FILE__), "support/**/*.rb"))].each { |f| require f }
+Dir[File.expand_path(File.join(__dir__, "support/**/*.rb"))].each { |f| require f }
 
 RSpec.configure do |c|
   c.mock_with :rspec
@@ -19,10 +19,6 @@ RSpec.configure do |c|
     WebMock.disable_net_connect!(:allow => "codeclimate.com")
   end
 
-  c.before :suite, integration: true do
-    WebMock.allow_net_connect!
-  end
-
   c.after :each do
     WebMock.reset!
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rakuten_web_service
 version: !ruby/object:Gem::Version
-  version: 1.0.0.rc1
+  version: 1.0.0
 platform: ruby
 authors:
 - Tatsuya Sato
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-29 00:00:00.000000000 Z
+date: 2016-07-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.14.1
+        version: 3.5.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.14.1
+        version: 3.5.0
 - !ruby/object:Gem::Dependency
   name: tapp
   requirement: !ruby/object:Gem::Requirement
@@ -224,9 +224,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>'
+  - - '>='
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.0.3