rakuten_web_service 0.2.1 → 0.2.2

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MzYxYzA3MmVkMzNiMjMxZDYzZmY1MDM1NmI2MTUzMmQxZDY2ZGJkNA==
+    NTVjZWM1MjZhMWRmZDZhMzZkYmZhZThjNjJiZGE1NzNkZjNmYTYyMw==
   data.tar.gz: !binary |-
-    NDIzYTA0Njc1NTc4YjkwMzM0MjQwNzQ2MGJhYjRmZmQ1ZGY5NzMxMw==
+    YjUzZDE3YzY0NGQxYjVjOTdmOGQ1ODAzYzU5Yzc2ZGI3MjhiNzZiYQ==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    NjVlYmRiMGMxNTU1MzUxMTFhMGUwMjQ5ZTE5ZjQzYjU3MzVkZTNlZTg1Mjcw
-    MDM0ZGE4NTIwYTM3ZDdkZTJkZWNkNTBlYmQ4YWU1NGU3NGYyMGUyZmRjYTNi
-    M2E4MDlmZDlmMTc4NTYxOTQwMjIyYTZjMmE0Y2JmYjdkYWQzNTg=
+    MTY4NDM0OGQwZmEyYTc3MzE2YjJhZDA4MGRjYWQwYjQwNGY1MWQ0YzU2NGVm
+    MzgzODI3ZTRjZmY5NGQ2ZWEwNThmZjE0MzQ4YzM3MjczYTljYWFjMWNkODEz
+    NGEyNzk1NjgzNjgxZmYzNWNiMWM0MTg0YTk3ZGRjZGQxN2E1ZGQ=
   data.tar.gz: !binary |-
-    YjJhN2NmZTg4NTUyOWNiZjkwNjZjMjE4ZThhZjUxNzA4ZTI3ZTQyOWUxODUz
-    MTQwMjI2NDFlOTk5YWJkYmNlNmEzZDVjZjU0OWZhYTE0YTVlNGM0NDVkYWFh
-    Mzk5YTMzMzE0N2FkMTY4YzhjZjFmYTViMjRkMDM4NGU1ZGI1MjU=
+    MzM0NGQ2NmZmZWRiNjU2Y2QxYjgyNWM1NThjNWNlZmE3NDVlNDc1ZjM0MmVk
+    YjA0ODA1ZWJmOTM1YzA0MWMwZTQwZjM0YzI3MzcxZTc3MjUxOGM3NmE4NmFl
+    ZTM3MDY3NGI5MzZhNTNjYzYxYTk1MjViYjliNWU3ZTdmMjU0ZTQ=

data/lib/rakuten_web_service/client.rb

@@ -3,6 +3,7 @@ require 'faraday_middleware'
 
 module RakutenWebService
   class WrongParameter < StandardError; end
+  class NotFound < StandardError; end
   class TooManyRequests < StandardError; end
   class SystemError < StandardError; end
   class ServiceUnavailable < StandardError; end
@@ -25,6 +26,8 @@ module RakutenWebService
         return response
       when 400
         raise WrongParameter, response.body['error_description']
+      when 404
+        raise NotFound, response.body['error_description']
       when 429
         raise TooManyRequests, response.body['error_description']
       when 500

data/lib/rakuten_web_service/ichiba/item.rb

@@ -29,7 +29,7 @@ module RakutenWebService
         :genreId
 
       def genre
-        Genre[self.genre_id]
+        Genre.new(self.genre_id)
       end
 
       def shop

data/lib/rakuten_web_service/version.rb

@@ -1,3 +1,3 @@
 module RakutenWebService
-  VERSION = "0.2.1"
+  VERSION = "0.2.2"
 end

data/spec/rakuten_web_service/client_spec.rb

@@ -104,5 +104,18 @@ describe RakutenWebService::Client do
         expect { client.get({}) }.to raise_error(RWS::ServiceUnavailable, 'XXX/XXX is under maintenance')
       end
     end
+
+    context 'The specified genre has no ranking data' do
+      let(:expected_response) do
+        { :status => 404,
+          :body => '{ "error": "not_found",
+                      "error_description": "This genre data does not exist"}'
+        }
+      end
+
+      specify 'raises NotFound exception' do
+        expect { client.get({}) }.to raise_error(RWS::NotFound, 'This genre data does not exist')
+      end
+    end
   end
 end

data/spec/rakuten_web_service/ichiba/item_spec.rb

@@ -92,7 +92,7 @@ describe RakutenWebService::Ichiba::Item do
         to_return(:body => response.to_json)
 
       expected_item = response['Items'][0]['Item']
-      RakutenWebService::Ichiba::Genre.should_receive('[]').with(expected_item['genreId']) 
+      RakutenWebService::Ichiba::Genre.should_receive('new').with(expected_item['genreId']) 
     end
 
     subject { RakutenWebService::Ichiba::Item.search(:keyword => 'Ruby').first.genre }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rakuten_web_service
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Tatsuya Sato