rakuten_web_service 0.1.0 → 0.1.1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MTQ4NTc2ZGU1NWYxM2EzYjdhYmY0ZmRkMzE3YTQzMDQ2MDY1MmM5ZQ==
+    ZTMxYmJkZDY4MjE0MDI0MDIzZDIyOTRkN2EyMGU1NjRhMDMzMDg5NA==
   data.tar.gz: !binary |-
-    MjM5N2E1NThiNGZlMTViNTUwMTg5NDE3ZjE3YjRkNGZjOGViYmQxZQ==
+    ODY4NjQ2MGI2Mzc0OTE4ZDE0OWE4ZmIwNTZiNGYyN2UxMTFmOWJmNQ==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    Y2YxNmMyNzBlZWNlNWY3ZTk1ODQxMjNiN2I2ZjliMTBmYmM5NTJiOGM0ZTAx
-    ZmViYzJlNDc4MWQ4M2MyODM4N2NiYzczMTJiYTc4Y2JmOWE3YmU4YjVjZWYy
-    NGMxNWFiMDdmNjhjMzNiYWEzMDAyNjM5YTY5ZWY0Yjc4M2VkYTU=
+    M2ZhY2UzYmY0ZjlhZDAwNWY3OThkMWIzODVkZDZhMmUyNDczYjY0NDRjNzM3
+    M2IzYjM1NzY1NzBlNWFjODhlNWRiNTkyYjE4NmQ3ODE3MjI0ZjEwMWMwY2E3
+    NzNhM2YxZGZkYTQwYjA2MWUyMWJhZmQ2MGE2YmIyNzdkYzJjZjk=
   data.tar.gz: !binary |-
-    YjI1ZmU1YzIzMWVhNDFlYTAyMzAwMjA5MTQ1N2U2NjNmNjU3ODUxNjExOTc3
-    ZjE3OWIyN2FjOTg3NmYzZTI1OTY1ZDA5MWU0Y2FiN2I2YzEyNDExZDc2ZDJh
-    YWYxNmZkNDFjYjdkNjM2N2M5NDY2YjMyMzRiZmY2YzIzOGEzYjg=
+    OGNjNzQzNWFlNTBhNjg1ZTZkNWYyMjk0ZjcyODcwMGM5ZDg5YzQ5MTVkOTBi
+    N2E0NTViMjc3MTg3MTAwNTkxYzZmMjhkMTQzODE0NjE0ZGEzNWFjYTY0NjNj
+    NWQ0MDJhYzZkMzMwMDc4MzUzMWE0YjUwZGRlMGYxM2FiMjQyZWU=

data/README.md

@@ -1,6 +1,6 @@
 # RakutenWebService
 
-[![Build Status](https://travis-ci.org/satoryu/rakuten_web_service.png?branch=master)](https://travis-ci.org/satoryu/rakuten_web_service)
+[![Build Status](https://travis-ci.org/satoryu/rakuten_web_service.png?branch=master)](https://travis-ci.org/satoryu/rakuten_web_service) [![Gem Version](https://badge.fury.io/rb/rakuten_web_service.png)](http://badge.fury.io/rb/rakuten_web_service)
 
 ## Installation
 

data/lib/rakuten_web_service/client.rb

@@ -2,6 +2,11 @@ require 'faraday'
 require 'faraday_middleware'
 
 module RakutenWebService
+  class WrongParameter < StandardError; end
+  class TooManyRequests < StandardError; end
+  class SystemError < StandardError; end
+  class ServiceUnavailable < StandardError; end
+
   class Client
     attr_reader :url, :path
 
@@ -14,7 +19,19 @@ module RakutenWebService
     def get(query)
       query = RakutenWebService.configuration.generate_parameters.merge(query)
       query = convert_snake_key_to_camel_key(query)
-      connection.get(path, query)
+      response = connection.get(path, query)
+      case response.status
+      when 200
+        return response
+      when 400
+        raise WrongParameter, response.body['error_description']
+      when 429
+        raise TooManyRequests, response.body['error_description']
+      when 500
+        raise SystemError, response.body['error_description']
+      when 503
+        raise ServiceUnavailable, response.body['error_description']
+      end
     end
 
     private

data/lib/rakuten_web_service/version.rb

@@ -1,3 +1,3 @@
 module RakutenWebService
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/spec/rakuten_web_service/client_spec.rb

@@ -9,11 +9,14 @@ describe RakutenWebService::Client do
   let(:expected_query) do
     { :affiliateId => affiliate_id, :applicationId => application_id }
   end
+  let(:expected_response) do
+    { :body => '{"status":"ok"}' }
+  end
 
   before do
     @expected_request = stub_request(:get, endpoint).
       with(:query => expected_query).
-      to_return(:body => '{"status":"ok"}')
+      to_return(expected_response)
 
     RakutenWebService.configuration do |c|
       c.affiliate_id = 'default_affiliate_id'
@@ -21,28 +24,85 @@ describe RakutenWebService::Client do
     end
   end
 
-  context 'call get without any parameters' do
-    before do
-      client.get({})
+  describe '#get' do
+    context 'call get without any parameters' do
+      before do
+        client.get({})
+      end
+
+      specify 'call endpoint with default parameters' do
+        expect(@expected_request).to have_been_made.once
+      end
     end
 
-    specify 'call endpoint with default parameters' do
-      expect(@expected_request).to have_been_made.once
+    context 'call get with parameters' do
+      let(:affiliate_id) { 'latest_affiliate_id' }
+      let(:application_id) { 'latest_application_id' }
+
+      before do
+        client.get(:affiliate_id => affiliate_id,
+                   :application_id => application_id)
+      end
+
+      specify 'call endpoint with given parameters' do
+        expect(@expected_request).to have_been_made.once
+      end
     end
   end
 
-  context 'call get with parameters' do
-    let(:affiliate_id) { 'latest_affiliate_id' }
-    let(:application_id) { 'latest_application_id' }
+  describe 'about exceptions' do
+    context 'parameter error' do
+      let(:expected_response) do
+        { :status => 400,
+          :body => '{"error": "wrong_parameter",
+                     "error_description": "specify valid applicationId"}'
+        }
+      end
+
+      specify 'raises WrongParameter exception' do
+        expect { client.get({}) }.to raise_error(RWS::WrongParameter, 'specify valid applicationId')
+      end
 
-    before do
-      client.get(:affiliate_id => affiliate_id,
-                 :application_id => application_id)
     end
 
-    specify 'call endpoint with given parameters' do
-      expect(@expected_request).to have_been_made.once
+    context 'Too many requests' do
+      let(:expected_response) do
+        { :status => 429,
+          :body => '{ "error": "too_many_requests",
+            "error_description": "number of allowed requests has been exceeded for this API. please try again soon." }'
+        }
+      end
+
+      specify 'raises TooManyRequests exception' do
+        expect { client.get({}) }.to raise_error(RWS::TooManyRequests,
+          'number of allowed requests has been exceeded for this API. please try again soon.')
+      end
     end
-  end
 
+    context 'Internal error in Rakuten Web Service' do
+      let(:expected_response) do
+        { :status => 500,
+          :body => '{ "error": "system_error",
+                      "error_description": "api logic error" }'
+        }
+      end
+
+      specify 'raises SystemError exception' do
+        expect { client.get({}) }.to raise_error(RWS::SystemError, 'api logic error')
+      end
+    end
+
+    context 'Unavaiable due to maintainance or overloaded' do
+      let(:expected_response) do
+        { :status => 503,
+          :body => '{ "error": "service_unavailable",
+                      "error_description": "XXX/XXX is under maintenance" }'
+        }
+      end
+
+      specify 'raises ServiceUnavailable exception' do
+        expect { client.get({}) }.to raise_error(RWS::ServiceUnavailable, 'XXX/XXX is under maintenance')
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rakuten_web_service
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Tatsuya Sato
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-23 00:00:00.000000000 Z
+date: 2013-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday